[00:45:48] AndyRussG: is there a patch on the sendmail? [01:29:45] (PS6) Eileen: Move skipping of wmf-donor fields to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676175 (https://phabricator.wikimedia.org/T270679) [01:38:42] (PS7) Eileen: Move skipping of wmf-donor fields to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676175 (https://phabricator.wikimedia.org/T270679) [01:40:51] (CR) Eileen: "I think I've fixed it now - I hit a nasty gotcha where not defining is_contact = 0 causes problems but that is defined now" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676175 (https://phabricator.wikimedia.org/T270679) (owner: Eileen) [01:50:59] (CR) AndyRussG: "Just trying to recall what was discussed previously about this... Is it the case that this should also take contact_id as a parameter, and" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [01:51:44] (CR) Eileen: "> Patch Set 7:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [01:52:34] (CR) AndyRussG: "> Patch Set 7:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [01:59:55] (CR) AndyRussG: WIP: Add CiviProxy setup (1 comment) [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/673094 (https://phabricator.wikimedia.org/T268683) (owner: Jgleeson) [02:01:42] eileen: yes, it's https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/678432 [02:02:44] it's attached to the task (https://phabricator.wikimedia.org/T279669) but with all the recent comments on that task, you have to click "Show Older Changes" to see it [02:31:21] (CR) Eileen: [V: +2 C: +2] "Ok - let's get this merged so we can see if it fixes it consistently or is just noise" [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/678432 (https://phabricator.wikimedia.org/T279669) (owner: AndyRussG) [02:31:47] eileen: thanks!! :) [02:31:56] AndyRussG: OK - l'm not totally convinced it's 'the' fix but I think we've all agreed it's a helpful change [02:32:33] & also - I tried so many combinations of things locally - things that used to work (I am fairly sure) - so I just don't know what changed [02:32:34] eileen: k I understand... looking forward to hearing how it works for u and others :) [02:33:43] eileen what could have change also could be something unrelated... like some new update to Debian packages that we started pulling in when we updated the images [02:33:53] *could have changed [02:34:10] yeah - must be something like that [02:34:36] I'm having issues with debugging that are new too - but not new new so could have started about the same time [02:34:43] oh no... what happened? [02:34:50] I'm experimenting with the php output_buffering setting [02:35:16] for debugging debugging the xdebug log has been helpful [02:35:18] I don't know how consistent it is but I find that when I debug the page doesn't render in the end [02:35:39] hmmm never seen that [02:35:48] but I don't know that I've debugged into civi much [02:36:00] that does sound like something to look at the debug log for [02:36:41] yeah I don't think it's civi [02:37:20] I think it's something at the php layer [02:37:35] ie the page renders when I'm not listening but not when I am [02:37:47] I *think* it's working at the moment most of the time [02:38:06] regarding the sendmail/php.ini fix, without knowing anything about the code that's running, I feel doubtful that it would work in a completely clean state for me (i.e., new clone of wmff code and newly recreated system storage) and not for others... but maybe I'm too confident in Docker's standardizing across all environments [02:38:09] with me messing with output buffering - but nto quite sure [02:39:12] Yeah - I don't want to blow it all away again right now as it took me a long time to recover when I did that earlier [02:39:49] - although it might 'just work' - but actually I have other stuff too - like git remotes configured that are a pain to re-do [02:40:01] right... ahh welp we'll see how it goes [02:41:04] if you don't have anything important stored directly in the container (i.e. the anonymous container filesystem, not the db volume) you can do docker-compose down, update to the latest fr-dev and do docker-compose up -d, in theory without losing anything [02:42:49] (PS8) Eileen: Civiproxy preferences shell [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) [02:43:15] AndyRussG: ^^ I haven't really tested but should address the contact_id check [02:43:40] eileen: ah cool thanks! I can test it now :) [02:45:20] eileen: btw got a quick pointer to the code I should look at to figure out how to write the queue consumer? ahhh thx in advance [02:53:44] (PS1) Eileen: Mock up on setting preferences [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/678464 [02:53:45] AndyRussG: so maybe something like ^^ [02:54:20] It would be good to have a separate api call to load from the queue but we probably have to stick weird stuff in there to do that for now [02:56:02] eileen: oh hey that's fantastic, thanks so much! [02:58:28] K so same api... file, I guess? ("call"? K not sure about the distinctions here, but I can dig in a lot with what you just sent, thanks!) [03:01:34] (CR) jerkins-bot: [V: -1] Civiproxy preferences shell [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [03:09:40] (CR) jerkins-bot: [V: -1] Mock up on setting preferences [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/678464 (owner: Eileen) [04:37:27] (CR) AndyRussG: "This works great when I send in the right contact_id ad hash! Also it does return an error if the contact_id param is left off. However, w" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [04:54:21] (PS10) AndyRussG: Initial general e-mail preferences prototype [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/672362 (https://phabricator.wikimedia.org/T268510) [05:10:56] (PS7) AndyRussG: Email Preference Center: Guzzle connetor to Civiproxy [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/677018 (https://phabricator.wikimedia.org/T268497) [06:41:22] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/678495 (owner: L10n-bot) [07:06:37] (CR) Eileen: "AndyRussG so my thinking in not giving a validation error when they don't match is that it's kinda like telling a potential brute force th" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [10:06:22] (CR) Nikerabbit: "> @Abi, Niklas: Do we have a script to mass-delete most but not all? See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInt" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/677754 (owner: L10n-bot) [13:04:01] (Abandoned) Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/678495 (owner: L10n-bot) [13:04:54] (Abandoned) Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/677754 (owner: L10n-bot) [13:42:33] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] [13:47:33] RECOVERY - check_log_messages on frav1002 is OK: OK [15:05:12] (CR) AndyRussG: "> Patch Set 8:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [18:50:06] Fundraising-Backlog, Analytics, FR-Tech-Analytics: Whitelist Portal and WikipediaApp event data for (sanitized) long-term storage - https://phabricator.wikimedia.org/T273246 (EYener) Hi all! I am going to close out this ticket, since the main point - whitelisting the 3 mentioned schemas - has been re... [18:50:09] Fundraising-Backlog, Analytics, FR-Tech-Analytics: Whitelist Portal and WikipediaApp event data for (sanitized) long-term storage - https://phabricator.wikimedia.org/T273246 (EYener) Open→Resolved [19:34:34] I can't see anyone else in the mtg [19:36:51] dstrine: cstone ? [19:37:54] Repeat of last time eileen surprise holiday [19:39:22] oh right [19:39:24] nice [19:47:11] lol yeah surprise! [19:51:20] eileen: I am working today. I invited you to a meeting later. I got some civi stuff to cover [19:51:31] oh cool [19:51:50] I want to talk about drupal and forms in searchkit. I'm gonna try and break stuff before :) [19:52:05] :-) [20:01:29] eileen: I think I already did it. lol I think I got a runaway query [20:01:52] well done [20:02:23] dstrine: I have an update ready to go out when it's +2d with some improvements to search kit [20:02:35] (would have been good to do today with people being off) [20:07:33] eileen: yeah friday tends to be chill maybe someone could help deploy it? could you kill whatever query I did? I think there may be 2 at this point :P [20:07:50] hmmm the wheel already stopped spinning [20:13:21] oh yeah some queries on the read only db [21:12:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-drupal-upgrade-2021: develop more detail plan on queue refactor for drupal upgrade - https://phabricator.wikimedia.org/T279962 (DStrine) [21:55:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: relationship giving test query doesn't return some data for the related contact - https://phabricator.wikimedia.org/T279966 (DStrine) [23:06:25] (Abandoned) Eileen: Additional check pre-tearDown for MergeTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/677068 (owner: Eileen) [23:06:34] (Restored) Eileen: Additional check pre-tearDown for MergeTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/677068 (owner: Eileen) [23:16:57] (PS8) Eileen: Move skipping of wmf-donor fields to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676175 (https://phabricator.wikimedia.org/T270679) [23:16:59] (PS4) Eileen: Move handling for do_not_solicit field to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676180 (https://phabricator.wikimedia.org/T270679) [23:18:04] (PS6) Eileen: Move preferred_language [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676181 (https://phabricator.wikimedia.org/T270679) [23:18:06] (PS3) Eileen: Add additional check on data before tearDown [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/677061 [23:18:08] (PS5) Eileen: Add test and fix for handling emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/677414 (https://phabricator.wikimedia.org/T276391)