[01:40:46] eileen: oh man, I spent a while trying to trigger that new location resolve code and getting stumped as to why it wasn't finding any conflicts, but of course it was because the old code was handling them still [01:41:13] though looking at the patch where you drop the old code, I'm a bit sad at losing the only country vs full address resolution [01:41:33] in case someone donates e.g. via paypal and doesn't share their full addy, all we have is country for the new contact [01:42:00] and if we have full addy for the old one don't we want to keep using that? [01:45:29] I can try my hand at writing an AddressQualityResolver [01:49:05] (PS2) Ejegg: Clean up some unused imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676483 [01:49:32] (PS1) Ejegg: Deduper settings: store groups to skip as array [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679069 [02:01:29] Fundraising-Backlog, FR-AutoTY-Email, fr-donorservices, Epic, FR-Email: Creating exceptions for when to send the recurring expiry/fail email - https://phabricator.wikimedia.org/T276959 (MBeat33) Thank you, @CDenes_WMF - Yes, they are translation requests, and waiting to finalize before deploy... [02:13:13] (CR) Eileen: [C: +2] Deduper settings: store groups to skip as array [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679069 (owner: Ejegg) [02:27:49] (Merged) jenkins-bot: Deduper settings: store groups to skip as array [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679069 (owner: Ejegg) [02:29:35] eileen: I think I found an issue in MergeHandler::isBlockUnique [02:29:47] if ($existingEntity !== $blockNumber && $.... [02:30:02] but $existingEntity is always an array and blockNumber is an int [02:30:26] maybe comparing the ids would be the way to go here? [02:30:28] ejegg: did I fix that in the second one? [02:30:35] oh, lemme look [02:31:09] not that I can see [02:32:49] hmm ok - there is a lot of witchcraft going on [02:33:16] so basically that fn compares one block with the list of all blocks [02:33:32] and should only return false if there's a different location block that's equivalent [02:33:43] yah, i think an ID comparison would be the thing [02:34:14] i'll put up another micropatch [02:34:25] so - existingentity comes from iterating the array [02:34:27] foreach ($this->getAllLocationBlocks($locationEntity) [02:34:46] yep yep, and it's an array of arrays from what I see stepping through [02:34:51] ok htat makes sense [02:35:16] so the block number is a weird thing [02:35:39] it's the Home / Billing / etc type? [02:35:48] kinda [02:36:15] is that relevant for the uniqueness test? [02:36:18] it's matched by location type [02:36:30] BUT the primary is matched regardless of type [02:36:54] yeah - I kinda think we should maybe just remote the comparison [02:37:02] because it's never true - so take it out [02:37:22] or rather it's never false [02:37:34] so with the code as-is, and my address resolution setting to 'preferred_contact_with_re-assign' [02:37:53] i never seem to get that re-assignment [02:37:59] - on address or email? Because that patch should only be tested with email [02:38:07] arrrr [02:38:09] silly me [02:38:14] the second patch removes wmf_civicrm stuff that deals with address [02:38:24] i've been testing with address, with that wmf_civicrm unset line commented out [02:38:36] yeah - it's not that nice [02:38:55] just because I've been testing the deduper with contacts that always have the same email [02:39:33] maybe pull both in & test together ? (if they don't conflict) [02:40:17] yah, will do [02:40:40] I think they WERE in a direct chain, till you rebased the thing in the middle of them for deploy last night [02:40:45] so probs no conflicts [02:41:36] grr, gerrit connection notworking [02:41:52] hmm, web ui still worky [02:42:17] tunnel tunnel tunnel [02:45:03] ejegg: ok I was getting confused [02:47:22] I feel like last round I had good ideas about how to restructure it but things kept failing tests & I kept ad hoc fixing until they worked but it feels like some weird things happened [02:47:35] But - at least there are lots of tests [03:02:31] (CR) Eileen: [C: +2] "My IDE thinks your IDE is right" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676483 (owner: Ejegg) [03:09:17] (PS2) Eileen: Fix entity-ref search by id [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/678968 (https://phabricator.wikimedia.org/T280065) [03:13:26] oh jeez, i musta had an earlier version of your first patch [03:13:52] pulled down the latest and I see that comparison is now if ($existingEntity['block'] !== $blockNumber [03:14:04] so that makes a lot more sense [03:16:51] oic, one can have multiple home emails + multiple billing emails [03:16:59] so that block number is really just an array index [03:17:42] anyyyway, i think i understand what's happening, and it looks good [03:20:59] (Merged) jenkins-bot: Clean up some unused imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676483 (owner: Ejegg) [03:29:15] (PS6) Ejegg: Add test and fix for handling emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/677414 (https://phabricator.wikimedia.org/T276391) (owner: Eileen) [03:30:15] (CR) Ejegg: "PS6: rebase, rewrap commit message < 70chars" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/677414 (https://phabricator.wikimedia.org/T276391) (owner: Eileen) [03:40:52] (CR) Ejegg: [C: +2] "Whew, tricky stuff, this. Looks like it works, though! Nice to not lose data." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/677414 (https://phabricator.wikimedia.org/T276391) (owner: Eileen) [03:41:46] (PS2) Ejegg: Move rest of dedupe handling out of wmf_civicrm.module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/678707 (https://phabricator.wikimedia.org/T270679) (owner: Eileen) [03:45:34] ejegg: don't say you understand - that would be proof you've truly lost it [03:46:12] & yeah it's a bit grey whether multiple emails of one location is valid or not :-( [03:49:58] (PS1) Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/679109 [03:54:41] (CR) Eileen: [C: +2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/679109 (owner: Eileen) [03:58:37] ejegg: I thought you +2d them both - did I imagine that? [04:03:12] I did the first one, about to +2 the second [04:03:25] but wikibugs pinged on the rebases too [04:07:15] eileen: for the second patch, it looks like you're now indexing the ($entity)Conflicts fields by block number [04:08:02] ejegg: yeah I think that I had to make that change for ... some reason ... to make tests pass [04:08:09] (I've already blocked it out) [04:08:25] but inside the get(entity)Conflicts functions I still see things like this: $this->phoneConflicts[$field] = $value; [04:08:42] maybe need to add that [$blockNumber] index in there too? [04:08:54] or, adding that would at least save the recalculation later [04:10:38] well, it seems to return the right value anyway [04:10:46] I'll +2 for now [04:11:49] ejegg: yeah that was what I was saying about it having strayed from the original vision & just gotten a bit confusing :-( [04:12:32] (CR) Ejegg: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/678707 (https://phabricator.wikimedia.org/T270679) (owner: Eileen) [04:24:00] whew, started in on a lil cleanup patch and it's spiraling out [04:25:20] yep [04:25:46] well there was a reason that stuff was still in wmf_civicrm - cos it was in the too hard basket last time [04:26:04] :) [04:27:49] (Merged) jenkins-bot: Move rest of dedupe handling out of wmf_civicrm.module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/678707 (https://phabricator.wikimedia.org/T270679) (owner: Eileen) [04:29:36] (PS1) Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/679120 [04:29:52] (CR) Eileen: [C: +2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/679120 (owner: Eileen) [04:42:32] !log civicrm revision changed from a4c1a7b842 to 649e415c07, config revision is c5fc1b91e0 [04:42:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:44:19] Fundraising Sprint Git Rebase Jump, Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Move all remaining dedupe code out of wmf_civicrm to deduper extension - https://phabricator.wikimedia.org/T270679 (Eileenmcnaughton) this is do... [04:44:49] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM theme update - https://phabricator.wikimedia.org/T278888 (Eileenmcnaughton) a:Eileenmcnaughton [04:46:40] Fundraising Sprint Git Rebase Jump, Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Most recent email address becomes primary email address, former email address is moved to “Other” - https://phabricator.wikimedia.org/T276391 (Ei... [04:48:32] (PS1) Ejegg: Deduper: consistently index ($location)Conflicts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679128 [04:48:35] (PS1) Ejegg: Type hints for deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679129 [05:01:28] (CR) Eileen: "just looking - but noting the first (non blocking) think I spotted" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679129 (owner: Ejegg) [05:02:19] whew, locally I get a lotta test fail [05:02:38] though I should try those without my patches [05:02:49] (CR) jerkins-bot: [V: -1] Type hints for deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679129 (owner: Ejegg) [05:04:57] oh right, typed class properties are 7.4 [05:05:05] lemme at least pull that back [05:05:50] oh - I wondered about that as I hadn't seen it before [05:05:59] I just noted a deduper failmail - I'd better check [05:07:30] (PS2) Ejegg: Type hints for deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679129 [05:07:32] (PS1) Ejegg: Deduper: don't error when no skipped groups [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679146 [05:07:57] ohh that deduper fail mail is a it scary - CiviCRM_API3_Exception: [undefined: invalid criteria for IN [05:08:10] heh, maybe https://gerrit.wikimedia.org/r/679146 would help? [05:08:22] yeah - just saw that - super fast! [05:08:35] actually i hit the same problem locally [05:08:44] though it should also fix to just set that setting in the UI [05:08:50] lemme try that on prod [05:09:19] ejegg: why did you change from an arrayObject to an array? [05:09:55] - also if you want to you can just cast ie return (array) ..... [05:09:58] ah, just so that the return [] would work [05:10:01] oh yah [05:10:03] ah [05:10:05] that makes sense [05:10:21] and i wasn't sure how to get an empty ArrayObject [05:10:33] will change that to just cast [05:10:39] yeah - would have had to 'trick' it I think [05:10:46] and pop that patch to the front of the stack [05:11:15] however, that setting shouldn't be empty on live - so it's a good fix IMHO but we shouldn't deploy until we are sure there isn't another error (it could have been cache clearing) [05:11:41] (PS2) Ejegg: Deduper: don't error when no skipped groups [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679146 [05:11:43] (PS2) Ejegg: Deduper: consistently index ($location)Conflicts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679128 [05:11:45] (PS3) Ejegg: Type hints for deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679129 [05:12:31] eileen: I just looked in the UI on live and the multiselect was blank, so I selected wmf_donor and saved [05:12:47] now going back to the settings it seems to have persisted [05:12:56] hmm, lemme look in the log table to see what it was before [05:14:06] ahh, I guess it was the setting type change [05:14:18] previously was s:11:"wmf_donor"; [05:14:33] and I guess with my 'Array' change that didn't unserialize right [05:14:36] oops! [05:14:47] now it's a:1:{i:0;s:9:"wmf_donor";} [05:15:51] well, it's getting pretty late here. I should probably head to bed! [05:16:09] ejegg: yeah I did push out your change to that field [05:16:28] & I did re-save via the UI [05:16:40] oh really? [05:17:12] hmm, I guess there was something cached [05:17:32] yep - to be honest I didn't test your change - I +2d it because I assumed you had fought the UI long & hard & was going to take your word for it [05:17:40] right, the log_date on that s:11 version was 2021-04-14 04:47:45 [05:18:05] and then 20 min later when I saved at 2021-04-14 05:09:23 it saved as a:1:{i:0;s:9:"wmf_donor";} [05:18:08] yeah - I had to update the handling on address & phone since we had moved from wmf_civicrm [05:18:34] so - are you saying the currently saved value is OK? [05:18:45] yah, i see it persisted in the UI anyway [05:19:00] I could try a quick dedupe to check [05:19:01] ok - so if we don't see another fail mail then all is good [05:19:05] yeah for sure [05:19:16] lessee if I've got any new dupe records [05:21:13] I did a couple of UI merges [05:21:43] yep, me too [05:22:09] (CR) jerkins-bot: [V: -1] Deduper: don't error when no skipped groups [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679146 (owner: Ejegg) [05:22:09] and that 'invalid value for IN' exception would happen on the UI too [05:22:23] oh hey, jenkins didn't like that fix [05:22:32] (CR) Eileen: [C: +2] Deduper: don't error when no skipped groups [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679146 (owner: Ejegg) [05:22:53] lol, depends on a change that failed to merge [05:22:59] ah, before the rebase [05:23:07] thanks eileen! [05:23:21] jenkins seems a bit confused IMHO [05:26:22] (CR) Eileen: [C: +2] "Yep - stricter is better & I think the tests would have failed if any issues - let's not deploy tonight though :-)" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679129 (owner: Ejegg) [05:27:37] good night eileen [05:38:20] (Merged) jenkins-bot: Deduper: don't error when no skipped groups [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679146 (owner: Ejegg) [05:50:26] eileen: hi! I'm trying to figure out https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/678968 but I guess I don't understand it [05:50:43] AndyRussG: fair enough! [05:50:52] also, locally when I go to new contribution and soft credit [05:51:04] and try to select contact ID in refine search [05:51:09] it doesn't appear! [05:51:17] right - which is the bug report [05:51:19] however, strangely, I thought I saw it once [05:51:32] yep - which I also hit - because it was cached for me [05:51:47] ah I was on master [05:51:51] yeah I did do drush cc all [05:52:18] so the new good behaviour is that if you don't select anything you can enter the contact id & it will load [05:52:46] Coleman removed contact id from refine search because the way it worked was kinda awful [05:53:14] hmm so should I or should I not be seeing contact id? [05:53:19] ie you had to enter the contact id in the box AND enter a letter in the contact's name up higher - because it was 'refining' your main search [05:53:26] so contact id is gone [05:53:43] but just entering contact id - without changing anything else should work [05:53:54] hmmm [05:54:13] eileen: ahhh yes that does work! [05:54:39] yep - it's confusing that it's changed as it has but then I have to agree it was confusing before too [05:54:53] hmmm seems fine the new way! [05:55:00] yeah [05:55:33] eileen: ok so I can confirm that that functionality is now present with the patch [05:55:38] cool [05:55:40] but I don't understand basically anything else about it [05:55:45] lol [05:56:11] well the request is 'give us back the ability to search by contact id which we lost in yesterday's code update' [05:56:12] do you want me to +2? or try to dig in (tomorrow)? or leave it for someone else who does understand this bit of the code? [05:56:25] right [05:56:51] I think it's OK not to understand the code because it's already been written by one person (Coleman) & reviewed by another (me) & merged upstream [06:00:30] eileen: heheh okok sounds legit.... so +2, right? [06:00:37] :-) yep [06:04:27] (CR) AndyRussG: [C: +2] "Yay, thanks!! :)" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/678968 (https://phabricator.wikimedia.org/T280065) (owner: Eileen) [06:05:31] k done! [06:05:48] aaaaand now it's definitely sleepytime :) cya! [06:06:40] thanks! [06:22:52] (Merged) jenkins-bot: Fix entity-ref search by id [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/678968 (https://phabricator.wikimedia.org/T280065) (owner: Eileen) [06:25:00] (PS1) Eileen: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679178 [06:25:12] (CR) Eileen: [C: +2] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679178 (owner: Eileen) [06:40:24] (PS4) Eileen: Type hints for deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679129 (owner: Ejegg) [06:41:12] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/679201 (owner: L10n-bot) [06:42:22] (PS1) Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/679229 [06:42:32] (CR) Eileen: [C: +2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/679229 (owner: Eileen) [06:47:12] !log civicrm revision changed from 649e415c07 to ec2a3bcff6, config revision is c5fc1b91e0 [06:47:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [06:48:42] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Contact ID field for soft credit on contribution record is missing - https://phabricator.wikimedia.org/T280065 (Eileenmcnaughton) @MDemosWMF - this should work now - but note y... [06:50:08] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/679201 (owner: L10n-bot) [07:25:39] fundraising-tech-ops: deploy Let's Encrypt certificates for additional fundraising services - https://phabricator.wikimedia.org/T280034 (ayounsi) [14:35:44] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Contact ID field for soft credit on contribution record is missing - https://phabricator.wikimedia.org/T280065 (MDemosWMF) @Eileenmcnaughton Just tested it and is working when... [15:14:41] Fundraising Sprint Git Rebase Jump, Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Most recent email address becomes primary email address, former email address is moved to “Other” - https://phabricator.wikimedia.org/T276391 (SH... [15:21:13] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM theme update - https://phabricator.wikimedia.org/T278888 (DStrine) p:Triage→Medium [15:21:19] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog: Edits to MC Upsell TY Emails in production [by ED transition] - https://phabricator.wikimedia.org/T278460 (DStrine) p:Triage→High [15:21:36] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Stock TY email in Civi - double send/different templates - https://phabricator.wikimedia.org/T280047 (DStrine) p:Triage→Medium [15:21:55] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-drupal-upgrade-2021: develop more detail plan on queue refactor for drupal upgrade - https://phabricator.wikimedia.org/T279962 (DStrine) p:Triage→Medium [15:22:09] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Org Contact Fields in Engage Import not Importing to Record - https://phabricator.wikimedia.org/T278892 (DStrine) p:Triage→Medium [15:22:18] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-drupal-upgrade-2021: Remove unused code from wmf_civicrm - https://phabricator.wikimedia.org/T270678 (DStrine) p:Triage→Medium [15:22:29] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-drupal-upgrade-2021: Convert wmf_campaigns to an extension - https://phabricator.wikimedia.org/T270676 (DStrine) p:Triage→Medium [15:22:56] Fundraising Sprint Git Rebase Jump, Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, FR-Docker, Patch-For-Review: fundraising-dev CiviCRM set up failures (with fixes and workarounds) - https://phabricator.wikimedia.org/T279669 (DStrine) p:Triage→Medium [15:23:15] Fundraising Sprint Corrugated super slide, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Esperantoland, Fundraising Sprint File Systems Stage Show, and 5 others: Create civiproxy on docker - https://phabricator.wikimedia.org/T268683 (DStrine) p:High→Medium [15:32:55] fr-tech anything to share with scrum-o-scrums? [15:38:41] nay from me ejegg ! [15:44:13] fr-tech we've got another couple of candidate task submissions that we can sink our teeth into over some of tech-talk [15:44:37] ejegg: nothing here, thanks :) [15:44:46] jgleeson: ah cool fun fun [15:52:22] (PS1) Cstone: Update recurring notification emails. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679374 [15:56:22] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: Edits to MC Upsell TY Emails in production [by ED transition] - https://phabricator.wikimedia.org/T278460 (TSkaff) [16:02:19] (PS2) Cstone: Update recurring notification emails. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679374 [16:32:56] (CR) jerkins-bot: [V: -1] Update recurring notification emails. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679374 (owner: Cstone) [16:38:11] (CR) Jgleeson: [C: +1] "Little late sorry! but I've tested this locally also and the donation interface logs look good post the update to monolog 2.2.0!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/642028 (https://phabricator.wikimedia.org/T268207) (owner: Jforrester) [16:41:07] (CR) Ejegg: [C: +2] "Markup and template info comments look good, I think that katakana says Shimi Uerusu ? Close enough!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679374 (owner: Cstone) [16:41:19] (PS3) Ejegg: Update recurring notification emails. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679374 (owner: Cstone) [16:43:11] (PS4) Ejegg: Update recurring notification emails. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679374 (owner: Cstone) [16:43:48] oops, that rebase'll probably upset the merge-on-submit [16:47:01] (PS2) Ejegg: Update shoreditch theme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679019 (https://phabricator.wikimedia.org/T278888) (owner: Eileen) [17:07:27] hah jimi weeruzu ejegg [17:16:47] Fundraising-Backlog, fundraising-tech-ops: timeboxed description of fr-tech vs WMF security settings and processes - https://phabricator.wikimedia.org/T280173 (DStrine) p:Triage→Medium [17:32:07] (CR) Cstone: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679374 (owner: Cstone) [18:18:59] (PS2) Ejegg: Make select and inputs same height on Firefox [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/616122 (https://phabricator.wikimedia.org/T187451) (owner: Pcoombe) [18:24:49] Fundraising-Backlog: Civi-Fredge not importing correctly - https://phabricator.wikimedia.org/T280179 (EMartin) [19:05:42] (CR) Ejegg: "17px seems to be the sweet spot for me - any smaller and the text inputs stay the same height while just the select shrinks. At 15px, the " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/616122 (https://phabricator.wikimedia.org/T187451) (owner: Pcoombe) [19:08:08] Fundraising Sprint File Systems Stage Show, Fundraising Sprint Git Rebase Jump, Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, FR-AutoTY-Email: Production of New Annual Fund Thank You Email (due to ED transition) - https://phabricator.wikimedia.org/T278363 (CDenes_WMF... [19:12:52] fundraising-tech-ops: deploy Let's Encrypt certificates for additional fundraising services - https://phabricator.wikimedia.org/T280034 (Jgreen) [19:17:24] fundraising-tech-ops, Patch-For-Review: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (Dwisehaupt) Note: Can't roll forward on `require ssl` for the fr_stats db user until we sort out the older python2 DjangoBannerStats code and its connections. [19:42:22] Fundraising Sprint Git Rebase Jump, Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, FR-Civi-Dedupe, fr-donorservices: Civi: enable agents to view and edit the dedupe 'nickname' rules list - https://phabricator.wikimedia.org/T244404 (Eileenmcnaughton) a:Eileenmcnaugh... [19:43:43] Fundraising-Backlog: Civi-Fredge not importing correctly - https://phabricator.wikimedia.org/T280179 (Ejegg) Hi @EMartin, I'm looking at the database, and the order_id column for all the Ingenico transactions is using the merchant reference, not the Ingenico transaction ID. Can you try again with the merchan... [19:47:08] (PS1) Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/679431 [19:47:23] (CR) Cstone: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/679431 (owner: Cstone) [19:49:07] Fundraising-Backlog: Civi-Fredge not importing correctly - https://phabricator.wikimedia.org/T280179 (EMartin) Oh, for heaven's sake! Yes, that's the problem. All good now. I didn't catch that. Sorry about that. Evelyn [19:49:09] Fundraising-Backlog: Civi-Fredge not importing correctly - https://phabricator.wikimedia.org/T280179 (EMartin) Open→Resolved a:EMartin [19:50:23] !log civicrm revision changed from ec2a3bcff6 to c3342aa4ea [19:50:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:51:31] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, FR-AutoTY-Email: Edits to MC Upsell TY Emails in production [by ED transition] - https://phabricator.wikimedia.org/T278460 (Cstone) @CDenes_WMF the updates are now live [19:58:06] fundraising-tech-ops: deploy Let's Encrypt certificates for additional fundraising services - https://phabricator.wikimedia.org/T280034 (Jgreen) [20:08:41] (CR) Ejegg: [C: +2] "Looks good to me!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679019 (https://phabricator.wikimedia.org/T278888) (owner: Eileen) [20:10:14] (PS1) Ejegg: Add --file options to audit parser [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679436 (https://phabricator.wikimedia.org/T265545) [20:11:10] fr-tech anyone available to review a quick update to the audit parser? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/679436 [20:11:26] just lets us specify a single filename to (re)parse [20:21:41] (Merged) jenkins-bot: Update shoreditch theme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679019 (https://phabricator.wikimedia.org/T278888) (owner: Eileen) [20:31:37] (PS1) Eileen: Remove function only used in old update script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679444 (https://phabricator.wikimedia.org/T270678) [20:43:24] (PS1) Eileen: Remove unused functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679474 (https://phabricator.wikimedia.org/T270678) [20:43:26] (PS1) Eileen: Remove legacy data cleanup update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679475 (https://phabricator.wikimedia.org/T270678) [20:43:28] (PS1) Eileen: Remove legacy data cleanup update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679476 (https://phabricator.wikimedia.org/T270678) [20:43:30] (PS1) Eileen: Remove legacy data cleanup update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679477 (https://phabricator.wikimedia.org/T270678) [20:44:45] ejegg: I'm just going with ripping out the old cleanup from the install script - we could re-use some of the code if we hit it again but I doubt we would find it / get that much benefit [20:45:45] (CR) Eileen: [C: +2] Add --file options to audit parser [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679436 (https://phabricator.wikimedia.org/T265545) (owner: Ejegg) [20:52:49] thanks eileen [20:53:00] (PS1) Eileen: Remove legacy data cleanup update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679481 (https://phabricator.wikimedia.org/T270678) [20:53:03] (PS1) Eileen: Remove legacy data cleanup update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679482 (https://phabricator.wikimedia.org/T270678) [20:53:04] no worries - seemed simple [20:53:05] (PS1) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679483 (https://phabricator.wikimedia.org/T270678) [20:53:07] (PS1) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679484 (https://phabricator.wikimedia.org/T270678) [20:53:09] (PS1) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679485 (https://phabricator.wikimedia.org/T270678) [20:53:11] (PS1) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679486 (https://phabricator.wikimedia.org/T270678) [20:58:38] Fundraising Sprint Git Rebase Jump, Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13): Non-english soft descriptor - https://phabricator.wikimedia.org/T277598 (Ejegg) These updates got deployed with the security patch yesterday [21:01:49] (PS2) Ejegg: Remove function only used in old update script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679444 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:03:21] (CR) Ejegg: [C: +2] Remove function only used in old update script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679444 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:04:45] (PS2) Ejegg: Remove unused functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679474 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:05:19] (CR) Ejegg: [C: +2] "Guessing you zap the calculated_field_names fn too later?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679474 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:05:53] (PS2) Ejegg: Remove legacy data cleanup update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679475 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:06:15] (CR) Ejegg: [C: +2] "It served us well and now its day is gone past." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679475 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:07:35] fundraising-tech-ops: deploy Let's Encrypt certificates for additional fundraising services - https://phabricator.wikimedia.org/T280034 (Jgreen) [21:08:02] (PS1) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679488 (https://phabricator.wikimedia.org/T270678) [21:08:04] (PS1) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679489 (https://phabricator.wikimedia.org/T270678) [21:11:04] (Merged) jenkins-bot: Add --file options to audit parser [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679436 (https://phabricator.wikimedia.org/T265545) (owner: Ejegg) [21:21:33] (Merged) jenkins-bot: Remove function only used in old update script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679444 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:22:58] (PS2) Ejegg: Remove legacy data cleanup update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679476 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:23:08] (CR) Ejegg: [C: +2] "Phew, this one was a doozy!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679476 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:25:20] (PS2) Ejegg: Remove legacy data cleanup update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679477 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:25:31] (CR) Ejegg: [C: +2] Remove legacy data cleanup update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679477 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:26:53] (Merged) jenkins-bot: Remove unused functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679474 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:31:19] (PS2) Ejegg: Remove legacy data cleanup update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679481 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:31:50] (CR) Ejegg: [C: +2] Remove legacy data cleanup update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679481 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:32:36] (PS2) Ejegg: Remove legacy data cleanup update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679482 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:34:36] (CR) Ejegg: [C: +2] Remove legacy data cleanup update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679482 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:35:49] (PS2) Ejegg: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679483 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:36:38] (CR) Ejegg: [C: +2] Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679483 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:37:21] I'm not sure why some are stale but I'll let the ones that are gonna merge merge before I try any rebasing [21:38:18] (PS2) Ejegg: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679484 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:38:24] (CR) Ejegg: [C: +2] Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679484 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:42:56] (PS2) Ejegg: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679485 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:43:07] (CR) Ejegg: [C: +2] "memories..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679485 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:45:15] (PS2) Ejegg: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679486 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:45:48] (CR) Ejegg: [C: +2] "...light up the corners of my mind..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679486 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:46:59] (PS2) Ejegg: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679488 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:48:47] (CR) Ejegg: [C: +2] "Wow, we really have come a long way in data quality over the years!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679488 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:50:57] (PS2) Ejegg: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679489 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:53:54] (CR) Ejegg: [C: +2] "These rows seem to exist in the db in docker, so I guess this was just to overcome a missing update?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679489 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:54:29] (PS3) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679483 (https://phabricator.wikimedia.org/T270678) [21:54:31] (PS3) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679484 (https://phabricator.wikimedia.org/T270678) [21:54:33] (PS3) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679485 (https://phabricator.wikimedia.org/T270678) [21:54:35] (PS3) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679486 (https://phabricator.wikimedia.org/T270678) [21:54:37] (PS3) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679488 (https://phabricator.wikimedia.org/T270678) [21:54:39] (PS3) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679489 (https://phabricator.wikimedia.org/T270678) [21:54:41] (PS1) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679496 (https://phabricator.wikimedia.org/T270678) [21:54:43] (PS1) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679497 (https://phabricator.wikimedia.org/T270678) [21:54:45] (CR) jerkins-bot: [V: -1] Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679484 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:54:47] (CR) jerkins-bot: [V: -1] Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679485 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:54:49] (CR) jerkins-bot: [V: -1] Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679486 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:54:51] (CR) jerkins-bot: [V: -1] Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679488 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:54:53] (CR) jerkins-bot: [V: -1] Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679489 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:55:11] dang pushing more up did what I hoped not to do [21:55:32] oops, rebased backwards? [21:56:29] no - I think they are fine [21:56:45] I'm just not sure if the exisitn verifies now have to start again [21:56:53] ah boo, probably [21:57:08] ie the patch was unchanged per https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/679483 [21:57:12] i want to push that audit change up to try reparsing an old adyen file [21:57:26] so lemme do a deploy while we wait for zuul to untangle that [21:57:43] (PS1) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679498 (https://phabricator.wikimedia.org/T270678) [21:57:45] (PS1) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679499 (https://phabricator.wikimedia.org/T270678) [21:58:07] yep good idea [21:58:21] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679484 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:58:29] whoa, wha happen to my local checkout? mucho delete-o [21:58:39] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679483 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [21:59:40] when I do 'git checkout deployment' I see: fatal: cannot unlink 'drupal/sites/default/files/civicrm/persist/index.html': Permission denied [22:00:14] and then 'git status' show a zillion files deleted, including most of the drupal/sites folder [22:00:17] hmm hmm [22:03:50] yeah that is weird - we desymlinked sites but that sounds the wrong way around [22:05:30] I'm feeling a bit glazed by this install file - getting rid of those functions helps get rid of functions only called from them & it's good cleanup but it's getting a little tedious [22:05:32] well, guess I can just reclone the deployment branch from upstream [22:05:46] yah eileen, I can take another pass at it [22:05:49] yeah or git reset gerrit/deployment [22:06:07] right, I just can't get it to correctly be on that branch [22:07:15] ok, it's happy now [22:07:57] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/679500 [22:08:03] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/679500 (owner: Ejegg) [22:08:26] (CR) Ejegg: [C: +2] Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679483 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [22:08:41] (CR) Ejegg: [C: +2] Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679484 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [22:12:22] hmm, kernel update here. that'll kill a few minutes while zuul chews on the crm queue [22:16:11] oh hey, there's a CN code hygiene patch that'll go stale if it's left much longer [22:17:03] (PS4) Ejegg: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/628379 (https://phabricator.wikimedia.org/T253169) (owner: Reedy) [22:17:13] AndyRussG: I'mma take a look at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/628379 and maybe +2. Looks pretty harmless, but lmk if you have any concerns [22:20:50] AndyRussG: we got a happy response from that patch you +2d last night [22:21:55] (PS1) Eileen: Remove tokenize-damaged [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679510 (https://phabricator.wikimedia.org/T270678) [22:21:57] (PS1) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679511 (https://phabricator.wikimedia.org/T270678) [22:22:00] (PS1) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679512 (https://phabricator.wikimedia.org/T270678) [22:22:01] (PS1) Eileen: Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679513 (https://phabricator.wikimedia.org/T270678) [22:22:11] (CR) jerkins-bot: [V: -1] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/628379 (https://phabricator.wikimedia.org/T253169) (owner: Reedy) [22:22:20] ok all +2d patches now merged & I've pushed up all the ones I had locally now [22:35:34] cool cool [22:36:25] (PS5) Ejegg: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/628379 (https://phabricator.wikimedia.org/T253169) (owner: Reedy) [22:37:39] oh heck, kernel update seems to have disabled the trackpoint nub and the buttons above the trackpad [22:37:43] that's annoying [22:37:56] let's see [22:38:59] (CR) Ejegg: [C: +1] "+1 to existing patch. PS5 adds visibility to a couple of things added since this patch was originally filed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/628379 (https://phabricator.wikimedia.org/T253169) (owner: Reedy) [22:41:52] huh, working after a full power down and restart, same kernel version [22:41:56] ok [22:42:03] o [22:42:39] AndyRussG: want to +2 that constant visibility patch? Seems simple enough, but now I've touched the code too so it should get another peek from someone [22:49:20] (CR) Ejegg: [C: +2] "Ooh, those unintended recurrings from 2017 were a mess, weren't they" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679496 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [22:49:30] (CR) Ejegg: [C: +2] Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679497 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [22:49:32] (CR) Ejegg: [C: +2] Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679498 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [22:49:42] (CR) Ejegg: [C: +2] Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679499 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [22:49:46] (CR) Ejegg: [C: +2] Remove tokenize-damaged [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679510 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [22:50:20] (CR) Ejegg: [C: +2] "heh, removing the code to remove the old globalcollect code. loveit." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679511 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [22:52:48] (CR) Ejegg: [C: +2] "Oh jeez, that paypal bug was a real pain. Here's hoping we never have to do something like that again." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679512 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [22:53:23] (CR) Ejegg: [C: +2] Remove more unused update functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679513 (https://phabricator.wikimedia.org/T270678) (owner: Eileen) [23:04:34] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, SEO: CentralNotice code to fix the banner bump with “ESI and pageview+1 with possible exceptions for infrequent visitors or as needed” - https://phabricator.wikimedia.org/T279034 (Jdlrobson) If the banner was position fixe... [23:27:23] (PS1) Ejegg: Delete more wmf_civicrm update cruft [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/679521 [23:33:36] eileen: can we maybe get rid of wmf_civicrm_civicrm_post_Contribution ? [23:33:52] It looks liek those lastDonation params are all handled in the wmf_donor trigger now, I think [23:34:08] is there some case where that wouldn't fire but the post hook would? [23:34:38] I'm not sure - would have to re-dig but I think there *might* have been some we couldn't get to that way - maybe last original currency [23:34:41] or something [23:35:46] hmm, ok [23:37:18] no, that trigger does grab original currency from the extra table [23:38:34] huh, though the commit message is "Use post hook rather than triggers for original amount / currency" [23:39:30] ok, so you did the commit hook in April 2018 [23:39:50] but then in July 2019 you redid the triggers which now seem to set all those fields [23:41:46] let's see, the post hook does already check to see if its calculation is equal to the existing field value [23:42:00] so I guess we could tell it to log something when they're different [23:42:06] and then if we never see that log string [23:42:09] we can delete the post hook [23:48:36] yeah - that might work - do some tests...