[00:43:24] Fundraising-Backlog, Desktop Improvements, MediaWiki-extensions-CentralNotice, Product-Design-Strategy, and 4 others: Overview and general discussion: Strategies to prevent search ranking decline due to banners and Google metrics coming into effect May 1, 2... - https://phabricator.wikimedia.org/T280476 [02:59:34] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Product Infrastructure Roadmap, Readers-Web-Backlog, and 2 others: CentralNotice code to fix the banner bump with “pageview+1 with exceptions for infrequent visitors and as needed” - https://phabricator.wikimedia.org/T279034 (AndyRussG) [03:31:19] Fundraising-Backlog, Continuous-Integration-Infrastructure, Release-Engineering-Team, Patch-For-Review: Create composer-test-php70 docker image for fundraising tech's crm tests - https://phabricator.wikimedia.org/T230446 (thcipriani) [07:30:35] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1221 [07:35:38] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 2122747 Threads: 18 Questions: 49016215 Slow queries: 1737810 Opens: 361343964 Flush tables: 1 Open tables: 305 Queries per second avg: 23.090 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1 [13:29:45] Fundraising-Backlog, MediaWiki-Cache, Product-Infrastructure-Team-Backlog: ESI in the cache? 2021 Redux - https://phabricator.wikimedia.org/T280479 (MSantos) [13:29:55] Off to pick up Oscar. Back later! [14:20:08] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Product Infrastructure Roadmap, Readers-Web-Backlog, and 2 others: CentralNotice code to fix the banner bump with “pageview+1 with exceptions for infrequent visitors and as needed” - https://phabricator.wikimedia.org/T279034 (AndyRussG) [14:26:04] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Fr-planning-ahead: Email preference center: create new mail type "Email Preference Country" - https://phabricator.wikimedia.org/T280674 (DStrine) [14:26:49] Fundraising-Backlog, fr-email-preference-center, FR-Email, Patch-For-Review: Email Preference Center Prototype - https://phabricator.wikimedia.org/T263887 (DStrine) [14:27:27] Fundraising-Backlog, fr-email-preference-center, FR-Email, Patch-For-Review: Email Preference Center Prototype - https://phabricator.wikimedia.org/T263887 (DStrine) Just to note here I removed the country requirement and I'm making tasks to handle that as a new mail type in civi for the final ver... [14:30:29] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Fr-planning-ahead, Epic: Email preference center: Adjust export to acoustic to accommodate new data types - https://phabricator.wikimedia.org/T280675 (DStrine) [14:53:40] Fundraising-Backlog, MediaWiki-Cache, Product-Infrastructure-Team-Backlog: ESI in the cache? 2021 Redux - https://phabricator.wikimedia.org/T280479 (AndyRussG) [15:46:49] Fundraising-Backlog, FR-AutoTY-Email, fr-donorservices, Epic, FR-Email: Creating exceptions for when to send the recurring expiry/fail email - https://phabricator.wikimedia.org/T276959 (CDenes_WMF) Thank you Kristie! Noted. We will translate in the following languages then: ca da de es419 es... [16:06:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-AutoTY-Email, fr-donorservices: Civi: EoY recurring receipt email – 2021 catchall for retro - https://phabricator.wikimedia.org/T271883 (CDenes_WMF) Hi @krobinson ! Tomasz is working on the updates here that pertain to localization. A few que... [16:17:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-AutoTY-Email, fr-donorservices: Civi: EoY recurring receipt email – 2021 catchall for retro - https://phabricator.wikimedia.org/T271883 (krobinson) Thanks @CDenes_WMF! - We would definitely like to revamp this copy, although I'm not sure w... [16:22:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Japan, FR-Email: Clean up family name, given name order for Japanese donors - https://phabricator.wikimedia.org/T280695 (DStrine) [16:26:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe, FR-Email: Civi dedupe: automatically dedupe alternate family names - https://phabricator.wikimedia.org/T280696 (DStrine) [16:35:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-AutoTY-Email, fr-donorservices: Civi: EoY recurring receipt email – 2021 catchall for retro - https://phabricator.wikimedia.org/T271883 (CDenes_WMF) Thank you Kristie! I think a rewrite makes sense considering the aforementioned donor feedbac... [16:47:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-AutoTY-Email, fr-donorservices: Civi: EoY recurring receipt email – 2021 catchall for retro - https://phabricator.wikimedia.org/T271883 (TSkaff) Thanks both, Please always cc me about matters like this as I am currently the [[ https://docs.g... [16:50:19] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-AutoTY-Email, fr-donorservices: Civi: EoY recurring receipt email – 2021 catchall for retro - https://phabricator.wikimedia.org/T271883 (CDenes_WMF) Noted, thank you Thea! [18:26:31] fr-tech I owe an apology to whichever code test had that insert into ... set syntax [18:26:41] I guess it's valid, at least for mysql! [18:26:52] https://www.bennadel.com/blog/2913-using-the-insert-into-set-syntax-in-mysql.htm [18:27:47] ooh nice ejegg [18:51:59] ejegg well I can't speak for that code test, but if I were it, I would definitely accept your apology :) [18:54:58] hmm [18:55:21] ejegg: I think the actual SQL was something like 'INSERT INTO tbl SET ?' [18:55:49] so unless ? was passed in as 'field=val' [18:56:07] but yeah cool to know. I've not used that either! [18:58:55] looks like it works for mariadb also [20:14:54] Fundraising-Backlog, FR-LATAM: Adding PIX as a payment type for Brazil - https://phabricator.wikimedia.org/T280303 (EMartin) I have been able to confirm that PIX can be added in our current integration as follows: 1. complete pricing agreement, 2. DLocal needs to make some configurations on theirbend t... [20:38:10] Wikimedia-Fundraising-Banners: Decide whether to continue showing fundraising banners on IE11 - https://phabricator.wikimedia.org/T280735 (Pcoombe) [20:46:25] (PS1) Cstone: Update soft descriptor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/681477 (https://phabricator.wikimedia.org/T277598) [21:05:14] eileen: heyy so quick question, if an API has nothing to return other than "success" vs. "failure", what is the standard Civi way for an API to do so? thx! [21:32:07] (PS5) Jgleeson: Add email-preferences to queue configs [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/676944 (https://phabricator.wikimedia.org/T268510) (owner: AndyRussG) [21:32:09] (PS8) Jgleeson: WIP: Add CiviProxy setup [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/673094 (https://phabricator.wikimedia.org/T268683) [21:32:36] (PS9) Jgleeson: WIP: Add CiviProxy setup [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/673094 (https://phabricator.wikimedia.org/T268683) [21:34:21] (PS9) Jgleeson: Civiproxy preferences shell [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [21:35:53] AndyRussG: I looked at the options for injecting the ServerAlias into the generate apache config and I'll be honest I don't like any of them [21:36:29] I'm now thinking it be better to add a readme to setup [21:36:36] for civiproxy [21:37:27] maybe including a README in config/civiproxy or another location? [21:38:11] it's feasible that we'd need a readme to set some stuff up that isn't easily scripted in a sensible fasion [21:38:19] fashion* [21:38:31] jgleeson: hmmmm which options did you look at? [21:39:13] updating apache24-vhost.php (the template for the vhosts to add it regardless of site) [21:39:21] right that's where it should go, no? [21:39:41] yes I agree with adding it regardless of the site [21:39:52] or adding it to setup.sh, a process to inject it after the fact. felt ugly writing to civicrm config files from the civiproxy steps [21:40:01] I don't like that either [21:40:07] adding an unused alias to all sites? [21:40:11] other than wmff [21:40:16] well it won't necessarily be unused [21:40:27] would that pose an issue maybe [21:40:58] as they all run from the same apache instance I think [21:41:13] it's just a way to tell apache to use that config if it comes from [site-name].localhost vs [site-name].[container-name] [21:41:19] so you'd have multiple vhosts listening on the same alias [21:41:37] ah I see... hmmm I was thinking it wouldn't be hardcoded [21:42:27] yeah so in dmaster you'd end up with ServerAlias wmff.civicrm [21:42:35] and any others in the future [21:42:42] it can get the wmff|dmaster string from the beginning of the host variable via a regex [21:42:46] unless we tried to wrap that in a conditional [21:43:17] just a regex extract, and maybe a conditional to check that it extracted properly (in case of a $host with just one part I guess) [21:43:32] so i guess this is making me think should we even do it [21:43:34] if it works without it [21:43:39] and it's not straightforward [21:43:53] it's working fine without it for me [21:43:56] it didn't work for me without it [21:44:13] because civiproxy ended up reaching the dmaster civi site instead of the wmff one [21:44:14] maybe something else wrong in the setup ? [21:44:24] no, it started working when I added that [21:44:35] do you have the dmaster site configured too? [21:45:17] hmm is it still broken? [21:45:26] or did we fix the install [21:45:31] you mean if I remove that line? [21:45:41] hmm I can check, hang on [21:45:43] no sorry, the dmaster install [21:45:47] it was failing remember [21:45:53] I wonder if that hid the issue [21:45:55] the dmaster wasn't broken? [21:45:58] (it not being installed) [21:46:14] it was installed fine [21:46:53] AndyRussG: https://phabricator.wikimedia.org/T279876 [21:47:00] dmaster currently works fine for me, installed via the civiproxy via setup.sh [21:47:01] https://phabricator.wikimedia.org/T279669 [21:47:21] remember it stopped working so we skipped it briefly [21:47:42] jgleeson: ah right, well that was an upstream issue, but the workaround was just to re-run setup.sh [21:48:05] I don't know if that issue is fixed, but on re-running setup.sh it worked fine [21:48:15] I don't think it did fo rme [21:48:17] for me* [21:48:19] if I recall [21:48:28] K it could just be randomly intermittent I guess? [21:48:53] however in any case the expectation is that it will work and folks will have both dmsater and wmff sites set up [21:49:13] https://dmaster.localhost:32353/civicrm [21:49:15] loads for me [21:49:22] but I'm not convinced it's dmaster [21:49:30] lemme check the container [21:49:38] if it's dmaster it'll look totally different [21:49:59] do you have dmaster.localhost_32353.conf? [21:50:29] (CR) jerkins-bot: [V: -1] Civiproxy preferences shell [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [21:51:08] https://phabricator.wikimedia.org/F34408927 [21:51:10] yeah it's not installed [21:51:15] so that might be it [21:51:46] I think we did talk about this and you mentioned it was being tracked in another task [21:52:03] I'll rerun setup in the morning to see if it installs it all correctly [21:52:30] and if I recreate the bug then I guess we need to rejig the vhost template [21:53:00] jgleeson: okok cool, one sec, just adding the settings fix so I can see if civiproxy still dies for me without the ServerAlias line in the apache config [21:53:19] sure [21:54:20] it's working for me now with those changes https://phabricator.wikimedia.org/F34408931 [21:55:33] jgleeson: so, confirmed that civiproxy doesn't work for me without the ServerAlias wmff.civicrm line in wmff.localhost_32353.conf [21:56:09] it's the same error I got before when it was going to dmaster [21:56:24] jgleeson: I'd say try to finish the setup.sh steps for the full civi install of both sites [21:56:40] when yo go to https://dmaster.localhost:32353/civicrm it should show a totally different skin from our civi install [21:57:02] and you should get your dmaster.localhost_32353.conf file [21:57:24] I was just gonna try it then but I think it will setup wmff and dmaster [21:57:27] once that's set up, I think you'll find that indeed civiproxy doesn't work without the server alias line [21:57:38] yes it will set those up [21:57:42] and the drupal install time is beyond atm [21:57:47] so I'll run them first thing [21:58:02] okok right thanks so much for digging in eh! [21:58:43] so if that is the case it sounds like out default wildcard vhost stuff is capturing the requests for wmff.localhost as suspected [21:58:59] np [21:59:09] enjoy tech-talk fr-tech! [21:59:12] bfn [21:59:14] (PS10) Eileen: Civiproxy preferences shell [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) [21:59:37] (CR) Eileen: "AndyRussG you should get an error now" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [22:18:03] (PS1) Cstone: Script to put you into the drupal folder. [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/681487 [22:19:15] (CR) jerkins-bot: [V: -1] Civiproxy preferences shell [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [22:28:43] (Restored) Eileen: Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/649724 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [22:29:48] (CR) AndyRussG: [C: +2] Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/649724 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [22:41:56] (PS1) Eileen: idea [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/681491 [22:46:27] (Merged) jenkins-bot: Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/649724 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [23:03:52] (PS11) AndyRussG: Initial general e-mail preferences prototype [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/672362 (https://phabricator.wikimedia.org/T268510) [23:05:32] (PS2) Eileen: idea [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/681491 [23:07:37] (CR) Cstone: [C: +2] Add config defaults for email-prefs queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/677302 (https://phabricator.wikimedia.org/T268510) (owner: Ejegg) [23:08:31] (Merged) jenkins-bot: Add config defaults for email-prefs queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/677302 (https://phabricator.wikimedia.org/T268510) (owner: Ejegg) [23:11:07] (PS8) AndyRussG: Email Preference Center: Guzzle connetor to Civiproxy [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/677018 (https://phabricator.wikimedia.org/T268497) [23:19:50] eileen: ah hey just remembered the other question I wanted to ask you [23:20:12] shoot [23:20:56] for apache24-vhost.php [23:21:36] if were were to try to make it add automatically a line that says ServerAlias [project_name].[container_name] [23:22:14] so that wmf.localhost_32353.conf gets created with a line that says ServerAlias wmff.civicrm [23:22:39] and then dmaster.localhost_32353.conf gets created with a line that says ServerAlias dmaster.civicrm [23:22:51] where the "civicrm" part comes from an environment variable [23:23:33] (that part needs to be the name of the container as seen from the internal Docker network... it's sent into the containers using the environment variable FR_DOCKER_SERVICE_NAME) [23:23:42] what would be the recommended way of doing that? [23:24:04] I see we get $host and other values as variables inside that template [23:24:18] but I don't know what calls the template and what decides which variables will get [23:24:32] In the worst case, we can hack something up that doesn't need that [23:24:57] since the $host part already says [project_name].localhost, i.e., wmff.localhost [23:25:08] so we could potentially use a regex to extract the first part [23:25:18] and then call get_env to get the environment variable value for the second [23:25:26] but that feels kinda like a hack [23:25:39] so I was wondering if you had any suggestions on a better way to do it :) [23:25:42] thx in advance! [23:26:03] hmm they must be coming out of amp somehow [23:26:15] hmmm ok [23:28:56] I think it's here https://github.com/amp-cli/amp/blob/e0ee8724f6cd2e15911ab4e4fb7c0050426fcfa9/src/Amp/Command/CreateCommand.php#L104 [23:29:44] & here are the variables it collects https://github.com/amp-cli/amp/blob/e0ee8724f6cd2e15911ab4e4fb7c0050426fcfa9/src/Amp/Command/CreateCommand.php#L30 [23:30:00] but in php can't you just do getEnv() [23:30:18] yes you can [23:30:33] so as long as it's set before that apache php file is run it can access it that way [23:30:56] eileen: yeah it's set by Docker when the container starts [23:31:14] K seems like it'd be hackier to try to change things there [23:31:27] yeah - those amp variables are pretty tight [23:32:10] I'll debug a bit and see if any of those additional values are useful, and if not, I think we can just do the regex/getEnv thing directly in the template [23:32:13] thx much! :)