[02:23:16] eileen: I'm also around btw... (I was going to ping you earlier, but I--unexpectedly but not really all that unexpectedly--have the kids for longer than normal, they're still here but are expected to be picked up soon.) Wanted to ask, are there Civi things in the backlog that I could maybe help with? [02:24:04] If I understood correctly, some of them are about talking over options for stuff, or something like that? [02:28:03] (PS1) Eileen: Add monolog extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682345 (https://phabricator.wikimedia.org/T279983) [02:28:05] (PS1) Eileen: Move logging to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) [03:07:00] (PS7) AndyRussG: E-mail preferences center queue consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/680119 (https://phabricator.wikimedia.org/T268511) [03:07:03] (PS2) Eileen: Move logging to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) [03:07:06] (PS1) Eileen: Enable search kit by default on new installs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682347 [03:11:07] eileen: hiiii lmk if you feel like chatting abouthttps://phabricator.wikimedia.org/T279962 :) [03:11:18] (CR) jerkins-bot: [V: -1] Enable search kit by default on new installs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682347 (owner: Eileen) [03:12:18] hmm I don't think my head is in the right space for that one right now - I guess it's blocking though? [03:12:54] eileen: no not at all blocking... I just saw it last week and thought I might pick it up, and was told I should ask u for your thoughts on it [03:13:11] I can also perfectly well dig in on my own or do other stuff :) [03:13:28] yeah - we kinda chatted in that tech talk - I did say I would document what the current civi code does [03:14:40] I do have one thing I needed to ask you - we need to do that full db update to acoustic [03:14:56] & I think I need to pass a value from the command line through to mysql [03:15:10] hmmm [03:15:32] ahh so a python thing, right? [03:15:39] yeah [03:15:49] I think if we can get SET @offSetInDays = 7; [03:16:14] from python rather than hard-coded we could just pass in a super high number to get a full db update [03:16:34] right ok [03:17:03] so the question is how to pass the number for the value of that variable from the python script's command line, right? [03:17:14] I can definitely dig in yeah [03:20:42] yep [03:21:03] even if it doesn't quite work for this use case it will be useful in general - but I think it will [03:21:11] okok [03:28:50] (PS2) Eileen: Enable search kit by default on new installs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682347 [03:28:53] (PS3) Eileen: Move logging to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) [03:30:47] sorry - that didn't quite work for you - you asked me for help & I turned it back on you :-) [03:31:54] eileen: ahh no worries [03:32:22] just looking at that task I feel maybe the only issue is where to put the queue consumer classes? [03:36:23] in this one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/680119 [03:36:41] I moved it to CRM/Queue [03:37:39] I guess that and something about WmfException [03:38:11] (PS3) Eileen: Enable search kit by default on new installs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682347 [03:38:13] (PS4) Eileen: Move logging to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) [03:38:15] (PS1) Eileen: Add monolog extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682348 (https://phabricator.wikimedia.org/T279983) [03:39:46] AndyRussG: so one annoying thing is the code standards in the civi codebase is the drupal one (2 spaces, no tabs) [03:39:46] (CR) AndyRussG: "> Patch Set 6: Code-Review-1" (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/680119 (https://phabricator.wikimedia.org/T268511) (owner: AndyRussG) [03:40:15] eileen: ahhh ooops [03:40:47] K I can fix that [03:40:52] in terms of where to put the class I think it's OK - I want to keep thinking about it - but that's non blocking IMHO [03:41:27] but it does need some form of test - civix actually has a helper to generate the boilerplate for unit tests [03:42:44] hmmm ok [03:42:59] the tabs/spaces thing I imagine can be fixed automagically [03:43:23] yep - you can get drupal configs for your ide [03:43:54] looks like a lot of classes in our Drupal modules already follow Drupal customs [03:45:44] yeah they should do [03:47:11] I have a thought about structure - but I'm just thinking about how best to put it up as it would break it up slightly differently [03:47:42] okok sounds like letting it simmer for a bit is a good approach :) [03:49:56] yeah - I feel like it makes sense to have an api with the 'how do I process one message' [03:49:56] so function processMessage($message) { [03:49:56] would wind up just doing a try -catch to that api (& through whatever exception we want for our wmf purposes from the api exception) [03:49:56] - more of a bridge between the api way & the wmf way :-) [03:50:57] hmmm [03:51:19] (CR) jerkins-bot: [V: -1] Move logging to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [03:52:17] eileen: isn't that kinda what you got with dequeueMessages() in BaseQueueConsumer? [03:52:51] also sounds like you're thinking of some actual refactoring in addition to moving stuff about? [03:53:21] also looks like WmfException is a tad to ingenious for its own good [03:53:25] *too [03:53:31] well I think the action & the consumer are too tightly coupled [03:54:01] We are doing a lot of validation that you would handle by declaring metadata if you had a Preferences.create api [03:54:46] (Abandoned) Eileen: Add monolog extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682345 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [03:54:59] hmmm [03:55:05] too tightly coupled in what sense? [03:57:15] Well I'd normally expect that if we have an action to take some formatted stuff & do something with it we could call that action directly - let' me see if I can show you what I mean [03:59:04] (PS8) Eileen: E-mail preferences center queue consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/680119 (https://phabricator.wikimedia.org/T268511) (owner: AndyRussG) [03:59:13] AndyRussG: I just pushed up the reformatting from my IDE [03:59:49] eileen: ahh noice, thanks! [04:10:21] eileen: when you said "it does need some form of test" above, did you mean the queue consumer classes in general are lacking tests, or specifically the new preferences queue consumer needs tests? [04:10:23] or both maybe? [04:10:45] yeah - I actually realised I can throw it in in what I'm pseodocoding atm [04:15:09] ah hmmm! [04:16:01] (PS1) Eileen: Separate action to an api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682349 [04:16:25] AndyRussG: ^^ is what I mean - note I have not attempted to run the code [04:16:41] eileen: cool thanks, looking! [04:18:19] (PS2) Eileen: Separate action to an api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682349 [04:18:28] AndyRussG: try refreshing - I didn't commit very well [04:19:08] (PS3) Eileen: Separate action to an api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682349 [04:21:57] - the test is failing because my language value ('es_ES') was rejected [04:22:55] eileen: oh ok that's quite pretty! [04:23:15] lol - you know there was a you that never thought you would say that about code [04:25:01] heheh it _is_ pretty [04:25:10] I see what you mean about the coupling. As in, it's nicer if where you determine what's valid for a message is not too coupled to the batch process for consuming it [04:27:16] AndyRussG: it's also easier to write a test! [04:30:54] eileen: right! hmmm I don't understand enough about either WmfException or API_Exception to know really what goes in the catch block, but I might try figuring it out [04:31:02] would you say this approach is more Civi-y, I guess? [04:33:42] (CR) jerkins-bot: [V: -1] Separate action to an api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682349 (owner: Eileen) [04:34:29] AndyRussG: yeah - it is more civi-y [04:34:55] regarding the exception part - yeah I'm not too sure [04:35:34] the point of the wmf exception is that we have handling that will re-queue or otherwise based off that [04:38:19] eileen: what about for now just re-throw an equivalent-ish WmfException inside the catch block [04:38:25] and leave that refactoring as a TODO? [04:40:19] yeah - I'm just looking at it appear that even if we just let the exception bubble up the right thing would happen - ie it looks like it would wind up in the damaged message queue [04:41:28] but yeah I think your idea is right for now [04:41:34] ohhh okok hmmm [04:41:54] at least absent Elliott's advice [04:42:43] I could just merge what's left of the original queue consumer patch I sent up into your code there, add that exception bit, and abandon the other one [04:45:21] (PS5) Eileen: Move logging to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) [04:51:19] if that works [04:51:55] okok [04:53:48] eileen: ahh also ^ speaking of logging, I imagine I may not be doing this right? as in: Civi::log()->info('Executing: Preferencesqueue.consume'); [04:54:13] if I rebased to follow that logging patch of yours, maybe there'd then be a truly right way I could do it? [04:54:42] AndyRussG: well so we are just getting to what that is but I think it will look like [04:54:42] Civi::log('wmf')->info(....) [04:55:07] that should work without my patch based on what is already merged - but it will log to the civicrm default logging location [04:55:20] (which is sites/default/files/civicrm/ConfigAndLog) [04:55:30] once my patches are merged it will log to syslog [04:56:41] I think the other pattern that we need to adopt is not relevant to that line - but basically it's passing variables in a $context array as a second param rather than interpolating them (which we often do) [04:58:59] (CR) jerkins-bot: [V: -1] Move logging to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [05:01:51] hmmm ok also sounds quite reasonable :) [05:02:22] lemme try rebasing on that and see what I get--syslog would be nice 'cause Docker already works with that [05:06:12] AndyRussG: yeah -- I have a test fail to diagnose [05:06:44] but I think you can use the ```Civi::log('wmf')->info(....)``` pattern already - it will just behave better once the monolog stuff is all go [05:08:05] eileen: do you think monolog stuff has very far to go? [05:09:06] no - I think it's close - I was hoping to have it review ready before I finish today although that test fail is a bit annoying [05:09:20] K I can take a look there toothen [05:12:21] Hmm - the test fail is something silly [05:12:40] it won't stop it working [05:17:53] eileen: will I have to re-run buildkit? [05:18:06] AndyRussG: yeah I think that's easiest [05:18:10] Sorry no [05:18:20] just civibuild create wmff [05:18:32] oh okok [05:18:33] Is that what you meant? [05:18:52] sort of... I would have just run the stuff in setup.sh [05:23:31] I guess I don't know a bunch of stuff that I'd want to to be able to review decently there also [05:24:01] I think this is the fix for the test fail https://github.com/civicrm/civicrm-core/pull/20146 [05:24:02] For example I don't see where the logic that's erased in wmf_civicrm_civicrm_merge is replaced [05:24:21] so the logic is removing the line that calls 'watchdog' [05:24:43] & it is replaced in the wmf_civicrm extension with Civi::log('wmf')->... [05:25:30] eileen: ahh sorry yeah I missed that :) [05:25:33] but AndyRussG I don't think that PR is a pre-requisite for you using Civi::log('wmf') in your code - you can just do that now & it will work but not quite how we want it to [05:25:44] yep okok [05:30:05] what would you say is the general principle for when some additional functionality in Civi should be coded up by creating an API call? I guess when it's ingressing or egressing data to or from Civi somehow? [05:30:15] (PS1) Eileen: Fix enotice when Log service is swapped out [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/682354 (https://phabricator.wikimedia.org/T279983) [05:30:30] AndyRussG: yeah that sounds about right [05:30:48] eileen: okok cool [05:31:34] In civi apis can be called in quite a few ways so if there is a contained chunk of functionality it's usually a good plan - (drush, javascript, api explorer etc) [05:31:54] hmm ok [05:32:51] I mean normally in other contexts if i were writing code in php that I was only ever planning to have called from php, I wouldn't worry about exposing an internal API anywhere other than in php [05:32:56] but here it seems it's otherwise [05:34:18] yeah - we use apis a lot from internal code in civi [05:34:54] hmmm okok [05:35:36] the api wrapper has vaildation & encourages metadata which helps reduce the endless arrays of unknown keys that get passed around [05:36:27] right... so I guess sort of saying the same thing, it seems useful when you want the contract between the caller and the callee to be expressed declaratively [05:39:00] yeah I think so - we do basically use them pretty heavily in civi-land [05:39:12] okok gotcha [05:39:19] heheh when in Rome... [05:43:27] yep [05:50:36] eileen: k cool thanks much for the help! gonna sleep in a few minutes, just wondering where I should put notes on the Python cmd line variable 2 mysql topic? is there a task or a patch? [05:53:07] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (Eileenmcnaughton) @AndyRussG - this the phab I was looking for some python help - b... [05:53:10] AndyRussG: I pinged you from it [05:53:27] & yeah I'm sure you should go to bed now - I'm close to finishing [05:54:41] eileen: cool got it... thx again! cya! :) [05:54:49] night [06:08:38] (PS1) Eileen: Save full name to addressee where supplied [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682356 (https://phabricator.wikimedia.org/T275445) [06:12:14] Fundraising Sprint File Systems Stage Show, Fundraising Sprint Git Rebase Jump, Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, and 2 others: Creating New Fidelity File Civi Import - https://phabricator.wikimedia.org/T275445 (Eileenmcnaughton) @RLewis @MDemosWMF I've put u... [06:22:22] (CR) jerkins-bot: [V: -1] Save full name to addressee where supplied [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682356 (https://phabricator.wikimedia.org/T275445) (owner: Eileen) [06:27:51] (PS2) Eileen: Save full name to addressee where supplied [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682356 (https://phabricator.wikimedia.org/T275445) [06:42:20] (CR) jerkins-bot: [V: -1] Save full name to addressee where supplied [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682356 (https://phabricator.wikimedia.org/T275445) (owner: Eileen) [08:24:27] Fundraising-Backlog: Failed recurring donation attempts making it to status 600 in Ingenico - https://phabricator.wikimedia.org/T281091 (krobinson) [10:35:13] fundraising-tech-ops: Fundraising access request for Julia Brungs - https://phabricator.wikimedia.org/T281111 (MeganHernandez_WMF) [13:01:58] PROBLEM - check_ssl on payments1003 is CRITICAL: SSL CRITICAL - failed to connect or SSL handshake:Connection refused [13:06:54] RECOVERY - check_ssl on payments1003 is OK: SSL OK - Certificate payments.wikimedia.org valid until 2021-12-12 16:16:02 +0000 (expires in 230 days) [14:32:04] (CR) AndyRussG: "Thanks @Eileen! Just copying here your note from IRC: it seems the test failure is an upstream issue, fixed in https://github.com/civicrm/" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [15:25:59] (CR) AndyRussG: [C: +1] "Looks great and works as advertised! Just one very small detail (see inline) and I guess getting the tests passing, then... thanks!! :)" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [15:52:39] Fundraising Sprint File Systems Stage Show, Fundraising Sprint Git Rebase Jump, Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, and 2 others: Creating New Fidelity File Civi Import - https://phabricator.wikimedia.org/T275445 (MDemosWMF) Thanks @Eileenmcnaughton - does this... [16:37:16] Fundraising-Backlog, fr-email-preference-center: Handle merged contacts in e-mail preferences center - https://phabricator.wikimedia.org/T281175 (AndyRussG) [16:39:39] (CR) AndyRussG: "> Patch Set 12:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [16:56:06] fundraising-tech-ops: Fundraising access request for Julia Brungs - https://phabricator.wikimedia.org/T281111 (Dwisehaupt) [17:01:58] fundraising-tech-ops, DC-Ops, ops-codfw: (Need By: TBD) rack/setup/install frdb2003.frack.codfw.wmnet - https://phabricator.wikimedia.org/T281177 (RobH) [17:02:20] fundraising-tech-ops, DC-Ops, ops-codfw: (Need By: TBD) rack/setup/install frdb2003.frack.codfw.wmnet - https://phabricator.wikimedia.org/T281177 (RobH) [17:02:52] fundraising-tech-ops, DC-Ops, ops-codfw: (Need By: TBD) rack/setup/install frdb2003.frack.codfw.wmnet - https://phabricator.wikimedia.org/T281177 (RobH) a:Papaul [17:12:52] (CR) AndyRussG: WIP: Add CiviProxy setup (1 comment) [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/673094 (https://phabricator.wikimedia.org/T268683) (owner: Jgleeson) [17:15:07] fundraising-tech-ops: Fundraising access request for Julia Brungs - https://phabricator.wikimedia.org/T281111 (Dwisehaupt) @MeganHernandez_WMF Just wanted to check to see if you had sent on the request for access to Lisa or if you would like for me to do that. Additionally, we will need to get Julia added to... [17:20:24] (CR) AndyRussG: [C: +2] "Woohooo lgtm!!!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [17:32:41] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: A solution to payments.wiki language "stickiness" - https://phabricator.wikimedia.org/T272915 (jbolorinos-ctr) How long do these cookies stay active? Is it until the browser is closed and everything is cleared? Or is there an expiration time on... [17:38:24] (Merged) jenkins-bot: Civiproxy preferences shell [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [18:21:20] (PS2) AndyRussG: Add monolog extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682348 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [18:21:38] (PS4) AndyRussG: Enable search kit by default on new installs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682347 (owner: Eileen) [18:22:11] (PS6) AndyRussG: Move logging to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [18:27:48] (PS4) AndyRussG: [WIP] E-mail pref ctr queue consumer using api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682349 (https://phabricator.wikimedia.org/T268511) (owner: Eileen) [18:29:59] (PS3) AndyRussG: Save full name to addressee where supplied [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682356 (https://phabricator.wikimedia.org/T275445) (owner: Eileen) [18:31:15] (CR) AndyRussG: "Rebased on top of new logging stuff, so we can use it here... :) Still some stuff to fill on this change also, btw." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682349 (https://phabricator.wikimedia.org/T268511) (owner: Eileen) [18:32:07] (Abandoned) AndyRussG: E-mail preferences center queue consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/680119 (https://phabricator.wikimedia.org/T268511) (owner: AndyRussG) [18:40:32] (CR) jerkins-bot: [V: -1] Move logging to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [18:44:43] Fundraising-Backlog: Failed recurring donation attempts making it to status 600 in Ingenico - https://phabricator.wikimedia.org/T281091 (Cstone) Just some initial investigation, looks like this started with the recurring charges on 4/22 and lasted through 4/23. I don't see it happening before or after those... [18:50:13] (CR) jerkins-bot: [V: -1] [WIP] E-mail pref ctr queue consumer using api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682349 (https://phabricator.wikimedia.org/T268511) (owner: Eileen) [18:51:00] (CR) jerkins-bot: [V: -1] Save full name to addressee where supplied [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682356 (https://phabricator.wikimedia.org/T275445) (owner: Eileen) [19:13:52] Fundraising-Backlog: Failed recurring donation attempts making it to status 600 in Ingenico - https://phabricator.wikimedia.org/T281091 (EMartin) It's interesting that I don't see 475 stopped transactions in the fraud report. [19:32:31] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, FR-Ingenico, Recurring-Donations: Failed recurring donation attempts making it to status 600 in Ingenico - https://phabricator.wikimedia.org/T281091 (DStrine) [19:33:00] (PS5) AndyRussG: E-mail pref ctr queue consumer using api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682349 (https://phabricator.wikimedia.org/T268511) (owner: Eileen) [19:33:47] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, FR-Ingenico, Recurring-Donations: Failed recurring donation attempts making it to status 600 in Ingenico - https://phabricator.wikimedia.org/T281091 (DStrine) Fr-tech will look a little deeper into this but we might need to s... [19:52:42] (CR) jerkins-bot: [V: -1] E-mail pref ctr queue consumer using api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682349 (https://phabricator.wikimedia.org/T268511) (owner: Eileen) [20:03:59] Fundraising Sprint File Systems Stage Show, Fundraising Sprint Git Rebase Jump, Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, and 2 others: Creating New Fidelity File Civi Import - https://phabricator.wikimedia.org/T275445 (Eileenmcnaughton) @MDemosWMF yes - you are spot... [20:21:02] (PS6) AndyRussG: E-mail pref ctr queue consumer using api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682349 (https://phabricator.wikimedia.org/T268511) (owner: Eileen) [20:21:56] fr-tech ^ fixes the echo foo and a foo more oversights, thanks much jgleeson for catching that :) [20:33:31] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-drupal-upgrade-2021: develop more detail plan on queue refactor for drupal upgrade - https://phabricator.wikimedia.org/T279962 (AndyRussG) Here are the notes I have so far about stuff to do,... [20:33:53] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-drupal-upgrade-2021: develop more detail plan on queue refactor for drupal upgrade - https://phabricator.wikimedia.org/T279962 (AndyRussG) a:AndyRussG→None [20:34:31] AndyRussG: loving the foo pun [20:34:36] :) [20:36:17] (CR) jerkins-bot: [V: -1] E-mail pref ctr queue consumer using api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682349 (https://phabricator.wikimedia.org/T268511) (owner: Eileen) [20:38:47] :) [20:39:30] gotta foomigate the code to get rid of de-BUG kludges.... [20:44:59] Fundraising Sprint File Systems Stage Show, Fundraising Sprint Git Rebase Jump, Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, and 2 others: Creating New Fidelity File Civi Import - https://phabricator.wikimedia.org/T275445 (MDemosWMF) Ok great - in that case @RLewis it m... [22:53:52] Fundraising Sprint Humongous bacteria petting zoo, Fundraising-Backlog, FR-Ingenico, Recurring-Donations: Failed recurring donation attempts making it to status 600 in Ingenico - https://phabricator.wikimedia.org/T281091 (Cstone) I talked to Evelyn and we looked into this a bit more, the ones sit... [23:15:37] so I didn't get selected onto the jury- I think I'll likely be safe from being on it now [23:21:52] If someone is able to merge this I can see if monolog passes now https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/682354 [23:48:55] sure eileen [23:49:39] (CR) Cstone: [C: +2] Fix enotice when Log service is swapped out [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/682354 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [23:53:14] thanks cstone - cross fingerts the other passes with that merged - [23:53:32] (PS2) Eileen: Fix enotice when Log service is swapped out [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/682354 (https://phabricator.wikimedia.org/T279983) [23:53:58] hmm I rebased out the civi update - we should do that although I don't think the vulnerability affects us