[00:05:38] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (KHaggard) @Ei... [00:10:14] eileen: any doc anywhere about the monolog config in Monolog.mgd.php? I got as far as https://lab.civicrm.org/extensions/monolog [00:11:46] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (KHaggard) @Ei... [00:30:44] (CR) AndyRussG: Move logging to extension (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [00:32:11] AndyRussG: nothing outside that readme at the moment - I kinda added some loggers as default for demo purposes [00:33:12] eileen: okok or some bit of the code that reads in those config settings? [00:33:41] yeah the config settings are really more for when we add email to it [00:33:50] at the moment can be ignored / use the defaults [00:34:09] k I mean just as part of review I'd like to know what they're doing? [00:34:59] If I can look at the code that reads them in and translates that to something monolog-native (?) that should be enuf [00:35:33] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (Eileenmcnaught... [00:35:58] also, so is this patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/682348 just copying in everything from here? https://lab.civicrm.org/extensions/monolog/-/tree/master [00:38:24] AndyRussG: yep [00:38:39] that's why I said I'd do any more changes as a follow on [00:39:14] & yeah config_settings is basically for the parameters you need to pass when constructing the different log handling classes [00:39:26] right [00:39:39] so where can I see what each of those settings means? [00:40:11] So this class here is basically the most important class in the extension https://lab.civicrm.org/extensions/monolog/-/blob/master/Civi/MonoLog/MonologManager.php [00:41:27] there are defined defaults for the config options - but they wind up here https://lab.civicrm.org/extensions/monolog/-/blob/master/Civi/MonoLog/MonologManager.php#L160 [00:41:57] - that handler is pretty much equivalent to the built in civi handler [00:42:58] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (KHaggard) @Ei... [00:43:38] eileen: okok cool thx! [00:44:18] eileen: just one note about https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/682348 -- is there some appropriate place to put a link to the upstream repo, and the sha of the commit that it was copied into our repo from? [00:44:36] I think if there's no standard place for that, maybe at least the commit message? [00:45:08] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (Eileenmcnaught... [00:46:33] AndyRussG: yeah we don't have a standard place - once we've finalise it all I can add a release to the upstream repo to tag against [00:47:09] right... so there's no package-manager-y thing for civi extensions, I guess? [00:47:15] like npm or composer etc etc [00:47:46] - not really - potentially in future it will be composer - although I'm not sure if civi supports that yet [00:47:55] ah okok [00:47:56] (on drupal 8 you install civi using composer) [00:48:48] I feel like in this change in Gerrit in it'd still be good to have a link to the upstream repo and the sha we copied stuff form in the commit message, even if there will be ab upstream tagged release in the future [00:49:09] at least that would make it easy to see which commits from upstream we have, and which we don't? [00:49:21] instead of having to diff files to see where we left off? [00:53:00] (PS1) Cstone: Update 2021 thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/683450 (https://phabricator.wikimedia.org/T278363) [00:56:24] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (KHaggard) @Ei... [00:58:24] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (Eileenmcnaught... [01:01:37] (PS2) Cstone: Update 2021 thank you emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/683450 (https://phabricator.wikimedia.org/T278363) [01:04:15] (PS4) Eileen: Add monolog extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682348 (https://phabricator.wikimedia.org/T279983) [01:04:29] AndyRussG: OK - I've added it to the commit message [01:04:34] Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-AutoTY-Email: New Endowment TY email - https://phabricator.wikimedia.org/T280574 (Cstone) @TSkaff @AParker I don't have access to the google doc [01:05:20] eileen: cool beans thanks! [01:05:36] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (KHaggard) Ok,... [01:06:21] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (Eileenmcnaught... [01:10:12] Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-AutoTY-Email: New Endowment TY email - https://phabricator.wikimedia.org/T280574 (TSkaff) @Cstone Updated the settings, sorry about that. [01:10:14] Fundraising-Backlog: Recurring Charge Processor Vague Error Message - https://phabricator.wikimedia.org/T281439 (Cstone) [01:22:15] eileen: K so I'm at least just gonna debug through the most important bits and make sure I understand the overall strcuture of the logging extension code [01:22:31] I think that should be sufficient for a +2 in a case like this... does that sound ok? [01:22:50] cool - in monolog.php it registers that LogManager [01:23:24] & then when Civi::log() is called it calls it to get the Logger [01:24:19] okok cool [01:24:25] is monolog.civix.php really still auto-generated? [01:24:47] yep [01:24:48] "// AUTO-GENERATED FILE -- Civix may overwrite any changes made to this file" [01:24:53] ok hmmm [01:25:19] yeah - when you re-run civix it updates it with latest conventions [01:25:25] ok I see https://docs.civicrm.org/dev/en/latest/extensions/civix/ [01:26:38] docker@civicrm:/srv/civi-sites/wmff/drupal$ /srv/civicrm-buildkit/bin/civix civicrm:ping [01:26:40] Ping successful [01:28:14] :-) [01:28:46] AndyRussG: yeah so whenever you create a civi extension you start with civix generate:module [01:29:01] k gotcha [01:29:11] & it will generate some things within that once generated [01:30:24] so where did it get whatever info it needed to generate monolog.civix.php? I assume it's not all stock stuff that goes in every single extension? [01:31:02] I guess Monolog.xml? [01:31:03] So yeah that file is stock with just the name'monolog' added in [01:31:22] Monolog.xml is used to generate the autoinstall & the DAO files [01:31:28] ah hmmm [01:31:39] (civix generate:entity-boilerplate) [01:31:47] hmmm ok [01:32:01] I guess we're not the only users of this extension also? [01:32:01] but monolog.php is the important file - that's the one you customise [01:32:21] of monolog? [01:32:25] yeah [01:32:38] so far - yes - but we will blog / share/ [01:34:03] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (Eileenmcnaught... [01:34:51] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (Eileenmcnaught... [01:40:09] (PS1) Cstone: Update endowment thank you for 2021 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/683461 (https://phabricator.wikimedia.org/T280574) [01:45:27] (PS2) Cstone: Update endowment thank you for 2021 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/683461 (https://phabricator.wikimedia.org/T280574) [01:54:38] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (Eileenmcnaught... [02:10:09] (PS11) Eileen: Move logging to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) [02:12:10] (PS12) Eileen: Move logging to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) [02:14:05] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Org Contact Fields in Engage Import not Importing to Record - https://phabricator.wikimedia.org/T278892 (... [03:02:27] just taking a peek at that monolog extn too [03:02:49] so... that's a heck of a lot more sophisticated than the lil proof of concept thing i saw last week! [03:03:03] whole db table for log channel config, nice [03:06:10] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Load Adyen's Drop-In Web scripts on AdyenDropIn form - https://phabricator.wikimedia.org/T281441 (Ejegg) [03:11:08] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Load Adyen's Drop-In Web JS and CSS on AdyenDropIn form - https://phabricator.wikimedia.org/T281441 (Ejegg) [03:14:09] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface: Update MaxMind + GeoIP libraries to latest version - https://phabricator.wikimedia.org/T281443 (Ejegg) [03:14:17] ejegg: yeah - otherwise you can't really configure multiple [03:14:32] that firephp thing is cool - I tried it out & it's super cool [03:14:41] you need to install the browser extension [03:15:01] (I was gonna put up a blog about the extension & explain firephp in it) [03:15:09] so it sends the logging via a side channel? [03:15:51] yeah http headers [03:16:00] ahh word [03:16:16] you get an extra tab in your browser console [03:16:43] there is a similar one for the wordpress drush equivalent - ie you get extra logging if using wp-cli if you want [03:17:24] ejegg: I think we should update phpmailer soonish - that was the reason I didn't add that into monolog as yet - we are on an old version [03:19:04] yep, definitely [03:19:12] any API changes we need to adapt our code to? [03:19:27] lessee [03:19:57] oh hah, yeah [03:24:13] ah, mostly just namespace for what SmashPig uses it for. [03:24:38] (PS1) Ejegg: WIP update PHPMailer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/683470 [03:25:38] ok, and mw core doesn't use it [03:26:04] no direct use from our mw extensions either, it looks like [03:26:24] lemme just test that WIP locally [03:33:54] yah, that seems to work [03:34:18] that is the phpmailer update? [03:34:35] yup, will take that WIP off [03:34:41] looks like it was pretty simple after all [03:35:38] (PS2) Ejegg: Update PHPMailer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/683470 [03:37:03] so ^^^ is just the SmashPig patch [03:37:37] let me see if the ty mailer does anything more complicated [03:38:27] ah right, need to bump the smashpig version before I can get composer to pull in the new version to crm [03:38:31] boo [03:40:21] hah, managed to fudge it by editing the composer.json in the vendor dir [03:40:34] k, let's see what that takes [03:41:12] ejegg: so the change looks right to me - I feel like if you have just tested it I can maybe just common sense check it? [03:41:23] sure! [03:44:39] eileen: one sec [03:44:50] looks like the method names are camelCase in the new version [03:45:09] so php lets us get away with bad casing, but I'd rather fix that [03:45:56] yeah for sure! [03:46:04] do unit tests not grumble on that? [03:47:08] guess not! [03:47:21] would be a lint thing, I guess [03:47:34] (PS3) Ejegg: Update PHPMailer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/683470 [03:48:09] so the functions are all proper case but it seems the publicly settable properties are still Uppercase [03:53:21] that's weird IMHO [03:55:29] ejegg: if you are happy with ^^ I'm happy. I spot checked some of them [03:55:50] well, it sends me mail locally! [03:57:04] cool [03:57:25] (CR) Eileen: [C: +2] "The insanity is theirs not ours" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/683470 (owner: Ejegg) [04:10:32] (PS1) Ejegg: WIP update PHPMailer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/683471 [04:11:50] ^^ will fail on composer install till I the SmashPig patch merges and I tag a new version [04:12:08] hmm, SmashPig tests should run a lot faster than that? [04:12:27] oh, it merged, but wikibugs didn't tell us [04:13:49] tagged [04:16:12] ejegg: I clicked submit before it remembered to tun tests all over again [04:16:19] (PS2) Ejegg: Update PHPMailer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/683471 [04:18:51] well, I'mma head to bed. have a good day eileen [04:39:54] Fundraising-Backlog, Desktop Improvements, MediaWiki-extensions-CentralNotice, Product-Design-Strategy, and 6 others: [Discussion] Prevent SEO decline due to Google "page experience": mid-June 2021 - https://phabricator.wikimedia.org/T280476 (AndyRussG) >>! In T280476#7042031, @gabriel-wmde wrote... [06:27:38] (PS1) Eileen: phpmailer update to 6 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/683482 [06:32:20] (CR) Eileen: [C: +2] "I deployed this to staging & successfully sent myself a thank-you email" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/683471 (owner: Ejegg) [06:33:00] eileen: what does SavedSearch.mgd.php do? [06:33:39] AndyRussG: it declared 'managed entities' - basically a saved search to be created when the extension is installed [06:34:08] eileen: so saved search... within log files? or within the table of logger types? [06:34:17] https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_managed/ [06:34:33] the table is civicrm_saved_search [06:34:52] & you would see it in the UI under the search-kit [06:35:18] under 'search' at the top level [06:35:20] right but in this case it's not for searching log contents, right? [06:35:28] or is it? [06:36:47] so is this in the monolog one or the namepairs? [06:37:07] in the monolog one [06:37:34] ok - so it is a display of the configured log handlers [06:38:33] there is an add form & a display but at this stage we aren [06:38:57] t using them to add the monolog config - we are doing that via mgd files [06:39:55] hmmm ok so that saved search is what I'm actually seeing when I go to https://wmff.localhost:32353/civicrm/search#/display/Monolog%20configuration/Monologs ? [06:40:20] yep [06:40:23] okok cool [06:40:42] hmmm also what are your thoughts on eventually (in another patch) getting rid of the default loggers, at least for our install? [06:40:50] the whole saved search thing is all pretty new - the search kit work is what we sponsored [06:41:07] yeah on our stall we should disable most of them [06:41:09] if someone writes somewhere log('wmfff') by mistake, I think I'd rather it error out [06:41:25] ok [06:41:32] well we need the default default logger because civi logs [06:41:48] so without that we are taking away something civi expects [06:42:01] although I think it will try to handle that tbh [06:42:01] oh I see [06:42:19] but it will fall back to the default if we get 'wmfff' by mistake [06:42:41] and those are like the logs that go say to those massive log tables that I have heard rumours about? [06:42:51] yep - at this stage [06:42:53] so basically it's one unified logging system for all your logging needs? [06:43:13] well the current default civi rolls over at 250kb and never deletes [06:43:27] this one rolls over at 250kb & deletes after 10 I think [06:43:32] so it's slightly better :-) [06:43:42] okok [06:44:52] AndyRussG: if we want to throw away some stuff I think we should add a null handler [06:45:03] hmmm [06:45:16] but that's a decision for another day [06:45:32] yeah... hmm so is this or is it not linked somehow to the logging setting in https://wmff.localhost:32353/civicrm/admin/setting/misc?reset=1 ? [06:45:39] Logging Yes No [06:45:41] If enabled, all actions will be logged with a complete record of changes. [06:46:43] no - that is db audit logging - all those triggers & log_xx tables [06:47:18] (Merged) jenkins-bot: Update PHPMailer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/683471 (owner: Ejegg) [06:48:11] right okok [06:49:31] tests/phpunit/bootstrap.php is just the test harness but no actual tests yet, is that right? [06:50:27] yep - phpunit.xml specifies the bootstrap file - it's autogenerated & you can use it to run tests but you can also use our wmf phpunit.xml + bootstrap file [06:50:51] hmmm [06:51:34] would something bad happen if someone clicked on "Delete" on the Monolog configurations saved search? [06:52:04] apologies if this seems like an interrogation eh! [06:52:13] well the link would stop working [06:52:22] but that's it [06:54:12] hmmm ok [06:54:19] but I guess there's no getting around that? [06:54:59] not a blocker, of course, but admittedly it feels odd to have monolog configurations in my saved searches [06:55:09] ahhh btw overall fantastic work eh!! [06:55:10] well I suppose we could test if it exists when we add the menu item - [06:55:19] (I'm not rushing to do that) [06:55:32] I'm just here trying to justify my salary looking for some nits to pick [06:56:03] lol [06:56:31] heheh no joke, though it's still funny ;p [06:56:32] well there is a lot going on in that code tbh [06:56:50] I think I'm good to +2 both logging patches [06:57:09] cool [06:57:32] a good bit is indeed extension/entity boilerplate, if I understand correctly [06:57:40] yes it is [06:58:34] I think this is intended to reduce that a little https://github.com/civicrm/civicrm-core/pull/19865 [07:00:09] ahh fun! [07:00:45] eileen: ah also I couldn't find the new field mentioned in readme in Administer - System Settings - Debugging and Error Handling. [07:01:49] (CR) AndyRussG: [C: +2] "Wooohoo thanks so much for this!!!! Yaaaaaaaaaaaaay" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682348 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [07:01:49] is that the one added by the extension ? (if so I unadded it due to not being sure if there were security issues) [07:02:34] (CR) AndyRussG: [C: +2] "Yeeeee works as advertised! Thanks!!!!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [07:03:13] eileen: right I think you may just want to update the readme [07:03:21] cool yes [07:04:36] so that will bring your one to the top of the pile - I haven't followed through the issue you mention as yet [07:05:01] which issues? [07:06:45] (CR) Eileen: E-mail pref ctr queue consumer using api (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682349 (https://phabricator.wikimedia.org/T268511) (owner: Eileen) [07:06:52] I just commented [07:16:27] ah right that one... ah thanks! [07:16:48] yeah - I think you found a real bug not just a test bug there [07:17:40] (Merged) jenkins-bot: Add monolog extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682348 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [07:17:42] (Merged) jenkins-bot: Move logging to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/682346 (https://phabricator.wikimedia.org/T279983) (owner: Eileen) [07:21:17] see ya later [07:26:12] (CR) AndyRussG: [C: +2] "Thanks so much for this!! :) :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/677015 (https://phabricator.wikimedia.org/T271168) (owner: Ottomata) [07:26:25] eileen: cya! [07:27:03] yeah sleepy sleepy time time [07:41:41] (Merged) jenkins-bot: Use mw.eventLog.logEvent for all EventLogging logs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/677015 (https://phabricator.wikimedia.org/T271168) (owner: Ottomata) [08:57:38] Fundraising-Backlog, Desktop Improvements, MediaWiki-extensions-CentralNotice, Product-Design-Strategy, and 6 others: [Discussion] Prevent SEO decline due to Google "page experience": mid-June 2021 - https://phabricator.wikimedia.org/T280476 (awight) Great to hear that discussions are happening—i... [09:57:51] Fundraising-Backlog, Desktop Improvements, MediaWiki-extensions-CentralNotice, Product-Design-Strategy, and 6 others: [Discussion] Prevent SEO decline due to Google "page experience": mid-June 2021 - https://phabricator.wikimedia.org/T280476 (awight) I missed your comment when writing, sorry! Of... [10:42:15] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Org Contact Fields in Engage Import not Importing to Record - https://phabricator.wikimedia.org/T278892 (... [10:43:37] Fundraising Sprint File Systems Stage Show, Fundraising Sprint Git Rebase Jump, Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, and 3 others: Creating New Fidelity File Civi Import - https://phabricator.wikimedia.org/T275445 (RL... [12:52:53] (PS1) Zfilipin: selenium: Add JUnit reporter [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683594 (https://phabricator.wikimedia.org/T214686) [13:27:06] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Fr-planning-ahead, Epic: Epic: Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (Jgreen) [13:27:08] fundraising-tech-ops, fr-email-preference-center: Create fundraising_code_update project for civiproxy - https://phabricator.wikimedia.org/T281311 (Jgreen) [13:27:10] fundraising-tech-ops, fr-email-preference-center: Add Apache config to serve Civiproxy - https://phabricator.wikimedia.org/T281321 (Jgreen) [13:31:22] fundraising-tech-ops, fr-email-preference-center: Network configuration for Civiproxy - https://phabricator.wikimedia.org/T281320 (Jgreen) [13:31:24] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Fr-planning-ahead, Epic: Epic: Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (Jgreen) [13:38:05] fundraising-tech-ops, fr-email-preference-center: Add Apache config to serve Civiproxy - https://phabricator.wikimedia.org/T281321 (Jgreen) [13:44:20] fundraising-tech-ops, fr-email-preference-center: Network configuration for Civiproxy - https://phabricator.wikimedia.org/T281320 (Jgreen) @ejegg As far as I know the only server/service planned to access civiproxy is donorwiki, which will run on the frdata servers. Is that what this task is about, and n... [13:44:28] (PS1) Thiemo Kreuz (WMDE): Remove comments that literally repeat the code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683615 [13:44:43] fundraising-tech-ops: investigate adding additional security headers to Fundraising civicrm, superset, etc. sites - https://phabricator.wikimedia.org/T280387 (Jgreen) p:Triage→Medium [13:47:31] (PS1) Thiemo Kreuz (WMDE): Update small code pieces to use more modern PHP 7 syntax [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683617 [13:48:05] fundraising-tech-ops, fr-email-preference-center: Add Apache config to serve Civiproxy - https://phabricator.wikimedia.org/T281321 (Jgreen) [13:52:18] (PS1) Thiemo Kreuz (WMDE): Optimize regular expression code in PHP and JavaScript [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683619 [13:56:54] (CR) jerkins-bot: [V: -1] Optimize regular expression code in PHP and JavaScript [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683619 (owner: Thiemo Kreuz (WMDE)) [14:06:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, fr-email-preference-center: Configure CiviProxy vhost and firewall to allow requests from email prefs box - https://phabricator.wikimedia.org/T268499 (Jgreen) Open→Declined Same stuff has been tasked separately as T... [14:06:41] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Fr-planning-ahead, Epic: Epic: Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (Jgreen) [14:07:09] fundraising-tech-ops, fr-email-preference-center: Add Apache/Nginx config to serve Civiproxy - https://phabricator.wikimedia.org/T281321 (Jgreen) [14:13:23] fundraising-tech-ops, fr-email-preference-center: Network configuration for Civiproxy - https://phabricator.wikimedia.org/T281320 (Jgreen) [14:14:22] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Fr-planning-ahead, Epic: Epic: Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (Jgreen) [14:14:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, fr-email-preference-center: Configure CiviProxy vhost and firewall to allow requests from email prefs box - https://phabricator.wikimedia.org/T268499 (Jgreen) Declined→Resolved [14:21:09] Fundraising-Backlog, Desktop Improvements, MediaWiki-extensions-CentralNotice, Product-Design-Strategy, and 6 others: [Discussion] Prevent SEO decline due to Google "page experience": mid-June 2021 - https://phabricator.wikimedia.org/T280476 (Pcoombe) >>! In T280476#7044910, @awight wrote: > I al... [15:24:36] (CR) Jforrester: [C: +2] selenium: Add JUnit reporter [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683594 (https://phabricator.wikimedia.org/T214686) (owner: Zfilipin) [15:26:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fr-donorservices, FR-Email: Japanese donor name clean up pass - https://phabricator.wikimedia.org/T281493 (DStrine) [15:27:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Japan, fr-donorservices, FR-Email: Japanese donor name clean up pass - https://phabricator.wikimedia.org/T281493 (DStrine) [15:29:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Japan, FR-Email: Dedupe/data cleanup family name, given name order for Japanese donors - https://phabricator.wikimedia.org/T280695 (DStrine) [15:29:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Japan, FR-Email: continuing dedupe/data cleanup family name, given name order for Japanese donors - https://phabricator.wikimedia.org/T280695 (DStrine) [15:30:33] (CR) jerkins-bot: [V: -1] selenium: Add JUnit reporter [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683594 (https://phabricator.wikimedia.org/T214686) (owner: Zfilipin) [15:39:38] (CR) Zfilipin: "Failed with:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683594 (https://phabricator.wikimedia.org/T214686) (owner: Zfilipin) [15:39:47] (CR) Zfilipin: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683594 (https://phabricator.wikimedia.org/T214686) (owner: Zfilipin) [15:48:55] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (Dwisehaupt) >... [15:53:27] Fundraising-Backlog, Desktop Improvements, MediaWiki-extensions-CentralNotice, Product-Design-Strategy, and 6 others: [Discussion] Prevent SEO decline due to Google "page experience": mid-June 2021 - https://phabricator.wikimedia.org/T280476 (awight) Regarding cloaking, >>! In T280476#7045799, @... [15:58:27] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (KHaggard) Tha... [16:01:56] fr-tech i'll be a couple min late to standup [16:06:19] (CR) DannyS712: [C: +2] Remove comments that literally repeat the code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683615 (owner: Thiemo Kreuz (WMDE)) [16:24:28] (Merged) jenkins-bot: Remove comments that literally repeat the code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683615 (owner: Thiemo Kreuz (WMDE)) [16:44:18] (CR) Jforrester: [C: +2] "…" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683594 (https://phabricator.wikimedia.org/T214686) (owner: Zfilipin) [16:44:27] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (KHaggard) Ok,... [16:44:34] (CR) Jforrester: [C: +2] "> Patch Set 1:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683594 (https://phabricator.wikimedia.org/T214686) (owner: Zfilipin) [16:46:31] Fundraising-Backlog, FR-EN6C, FR-Ingenico, FR-Japan: Payments variant with no extra text - https://phabricator.wikimedia.org/T281503 (DStrine) [16:49:00] (CR) Zfilipin: "> Patch Set 1:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683594 (https://phabricator.wikimedia.org/T214686) (owner: Zfilipin) [16:50:15] (CR) Jforrester: [C: +2] "> Patch Set 1:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683594 (https://phabricator.wikimedia.org/T214686) (owner: Zfilipin) [16:51:12] (Merged) jenkins-bot: selenium: Add JUnit reporter [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683594 (https://phabricator.wikimedia.org/T214686) (owner: Zfilipin) [16:57:57] PROBLEM - Host frdb1002 is DOWN: PING CRITICAL - Packet loss = 100% [17:00:44] (CR) Zfilipin: "> Patch Set 1:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/683594 (https://phabricator.wikimedia.org/T214686) (owner: Zfilipin) [17:18:56] Fundraising Sprint File Systems Stage Show, Fundraising Sprint Git Rebase Jump, Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, and 3 others: Creating New Fidelity File Civi Import - https://phabricator.wikimedia.org/T275445 (MD... [17:21:08] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Load Adyen's Drop-In Web JS and CSS on AdyenDropIn form - https://phabricator.wikimedia.org/T281441 (Ejegg) The script path will differ between test and live, and seems to be updated frequently. Read it in from a setting. For cur... [17:32:32] RECOVERY - Host frdb1002 is UP: 72057594037927935 [17:42:51] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Send config needed for Drop-In Web to Adyen front-end - https://phabricator.wikimedia.org/T281509 (Ejegg) [17:43:07] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Send config needed for Drop-In Web to Adyen front-end - https://phabricator.wikimedia.org/T281509 (Ejegg) [17:45:59] ub... I guess we DO want to rewrite the SmashPig Adyen logic - it's still all using WSDL :( [18:05:26] is that what we really really want? [18:08:46] Fundraising-Backlog, FR-Adyen, FR-Smashpig: Fix amount formatting for Adyen recurring - https://phabricator.wikimedia.org/T281513 (Ejegg) [19:00:46] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Load Adyen's Drop-In Web JS and CSS on AdyenDropIn form - https://phabricator.wikimedia.org/T281441 (Ejegg) [19:12:21] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Show payment fields on Adyen Drop-In Web form - https://phabricator.wikimedia.org/T281516 (Ejegg) [19:14:05] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Send config needed for Drop-In Web to Adyen front-end - https://phabricator.wikimedia.org/T281509 (Ejegg) [19:14:21] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Show payment fields on Adyen Drop-In Web form - https://phabricator.wikimedia.org/T281516 (Ejegg) [20:22:13] fundraising-tech-ops, fr-email-preference-center: Create fundraising_code_update project for civiproxy - https://phabricator.wikimedia.org/T281311 (Dwisehaupt) a:Dwisehaupt [20:39:22] (PS1) Ejegg: Pare down email pref ctr config [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/683725 [20:41:37] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Handle payment submission in Adyen Drop-In web - https://phabricator.wikimedia.org/T281528 (Ejegg) [21:00:32] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: add translations to generic email for failed recurring donations - https://phabricator.wikimedia.org/T255837 (TSkaff) [22:35:30] Fundraising Sprint Humongous bacteria petting zoo, Fundraising Sprint Interstitial ads halfway down the coaster hill, Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (Eileenmcnaught...