[01:00:30] (PS5) Ejegg: WIP Create Adyen payment w/encrypted details [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/689196 (https://phabricator.wikimedia.org/T281528) [01:00:32] (PS1) Ejegg: Map AVS and CVV scores for Adyen Checkout [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/692742 (https://phabricator.wikimedia.org/T282641) [01:50:03] (PS2) Ejegg: Map AVS and CVV scores for Adyen Checkout [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/692742 (https://phabricator.wikimedia.org/T282641) [02:03:50] (PS1) Ejegg: WIP run some fraud filters for Adyen Checkout [extensions/DonationInterface] (adyen) - https://gerrit.wikimedia.org/r/692747 (https://phabricator.wikimedia.org/T282641) [02:07:16] (CR) jerkins-bot: [V: -1] WIP run some fraud filters for Adyen Checkout [extensions/DonationInterface] (adyen) - https://gerrit.wikimedia.org/r/692747 (https://phabricator.wikimedia.org/T282641) (owner: Ejegg) [02:32:37] (PS2) Ejegg: WIP run some fraud filters for Adyen Checkout [extensions/DonationInterface] (adyen) - https://gerrit.wikimedia.org/r/692747 (https://phabricator.wikimedia.org/T282641) [03:51:50] Fundraising-Backlog: Update Remind Me Later (RML) form to post to CiviCRM and send that data to Acoustic - https://phabricator.wikimedia.org/T283124 (EWilfong_WMF) [04:36:01] (PS3) AndyRussG: Initial api to purge old thank yous [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/692456 (https://phabricator.wikimedia.org/T280587) (owner: Eileen) [05:54:21] (PS1) Eileen: Add Japanese names to deduper as data and add api support [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/692756 (https://phabricator.wikimedia.org/T281493) [06:52:18] Fundraising-Backlog, fr-donorservices: RML language preference issue - https://phabricator.wikimedia.org/T282912 (MSuijkerbuijk_WMF) Thanks @KHaggard for sharing the path to look at it, I've never been trained on that. Thanks also for confirming that language is English vs the below info shared by Michae... [08:07:39] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [08:12:43] RECOVERY - check_log_messages on frav1002 is OK: OK [15:13:41] Fundraising-Backlog: Update Remind Me Later (RML) form to post to CiviCRM and send that data to Acoustic - https://phabricator.wikimedia.org/T283124 (DStrine) TLDR: This has big security implications and needs planning, design and discussing before we could even talk about putting this on a roadmap. It may n... [15:16:36] fr-tech: any cross-team news to put in the scrum-o-scrums etherpad? [15:16:53] ejegg: none here thx! [15:17:11] nope [15:21:29] whoa, what's this jive in the freenode messages? grumble [~Thunderbi@freenode/staff/grumble] has quit [Killed (grumble (My fellow staff so-called 'friends' are about to hand over account data to a non-staff member. I'm leaving freenode forever and I recommend you drop your NickServ account to keep your data safe.))] [15:22:00] i mean, i don't reuse my NickServ account anywhere else [15:22:13] but that sounds potentially bad [15:23:23] ejegg: Seddon shared the background in vivafredge [15:23:32] oh thanks! [15:56:20] (PS1) Ejegg: Add D-Local decoder data for MS and PQ [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/692908 (https://phabricator.wikimedia.org/T280303) [15:57:12] fr-tech ^^^ just adds a couple more entries to a reference array, but we need it to stop astropay audit parser failing [15:57:31] I just added the PQ => pix mapping because why not [15:58:05] just makes it faster to enable in the frontend later [16:02:20] (CR) AndyRussG: "Thanks for this!! Just one comment so far.... :)" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/692456 (https://phabricator.wikimedia.org/T280587) (owner: Eileen) [16:13:40] (CR) Jgleeson: [C: +2] "looks good" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/692908 (https://phabricator.wikimedia.org/T280303) (owner: Ejegg) [16:14:11] (Merged) jenkins-bot: Add D-Local decoder data for MS and PQ [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/692908 (https://phabricator.wikimedia.org/T280303) (owner: Ejegg) [16:21:13] (PS2) Cstone: Add Adyen Checkout settings [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/692711 [16:26:42] Fundraising-Backlog, FR-LATAM, Patch-For-Review: Adding PIX as a payment type for Brazil - https://phabricator.wikimedia.org/T280303 (EMartin) This is great! I will have Dlocal set this up on their end. [16:28:45] Fundraising-Backlog, FR-LATAM, Patch-For-Review: Adding PIX as a payment type for Brazil - https://phabricator.wikimedia.org/T280303 (DStrine) @EMartin we are not turning this on [17:16:49] Fundraising-Backlog: Australian country score/fraud setting - https://phabricator.wikimedia.org/T283187 (EMartin) [17:52:26] Fundraising-Backlog, fr-donorservices: Australian country score/fraud setting - https://phabricator.wikimedia.org/T283187 (MBeat33) [18:26:17] (PS1) Jgleeson: WIP: Add adyen request template [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/692956 (https://phabricator.wikimedia.org/T281528) [18:26:59] (CR) jerkins-bot: [V: -1] WIP: Add adyen request template [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/692956 (https://phabricator.wikimedia.org/T281528) (owner: Jgleeson) [19:44:16] fr-tech you may want to claim your usernames over at libera.chat [19:44:24] https://libera.chat/guides/registration [19:44:37] there's a guide to grouping alt nicks that may be useful [19:44:55] so you don't get kicked from channels because your alt nick doesn't have the right cloak [19:46:01] ejegg: thx will do! [21:10:34] Wikimedia-Fundraising-Banners: [M Lg] Accidental clicks outside of "Other monthly amount" modal window leads to confusing user experience - https://phabricator.wikimedia.org/T282705 (jbolorinos-ctr) Open→Resolved a:Pcoombe Ok I'm just going to close this task then. We can always revisit again in... [21:27:21] ejegg: do you have any thoughts on AndyRussG's comment here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/692456 ? - I can't think of a good config place to put it [21:34:16] ah heh I was worried that might be the case [21:37:00] I guess for most things in our extensions we get config from smashpig, but this kinda feels out of scope for that [21:40:05] yeah - so we used to stick stuff like this in wmf_civicrm.install - that masive long file of drupal upgrade actions [21:40:47] & I kinda imagine the WMFDataManagement entity becoming the replacement for that - ie our cleanups wind up in there - at least if they are semi-reusable or ongoing [21:41:08] so that namespace would basically be for all our weird bits & pieces of cleanup [21:41:26] & data management [21:42:10] but - the really ad hoc stuff like 'reverse this specific botch up we made' - I guess that has to go in wmf_civicrm upgrader - it's not quite as lightweight for that stuff as the drupal one [21:46:00] eileen: what is the normal locations for civi extensions to place their config [21:46:02] ? [21:46:31] Well - generally if you are going to store something it would be in settings - which go in the DB [21:46:59] If we want this list to be UI-editable we could do that - but I really expected to run the job & then do more queries & code- extend the list [21:47:47] eileen: so there's no standard non-ui editable settings place? [21:48:02] - I mean settings don't HAVE to be exposed to the UI & they can be stored / overridden in civicrm.settings.php - although we don't have great visibility on code review for changes there [21:48:11] or what about a text file or php file location that provides the default for a setting [21:48:22] ah hmmmm right [21:48:32] yeah - civicrm.settings.php is where we normally override settings [21:48:35] can the extension provide a sane default, like with the content u put in the code? [21:48:55] or another option could be just to re-run the query to get those subjects every time? [21:49:20] I guess we do define settings defaults under wmf_civicrm/Managed [21:49:37] the thing is - I went through & picked out some lines that seemed sensible to me [21:49:57] ah hmmm [21:50:02] it wasn't like I took all the results from the query - just the ones that seemed to have the most hits [21:50:24] & if we put it into somewhere more configurable we are saying 'changes to this don't need to go through code review' [21:50:46] I mean I guess I'm ok with any location that is sane in a Civi and wmf code context, and I guess preferably marked as "settings" or "config" [21:50:47] which I'm not sure is where I think we should be on that list [21:51:01] I think it's ok for this not to go through CR [21:51:17] we have a lot of MediaWiki settings that don't go through normal review process [21:51:39] hmm - I don't know - I felt like picking up that list I chose a bunch of lines based on 'that looks like it' [21:51:42] though we (as non-ops engineers) do have the ability to change and deploy, if that's what you're worried about [21:52:07] eileen: right... so that sounds like a settings thing? like on the next run you might want to try something different? [21:52:15] not sure, not really a huge deal either [21:52:27] we could leave them where they are in your patch and mark with a TODO [21:52:36] so - I don't think I'd want to add lines without someone else checking them out [21:52:48] and move think about where else we might want them as we do the drupal upgrade [21:52:56] because we are saying ' this is the list of things where we are comfortable deleting data' [21:53:15] eileen: right... I mean, that's OK... we don't normally change things in localsettings without everyone being on board [21:53:34] yeah - but the code review process is kind of invisible for localsettings [21:53:36] and changing those values doesn't actually change any of the code logic [21:53:42] yeah [21:53:44] hmmmm [21:55:34] AndyRussG: another thing to consider is that I don't actually know how the list will evolve in that I tried to avoid LIKE to make the query efficient but in one case I couldn't [21:56:17] so after the first run which picks off the lowest hanging fruit I don't know what the next fruit will look like [21:56:58] K in terms of process that really sounds like config, or maybe even something (like a filename) to pass in on the command line [21:57:09] but I don't think we need to complicate the matter too much either [21:59:18] though at the very least I feel it should have some kind of symbolic separation (i.e. slightly different location, in a file or folder with "config" or "settings" in the name) from the code where the actual execution logic lives [21:59:37] yeah - we could just stick it in a file in the same folder [22:02:51] eileen: okok definitely sounds reasonable for now :) [22:03:30] AndyRussG: yeah good points to keep thinking about - probably worth getting this job running at this stage [22:04:36] but we'll be working through this more & more - we do have configurable settings & forced settings - some of the latter are private but some could be more obviously in a file that goes through normal CI. [22:05:03] be good to chat about in a tech talk [22:05:34] yeah for sure :) [22:10:03] AndyRussG: if you want to add some comments in there then just go ahead & push them up [22:10:32] eileen: hmmm I haven't quite finished the review tho also heheh [22:10:38] :-) [22:10:48] eileen: also just cooking supper now, I'll be back at this properly in a couple hours ;) [22:10:57] yum [22:11:13] (PS1) Ejegg: Update SmashPig library [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/692999 [22:13:36] heh, wikibugs is already announcing our gerrit patches over at liberachat/#wikimedia-fundraising [22:13:44] heheh hopefully [22:13:59] it is! [22:14:26] paladox and awight were in the channel too, at least briefly [22:15:59] ah cool! ah I meant hopefully wrt eileen's "yum" comment about some cooking occurring around here.... [22:16:27] ah, yess, hopefully yum [22:16:37] AndyRussG: I have a lot of faith in your cooking being yum [22:17:37] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/693000 [22:19:08] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/693000 (owner: Ejegg) [22:19:47] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/693001 [22:20:25] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/693000 (owner: Ejegg) [22:23:53] (PS1) Ejegg: Update SmashPig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/693002 [22:46:28] (CR) Ejegg: [V: +2 C: +2] Update SmashPig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/693002 (owner: Ejegg) [22:48:33] (PS1) Ejegg: Update CiviCRM submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/693009 [22:48:35] (PS1) Ejegg: Update SmashPig library [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/693010 [22:48:37] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/693011 [22:48:47] (CR) jerkins-bot: [V: -1] Update CiviCRM submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/693009 (owner: Ejegg) [22:48:50] eileen: any concerns about deploying ^^^ ? [22:48:52] oh hmm [22:48:59] (CR) jerkins-bot: [V: -1] Update SmashPig library [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/693010 (owner: Ejegg) [22:49:23] oh, did I not need that civicrm submodule update? [22:50:22] oh oops, those are up for review against deployed [22:50:27] *deployment [22:51:16] (PS1) Ejegg: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/693013 [22:51:18] (PS1) Ejegg: Update SmashPig library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/693014 [22:51:48] (Abandoned) Ejegg: Update SmashPig library [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/693010 (owner: Ejegg) [22:52:02] (Abandoned) Ejegg: Update CiviCRM submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/693009 (owner: Ejegg) [22:52:22] (CR) Ejegg: [C: +2] Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/693013 (owner: Ejegg) [22:52:49] (CR) Ejegg: [C: +2] Update SmashPig library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/693014 (owner: Ejegg) [23:14:13] (Merged) jenkins-bot: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/693013 (owner: Ejegg) [23:14:15] (Merged) jenkins-bot: Update SmashPig library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/693014 (owner: Ejegg) [23:20:27] ejegg: I think I abandoned it on the basis we should grab a more recent one now [23:21:13] hmm I'm thinking of https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/681857