[07:22:20] hey [07:24:20] jeremyb you won a beer [07:26:09] jeremyb how do I sync my repo [08:13:39] !leslie [08:13:40] git reset --hard origin/test [09:05:17] mutante: https://gerrit.wikimedia.org/r/#/c/22172/ [09:05:19] ty :D [09:05:26] or whoever who can approve it [09:07:15] !log deployment-prep petrb: inserted OSB to update-extensions.sh and extensions [09:07:17] Logged the message, Master [09:08:42] !log deployment-prep petrb: deployed OSB to enwiki [09:08:44] Logged the message, Master [09:13:25] !log deployment-prep petrb: OSB doesn't seem to be installed properly, investigating [09:13:27] Logged the message, Master [09:22:58] !log deployment-prep petrb: rebuilding localization [09:23:00] Logged the message, Master [12:16:50] Change on 12mediawiki a page Developer access was modified, changed by Henry0127 link https://www.mediawiki.org/w/index.php?diff=578338 edit summary: [12:20:01] Change on 12mediawiki a page Developer access was modified, changed by Henry0127 link https://www.mediawiki.org/w/index.php?diff=578351 edit summary: corrected shell username [12:46:26] JeroenDeDauw1: getItemIdsForLabel() in TermSqlLookup.php [12:48:13] hey hashar [12:50:37] there is some problem on beta [12:50:44] hashar how do I recreate localization cache [12:50:56] oh yeah that one [12:50:58] grmblb [12:51:04] also I was getting some exception regarding magic words, was there some update in mediawiki 1.20? [12:51:09] that is in the scap script :( [12:51:10] because OSB works ok in 1.19 [12:51:13] need to split it up one day [12:51:17] ok [12:51:33] the magic word exceptions usually comes from a wrong l10n cahce [12:51:37] I deployed it but now it doesn't have proper language, doesn't work at all :D [12:51:41] which is really dumb ;) [12:51:44] but in mediawiki 1.19 it's fine [12:51:49] aha [12:51:51] mwscript mergeMessageFileList.php --wiki=aawiki --list-file=/home/wikipedia/common/wmf-config/extension-list --output=/home/wikipedia/common/wmf-config/ExtensionMessages-master.php [12:52:00] and then the awfully long mwscript rebuildLocalisationCache.php --wiki=aawiki --threads=2 [12:52:01] that is what [12:52:02] i will do it [12:52:09] ok [12:52:18] the first script generate a list of all i18n files [12:52:23] the later rebuild the cache [12:52:26] how do I properly clone extension? [12:52:31] so that it's automatically updated [12:52:40] must be a submodule [12:52:44] !log deployment-prep petrb: fixing repo for OSB [12:52:46] Logged the message, Master [12:52:57] !beta rebuilding l10n cache [12:52:57] !log deployment-prep rebuilding l10n cache [12:52:58] Logged the message, Master [12:53:20] the repo is https://gerrit.wikimedia.org/r/p/mediawiki/extensions.git [12:53:29] and OSB is already there [12:53:40] the script should be auto updating every 180seconds [12:54:58] <^demon> hashar: fyi, the gerrit instance for labs is now on 'gerrit-dev' instead of 'gerrit' and rebuilt with puppet. [12:55:04] <^demon> Old manual install went away :) [12:55:13] ^demon: whaooou congratulations!!! [12:55:40] if you want to play with replication, we could setup an instance in deployment-prep that would act as a git receiver [12:56:03] <^demon> Or within gerrit project. Would let us test the slave role. [12:56:19] up to you, but will definitely need it for beta :) [12:57:31] <^demon> Hmm. Could do that too. Right now gerrit::account only does the SSH key. If we made that a little more robust, it could be used by any host that's wanting to receive git replication. [12:57:36] <^demon> All you need is git+ssh [12:58:01] and an op :) [12:58:25] How does gerrit actually replicate? rsync style over ssh or custom job over ssh? [12:58:47] Damianz: RFC 1149 protocol [12:58:59] hashar how I make it a submodule then [12:59:04] though it is a numeric implementation [12:59:13] * Damianz squawks at hashar [12:59:14] petan: you don't need OSB is already hosted by wmf [12:59:21] petan: so that is a submodule of mediawiki/extensions [12:59:23] ok but it wasn't in there [12:59:26] Damianz, I guess it's a mixture of git clone and mysql replication [12:59:26] petan: and hence is already updated [12:59:30] in folder [12:59:32] it wasn' [12:59:37] how I put it there properly [12:59:43] <^demon> Cuz really, if formey's just holding the git commits a slave doesn't really need the gerrit jetty and everything else. [12:59:52] I did git clone https://gerrit.wikimedia.org/r/p/mediawiki/extensions/OnlineStatusBar.git [12:59:55] I was thinking it would be cool to have all open repos replicated to /data/repos on labs in read only ftw [13:00:03] ll -d /home/wikipedia/common/php/extensions/On* [13:00:03] drwxr-xr-x 4 petrb svn 8192 2012-08-31 12:57 /home/wikipedia/common/php/extensions/OnlineStatusBar/ [13:00:05] it is there :) [13:00:05] <^demon> Damianz: Replicates using git over ssh. [13:00:15] ^demon: :D [13:00:16] hashar yes because I did that [13:00:20] git clone https://gerrit.wikimedia.org/r/p/mediawiki/extensions/OnlineStatusBar.git [13:00:23] ahh no [13:00:25] but before it wasn't [13:00:48] let me delete it and redo it properly [13:00:50] ok [13:00:57] write it somewhere how to do that [13:01:56] I am confused by git submodule system [13:02:03] I am confused by git [13:02:06] we probably need to do a git pull in mediawiki/extensions [13:02:11] petan is a cvs child [13:02:20] I wrote git for idiots guide today [13:02:29] create mode 160000 OnlineStatusBar [13:02:31] did a git pull [13:02:33] https://www.mediawiki.org/wiki/User:Petrb/Git_for_idiots [13:02:36] will add that to the job [13:03:00] hashar: git submodule foreach git pull origin master? [13:03:06] yeah [13:03:16] but I forgot to use git pull in mediawiki/extensions first [13:03:24] Ah [13:03:43] !log ran git pull in /home/wikipedia/common/php/extensions , bringing up a ton of forgotten exts. Will update autoupdater [13:03:43] ran is not a valid project. [13:03:48] lol [13:04:18] FUCKING LOG CMD [13:04:20] grm [13:04:28] !beta ran git pull in /home/wikipedia/common/php/extensions , bringing up a ton of forgotten exts. Will update autoupdater [13:04:28] !log deployment-prep ran git pull in /home/wikipedia/common/php/extensions , bringing up a ton of forgotten exts. Will update autoupdater [13:04:29] Logged the message, Master [13:05:00] "There are many ways to reset the repository to original state, but I found it simplest just to delete it and clone it again." < Try doing that with the linux kernel [13:05:33] :P [13:07:16] Damianz: who ever wrote that doc deserve to be sent in fire flames and the doc buried somewhere we all forgot about [13:07:47] * Damianz holds petan up for hashar [13:08:29] !log deployment-prep Updating beta auto updater {{gerrit|22116}} to patchset 6 so it update the extensions list [13:08:41] petan: https://gerrit.wikimedia.org/r/#/c/22116/ patchset 6 :-) [13:08:45] ok [13:08:53] * Damianz looks at labs-morebots [13:08:57] that no run git pull in the extensions dir [13:09:02] grbaoi [13:09:21] Is it just me or is morebots slow/not working randomly. [13:09:27] Assume it's the api being a laggy whore [13:09:56] hashar you are person I will contact when I'd need to revert changes to my repo :D [13:10:10] if yout hink that guide should be burned [13:10:25] IMHO it's the only guide regarding git that doesn't LIE to you [13:10:37] petan: http://learn.github.com/p/intro.html ;) [13:10:49] that one lies [13:10:53] gitref is awesome [13:11:04] it doesn't start with "GIT IS TOOL MADE BY EVIL PEOPLE" [13:11:26] That line is reserved for cvs [13:11:31] hah [13:11:38] it's simple and it works, most of time [13:13:18] petan: there is a few thing you can do to enhance your git experience [13:13:21] the first would be to add colors [13:13:32] the second to use ryan lane patch that show you the current branch in your prompt [13:13:45] last tip is to try out stuff in a local repository ;) [13:14:01] I'm bias because I've been using git for ~2years but it's fucking awesome [13:14:09] hashar is that somewhere waiting for me? [13:14:14] I mean, that Ryan's patch etc [13:14:17] No more waiting 3hours when svn gets to 600 commits [13:15:00] petan: I think it was on his blog [13:15:09] petan: you can take a look at my bashrc : https://github.com/hashar/alix [13:15:20] https://github.com/hashar/alix/blob/master/bashrc [13:15:23] http://ryandlane.com/blog/2011/09/23/configuring-a-local-environment-for-dealing-with-git/ [13:15:39] I really need to update damianzaremba/dotfiles, so out of date [13:15:52] the trick is the parse_repo_branch function [13:16:04] which is inlined in PS1: PS1=$(parse_repo_branch) [13:16:22] Someone needs to talk to Ryan about his horrible terminal [13:16:28] hashar what I do with that? [13:16:36] should I overwrite some files? [13:16:40] or how I install that [13:16:47] arghhh [13:16:50] sohmm [13:17:08] copy the parse_repo_branch parse_git_branch parse_svn_branch in your bashrc [13:17:20] * Damianz wonders if he should move his private git repos to github [13:17:25] then somewhere in the PS1 variable of your bashrc, add : $(parse_repo_branch) [13:17:43] example: PS1="\u@\h$(parse_repo_branch)$" [13:18:08] Why do we have some many french mediawiki people, they're invading :P [13:18:09] Damianz: whenever i got time, I will publish my ~ dir directly :-D [13:18:33] Damianz: send the frenchies to me :-D [13:19:12] My long term plan to move my scripts to 1 framework with 1 key is <> and has been for a year so they've just stayed private :P Tidied up my dns zones though so they can go public soon [13:19:55] * Damianz sends hashar to hashar [13:20:01] my veryyy long term plan is to get color output and debug level in mediawiki [13:20:02] ala http://www.bashinator.org/images/bashinator-term.large.png [13:20:22] That's freaking insane [13:20:48] Oh god I love python tracebacks looking at that... [13:22:17] hashar: Considering most of mediawiki is web based... how would that work with log files, going to tail them and run though a pre-processor [13:27:26] <^demon> Damianz, hashar: PS1 and git tips: https://labsconsole.wikimedia.org/wiki/User:Demon :) [13:28:32] I have made it simpler by using __git_ps1 :D [13:28:47] https://github.com/hashar/alix/blob/master/bashrc [13:29:04] I swear no one around here looks like I imagine them too when I see their picture :P [13:29:48] Your terminal is much better though :D [13:29:55] * Damianz should fix his diff colours on this pc [13:30:10] feel free to reuse the files [13:30:33] License: GPLv2 Some portions of code have been borrowed from the internet and are under a Public Domain attribution. [13:31:20] hashar, what does it do? [13:31:28] I installed the script but I see no difference in my promtp [13:31:30] prompt [13:31:38] it's still same [13:31:42] even if I relog [13:31:43] source ~/.bashrc [13:31:52] Damianz I created new screen [13:31:56] still same [13:31:58] or that [13:32:27] * Damianz throws menthols at hashar then goes to get subway [13:32:27] PS1="\[\e]0;${debian_chroot:+($debian_chroot)}\u@\h: \w\a\]$(parse_repo_branch)$PS1" [13:32:35] cya [13:38:53] Really not having a conversation about the physics of using a whip in porn and why disabled people should be allowed in the olympics rather than eating lunch. IRC is weird sometimes [13:40:06] petan: what does sync mean? [13:40:23] whwere [13:40:36] jeremyb synchronize [13:40:38] Damianz: NO MORE MENTHOL !!!!!!!!!!! [13:40:53] hashar: re [13:41:16] 31 07:26:09 < petan> jeremyb how do I sync my repo [13:41:19] petan: OlineStatusBar should be fine :) [13:41:39] jeremyb I think I wanted --rebase [13:41:39] hashar: do we need to add a build.xml to extensions to do the phpunit testing? [13:41:47] git people helped me [13:42:37] OrenBo: depends :-) [13:42:42] OrenBo: what are you trying to do ? [13:42:45] hashar: Btw on beta - is it currently possible to see what git ref is being used, would be interesting for reports again extensions if we can step though and say works in a, b, c, d, broken after e. Though that requires more testing/git integration. [13:43:02] if you want to create a new job in Jenkins, you can just sym link the build file from jobs/_shared/build.xml [13:43:05] and other files [13:43:19] hashar: like I said on the list I am trying to run unit test on Jenkins for the translate extension [13:43:20] note that there is ZERO documentation about setting up a new extension job :( [13:43:28] oh [13:43:49] I've mirrored the setting for TitleBlackList but it wont build [13:43:55] I guess the easiest is to create a new job that would be a copy of Ext-TitleBlacklist [13:44:04] then change all titleblacklist paths to translate [13:44:14] and hope / praise / crosse fingers [13:44:39] Damianz: Special:Version maybe ? [13:44:46] hashar: olinestatusbar???? [13:45:05] jeremyb: some extension that is apparently going to be deployed on the cluster [13:45:07] hashar: how does that relate to klinestatusbar or ilinestatusbar? [13:45:19] Damianz: http://commons.wikimedia.beta.wmflabs.org/wiki/Special:Version [13:45:24] Ah cool [13:45:58] jeremyb: I am not sure I understand what you mean. Is that a joke? [13:46:14] err how do I make a symlink on jenkins ...? [13:46:15] jeremyb: :P [13:46:18] Damianz: we have a bug open somewhere about adding the date of the commit [13:46:19] irc lols [13:46:33] OrenBo: ah that hmm you don't get shell access :-D [13:46:36] let me create them [13:46:43] ideally [13:46:48] I would set up a job template [13:47:00] :) [13:47:00] and write a script to generate all the extension jenkins jobs [13:47:03] I'll be much obliged [13:47:17] https://integration.mediawiki.org/ci/view/All/job/Ext-Translate/ [13:47:26] have you created it by copying the Ext-TitleBlacklist ext ? [13:47:35] manualy [13:47:41] I'd rather like to have extensions and debs setup automagically from the list out of gerrit and in the case of debs, built and pushed to the mirror (as talked about before) ftw [13:47:56] I do still pull the code from git [13:47:58] * Damianz actually goes for lunch rather than eating his gum and will be back shortly [13:48:03] but I could remove that [13:48:36] hashar: yes. oline and kline and iline are things that effect what users can do on an IRC server/network. maybe you meant onlinestatusbar instead of olinestatusbar? ;-) ;-) [13:48:50] OrenBo: I have created a bunch of required symlinks [13:49:24] jeremyb: ahh K-Line :-) [13:49:30] jeremyb: yeah I mean OnlineStatusBar [13:49:52] * hashar notices his level of english improved since he can now detect jokes [13:50:03] haha [13:50:19] maybe I will one day relocate to the US :-D [13:50:28] with kids?? [13:50:31] OrenBo: the ant target I am using are properties setup-extension phpunit-extensions take-fingerprints [13:50:33] do you see much of guillom? are you in the same city? [13:50:47] hashar: Are you up on colloquialisms yet? :P [13:50:50] OrenBo: properties dump all the properties, can be skipped. take-fingerprints should be last I think [13:51:04] I copied that [13:51:08] jeremyb: We live in different cities [13:51:21] jeremyb: well you would need a proper medical system and disallow weapons before I consider moving to the us :-D [13:51:23] I live in Toulouse (near Spaine), hashar lives in Brittany. [13:51:28] jeremyb: and adopt Euro of course [13:51:35] not sure what fingerprint are for - we never used them in Java builds [13:51:46] hashar: define disallow. well and define weapons [13:51:52] jeremyb: guillom and I are roughly 7 hours apart by train [13:51:56] Guns are a reason *to* move [13:51:58] I guess to allow people to check for temparing [13:52:03] Damianz: TROLL ;-))))))))))) [13:52:10] Hey I like guns, they're fun [13:52:19] hmm [13:52:35] OrenBo: I think fingerprinting can be skipped for extensions [13:52:36] btw coping the project does not work [13:52:38] oh, huh, why did i think maybe you were paris [13:53:04] OrenBo: fingerprints are used by jenkins to detect relation between jobs. Since for extension there is only one job per extension, I guess we can remove them [13:53:06] meaning it still misses the file [13:53:29] makes sense [13:53:30] France is pretty awesome, last time I was there it rained for 2 weeks while I was camping -.- [13:53:45] I love France [13:54:16] just which we had Belgium beer, Switzerland weakness, and replace the inhabitants with Dutch people [13:54:22] wish* [13:54:22] and all of them would speak German [13:54:26] and we will get a perfect country :-] [13:54:32] OR [13:54:37] I can live in Europe and travel around :D [13:54:39] Belgium beer is the best in the world [13:54:40] oh, you don't love french lang? [13:54:51] hashar: Ever frequent FOSDEM? [13:54:56] I just find German to sound better [13:55:04] we have belgian beer in NYC :) [13:55:10] Damianz: na never. Was not possible last year cause my daughter was too young [13:55:19] might attend the next one though. [13:55:20] did either of you see https://commons.wikimedia.org/wiki/Category:Wikip%C3%A9dia_dans_Rennes in person? [13:55:22] regarding shell - I asked nicely 6 months ago to install artifactory - at this point I just want to get the thing to work [13:55:26] need to find out if the WMF is willing to send me there [13:55:29] Ah, same here but I keep meaning too. Missed the last few due to work! [13:55:31] and of course, something to do there [13:55:57] OrenBo: ah artifactory [13:56:06] Videos allways look fun, keep meaning to spend a year doing the big cons (fosdem, defcon, django, python etc) but finding time is tricky [13:56:24] OrenBo: I think nullspoon (David Schonoover, WMF staff in SF) is going to set that up [13:56:32] OrenBo: or a maven repository, can't remember [13:57:42] its the same [13:57:52] so can you set up the symlink [13:57:57] jeremyb: I did not. It is on my plan of stuff to do [13:58:09] jeremyb: I am like 100 km away from Rennes ( like 60 miles? ) [13:58:23] that is really a neat project [13:58:31] hashar: are they still up?? [13:58:45] I have no idea [13:58:49] hashar: too much of the stuff written about the project is in greek ;( [13:58:53] although it would be nice to see what is in that super secret build.xml file :-) [13:59:05] From May 21st to 28th 2011 apparently [13:59:40] thanks [13:59:51] oh yeah [13:59:52] sorry [14:00:06] OrenBo: all the jenkins configuration is in a git repository : integration/jenkins [14:00:33] hmm [14:00:51] https://gerrit.wikimedia.org/r/gitweb?p=integration/jenkins.git;a=summary [14:00:54] https://gerrit.wikimedia.org/r/p/integration/jenkins.git [14:01:06] or ssh://gerrit.wikimedia.org:29418/integration/jenkins.git since you have a labs account [14:01:15] what I do is that I do all my configuration in Jenkins [14:01:22] then git commit from the server to gerrit and then merge [14:01:37] the build.xml file, I change it on my local machine [14:01:44] then git commit -> gerrit -> merge -> update on server [14:02:05] of course having a documentation would make that possible for others to help [14:02:18] OrenBo: ^^ [14:02:30] taking some fresh air for a few, will update https://www.mediawiki.org/wiki/Jenkins after [14:02:58] it might be best to put that file in the extensions dir as part of the mediawiki distor [14:03:00] it might be best to put that file in the extensions dir as part of the mediawiki distro [14:03:27] and add a target to test all extensions localy [14:03:44] of course I guess you don't have ant localy [14:03:51] or do you ? [14:04:38] any how CI best practices is KISS [14:07:25] Change on 12mediawiki a page Developer access was modified, changed by Jeremyb link https://www.mediawiki.org/w/index.php?diff=578387 edit summary: /* User:Zen4us */ done [14:07:28] Change on 12mediawiki a page Developer access was modified, changed by Jeremyb link https://www.mediawiki.org/w/index.php?diff=578388 edit summary: /* User:Henry0127 */ done [14:07:43] so how to fix the gerrit env ? [14:08:16] the most useful is to prametrise it from jenkins ui [14:21:50] OrenBo: what do you mean by "fix the gerrit env"? [14:48:28] wtf [14:48:50] /Git/New_repositories/Requests totally just served me an out of date cached version of the page with my entry missing -.- [15:10:58] 08/31/2012 - 15:10:58 - User henry0127 may have been modified in LDAP or locally, updating key in project(s): allnovausersstatic [15:11:09] 08/31/2012 - 15:11:09 - Creating a home directory for henry0127 at /export/keys/henry0127 [15:14:00] o.0 [15:14:13] That's really a project heh [15:16:10] 08/31/2012 - 15:16:10 - Updating keys for henry0127 at /export/keys/henry0127 [15:52:08] mutante: around? I need some info on some planet stuff [15:58:11] Alchimista: is in SF now, so probably not yet in office [15:59:20] hashar: nop, it's nothing urgent. Does anyone else knows where is the planet code? I'm not finding it [15:59:38] Alchimista: I guess it is in operations/puppet git repository [15:59:43] !gitweb operations/puppet [15:59:43] https://gerrit.wikimedia.org/r/gitweb?p=analytics/udp-filters.git [15:59:47] hahaha [15:59:50] wrong link [15:59:55] petan: ^^^ [16:00:02] lool [16:00:02] hm [16:00:18] https://gerrit.wikimedia.org/r/gitweb?p=operations/puppet.git [16:00:25] Alchimista: let me find out in a few minutes [16:01:56] Alchimista: what are you looking for ? [16:02:02] hashar: i've found what i was looking :D thanks [16:02:06] apparently config is in ./templates/planet/de_config.erb [16:02:28] hashar yes? [16:02:34] you pinged me [16:02:43] !gitweb operations/puppet [16:02:43] https://gerrit.wikimedia.org/r/gitweb?p=analytics/udp-filters.git [16:02:47] i was looking at the local .ini files, to check what i had made wrong, but now i see that those files where replaced by a new config file [16:02:47] gives out the wrong link :-D [16:02:53] !gitweb [16:02:53] https://gerrit.wikimedia.org/r/gitweb?p=analytics/udp-filters.git [16:02:54] !gitweb [16:02:54] https://gerrit.wikimedia.org/r/gitweb?p=analytics/udp-filters.git [16:02:58] !gitweb puppet [16:02:58] https://gerrit.wikimedia.org/r/gitweb?p=analytics/udp-filters.git [16:03:01] !gitweb seriously [16:03:01] hashar because there is no $1 [16:03:01] https://gerrit.wikimedia.org/r/gitweb?p=analytics/udp-filters.git [16:03:04] ahhh [16:03:05] it has no parameters at all [16:03:08] !del gitweb [16:03:13] !gitweb del [16:03:13] !gitweb del [16:03:13] Successfully removed gitweb [16:03:14] Unable to find the specified key in db [16:03:23] !del is if you want to delete a key, this is wrong way [16:03:24] Key was added [16:03:26] !del git [16:03:26] !gitweb is https://gerrit.wikimedia.org/r/gitweb?p=$1.git [16:03:26] if you want to delete a key, this is wrong way [16:03:27] Key was added [16:03:33] !gitweb operations/puppet [16:03:33] https://gerrit.wikimedia.org/r/gitweb?p=operations/puppet.git [16:03:51] petan: thanks!!! [16:04:06] !gitweb [16:04:07] https://gerrit.wikimedia.org/r/gitweb?p=$1.git [16:47:40] Alchimista: hi [18:16:26] <^demon|lunch> Ryan_Lane: So, I'm trying to get gerrit in labs to talk to LDAP, but it ain't working :( [18:16:36] <^demon|lunch> http://p.defau.lt/?Uq_KUzJ0wvEtyFAydmlY6w - this is the current config [18:16:57] that should work [18:17:06] what's happening with it? [18:17:17] why person? [18:17:18] <^demon|lunch> Nothing in gerrit's error log, just a generic sign in failure from the UI [18:17:22] rather than inetorgperson? [18:17:41] <^demon|lunch> This was copied from prod. [18:17:44] ah [18:18:50] New review: Dzahn; "check_ram.sh made it into prod somehow through another change but i do not see it being used anywher..." [operations/puppet] (test); V: 0 C: -2; - https://gerrit.wikimedia.org/r/12164 [18:19:24] ^demon|lunch: you need to set username and password in secure.conf [18:19:29] secure.config [18:19:35] under the [ldap] section [18:19:43] <^demon|lunch> user & password has to be in secure.config? [18:20:00] <^demon|lunch> password is in secure.config, user is in gerrit.config [18:20:48] <^demon|lunch> Actually, both are in secure.config [18:32:02] New review: DamianZaremba; "21822 added check_ram.sh back in and resolved monitoring issues, 21831 fixed snmp issues for puppet ..." [operations/puppet] (test) C: -1; - https://gerrit.wikimedia.org/r/12164 [18:33:29] You really want me to review that change Sumanah *finds php hat* :P [18:33:45] ^demon|lunch: hm [18:34:03] ^demon|lunch: usually errors will show in the log if its not working [18:34:35] Damianz: maybe I was wrong, but IIRC you had worked on an issue with related functionality in a different part of the codebase [18:34:56] Damianz: no obligation of course, just a request [18:35:16] <^demon|lunch> Ryan_Lane: That's what I thought. [18:35:34] <^demon|lunch> We're running 2.5rc0. Wonder if there's a regression :\ [18:35:42] Possibly, I've not looked at the diff yet - I don't usually work on mediawiki directly though. I'll take a look in a few when I'm caught up. [18:35:42] I can check the logs to see what it's trying [18:35:52] ^demon|lunch: what's the url so I can test? [18:35:52] * Damianz possibly complained in a bug somewhere about it :) [18:36:23] :) [18:36:30] <^demon|lunch> Ryan_Lane: http://gerrit-dev.wmflabs.org/, instance in labs is "gerrit-dev" as well [18:36:50] ugh [18:36:52] no https? [18:37:02] please fix that [18:37:07] * Damianz opens tcpdump [18:37:08] and require it [18:37:09] :D [18:37:20] * Damianz notes he's not *that* evil [18:37:23] Ryan_Lane: Using what, the labs cert? Isn't the labs cert self-signed or something? [18:37:36] RoanKattouw: self-signed is fine [18:37:38] <^demon|lunch> Ryan_Lane: If we require https, it would simplify the config too ;-) [18:37:48] Using ssl around labs would be awesome but also somewhat pointless since we would all have access to the key [18:37:50] we do in production [18:37:59] I'd prefer self-signed [18:38:06] I kind of want to kill the * key [18:38:08] Ryan_Lane: Just sayin', requiring everyone to click through a security warning to use the gerrit-dev site is suboptimal IMO [18:38:10] it's not terribly helpful [18:38:10] Though we're pretty trustable in general, is an open for open signups though. [18:38:24]