[00:16:38] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 031] "I'm pretty much happy with this, though I guess we can't really test this except on the cluster - I'll merge if you're ready for that." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/95173 (owner: 10Gergő Tisza)
[00:29:40] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Right, let's do it and see how it works on beta." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90919 (owner: 10Gergő Tisza)
[00:29:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Return assessment level [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90919 (owner: 10Gergő Tisza)
[00:29:45] <marktraceur>	 Executive decision
[00:35:31] <marktraceur>	 As expected, http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&prop=imageinfo&titles=File:Title_0.6229354626122394.png&iiprop=extmetadata is sparse but http://commons.wikimedia.beta.wmflabs.org/w/api.php?action=query&prop=imageinfo&titles=File:Title_0.6229354626122394.png&iiprop=extmetadata is working
[00:35:38] <marktraceur>	 I'm basically OK with that
[00:35:40] <marktraceur>	 For now, anyway
[00:43:42] <tgr>	 marktraceur: that working on en.wikipedia depends on https://gerrit.wikimedia.org/r/#/c/95148/ which is waiting for aaron's review
[00:44:09] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Ah, 'kay." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/94088 (owner: 10Gergő Tisza)
[00:44:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Handle multiple license templates [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/94088 (owner: 10Gergő Tisza)
[00:44:19] <marktraceur>	 'kay
[00:50:53] <marktraceur>	 tgr: Are you waiting for review because of the DB call?
[00:51:37] <marktraceur>	 It seems like a very simple thing
[00:53:53] <marktraceur>	 tgr: /me thinks caching is in order
[00:57:51] <tgr>	 WikiPage::getCategories() and other similar calls are not cached either
[00:58:30] <tgr>	 but CommonsMetadata is heavily cached
[00:58:49] <tgr>	 or more precisely the extmetadata API
[00:59:09] <tgr>	 so shouldn't be a problem IMO
[00:59:10] <bawolff>	 That does seem like a very cheap db query as far as db queries go
[00:59:36] <tgr>	 yes, its a primary key lookup
[01:00:26] <bawolff>	 I'd point out that WikiPage::getCategories actually isn't called very much afaik
[01:00:35] <bawolff>	 so probably not the greatest point of comparision
[01:00:47] <tgr>	 don't think there is much to review on it, but Aaron suggested this approach, i thought he might want to have a look at it
[01:01:12] <tgr>	 Title::getParentCategories is not cached either
[01:01:37] <bawolff>	 Categories, when they are displayed on wiki, usually come from the parser cache, and not a direct query
[01:02:25] <tgr>	 in this case they would come from the GetExtendedMetadata cache
[01:02:35] <tgr>	 i dont think there is a problem there
[01:03:12] <bawolff>	 I think you're likely right that it should be fine
[01:03:59] <bawolff>	 The only thing thing that would give me pause would be that its cross wiki, although I can't imagine that would change much
[01:13:25] <tgr>	 anyway, i am past my shelf life for today
[01:13:59] <tgr>	 i'll add caching tomorrow, if marktraceur thinks it is needed
[01:14:24] <marktraceur>	 'kay, I'll remove that comment, you're probably right
[01:18:22] <tgr>	 aaron suggested using shared memcache caching for this and the description text, i will do that at some point, but that's more complicated (the host wiki neads to clear the cache whenever the file is changed), and as long as CMD is heavily cached, i don't think it matters
[01:21:15] <bawolff>	 Isn't the description text already cached in shared memcache?
[01:22:20] * bawolff  subtly tries to convince someone to review https://gerrit.wikimedia.org/r/#/c/85446/ - Its a whole other step after merge to make it actually on on wmf wikis, so its not scary, I promise ;)