[16:27:57] bd808: any tips whom i should ask to review the thumbnail patch? [16:27:58] tim maybe? [16:29:23] tgr: Tim would be great but I don't know how busy he is. Aaron might be a good choice too. [16:29:43] He's always busy too :( [16:30:52] I'll look at it again too in a bit [16:31:13] But I probably won't be bold enough to +2 it [16:31:48] I can bring it up at the Core weekly meeting if it is still in need of +2 by this afternoon [16:32:24] We have a standing section of the meeting to highlight patches that need review [16:33:08] You should probably take the "WIP" off of the commit message if you think it's ready for use pending the review [16:33:42] WIP it [16:33:44] WIP it good [18:21:50] marktraceur: things get political if you aren't diplomatic enough :-) [18:22:24] I mean [18:22:31] I think diplomacy is a subset of political action [18:23:21] * robla just thinks it's fun to make portmanteaus of those two words [18:23:30] diplitical [18:23:36] polomatic [18:23:52] whee! [18:23:53] Politmacy sounds pretty arcane [19:00:40] So I'm gonna try to get some shopping done today, but I will be on late, working on the two tickets I've claimed [19:21:18] Ohai pginer [19:21:41] Hi marktraceur [19:23:20] D'you have thoughts about putting the close button outside the image? [19:25:09] Since images have very different aspect ratios, the X will be outside the image at some point. [19:25:20] for example, imagine a 1px width image [19:25:31] The question would be, at which point [19:27:08] If the image occupies (most of) the whole with, I think it is fine to have it over the image (otherwise, we would be adding an artificial margin just for the X not to be over the image). [19:27:26] Well, I mean, a 1px image would (currently) mean that the X was overlapping the entire image, not that it was outside [19:27:43] pginer: Did you not see jzimmerman's email? [19:28:27] And fabriceflorin and I have discussed it multiple times, each time coming closer to the idea that "most" "good" lightbox implementations wind up putting the chrome (including the close button) outside the image in a small frame [19:30:12] pginer: You should maybe reply to that email and list concerns, if you have them, with that solution, else we'd like to have an idea of what kind of look we should go with [19:31:19] pginer marktraceur : Yeah, I agree that moving the 'X' and related controls away from overlaying on the image is the most practical solution for now, unless Pau has other recommendations. To that end, I have started this Mingle ticket, so we can address these issues this week: https://mingle.corp.wikimedia.org/projects/multimedia/cards/68 [19:31:35] ok, I found the email. I'll check this and reply tomorrow in my morning [19:32:58] pginer: Thanks so much for your help with this important aspect. Note that this applies not only to the 'x' and full-screen buttons, but also to the next/previous arrows and eventually to the slide-show play button. I am seeing a clear trend across all multimedia sites to consolidate around a thin black frame around the image. [19:33:25] pginer: Also, thanks for all your great work on the Multimedia Vision slides, which look great! [19:35:28] Pau: I am going to create a separate Roundtables deck that will include the Multimedia Vision, along with other discussion slides. Will leave the current Vision deck as the master, but will not share it directly with users. Instead, I plan to make a separate PDF and upload it on Commons tomorrow, when you confirm that we are all done on your end. Thanks again! [19:36:51] Well [19:37:02] Regarding the deck, I think it is mostly done. I can make some small changes (e.g., make titles different...) [19:37:12] "thin black frame" in that we basically will just subtract some amount of space from the max image size [19:37:18] The image is already auto-centered [19:37:20] but that has probably less priority than resolving the MM Viewer doubts [19:38:03] so I'll start tomorrow with the control positioning pro the different aspect ratios. Feel free to add comments to the MM Vision deck if you find something that needs fixing. [22:34:02] (03PS3) 10Amire80: Fix images and related CSS for RTL wikis [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/94269 [22:34:31] Yay [22:35:22] (03CR) 10MarkTraceur: [C: 04-1] "Still changing the MLB CSS file, but almost there :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/94269 (owner: 10Amire80) [22:55:04] (03PS4) 10Amire80: Fix images and related CSS for RTL wikis [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/94269 [23:20:43] Ugh [23:20:55] I'm rewriting a big pile of the interface code...again :( [23:21:16] I *think* this will be slightly nicer [23:23:50] Luckily it's still relatively small