[00:01:12] (03PS1) 10Yamelnychuk: "Use this file" does not contain license information Bug: 56588 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99003 [00:18:11] (03CR) 10Qgil: [C: 04-1] "I haven't looked at the code, but here is a comment about the commit message:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99003 (owner: 10Yamelnychuk) [00:33:35] (03PS2) 10Yamelnychuk: "Use this file" does not contain license information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99003 [08:20:37] (03CR) 10Raimond Spekking: [C: 04-1] "Use this file" does not contain license information (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99003 (owner: 10Yamelnychuk) [13:47:55] (03PS3) 10Yamelnychuk: "Use this file" does not contain license information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99003 [13:48:02] (03CR) 10jenkins-bot: [V: 04-1] "Use this file" does not contain license information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99003 (owner: 10Yamelnychuk) [13:49:09] (03PS4) 10Yamelnychuk: "Use this file" does not contain license information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99003 [16:29:38] grrrr.... [16:29:54] upload wizard seems to get less and less reliable for me. [16:30:24] I have to use the old form all the time now, because the wizard just spins forever on uploading. [16:32:33] ragesoss: Do you see errors in the JS console? [16:34:34] yeah, I got these: [16:34:53] [11:33:51.006] "mw.FirefoggHandler::start> upload start!" [16:34:53] [11:33:51.325] GET https://commons.wikimedia.org/w/api.php?action=tokens&format=json&type=edit [HTTP/1.1 200 OK 78ms] [16:34:53] [11:33:51.387] POST https://commons.wikimedia.org/w/api.php [HTTP/1.1 200 OK 1776ms] [16:34:53] [11:33:58.736] "mw.FirefoggHandler::start> upload start!" [16:34:53] [11:33:58.989] TypeError: info.audio is undefined @ https://bits.wikimedia.org/commons.wikimedia.org/load.php?debug=false&lang=en&modules=ext.uploadWizard&skin=vector&version=20131204T022536Z&*:34 [16:35:27] (file is a pdf that worked fine in old upload form) [16:37:09] Whoa, Firefogg? [16:37:14] That's fantastic [16:37:23] I don't think I've seen anyone using it before [16:37:40] I'll take a look at it [16:37:52] I've been using it for ages, although not for a while now. [16:38:08] actually, a bug I filed against it just got closed WONTFIX this morning, since we don't support it anymore. [16:39:50] Huh [16:39:58] Well, I'll look at the bug quickly when I get in [16:40:26] And I'll disabled firefogg. [16:40:27] :) [17:36:48] ragesoss: Were you uploading an image? [17:52:27] (03PS3) 10Gergő Tisza: WIP Add tests for InformationParser [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/98546 [17:53:23] (03CR) 10jenkins-bot: [V: 04-1] WIP Add tests for InformationParser [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/98546 (owner: 10Gergő Tisza) [17:55:59] (03PS4) 10Gergő Tisza: WIP Add tests for InformationParser [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/98546 [17:57:29] wmfmedia-standup: Watch yourself, I know you're tempted [17:57:46] marktraceur: the roundtable hangout thing is started nowish right? [17:57:46] It's just not gonna work [17:57:58] bawolff: Yeah, we're getting it set up [18:00:00] Stand-up! [18:00:00] Order: marktraceur -> tgr -> fabriceflorin -> bd808 [18:00:07] Gahhhhh [18:01:09] wmfmedia-standup: I'll fix you one day [18:01:14] Right after I fix grrrit-wm [18:11:11] bawolff: We lost ye [18:12:24] yeah, I'm not sure what happened. My connection dissapeared the moment I started talking [18:12:44] I guess transferring the audio stream was enough of a bandwidth hit [18:13:39] I feel like my bandwidth is significantly less then what my ISP advertizes :s [18:15:49] bawolff: Remember, .001 cents is the same as .001 dollars. :) [18:22:25] marktraceur: I was uploading a pdf. [18:22:59] ( also uploaded two images in that session; I had to "remove" the stalled pdf) [18:23:09] Well, a PDF also wouldn't have an audio track [18:23:11] Hopefully [18:23:16] But I haven't read the spec recently [18:24:11] lol, wat [18:24:30] indeed. [18:24:34] Yeah I hope not [18:24:41] no audio track that I know of. [18:24:45] Although I would point out that jpeg files can have audio tracks [18:24:48] bawolff: You just never know! Adobe could have messed with it! [18:24:59] * marktraceur will submit a patch to fix the immediate error. [18:25:04] it was output from InDesign, most likely. [18:25:18] There's a lot of weird stuff in pdf file from what I understand (3D models, etc) [18:26:03] ragesoss: No, it was someone checking info.audio.length without checking that info.audio existed [18:26:26] the pdf itself, I mean, as output from InDesign. [18:26:44] so, Adobe is to blame. [18:26:49] Ah, yeah. Always. [18:27:02] Actually I wonder if Elsie should add Adobe to the blame wheel [18:27:08] Maybe we can make a Multimedia Blame Wheel [18:33:23] https://en.wikipedia.org/wiki/User:MarkTraceur/Multimedia_blame_wheel [18:36:17] Booooooost the siiiiiiignal [18:45:26] ragesoss: FYI I uploaded a one-line patch you could review or bug people to review at your leisure. I would be very happy to work through Firefogg use with you and see where the remaining issues are. [18:50:42] marktraceur: sweet. [19:03:16] marktraceur: 7/10 tries it blamed Adobe. Seems about right :) [19:03:49] bd808: Basically yup. [20:40:52] mc [20:41:08] meh [20:41:14] too many windows [20:48:19] Never [21:17:23] (03CR) 10MarkTraceur: [C: 032] Add a very simple resize test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98746 (owner: 10Aarcos) [21:17:53] (03Merged) 10jenkins-bot: Add a very simple resize test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98746 (owner: 10Aarcos) [21:17:59] {{done}} yay [21:18:43] tx ! [21:37:39] (03CR) 10MarkTraceur: "OK, for some reason now I see local links on en.wikipedia.org but they don't happen on localhost. MediaWiki.org also seems to use local li" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 (owner: 10Vldandrew) [21:50:01] (03CR) 10MarkTraceur: "We wind up with" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99003 (owner: 10Yamelnychuk) [21:50:07] (03CR) 10MarkTraceur: [C: 04-1] "Use this file" does not contain license information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99003 (owner: 10Yamelnychuk) [22:05:29] (03Abandoned) 10MarkTraceur: WIP: Add unit tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96152 (owner: 10MarkTraceur) [22:19:33] aarcos: I'm working on our image size bucketing patch while the RFC review is happening, I can work on the UW test stuff with you around 15:30 or so maybe [22:20:21] marktraceur: sgtm [22:40:03] (03PS5) 10Gergő Tisza: WIP Add tests for InformationParser [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/98546 [22:46:20] (03PS6) 10Gergő Tisza: Add tests for InformationParser [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/98546 [22:47:17] (03CR) 10jenkins-bot: [V: 04-1] Add tests for InformationParser [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/98546 (owner: 10Gergő Tisza) [22:49:00] (03CR) 10jenkins-bot: [V: 04-1] Add tests for InformationParser [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/98546 (owner: 10Gergő Tisza) [22:50:17] (03PS7) 10Gergő Tisza: Add tests for InformationParser [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/98546 [22:55:27] (03PS5) 10MarkTraceur: WIP Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 [22:55:39] (03CR) 10MarkTraceur: "MASSIVE rebase." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 (owner: 10MarkTraceur) [23:00:41] (03PS6) 10MarkTraceur: Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 [23:01:47] (03CR) 10MarkTraceur: "Added ze tests." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 (owner: 10MarkTraceur) [23:11:31] * marktraceur looks at brion [23:11:39] I added unit tests for the image bucketing patch :) [23:11:56] Probably our first actually unit tests