[12:42:20] (03PS1) 10Pginer: Styling adjustmants on the bottom panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100362 [12:42:56] (03PS2) 10Pginer: Styling adjustmants on the bottom panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100362 [19:12:49] (03PS10) 10Aarcos: Fix resize listener leak problem. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 [19:17:05] (03CR) 10Aarcos: "Reviewers, PTAL (please take another look)." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 (owner: 10Aarcos) [19:19:53] Interesting, our profiler is telling me that we're making *two* image loads and *two* image metadata fetches per image [19:20:03] That could be causing some performance hits maybe [19:28:17] (03PS2) 10MarkTraceur: Add performance logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99786 [19:28:29] I should maybe add logging tests also [20:16:33] aarcos: Just added you on https://gerrit.wikimedia.org/r/99722 FYI [20:17:46] sure !, will take a look. [20:17:59] Thanks, James_F says they want it to go out soonish maybe [20:22:48] (03PS1) 10Aarcos: Create smoke tests for the LightboxImage class. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100427 [20:22:50] (03CR) 10jenkins-bot: [V: 04-1] Create smoke tests for the LightboxImage class. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100427 (owner: 10Aarcos) [20:30:14] (03PS2) 10Aarcos: Create smoke tests for the LightboxImage class. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100427 [20:30:53] (03CR) 10jenkins-bot: [V: 04-1] Create smoke tests for the LightboxImage class. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100427 (owner: 10Aarcos) [20:37:24] (03PS3) 10Aarcos: Create smoke tests for the LightboxImage class. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100427 [20:45:34] Well, Jenkins? [20:45:47] (03PS11) 10MarkTraceur: Fix resize listener leak problem. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 (owner: 10Aarcos) [20:48:29] aarcos: Are any of the listener leak changes going to conflict with the patch I linked you to? Should we rebase them in any particular order? [20:52:34] * marktraceur will merge aarcos's patch unless he objects [20:52:52] (03CR) 10MarkTraceur: [C: 032] Fix resize listener leak problem. (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 (owner: 10Aarcos) [20:53:34] (03Merged) 10jenkins-bot: Fix resize listener leak problem. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 (owner: 10Aarcos) [21:09:42] (03CR) 10Aarcos: Fix resize listener leak problem. (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 (owner: 10Aarcos) [21:33:05] (03CR) 10Aarcos: Move clearInterface things to mw.LightboxInterface (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99722 (owner: 10MarkTraceur) [21:51:40] Is that intended as a -1? [22:05:14] thought you all might like to see this http://commons.wikimedia.beta.wmflabs.org/w/index.php?title=Category:Images_from_the_National_Library_of_the_Netherlands [22:07:44] Wow! [22:08:09] dan-nl: Have you and bd808 been watching the performance on the beta cluster to make sure there's nothing narsty happening? [22:08:38] marktraceur: have no idea how to do that … [22:09:00] we have run into issues when the glam has a slow server and large ~ 10mb images [22:09:37] took about 5-6 minutes for those 369 images for those images [22:10:20] marktraceur: would you be able to allow me to import templates into http://commons.wikimedia.beta.wmflabs.org/ [22:10:28] the photograph template isn't up there [22:12:26] I don't know [22:12:32] chrismcmahon: Can you help? ^^ [22:13:28] Ugh, 76 assertions for the logging tests. I should split these. [22:13:40] dan-nl marktraceur if it's a matter of permissions to import templates, sure, let me know your user name on commons [22:13:57] marktraceur: that is a big-ass test indeed [22:14:22] chrismcmahon: it's dan-nl [22:14:44] chrismcmahon: just need it for the beta cluster [22:16:37] dan-nl: you now have rights for 'importer' and 'transwiki importer' on http://commons.wikimedia.beta.wmflabs.org. let me know if you need more than that. [22:16:51] thanks chris! [22:16:55] Ass-test. [22:17:34] Is there a ganglia instance for beta? (wondering about answering marktraceur's question about performance impact of gwtoolset) [22:17:40] I dunno [22:17:50] * marktraceur doesn't run beta [22:18:36] bd808 marktraceur is http://ganglia.wmflabs.org/latest/ what you're after? [22:19:02] chrismcmahon: Yes. I'll bookmark that. Thanks [22:37:04] bd808: fyi david was running that test around 22:05 cet [22:39:07] bd808: i'm guessing this is the page to look at? http://ganglia.wmflabs.org/latest/?c=deployment-prep&m=load_one&r=hour&s=by%20name&hc=4&mc=2 [22:39:53] dan-nl: The jobrunner node specifically I think: http://ganglia.wmflabs.org/latest/?r=hour&cs=&ce=&c=deployment-prep&h=deployment-jobrunner08&tab=m&vn=&mc=2&z=small&metric_group=ALLGROUPS [22:40:42] would it be that blue user peak? [22:42:51] The memory looks like it jumped up but it doesn't look horrible vs historical trends: http://ganglia.wmflabs.org/latest/graph_all_periods.php?h=deployment-jobrunner08&m=load_one&r=week&s=by%20name&hc=4&mc=2&st=1386628899&g=mem_report&z=large&c=deployment-prep [22:43:31] k, david had an issue with downloading large map images ~ 10mb [22:43:39] the server came back with a 503 [22:44:34] Don't all the image downloads happen in the job queue? [22:45:53] bd808 yes, but the first 3 are part of the previw [22:47:01] Ok. I remember that now [22:49:03] There are a lot of log messages like: "The media file URL could not be evaluated. The URL delivers the content in a way that is not yet handled by this extension." [22:50:19] "a lot" being ~1000 [22:52:34] bd808: oh my, really? [22:52:57] i think that might have to do with the domain whitelist [22:53:10] (03PS3) 10MarkTraceur: Add performance logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99786 [22:53:15] Tests! All the tests. [22:53:20] not 100% sure … david was trying to upload a set that wasn't white listed [22:53:22] 28 + 48 tests. [22:53:50] (03CR) 10jenkins-bot: [V: 04-1] Add performance logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99786 (owner: 10MarkTraceur) [22:53:51] dan-nl: could you add that to https://bugzilla.wikimedia.org/show_bug.cgi?id=57249 those 503s are getting super annoying, they've been happening for a couple of weeks, and not only on beta labs [22:53:58] Bah humbug [22:54:18] bah Varnish [22:55:07] (03PS4) 10MarkTraceur: Add performance logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99786 [22:55:09] dan-nl: You can look with `grep 'could not be evaluated' /data/project/logs/runJobs.log` on deployment-bastion [22:55:19] <3 tests [22:55:40] bd808: k, i'll try and coordinate with david tomorrow [22:56:15] The error messages have more data including URLs [22:58:01] yes [22:58:39] we have found that some urls are outdated and have issues but 1000 + is very odd. i'm hoping it just has to do with the whitelist [23:01:04] chrismcmahon: added the message david got when he tried the upload [23:02:17] dan-nl: thanks, these strange 503s from Varnish started about 3 weeks ago on a number of wikis and no one is exactly sure why. :-( [23:02:51] ah, that sucks [23:03:15] if we can provide more input tomorrow we will