[18:25:59] 8 [18:30:16] fabriceflorin: btw, you might be interested in this conversation on commons - https://commons.wikimedia.org/wiki/Commons:VP#Identify_video_data (Basically a bunch of people talking/complaining about the usability of video embedding) [18:31:22] "btw"? Like, related to him saying "8"? [18:31:44] Thanks, bawolff -- that's very timely, as I am now writing a draft for the Video RfC, to ask for community comments on our options regarding MPEG-4 video formats. [18:32:21] Sorry about my laconic '8' comment. As poetic as it might seem, it was merely a typo :) [18:32:47] 8's a good number. Power of 2, and all that. [18:37:34] That's the power of love, or at least so says Huey. [18:40:34] Actually, I still harbor the superstition that '8' is my magic number, and use it often in my daily life. I know it sounds crazy, but any multiple of 8 seems to bring me good luck. [18:41:01] Of course, the 'rational' part of me frowns at this idea all the time :) [18:44:51] 8 is also rational, though [18:44:59] lol [18:49:29] Yeah, there is no denying that '8' is a very unique number from a mathematical perspective -- even if you set aside my own emotional attachment to it :) [18:49:51] Meanwhile, I have posted an update to the Village Pump post you pointed us to. Thanks for passing it on :) [21:04:04] hey marktraceur - are we pushing out the fix for multimedia/VE interaction before next week? [21:04:11] s/multimedia/media viewer/ [21:18:27] Eloquence: It should be pushed? [21:19:55] hmm, lemme ensure cache's clear and try again [21:21:41] nope, still borked [21:21:57] marktraceur, if I open https://en.wikipedia.org/w/index.php?title=John_Wilson_McConnell and press cursor-right, media viewer opens [21:22:07] (provided it's beta-feature-enabled) [21:22:21] ...hrm [21:22:41] I wonder if mw.org is working [21:22:53] I'm pretty sure wmf6 had it fixed, I tested on mw.org when I backported [21:23:15] Huh, mw.org doesn't have it fixed. Very odd. [21:23:27] Eloquence: What about debug=true? [21:23:39] Argh, never mind, not working at all. [21:23:42] * marktraceur investigates [21:23:45] Thanks Eloquence [21:24:12] I'm not getting the bug in wmf7 (mw.org) [21:24:16] just wmf6 (wp) [21:24:45] Oh? [21:24:49] I was getting it on mw.org [21:25:03] I think this is actually a separate bug from the initial one [21:25:35] The "on( 'keydown'" call needs to come later in the interface code [21:25:41] Before it was that the event handler was never cleared [21:25:48] * marktraceur will write patch and maybe backport today [21:26:26] marktraceur, does not trigger for me on https://www.mediawiki.org/wiki/Gadget_kitchen?veaction=edit when pressing cursor-right [21:27:05] Hm. [21:27:33] It triggered on https://www.mediawiki.org/wiki/Category:Files_with_unknown_copyright_status?debug=true for me [21:28:53] yeah, same here [21:30:46] It may be that that's an even more different bug. [21:31:08] Luckily that's fixed with the commit I'm about to upload [21:31:36] (03PS1) 10MarkTraceur: Fix another event handler bug [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/101107 [21:34:42] I wonder if it's actually the same bug, but load times affect it somehow? [21:34:59] Or position or something [21:35:16] I can try backporting the above fix and seeing what happens [21:36:02] aarcos: Looking at https://gerrit.wikimedia.org/r/101107 so we could maybe get it out today would be awesome [22:37:24] (03CR) 10Aarcos: Fix another event handler bug (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/101107 (owner: 10MarkTraceur) [22:55:37] hey bd808 i think i've covered all of chris' concerns. hopefully he'll get a chance to review by the end of the day and there won't be anything else for me to change. if that's the case and you're able to merge, i'll run another test on beta to see how it plays out. if that works out well we should be ready for tuesday unless you can think of anything else [22:56:28] dan-nl: Have you written (or seen where someone else has written) a patch that introduces the production config? [22:56:43] That's the only other thing I've thought of that needs to be done [22:57:38] no, but i did start some work based on the conversations with aaron https://gerrit.wikimedia.org/r/#/c/101058/ and https://gerrit.wikimedia.org/r/#/c/101061/ [22:57:53] are those what you mean or is there something else? [23:06:03] thanks for your help today bd808 i'm off to bed .... [23:07:08] dan-nl: Good night. I think those patches are exactly what I was thinking we needed still. [23:07:41] (03PS2) 10MarkTraceur: Fix another event handler bug [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/101107 [23:07:48] Jenkins will maybe -1 that. [23:08:01] * marktraceur waits [23:08:10] (03CR) 10jenkins-bot: [V: 04-1] Fix another event handler bug [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/101107 (owner: 10MarkTraceur) [23:08:14] Figures [23:08:59] (03PS3) 10MarkTraceur: Fix another event handler bug [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/101107 [23:09:00] Useless test anyway [23:09:23] Instead I should probably check that addHandler and clearEvents are working sanely [23:15:18] (03PS4) 10MarkTraceur: Fix another event handler bug [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/101107 [23:15:20] Even more better [23:16:00] aarcos: If you can TAL, maybe we can still get it in *fingers crossed* [23:18:26] greg-g says that there's room in the LD [23:27:31] (03PS5) 10MarkTraceur: Fix another event handler bug [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/101107 [23:27:40] (03CR) 10Aarcos: Fix another event handler bug (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/101107 (owner: 10MarkTraceur) [23:30:07] (03CR) 10Aarcos: [C: 031] Fix another event handler bug [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/101107 (owner: 10MarkTraceur) [23:30:15] (03PS6) 10MarkTraceur: Fix another event handler bug [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/101107 [23:37:30] (03CR) 10MarkTraceur: [C: 032] Fix another event handler bug [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/101107 (owner: 10MarkTraceur) [23:38:12] (03Merged) 10jenkins-bot: Fix another event handler bug [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/101107 (owner: 10MarkTraceur) [23:51:15] (03PS1) 10MarkTraceur: Fix another event handler bug [extensions/MultimediaViewer] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101142 [23:51:39] (03CR) 10MarkTraceur: [C: 032] "Charge forward!!!!" [extensions/MultimediaViewer] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101142 (owner: 10MarkTraceur) [23:52:12] (03Merged) 10jenkins-bot: Fix another event handler bug [extensions/MultimediaViewer] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101142 (owner: 10MarkTraceur) [23:56:43] (03PS1) 10MarkTraceur: Fix another event handler bug [extensions/MultimediaViewer] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101144 [23:57:12] (03CR) 10MarkTraceur: [C: 032] "RAAAAAWR" [extensions/MultimediaViewer] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101144 (owner: 10MarkTraceur)