[00:09:49] oh :/ [07:10:08] (03PS1) 10Apsdehal: Added 'Learn More' message [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102631 [09:51:56] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102631 (owner: 10Apsdehal) [11:07:00] (03CR) 10Aklapper: "Superseded by https://gerrit.wikimedia.org/r/#/c/102631/" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99359 (owner: 10Durga94) [11:25:49] (03Abandoned) 10Siebrand: Added a local only message to the MultimediaViewer.i18n.php file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99359 (owner: 10Durga94) [15:29:37] (03CR) 10MarkTraceur: [C: 04-1] "Patch 102553 has some changes that you should rebase on top of - sorry to make things complicated." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102631 (owner: 10Apsdehal) [16:28:22] marktraceur: shouldn't grrrit-wm track uploadwizard changes? [16:28:30] It does, in -dev [16:28:49] There are too many people not on our team who work on it that I didn't want to drag the messages in here [16:46:03] marktraceur: shouldn't they show up in both channels then? [16:46:28] i would expect the multimedia channel to tell about all multimedia-related changes [17:03:52] tgr: Sure, we can do that. [17:21:08] (03CR) 10MarkTraceur: "(ignore this message)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty) [17:21:10] tgr: ^^ [17:21:28] thanks! [17:21:45] Yarp [17:22:06] I'll just merge it and make sure it's deployed [17:25:03] And done. [18:00:37] tgr: comming? [20:13:45] bd808, should i now add marktraceur and tgr to all commits i make for gwtoolset instead of you? [20:15:01] dan-nl: That would be swell :) [20:15:16] k, np :) [20:15:46] I'm watching the repo so I'll get pinged for changes anyway, but I don't know if I'll have time to review them all [20:16:12] By the way, do you have a gerrit watch setup for it? [20:16:34] probably not … how do i do that? [20:17:04] Click your user name in the upper right and select "settings" [20:17:31] Then there will be a "Watched Projects" link on the left side of the page [20:17:59] Type "mediawiki/extensions/GWToolset" into the Project Name field and click "Watch" [20:18:03] thanks, got it [20:19:50] I usually have it email for new patch sets on things I watch. Then I get pinged with an email when a new change comes in or an existing one is updated even if I'm not on the changeset as a reviewer. [20:20:27] It can be a little spammy at times. Just watching for new changes might be enough [20:21:18] thanks, i'll see how much comes in and adjust as necessary … [21:14:19] (03PS2) 10Cmcmahon: Smoke tests for Upload Wizard using the API. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 (owner: 10Aarcos) [21:42:36] (03CR) 10MarkTraceur: "Thoughts" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102595 (owner: 10Theopolisme) [22:00:32] (03PS2) 10Theopolisme: Include license in title attribute of link in FileUsageDialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102595 [22:01:09] (03CR) 10Theopolisme: Include license in title attribute of link in FileUsageDialog (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102595 (owner: 10Theopolisme) [23:07:54] wow, thanks for the compliments guys … [23:08:06] off to bed, have a good day/night