[02:38:57] <grrrit-wm>	 (03PS1) 10Aarcos: Add smoke test to LicenseInput class and needed testing hooks. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103518 
[02:43:18] <grrrit-wm>	 (03PS2) 10Aarcos: Add smoke test to LicenseInput class and needed testing hooks. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103518 
[02:46:09] <grrrit-wm>	 (03PS3) 10Aarcos: Add smoke test to LicenseInput class and needed testing hooks. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103518 
[08:39:25] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 04-1] "See inline comments." (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 (owner: 10Theopolisme)
[11:36:45] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Nitpicks." (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103518 (owner: 10Aarcos)
[13:01:04] <grrrit-wm>	 (03PS2) 10Gergő Tisza: Handle multiple Flickr uploads with identical title [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 
[13:03:31] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Added tests." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 (owner: 10Gergő Tisza)
[13:03:36] <grrrit-wm>	 (03CR) 10Gergő Tisza: Handle multiple Flickr uploads with identical title (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 (owner: 10Gergő Tisza)
[14:23:03] <grrrit-wm>	 (03PS1) 10M4tx: Add "Test images" category to "upload-wizard_tests.py" script [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103552 
[16:05:36] <dan-nl>	 hey bd808, do you think we could close https://bugzilla.wikimedia.org/show_bug.cgi?id=56186 or is there something else i need to add?
[16:06:59] <bd808>	 dan-nl: I think it's reasonable to close it.
[16:07:27] <dan-nl>	 cool, does it matter who closes it?
[16:07:39] <bd808>	 Nope. Go for it.
[16:10:50] <grrrit-wm>	 (03CR) 10Theopolisme: Allow category prefix when entering categories (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 (owner: 10Theopolisme)
[16:11:46] <dan-nl>	 thanks
[17:50:12] <grrrit-wm>	 (03PS4) 10Aarcos: Add smoke test to LicenseInput class and needed testing hooks. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103518 
[17:55:43] <mayankmadan_>	 hi aarcos
[17:56:09] <aarcos>	 mayankmadan_: Yeap !, who is this?
[17:56:20] <mayankmadan_>	 aarcos, im a gci student
[17:56:22] <mayankmadan_>	 http://www.google-melange.com/gci/task/view/google/gci2013/5805605944033280
[17:56:26] <mayankmadan_>	 i wanted to this task
[17:56:27] <mayankmadan_>	 aarc
[17:56:30] <mayankmadan_>	 aarcos, ^^
[17:57:47] <mayankmadan_>	 aarcos, do i need to make a random image
[17:57:53] <mayankmadan_>	 with random title?
[17:58:32] <aarcos>	 mayankmadan_: yeap !, the I was thinking on using the unix time as title and string in the image.
[17:58:57] <mayankmadan_>	 okay
[18:00:00] <aarcos>	 mayankmadan_: You should start with the easy task first, then this one will make more sense...
[18:00:40] <mayankmadan_>	 aarcos, m4tx has already added a comment on the easy task
[18:01:51] <aarcos>	 mayankmadan_: ok, then feel free to tackle this one, ;-).
[18:01:56] <mayankmadan_>	 aarcos, can i import image module?
[18:04:32] <aarcos>	 mayankmadan_: Sure !
[18:05:17] <mayankmadan_>	 aarcos, do i clone the mediawiki uploadwizard repository or download the uploadwizard extension?
[18:06:29] <aarcos>	 mayankmadan_: cloning is the easiest, you don't need the extension to run the script.
[18:27:07] <mayankmadan_>	 aarcos, what font should i chose?
[18:27:17] <mayankmadan_>	 arial?
[18:29:05] <aarcos>	 mayankmadan_: your choice, doesn't really matter, also, try to keep the image small, it is a test and we don't want to upload big images.
[18:29:37] <mayankmadan_>	 aarcos, 640*480?
[18:30:24] <aarcos>	 mayankmadan_: too big, just big enough to contain the text you are going to generate.
[18:30:32] <mayankmadan_>	 ok
[18:38:41] <grrrit-wm>	 (03CR) 10Aarcos: [C: 031] Add "Test images" category to "upload-wizard_tests.py" script [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103552 (owner: 10M4tx)
[18:43:16] <grrrit-wm>	 (03CR) 10Jhall: [C: 032] "Looks great!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103552 (owner: 10M4tx)
[18:43:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add "Test images" category to "upload-wizard_tests.py" script [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103552 (owner: 10M4tx)
[18:44:12] <mayankmadan_>	 aarcos, online?
[18:48:39] <mayankmadan_>	 aarcos, im trying to use a font using ImageFont but im getting this error https://dpaste.de/VmeH
[18:49:02] <mayankmadan_>	 aarcos, i have made a seperate file to test in a seperate directory
[18:49:07] <mayankmadan_>	 i have placed the font there
[18:53:50] <aarcos>	 mayankmadan_: I would say, solving this problem is part of the task, ;-).
[18:53:56] <mayankmadan_>	 aarcos, i got it
[18:54:05] <mayankmadan_>	 aarcos, i have to escape the \
[18:54:22] <mayankmadan_>	 no i didnt got it :)
[18:55:26] <aarcos>	 mayankmadan_: I can help with specification questions but the rest is up to you to figure it out. Still, feel free to ask, ;-).
[18:55:47] <mayankmadan_>	 oka
[18:55:49] <mayankmadan_>	 *okay
[18:56:56] <mayankmadan_>	 aarcos, it worked
[18:56:58] <mayankmadan_>	 oh yeah
[18:57:46] <mayankmadan_>	 im sorry if im not behaving well :) i was just a little exited
[19:01:21] <mayankmadan_>	 aarcos, the image is showing perfectly
[19:01:29] <mayankmadan_>	 aarcos, i have set the size to 400*100
[19:01:32] <mayankmadan_>	 is that ok?
[19:02:05] <mayankmadan_>	 aarcos, and what should be the new image be called?
[19:02:13] <tgr>	 aarcos: ping
[19:02:19] <aarcos>	 Kind of big, I was thinking 100*25, 
[19:03:14] <mayankmadan_>	 aarcos, but the timestamp doesnt fit in that
[19:03:40] <mayankmadan_>	 aarcos, ill just reduce the font size
[19:05:09] <mayankmadan_>	 aarcos, but what should be the name of the image that is saved?
[19:10:01] <aarcos>	 mayankmadan_: That's a good question? What name do you think it should have?
[19:10:58] <mayankmadan_>	 aarcos, currenttimestamp.png
[19:11:12] <mayankmadan_>	 aarcos, can i copy the arial.ttf font in the repository?
[19:13:58] <aarcos>	 mayankmadan_: I will prepend some name to the timestamp but that's the idea. Regarding the font, I would just use the default, something that doesn't create another dependency. Not sure if possible but less is better, ;-).
[19:16:21] <mayankmadan_>	 aarcos, i have used the default font but it doesnt look very good :)
[19:16:46] <mayankmadan_>	 aarcos, and should the test create a new image with a unique name(using timestamp) every time it is run?
[19:17:28] <mayankmadan_>	 aarcos, and is this task being considered as a complex task?
[19:18:21] <aarcos>	 mayankmadan_: It doesn't matter, this is test image, ;-). Yes, new name should be created on every run. This should only happen if the user specifies the flag "--gen_new_image".
[19:19:17] <aarcos>	 mayankmadan_: I wouldn't call this complex, just medium effort.
[19:19:41] <mayankmadan_>	 aarcos, so its not considered as easy
[19:19:51] <aarcos>	 mayankmadan_: nope
[19:19:54] <mayankmadan_>	 good
[19:20:42] <mayankmadan_>	 aarcos, i know i shouldnt ask this but is there an example where the file checks which flag is being used so i could get a bit of idea on how it works?
[19:20:43] <aarcos>	 mayankmadan_: Also, make sure you test your code against a running API instance and user name. 
[19:21:53] <aarcos>	 mayankmadan_: Everything is in the code and in the internet, ;-).
[19:23:33] <mayankmadan_>	 aarcos, the test cant import wikitools
[19:29:08] <mayankmadan_>	 aarcos, i cant run the test
[19:29:18] <mayankmadan_>	 it says no module named wikitools
[19:35:04] <aarcos>	 mayankmadan_: Yeap !, you have to import that, ;-).
[19:35:26] <mayankmadan_>	 aarcos, i didnt mess with it
[19:35:33] <mayankmadan_>	 aarcos, it was there before too
[19:35:38] <mayankmadan_>	 why is it not working now?
[19:36:55] <aarcos>	 mayankmadan_: no idea? Rollback your changes and see if it still works. Maybe you introduced the problem.
[19:37:14] <mayankmadan_>	 aarcos, i havent changed anything in the file yet
[19:37:28] <mayankmadan_>	 aarcos, i tried everything in a seperate file outside the repo
[19:54:33] <grrrit-wm>	 (03CR) 10Aarcos: [C: 031] "One comment needs rewording but otherwise this looks good to me. I am giving you a +1, you can merge once the comment is fixed." (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 (owner: 10Gergő Tisza)
[20:02:38] <mayankmadan_>	 aarcos, shouldnt this have worked parser.add_argument("--gen_new_image", help="Create a new image with current timestamp", action="store_true")
[20:03:53] <mayankmadan_>	 aarcos, and why is verbose of type int?
[20:04:02] <mayankmadan_>	 isnt it supposed to be just true and false
[20:04:11] <mayankmadan_>	 *true or false
[20:05:39] <mayankmadan_>	 aarcos, online?
[20:05:40] <aarcos>	 mayankmadan_: The TestRunner has different levels of verbosity, you can say -v 2, -v 3, and more input will appear. 
[20:05:50] <mayankmadan_>	 ok
[20:06:02] <mayankmadan_>	 but the --gen_new_image flag?
[20:06:10] <aarcos>	 mayankmadan_: s/input/output
[20:06:20] <mayankmadan_>	 aarcos, what is that?
[20:06:40] <mayankmadan_>	 s/input/output?
[20:06:54] <aarcos>	 mayankmadan_: I meant to say output, instead of input. This is the 'vi' of saying that, ;-).
[20:07:42] <mayankmadan_>	 aarcos, but what about the --gen_new_image flag?
[20:07:47] <mayankmadan_>	 should it have worked?
[20:07:57] <mayankmadan_>	 with this parser.add_argument("--gen_new_image", help="Create a new image with current timestamp", action="store_true")
[20:08:33] <mayankmadan_>	 aarcos, and this task should have been in code category(not in user interface) :)
[20:10:04] <aarcos>	 mayankmadan_: About the flag, part of the task to see how to plug this into the test.
[20:10:30] <mayankmadan_>	 aarcos, the documentation says this is the way but it isnt working when i try it here
[20:11:22] <mayankmadan_>	 aarcos, and should i use CamelCase or snake_case for variables?
[20:11:35] <mayankmadan_>	 nevermind
[20:11:40] <mayankmadan_>	 snakecase it is
[20:11:58] <mayankmadan_>	 but the documentation says parser.add_argument("--gen_new_image", help="Create a new image with current timestamp", action="store_true")
[20:12:03] <mayankmadan_>	 is the way of doing it
[20:14:28] <aarcos>	 mayankmadan_: Everything is in the code, the idea if these tasks is for you to explore and learn not for me to tell you how to do them. Specification questions, sure no problem, implementation questions, all those are for you. Details about the implementation are addressed on the code review.
[20:14:54] <mayankmadan_>	 okay
[20:15:10] <mayankmadan_>	 aarcos, but this task should have been in the code category(not in user interface) :)
[20:19:54] <mayankmadan_>	 aarcos, why is file uploaded to the stash area?
[20:20:40] <mayankmadan_>	 this is a valid question :)
[20:22:57] <aarcos>	 mayankmadan_: The upload wizard uploads first to the stash area and then asks the user for more info about the image (license, title, labels, etc) and validates this data. Only then the file is move from the stash are to main using another upload api call. So, this test is simulating what the upload wizard UI does.
[20:27:09] <mayankmadan_>	 aarcos, it worked
[20:27:42] <mayankmadan_>	 aarcos, but still i have a question
[20:28:06] <mayankmadan_>	 aarcos, if --gen_new_image flag is used, then other tests shouldnt run, right?
[20:28:57] <grrrit-wm>	 (03PS3) 10Gergő Tisza: Handle multiple Flickr uploads with identical title [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 
[20:31:43] <aarcos>	 mayankmadan_ : if the flag is present you have to change the behavior of testUploadImageUsingWizardWorkflow so it uploads a new image with new title, otherwise it just does what is doing right now, makes sense?
[20:32:31] <mayankmadan_>	 aarcos, so it should abandon the old image if gen_new_image is present?
[20:35:03] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Clarified jsdoc for reserveFileName()." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 (owner: 10Gergő Tisza)
[20:35:13] <aarcos>	 mayankmadan_: This is just a mode flag. No flag, test runs as it is running now, upload the same image with same name once again. With the flag, the same test is run but in this case a new image with a new name is generated and uploaded.
[20:35:24] <mayankmadan_>	 okay
[20:35:47] <mayankmadan_>	 aarcos, how much time does the test usually takes to run?
[20:36:08] <aarcos>	 mayankmadan_: ~5sec
[20:36:22] <mayankmadan_>	 aarcos, the whole test?
[20:36:28] <mayankmadan_>	 from beginning?
[20:36:33] <aarcos>	 mayankmadan_: Yeap !
[20:36:37] <mayankmadan_>	 oh dear
[20:37:23] <aarcos>	 mayankmadan_: You should run it and try in on your own.
[20:42:14] <grrrit-wm>	 (03CR) 10Aarcos: [C: 031] "A wording suggestion but otherwise LGTM." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 (owner: 10Gergő Tisza)
[20:57:18] <mayankmadan_>	 aarcos, can you tell me why 53390 there in  55390test-image-rosa-mx-15x15.png
[20:57:46] <mayankmadan_>	 its in filename": "55390test-image-rosa-mx-15x15.png"
[20:57:53] <mayankmadan_>	 while uploading img to stash
[20:57:56] <mayankmadan_>	 aarcos, ^
[20:59:52] <aarcos>	 mayankmadan_: The API needs a name and that's the one I chose, the UI does something similar. For the use case you are implementing you can put there the unique name of the file you are generating.
[21:45:55] <grrrit-wm>	 (03PS1) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 
[21:45:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan)
[21:58:30] <grrrit-wm>	 (03PS2) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 
[21:58:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan)
[21:59:55] <grrrit-wm>	 (03PS2) 10Theopolisme: Allow category prefix when entering categories [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 
[22:01:00] <grrrit-wm>	 (03CR) 10Theopolisme: "mw.Title is very cool; thanks for that, Brian! Learn something new every day :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 (owner: 10Theopolisme)
[22:04:41] <grrrit-wm>	 (03PS3) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 
[22:40:13] <grrrit-wm>	 (03CR) 10Jhall: [C: 04-1] "Looks good overall, but a couple of things could be improved:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan)
[22:41:41] <grrrit-wm>	 (03CR) 10Aarcos: [C: 04-1] Functionality to create a new image in upload-wizard_tests.py (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan)
[23:59:28] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Add smoke test to LicenseInput class and needed testing hooks. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103518 (owner: 10Aarcos)
[23:59:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add smoke test to LicenseInput class and needed testing hooks. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103518 (owner: 10Aarcos)