[00:09:20] (03PS1) 10MarkTraceur: Make sure the post-image div is always the same height [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104694 [00:09:23] Weirder [00:19:17] Argh, the double-request thing is happening still? Damn it. I should prioritize that. [00:19:48] (03PS1) 10MarkTraceur: Animate the metadata div to show the user it's there [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104696 [00:19:49] Wierdest [00:19:56] Weirdest even [00:24:50] (03CR) 10Gergő Tisza: [C: 032] Replacing 'show on map' button with a link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty) [00:25:02] (03Merged) 10jenkins-bot: Replacing 'show on map' button with a link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty) [08:56:00] (03PS1) 10Pginer: Updated icons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104715 [09:23:19] (03PS2) 10Pginer: Updated icons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104715 [15:55:24] https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/MultimediaViewer+status:open,n,z whoopdee doo, more patches to review [15:55:48] I've got pginer's and I'll probably look through apsdehal's too [15:56:03] pginer: Did you see the -1 on your first style patch? [15:56:19] Yes [15:56:34] 'kay [15:57:13] For added fun, it will probably now conflict with other changes. WOOOO [15:57:21] (I dunno, I find that hilariously fun) [15:59:35] thanks for the review. I think I'll discard it and produce smaller changes on top of updated code. [16:00:30] Merging and rebasing is too much for me. [16:01:18] (Especially when Git and Gerrit start to complain about things I don't understand) [16:04:58] pginer: I can rebase it, if you want [16:05:08] Once my review on your new patch is done you can focus on that [16:06:14] ok [16:07:56] (03CR) 10Gergő Tisza: "This seems to work for me, apart from the tests. The tests should be async; when an event is triggered, the handler is put to the end of t" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104133 (owner: 10MarkTraceur) [16:11:26] (03CR) 10Gergő Tisza: [C: 032] Make sure the post-image div is always the same height [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104694 (owner: 10MarkTraceur) [16:16:45] (03CR) 10Gergő Tisza: "I am not convinced this conveys to the user what it is supposed to convey. Also, doing this on every load (including paging) seems a bit a" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104696 (owner: 10MarkTraceur) [16:26:39] (03CR) 10Gergő Tisza: [C: 04-1] "Very wides images are positioned above the scrollbar now (Chrome 31)." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104689 (owner: 10MarkTraceur) [16:41:33] Agh, damn, I remember now [17:13:04] (03CR) 10MarkTraceur: [C: 04-1] "-1 for CSS, comments inline" (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104715 (owner: 10Pginer) [17:14:03] (03PS5) 10MarkTraceur: Styling adjustments on the bottom panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100362 (owner: 10Pginer) [17:14:12] pginer: Turns out it was a trivial rebase [17:14:30] But the review comments still apply [17:16:11] I've seen your comments on the icon one [17:16:32] Yeah, both of them have comments now [17:16:34] The "center center" -> "centre" is clear [17:16:49] but the "This can be abstracted to another ruleset with all three of the buttons' hover state, also", is not clear for me. [17:17:16] Each arrow has a different property: margin-left vs. margin-right [17:17:31] pginer: If you have rules that are common to three different elements, you may as well write a new ruleset ".element1, .element2, .element3 {" and put the rules in there [17:17:45] The margin is different, but the opacity is the same [17:18:26] ok, so instead of 2 rulesets, they will be three? one for the opacity of all the elements, and specific ones for the arrow positions? [17:21:07] Right [17:21:10] There was another set of common things that you should also separate [17:21:23] pginer: The idea is, we want to minimize the places we have to change things later [17:21:37] So we don't need to look really hard to make sure we got everything [17:21:49] Later on we'll accomplish this much more easily with less, but I'm not there yet [17:49:53] (03PS3) 10Pginer: Updated icons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104715 [17:52:57] Ooh, I'm super excited now [17:53:03] These icons look seeeeeeexyyyyy [17:53:12] tgr: I think it's just us today, want to do IRC or? [17:53:20] sure [17:58:04] (03PS4) 10MarkTraceur: Updated icons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104715 (owner: 10Pginer) [17:58:10] (03CR) 10Gergő Tisza: "I'll add nicer assertions in the next patchset." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100569 (owner: 10Gergő Tisza) [17:58:34] (03CR) 10MarkTraceur: [C: 032] "I cleaned it up a liiiiittle bit, but nothing too complex, just consistency with other design reviews. Thanks Pau!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104715 (owner: 10Pginer) [17:59:47] (03Merged) 10jenkins-bot: Updated icons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104715 (owner: 10Pginer) [18:00:35] Them's some sexy icons [18:00:37] Just saying [18:01:12] tgr: Right, what you doin' [18:01:46] bunch of code reviews [18:02:07] plus updating CMD based on the code reviews I got [18:02:37] tgr: That basically what you were doing yesterday? [18:03:06] partially, yeah [18:03:24] * marktraceur wonders what else [18:03:55] I spent some time trying to debug the resize tests for MMV [18:05:01] also, I have a half-finished fix for balcklisting in UploadWizard which has been dragging on for some time, I'm still working on that [18:05:14] 'kay [18:05:59] Yesterday, I did a bunch of cool work on the design [18:06:04] I'm pretty happy with how it went [18:07:00] Today I'm reviewing pginer's patches, with an eye to merging them (one done already!), and probably some rebasing and ... um ... probably making the prev/next click areas bigger [18:07:15] Maybe working on fullscreen if theopolisme gets something done [18:08:57] any blockers? particularly review-related? [18:11:15] Uh [18:11:27] Not really, tgr; there are still MMV patches open but I'm not rushing to get them in I think [18:12:11] tgr: https://gerrit.wikimedia.org/r/104689 and its dependents are important for next week's release, but it's not important for my work [18:13:18] ok [18:18:01] And you? I think I saw the DOM navigator patch is updated [18:33:22] marktraceur: the ball is still on my side on that one [18:33:44] there are some UW patches you could look at, if you have time [18:34:31] Interesting, maybe I will [18:36:14] also, there is https://gerrit.wikimedia.org/r/#/c/97919/ which still needs polishing, i'm just waiting input on whether it is a good idea in the first place [18:47:28] (03CR) 10MarkTraceur: [C: 032] Change id to add mwe-upwiz prefix and match casing style [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/95594 (owner: 10Mattflaschen) [18:47:44] (03Merged) 10jenkins-bot: Change id to add mwe-upwiz prefix and match casing style [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/95594 (owner: 10Mattflaschen) [18:47:48] tgr: Most of the UW patches I see are either already reviewed, mine, or Flickr ones [18:51:14] ah, missed the license redirect review [18:51:29] it is annoying when the changeset is owned by somebody else [18:51:52] who can review Flickr-related changes? [18:53:42] can you look at this one? it's super simple, it was just an annoyance when testing [18:53:45] https://gerrit.wikimedia.org/r/#/c/103323/ [18:54:49] (03PS2) 10MarkTraceur: Focus to Flickr URL input field after "upload from Flickr" is clicked [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103323 (owner: 10Gergő Tisza) [18:55:15] (03CR) 10MarkTraceur: [C: 032] "Not tested, but the worst thing that can happen is focusing on the wrong thing, which is at least no worse than now." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103323 (owner: 10Gergő Tisza) [18:55:46] (03Merged) 10jenkins-bot: Focus to Flickr URL input field after "upload from Flickr" is clicked [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103323 (owner: 10Gergő Tisza) [18:56:51] thx [18:56:57] yuuup [18:58:17] (03PS3) 10MarkTraceur: Allow category prefix when entering categories [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 (owner: 10Theopolisme) [18:58:41] (03CR) 10MarkTraceur: [C: 032] "Sure! Thanks so much Theo, you're doing great work here." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 (owner: 10Theopolisme) [18:58:52] (03Merged) 10jenkins-bot: Allow category prefix when entering categories [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 (owner: 10Theopolisme) [19:07:20] (03PS6) 10Gergő Tisza: Rewrite template parsing with DOMDocument [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100569 [19:08:22] (03CR) 10Gergő Tisza: "Nicer looking assertions, fix a bug in closest(), add larger description pages for performance testing" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100569 (owner: 10Gergő Tisza) [19:09:07] (03CR) 10Gergő Tisza: Rewrite template parsing with DOMDocument (037 comments) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100569 (owner: 10Gergő Tisza) [19:15:40] (03PS7) 10Gergő Tisza: Rewrite template parsing with DOMDocument [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100569 [19:16:02] (03CR) 10Gergő Tisza: "Fixed lots of tiny spacing issues." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100569 (owner: 10Gergő Tisza) [19:17:20] (03CR) 10MarkTraceur: [C: 04-1] "The phpunit coder in me screams "assert.elementExists", but I don't think we do that in qunit as much." (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103624 (owner: 10Aarcos) [19:23:22] tgr: Let me know if you have more UW things to review, I'll probably spend the rest of today hunting for things to do [19:27:26] (03CR) 10Gergő Tisza: Rewrite template parsing with DOMDocument (031 comment) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100569 (owner: 10Gergő Tisza) [19:27:53] marktraceur, will do, thanks [19:28:53] if it's not limited to UW, though, I've just fixed up the CMD parser patch [19:29:21] a re-review on that would make me happy :) [19:35:35] 'kay [19:44:18] (03CR) 10MarkTraceur: [C: 032] "Seems good to me! Thanks, tgr." (031 comment) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100569 (owner: 10Gergő Tisza) [19:44:48] (03Merged) 10jenkins-bot: Rewrite template parsing with DOMDocument [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100569 (owner: 10Gergő Tisza) [19:46:25] Woot woot [19:47:23] (03CR) 10MarkTraceur: "PS5 was just a rebase - my comments on PS4 still apply" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100362 (owner: 10Pginer) [19:47:32] (03CR) 10MarkTraceur: [C: 04-1] Styling adjustments on the bottom panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100362 (owner: 10Pginer) [19:52:26] \o/ [19:52:36] thanks [19:55:55] Innnndeed [20:29:46] (03CR) 10Gergő Tisza: licenseInput: Handle redirects for license templates (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22) [20:34:48] (03CR) 10MarkTraceur: "I hereby vow to come back and make prettier SVGs of these." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104715 (owner: 10Pginer) [21:20:22] (03PS1) 10MarkTraceur: Bigger click targets for next and previous [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104768 [21:21:22] Well, those are all the priorities except for fullscreen and metrics [23:37:35] Right, I'm calling it a little early to deal with the new year [23:37:41] I'll probably work late next week [23:37:47] And likely this weekend a bit [23:37:51] * marktraceur waves [23:51:48] bye [23:51:58] happy new year and stuff [23:55:33] (03PS1) 10Mayankmadan: Adding code comments of resulting keys [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/104782