[00:08:23] (03PS9) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [00:09:00] (03CR) 10Gergő Tisza: "Improvements per Anomie's comments." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [09:21:10] (03CR) 10Nemo bis: Adding code comments of resulting keys (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/104782 (owner: 10Mayankmadan) [10:35:35] hi marktraceur [10:35:47] marktraceur, around? [11:51:46] is there a particular way to call the mw.UploadWizardDetails function? [11:59:03] ragesoss_, ^ [11:59:54] tgr, ^ [12:00:26] tgr: is there a particular way to call the mw.UploadWizardDetails function? [14:16:25] mayankmadan_: what do you mean by particular? [14:16:46] it is a constructor so it should be called with new [14:17:07] ok [14:17:48] tgr, what should i use as arguments [14:25:03] tgr, and im getting creating its instance [14:25:25] using anyVar = new mw.UploadWizardDetails() [14:26:27] mayankmadan_: that might be difficult [14:26:35] why do you need it? [14:26:52] tgr, https://bugzilla.wikimedia.org/show_bug.cgi?id=54524 [14:27:00] i found where the message gets undefined [14:27:10] but i want all the other possible messages [14:27:18] so i need to execute it [14:28:18] it is probably easier to debug the actual UploadWizard code then to try and load its pieces by hand [14:28:35] tgr, any hint? [14:28:41] the first argument to UploadWizardDetails is an UploadWizardUpload object [14:29:13] tgr, i cant make an instance [14:29:16] to create that, you will need an UploadWizard object [14:29:38] ok [14:30:00] so its a bit complicated, and you should not need to do that just to check some messages [14:30:33] just load uploadwizard in your browser in debug mode (?debug=1 at the end of the url) [14:30:41] and set some breakpoints [14:31:14] probably Chrome is the best for that, but all browsers have a decent debugger these days [14:33:23] tgr, why is debug=1 needed in the url params? [14:47:57] mayankmadan_: otherwise the JS code is minimized and it is not much fun to debug it that way [14:55:48] tgr, what should i pass as argument while instantiating UploadWizard [15:14:45] around? [15:46:20] tgr, i have created the required 2 for UploadWizardDetails but what arguments beside UploadWizardUpload should i pass to instantiate UploadWizardDetails [16:14:05] tgr, or is there any other easy way to get the messages [17:16:38] (03PS3) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [17:25:04] (03CR) 10Gergő Tisza: "* rebased on top of I97f8be, use flickrblacklist API instead of parsing the blacklist page by hand" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [17:25:54] (03CR) 10Gergő Tisza: "I97f8be also takes care of server-side checks." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [20:20:05] hi marktraceur [20:23:01] mayankmadan: Hi! What's up? [20:23:39] marktraceur, nothin much, was working on this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=54524 [20:24:24] marktraceur, i have found the lines of code which are at fault here but how do i make it return all the possible message keys? [20:24:25] 'kay [20:24:39] Um [20:24:58] I think that bug is an artifact of adding 'mwe-upwiz-' and literal undefined [20:25:08] Oh, yeah [20:25:22] mayankmadan: I don't know what you mean, then [20:25:31] Why do you need all possible message keys? [20:26:02] marktraceur, i need all the possible message keys that those lines can return so i can add it as code comments [20:26:03] https://gerrit.wikimedia.org/r/#/c/104782/1/resources/mw.FormDataTransport.js [20:30:24] marktraceur ^ [20:46:10] marktraceur, i think it will always return undefined as upload.stage doesnt exist [20:46:34] marktraceur, so the message key will always be mwe-upwiz-undefined [21:13:02] marktraceur, around? [21:23:42] marktraceur, around? [21:34:33] mayankmadan: Only sort of [21:34:52] I don't know what the possible values are [21:35:07] marktraceur, can you suggest how to make the function return values? [21:35:17] Um, not really [21:35:29] I don't have time to work through this right now, sorry [21:35:38] marktraceur, no problem