[09:47:52] (03CR) 10Gergő Tisza: Slideshow Functionality (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107023 (owner: 10Apsdehal) [10:24:42] (03CR) 10Gergő Tisza: [C: 031] Refactor to a data model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106846 (owner: 10MarkTraceur) [10:33:34] (03PS1) 10Gergő Tisza: Use JSONP for gender query to avoid cross-domain issues [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107125 [10:51:26] (03CR) 10Gilles: "Is there a plan to break down setImageInfo into smaller functions? I't way too long. The gender-fetching would be a good candidate to brea" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107125 (owner: 10Gergő Tisza) [10:57:26] is clicking or dragging on the chevron supposed to do something? it doesn't seem to at the moment and the change of cursor feels like an invitation to do so [11:01:27] (03CR) 10Gilles: "I've tested this change, but I can't tell what's supposed to change in the MMV when the author of the image sets his/her gender. Is it onl" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107125 (owner: 10Gergő Tisza) [11:09:54] (03CR) 10Gilles: "Answered my own question by looking at the code, russian is one that differenciates." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107125 (owner: 10Gergő Tisza) [11:09:58] (03CR) 10Gergő Tisza: "Translators can use the {{GENDER}} syntax to make the text depend on the gender of the user (how exactly it depends on it is probably diff" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107125 (owner: 10Gergő Tisza) [11:14:02] (03CR) 10Gilles: [C: 031] "Test, it works. I'd +2 if i could." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107125 (owner: 10Gergő Tisza) [11:14:32] (03CR) 10Gilles: "*Tested" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107125 (owner: 10Gergő Tisza) [12:36:02] (03CR) 10Mdale: [C: 032 V: 032] "COPYING file should commit to repo." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/95781 (owner: 10Mdale) [16:11:53] Wikified last week's meeting minutes [16:12:32] I guess I could make a navbox type thing for these [16:12:35] But gah. [16:12:58] For now, https://www.mediawiki.org/wiki/Multimedia/Weekly_meetings [16:58:43] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/68 since the relevant gerrit changeset has been merged, does that mean this card should be "in testing"? [16:59:12] or does "in testing" has another meaning than being seen on beta? [17:01:48] marktraceur: have you collected image load data yet? [17:08:32] marktraceur, tgr: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/98 doesn't this have a bug/gerrit ticket somewhere? [17:10:59] gi11es: Collected yes, visualised no [17:11:09] in what form do you have it? [17:11:22] gi11es: In CSV data generated every day at about midnight UTC [17:11:30] A timeseries more precisely [17:11:38] gi11es: https://bugzilla.wikimedia.org/show_bug.cgi?id=59817 [17:11:40] That can be displayed by limn but I don't have a public limn instance yet [17:11:55] Oh, that should definitely be "in testing" at worst [17:11:58] thanks tgr [17:12:21] gi11es: Re 68, yeah, it should be in testing especially since it's deployed [17:12:37] moving them [17:12:49] Woot woot [17:13:36] apsdehal: Re: the error you were getting, I have seen that locally but am not sure why it happens, in any case it seems "harmless" because the close icon is loaded correctly anyway [17:16:56] is the CSV big? if it's not gigantic it can just be imported into google docs, can't it? [17:17:20] * marktraceur not super excited to do that [17:17:32] gi11es: There's very little reason to do so but yes theoretically it could [17:18:03] well, it would just be nice to have a graph to look at for the meeting [17:18:13] even if the better long-term way of visualizing them is coming soon [17:18:18] I can screenshare my local limn if necessary [17:18:21] Or something [17:18:24] that'd be great [17:18:48] can you put that on the wiki, on a demo page of sort dated today? [17:18:53] *of sorts [17:19:07] Sure [17:19:12] It'll be a screenshot maybe [17:19:16] Not sure what limn can do [17:20:36] same kind of question again, does this have a bugzilla counterpart yet? https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/80 [17:22:50] I don't think so but one sec [17:23:05] gi11es: No, but I think we fixed it too [17:23:11] I could be wrong [17:23:29] the chevron wouldn't do anything when I clicked or dragged it today [17:23:51] I assume this is about that... the mingle story isn't explicit about what is the subject of the drag [17:25:22] Yeah [17:25:58] marktraceur: I think it was because of the definition of background-url for close button, also i corrected it in my patch for slideshow, I don't get to know why .mlb-close was defined in two css files [17:26:55] apsdehal: Because the multilightbox CSS file is overridden by the ext.multimediaViewer one [17:27:00] Everyone forgets about the C [17:29:12] Aaa'aargh I want gallery-formatted output from UploadWizard [17:29:15] * marktraceur files bug later [17:29:49] thats the case since its overwritten and was correctly defined in ext.multimediaviewer, so it loaded correctly while the url in lightbox one was incorrect it used ../img instead of /img [17:29:52] see https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMultimediaViewer/a8a0f4475457655cffa5d0b2eda007ee23a244e0/resources%2Fmultilightbox%2Fmultilightbox.css#L87 [17:30:03] but anyway its harmless [17:30:25] because its overwritten, but still we should correct it [17:32:18] apsdehal: Not necessarily [17:34:10] gi11es: Predictably we're still setting up [17:34:23] However, https://www.mediawiki.org/wiki/Multimedia/Media_Viewer/Metrics [17:34:28] marktraceur: i think then there is no necessity to give background img url in multilightbox.css since it has to be overwritten, and that makes the img folder in the same unnecessary [17:35:55] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/95 [17:41:53] apsdehal: But multilightbox is also its own standalone thing, however neglected [17:41:56] I don't want to break it. [17:44:54] Ok anyways I will fix the thing with my next patch definitely so it doesn't causes any breakdowns in future if it happens [19:36:42] Argh bloody rebase [19:39:08] (03PS14) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [19:40:05] (03CR) 10Gergő Tisza: "Disabled the tests for now, will revisit after bug 59921 is fixed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [19:47:18] (03PS2) 10MarkTraceur: Add caption to the interface in place of description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 [19:47:53] Whew, finally got Krinkle to assent to GPLv2 [19:49:46] All, https://gerrit.wikimedia.org/r/100618 is ready for review again. [19:50:06] Also, what's the "Scrum Way" to deal with requests for code review? Transfer of ownership? [19:52:21] I guess I'll take the location info card [19:52:31] Even though I dread it [19:52:34] No wait. [19:52:51] Yesbutno. [20:28:19] (03CR) 10Alex Monk: "How does that bug block this?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [21:08:56] tgr: Are we close enough to merging the model patch that I could base the location info patch on it? [21:16:04] aarcos, gi11es-away, you don't seem to have claimed any cards in Mingle, I'm wondering if that's supposed to be part of the process or not [21:17:29] tgr: The model patch changes, like, the entirety of setImageInfo, so it'd be useful to know [21:17:38] I'll already need to rebase it on top of the caption patch, sigh [21:35:06] (03CR) 10Gergő Tisza: "We don't have a test Flickr API key for UploadWizard right now (using the same key that's used in production for Commons seems unwise). Th" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [21:38:17] tgr: Thoughts? [21:39:41] marktraceur: i'm +2, just wanted to wait for others since it's a big change [21:39:45] 'kay [21:39:51] guess i should have mentioned that in the comments [21:40:16] I will base it on that then [21:40:19] I don't foresee big issues [21:40:44] (03CR) 10Gergő Tisza: [C: 032] Refactor to a data model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106846 (owner: 10MarkTraceur) [21:40:57] Woot [21:41:08] Even easier [21:41:15] (03Merged) 10jenkins-bot: Refactor to a data model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106846 (owner: 10MarkTraceur) [21:45:30] tgr: Given that I'll be calling mw.msg a few times do you think it makes sense to store the coordinates in string format too? It will turn out like the display on https://commons.wikimedia.org/wiki/File:Death_Valley_exit_SR190_view_Panamint_Butt_flash_flood_2013.jpg but will be localisable. [21:45:42] My instinct is "no" but also it's useful information [21:45:51] Just not super machine-readable [21:46:24] (03PS2) 10Michał Łazowik: Allow to upload WAV files with 32 bit float uncmopressed audio [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/103402 [21:48:50] marktraceur: you mean cache them? [21:48:57] Yeah [21:48:59] Well [21:49:05] I don't know how heavy mw.msg is [21:49:13] tgr: I'd create them in the model constructor [21:49:23] it has some sort of parser to deal with {{}}} stuff, right? [21:49:35] Well, s/them/it/ because it's only one string ultimately per Image [21:49:46] tgr: Yeah, but none of the messages I'll pass them will trigger the parser [21:49:52] Just replacements and number formatting. [21:50:23] I wouldn't bother then [21:51:26] it doesn't really belong to the model anyway [21:52:01] True [21:52:18] Stick it in setImageInfo it is, then [22:28:45] Does anyone know, off the top of their head, whether we have a "location information" icon? I don't see anything in the repo... [22:30:23] Bloody fabriceflorin is out [22:32:30] marktraceur: He's in a meeting next to me. :-) [22:32:53] James_F: I'm not sure he'd be helpful anyway, I'm sure he has the same emails as me [22:34:48] marktraceur: Steal the icon used in nearby? [22:34:56] marktraceur: Though will less of the solid blue, maybe? [22:34:58] James_F: violetto has one apparently [22:35:05] It's supposed to be greyish [22:35:06] Yeah, same icon probably. [22:54:09] (03PS1) 10MarkTraceur: Add location information to metadata div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107256 [22:54:10] Ta-daaaaa [22:54:24] I dunno WTF the location tags are [22:57:19] I will revise the story points on that card because the i18n team were surprisingly helpful (thanks Nikerabbit!) [22:59:26] And probably push things "in analysis" to the next iteration [23:04:37] tgr: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/96 this is yours - do you want it in this iteration or should I move it? [23:04:44] (I've already moved it to backlog but can move it back) [23:05:10] Sorry [23:05:12] 103 [23:05:14] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/103 [23:05:30] Ditto for https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/104 [23:06:29] Also not totally clear what the status is on https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/106 [23:06:36] 104 can wait [23:07:24] would be nice to fit 103 in, but since we have already committed to other stuff, I'll leave it on top of the backlog [23:08:03] 106 is also for the next iteration [23:08:19] sorry, probably should not be using in analysis as a dumping place for those [23:08:44] Heh [23:08:50] It's OK, it's getting sorted out [23:16:10] Exciting times [23:17:10] aarcos, tgr, I'm not totally trusting of the idea that all of the things in ready-for-development aren't claimed, are you claiming as you go? (nervousness because of new process, I'm sure it's normal) [23:17:56] I will claim my stuff, worry not. [23:17:58] ;-) [23:18:03] 'kay 'kay [23:21:29] fabr bollocks [23:54:42] (03PS4) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [23:54:44] (03PS1) 10Gergő Tisza: Refactor Flickr API calls [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 [23:56:56] (03CR) 10Gergő Tisza: "Rebasing made this change a lot bigger since UW now handles about a dozen URL types, so I split the refactoring part into a parent commit." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [23:58:24] (03CR) 10Alex Monk: [C: 04-1] "Seems like a good idea, shouldn't be based on the blacklisting stuff though." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 (owner: 10Gergő Tisza)