[00:01:26] (03CR) 10Gergő Tisza: "It is based on that for historical reasons (used to be part of the second blacklist patch, it was easier to just split the commit than to " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 (owner: 10Gergő Tisza) [00:04:20] (03CR) 10Alex Monk: "Okay, please rebase then" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 (owner: 10Gergő Tisza) [00:07:22] OK [00:07:39] I intend to finish dealing with email and then hopefully set up a limn instance on multimedia-alpha. [00:09:30] (03PS5) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [00:09:33] (03PS2) 10Gergő Tisza: Refactor Flickr API calls [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 [00:13:52] (03CR) 10Gergő Tisza: "PhpStorm tends to automatically un-fix bracket spacing :( I think I got them all now." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 (owner: 10Gergő Tisza) [00:21:23] tgr: https://gerrit.wikimedia.org/r/107127 \o/ [00:21:30] You snuck that one under me, wow [00:21:35] Great stuff [00:21:56] I'm not sure if it will be *necessarily* useful for MMV yet [00:22:03] Because it will be a different colour scheme [00:23:00] it seemed reasonable even apart from MMV [00:23:18] Yeah [00:23:38] I...will work on this next maybe. [00:26:30] Or someone else can! [00:26:39] It's on the wall, it has one story point, it's ready for development [00:26:51] I'm counting it as a replacement for the 3-pointer I knocked out in 4 hours. [00:44:49] (03PS13) 10Aarcos: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [00:49:46] (03CR) 10Aarcos: "Hi there folks," [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [01:30:24] (03PS6) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [01:31:52] (03CR) 10Gergő Tisza: "Modified to work with usernames as well as NSIDs." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [01:59:07] (03PS7) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [02:05:18] (03CR) 10Gergő Tisza: "Now works with lists." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [03:15:48] (03CR) 10Gergő Tisza: Add location information to metadata div (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107256 (owner: 10MarkTraceur) [03:18:30] (03CR) 10Mayankmadan: "Aarcos, I don't understand what was wrong with the supplyParams and the createRequest function? There is a lot of course that is being dup" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [03:19:02] (03CR) 10Mayankmadan: "*code" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [06:56:30] (03PS1) 10CSteipp: SECURITY: Prevent XSS by 'data-videopayload' [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/107334 [06:56:48] (03CR) 10CSteipp: [C: 032] "Already in production" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/107334 (owner: 10CSteipp) [06:57:10] (03Merged) 10jenkins-bot: SECURITY: Prevent XSS by 'data-videopayload' [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/107334 (owner: 10CSteipp) [09:18:06] marktraceur: normally you pick a card once you really start working on one. I didn't work after the call last night, so there was no point picking a card and then leaving right after [09:19:28] card-based workflow is based on how people work on assembly lines, each card representing the actual physical object they're working with. theoretically you're only supposed to pick one card at a time and work on it until you go as far as you can, then you come back to the board and pick one that's available, etc. [09:19:52] + put back the one you were working on [09:21:12] as for review, it would be good to have another field, yeah. if we can't, then I guess change the owner [09:21:52] which means that when we put something in the review column, we need to remember to clear the owner [09:22:16] otherwise someone visiting the card won't know right away if the owner is the reviewer or the person who wrote the code [09:22:55] and if you review and only +1, you just go back to the board and remove yourself as owner of the review [09:25:27] the reason why claiming something before you really work on it is a bad idea is that you might get caught up in something else and somebody freeing up could have picked it up. i.e. you're holding the assembly line unnecesseraly, if there are other workers who are equally capable of doing the same task [09:26:24] and as a team we should aim to all have the same level of expertise on everything, having experts of specific areas of the code who would always claim the same kind of task is counter-productive [09:27:27] not only it makes others less apt to review the changes, it can also create major blockage when someone isn't at work for an extended period of time [11:04:05] (03CR) 10Gilles: [C: 04-1] "I couldn't figure out why, but on my stock VM, despite making sure that a description is entered, the metadata call never returns it and i" (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [11:15:57] (03CR) 10Gilles: "When I set this up on my local machine, I only had to enter the public API key, not the API secret. I think you would be fine putting any " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [13:45:41] (03CR) 10Gilles: [C: 04-1] Add blacklisting feature for flickr in backend (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [14:14:35] (03CR) 10Gilles: [C: 04-1] Add location information to metadata div (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107256 (owner: 10MarkTraceur) [14:19:27] (03PS1) 10Amruthasangeeth: Renamed 'Credit' to 'FileSource' [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/107368 [14:25:29] (03CR) 1001tonythomas: [C: 031] "Looks good to me." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/107368 (owner: 10Amruthasangeeth) [15:33:40] (03CR) 10Hoo man: [C: 04-1] Renamed 'Credit' to 'FileSource' (031 comment) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/107368 (owner: 10Amruthasangeeth) [15:43:28] (03PS1) 10Gilles: Make sure that the close button is always visible [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107379 [15:45:31] (03CR) 10MarkTraceur: "Hoo's note applies, but after that I'm +1. Please don't merge until we've merged a supporting patch in MultimediaViewer that will let us d" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/107368 (owner: 10Amruthasangeeth) [15:53:26] marktraceur, tgr: was there ever code that took care of the drag affordamce? I don't see any trace of it in the current code [15:54:01] gi11es: There was but I dunno where it went... [15:54:15] do you know who wrote it? [15:54:39] Well, me [15:55:09] is it an "I don't know where it went on my laptop" or "I don't know where it went on gerrit"? [15:55:11] gi11es: toggleMetadata in lightboxinterface [15:55:28] a-ha, thank you [15:55:28] Sorry, I should have looked before being defeatist [15:56:31] that looks like it animates, is the plan to play the animation on click? [15:56:59] somehow I thought that the thing would be draggable [15:57:27] as in, dragging the chevron as an alternative to scrolling the page [15:57:42] gi11es: I didn't look into that, but I totally could [15:57:44] I guess it's the resize cursor that makes me want to do that [15:57:58] I think the initial design made sense to drag, but not this one [15:58:03] We can change the cursor to pointer [15:58:07] well, I don't really feel like I should be the one deciding [15:58:16] makes sense [15:58:28] I'll check out medium since that's fabrice's main inspiration [15:58:30] see what they do [15:58:42] 'kay [15:58:57] animation + pointer it is [16:16:57] (03PS1) 10Gilles: Clicking on the chevron should open/close the details [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107384 [16:17:41] Hi can some one help me with bug 56454 i tried to make height:100%; width: 100%; in .mw-mlb-image-links-div class in ext.multimediaviewer.css file in multimediaviewer extension [16:22:38] aalekhN: if I'm not mistaken the fullscreen feature has been pulled and is ongoing some work, what's described on that bug report shouldn't apply to the current version of mmv [16:24:47] Yeah [16:25:14] hard to say if the bug will still be valid once fullscreen is brought back [16:36:36] marktraceur gi11es I'll queue up at the Social Security Administration to get my SSN, I should be back by standup time but if not (and I can't connect via Mumble on Android) I've been working on the client side of the Flickr blacklisting which required a major rewrite due to some recently merged changes (and had some stuff missing in the first place) [16:42:05] cool beans, I've only reviewed the backend one today [16:54:39] in bug 56666:Can i simply use comment passed as ex:[[image:test.png|left|thumb|50px|Comment]] to be show in mediaviewer ....as annotations [17:04:13] (03CR) 10Aarcos: "Matankmadan: I left some comments in revision 11, addressing your questions. Hope that makes sense, let me know otherwise. Thanx for helpi" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [17:34:20] Hm, tgr's not around. [17:35:18] (03CR) 10MarkTraceur: [C: 04-1] "Wait." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/107368 (owner: 10Amruthasangeeth) [17:39:12] (03CR) 10MarkTraceur: [C: 032] "Per gilles." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107125 (owner: 10Gergő Tisza) [17:39:14] (03CR) 10jenkins-bot: [V: 04-1] Use JSONP for gender query to avoid cross-domain issues [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107125 (owner: 10Gergő Tisza) [17:49:22] gi11es: Wait, we aren't using Mumble today are we? [17:49:37] I mean, that would be awesome, but it says Hangout in the calendar :/ [17:49:39] nope [17:49:45] Balls [17:50:15] * marktraceur hangs out in the mumble anyway [17:55:27] marktraceur: some gobling might be eating your config edits, http://multimedia-metrics.wmflabs.org/datasources still 404s [17:57:40] ...wat [17:57:46] What the fuck [19:11:40] (03PS15) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [19:11:43] (03PS8) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [19:11:46] (03PS3) 10Gergő Tisza: Refactor Flickr API calls [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 [19:14:53] (03CR) 10Gergő Tisza: "I misunderstood what the API key is good for, thanks for correcting that. I added a key (not the one used in production) to the default co" (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [19:33:27] (03CR) 10Aarcos: Add caption to the interface in place of description (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [19:54:24] (03CR) 10Gergő Tisza: "Aarcos, can you test this on mediawiki-vagrant? I am getting various errors when running pip (first "No distributions at all found for os>" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [20:02:09] (03PS14) 10Aarcos: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [21:23:38] (03CR) 10MarkTraceur: Add caption to the interface in place of description (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [21:29:22] (03PS15) 10Aarcos: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [21:39:00] (03CR) 10MarkTraceur: "Patch incoming" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [21:39:12] (03PS3) 10MarkTraceur: Add caption to the interface in place of description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 [21:39:14] (03CR) 10jenkins-bot: [V: 04-1] Add caption to the interface in place of description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [21:39:40] Agh, rebase time [21:47:21] (03PS4) 10MarkTraceur: Add caption to the interface in place of description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 [21:47:34] (03CR) 10MarkTraceur: "Rebase done" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [22:03:32] (03CR) 10MarkTraceur: [C: 032] "Easy enough! :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107379 (owner: 10Gilles) [22:04:28] (03Merged) 10jenkins-bot: Make sure that the close button is always visible [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107379 (owner: 10Gilles) [22:07:06] (03CR) 10MarkTraceur: [C: 04-1] "-1 for indentation but I'm going to fix it then +2" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107384 (owner: 10Gilles) [22:07:09] (03PS2) 10Gergő Tisza: Use JSONP for gender query to avoid cross-domain issues [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107125 [22:08:59] (03PS2) 10MarkTraceur: Clicking on the chevron should open/close the details [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107384 (owner: 10Gilles) [22:11:27] (03CR) 10MarkTraceur: "I actually changed the way this works because $( 'html' ) didn't do the right thing for me. If we need to do both, that's probably fine, b" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107384 (owner: 10Gilles) [22:11:31] (03CR) 10MarkTraceur: [C: 031] Clicking on the chevron should open/close the details [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107384 (owner: 10Gilles) [22:16:25] (03CR) 10Aarcos: Make sure that the close button is always visible (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107379 (owner: 10Gilles) [22:35:38] (03CR) 10Gergő Tisza: Add location information to metadata div (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107256 (owner: 10MarkTraceur) [23:55:03] (03CR) 10Gergő Tisza: "I was hoping more people would weigh in on the bug, then forgot about it :)" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/107368 (owner: 10Amruthasangeeth)