[00:06:50] (03PS1) 10Jhall: WIP Initial setup for Multimedia Viewer browser tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107517 [00:07:29] (03CR) 10Gergő Tisza: [C: 032] Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [00:08:21] (03Merged) 10jenkins-bot: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [05:39:27] (03PS1) 10MarkTraceur: Fix resize functions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107548 [07:13:52] (03PS2) 10Apsdehal: Added test if Lightbox is attached [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106889 [07:34:13] (03CR) 10Mayankmadan: "There are no comments in patch set 11" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [07:41:37] (03CR) 10Gilles: [C: 04-1] "Well, apparently html works in firefox but not chrome (I assume you were using chrome) and document.body works in chrome but not firefox. " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107384 (owner: 10Gilles) [07:43:37] Lol. [08:06:21] (03PS3) 10Gilles: Clicking on the chevron should open/close the details [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107384 [08:06:49] (03CR) 10jenkins-bot: [V: 04-1] Clicking on the chevron should open/close the details [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107384 (owner: 10Gilles) [08:08:10] (03CR) 10Gilles: "After looking at jquery.scrollTo's source code (a plugin I usually use to do document scrolling) it was clear that some of that stuff is i" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107384 (owner: 10Gilles) [08:20:32] so, jenkins rejecting a 3rd-party library... am I supposed to painstakingly fix the library? [08:20:55] gi11es: For jshint? Naw, add it to .jshintignore [08:21:01] ok, thanks [08:22:10] (03PS4) 10Gilles: Clicking on the chevron should open/close the details [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107384 [08:23:27] (03CR) 10Raimond Spekking: "I think this is a wrong match." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/107368 (owner: 10Amruthasangeeth) [08:30:17] gi11es: ummm, I think there is a scrollTo library in core [08:30:47] * legoktm looks [08:30:55] I didn't see it [08:31:01] oh [08:31:03] not merged yet [08:31:03] https://gerrit.wikimedia.org/r/#/c/96949/ [08:31:05] soon! [08:31:26] http://mybroadband.co.za/vb/attachment.php?attachmentid=19597&d=1348058492 [08:32:37] is it possible to watch a gerrit changeset like that one without adding myself as a reviewer? [08:33:04] hit the star button by the commit message [08:33:21] ah, thank you [08:33:44] will that send me email notifications? or just add it to my front page? [08:35:43] email [08:36:27] all my wildest desires fulfilled. [08:53:32] (03CR) 10Gilles: [C: 031] "Would +2 if I could" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [08:59:46] (03CR) 10Gilles: [C: 031] "All my concerns have been addressed" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [09:01:09] (03CR) 10Gilles: [C: 031] Use JSONP for gender query to avoid cross-domain issues [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107125 (owner: 10Gergő Tisza) [09:22:20] (03CR) 10Zfilipin: "When this is merged into master branch, please update the list of repositories that have Selenium tests:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107517 (owner: 10Jhall) [09:52:28] (03CR) 10Gilles: [C: 031] Fix resize functions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107548 (owner: 10MarkTraceur) [09:55:57] (03CR) 10Gilles: [C: 04-1] Added test if Lightbox is attached (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106889 (owner: 10Apsdehal) [10:14:46] (03CR) 10Gilles: [C: 04-1] A way to blacklist flickr users. (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [10:18:43] would be cool if we had a mingle bot [10:20:59] apparently the history is available as an atom feed [10:21:46] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/feeds/L*Qlz2vMzc6-mzoQItWjww.atom [10:21:52] doesn't even require auth [10:22:55] hmmmm http://hackage.haskell.org/package/rss2irc [10:35:49] Story #107 Use site favicon as icon for list item to remote repo changed by Gilles Dubuc [10:37:01] Story #107 Use site favicon as icon for list item to remote repo changed by Gilles Dubuc [10:37:33] Story #107 Use site favicon as icon for list item to remote repo changed by Gilles Dubuc - Comment added: Come on, mingle bro... [10:40:36] Story #81 Show close button all the time changed by Gilles Dubuc - Comment added: Testing IRC bot, please ignore [10:45:03] Story #81 Show close button all the time changed by Gilles Dubuc - Comment added: Another IRC bot test [10:46:05] Story #81 Show close button all the time changed by Gilles Dubuc - Comment added: Last one, I think mingle bro is correctly confi... [10:48:33] for the record, the set of parameters I needed to make mingle bro behave: [10:48:37] rss2irc https://wikimedia.mingle.thoughtworks.com/projects/multimedia/feeds/L*Qlz2vMzc6-mzoQItWjww.atom mingle-bro@irc.freenode.org/#wikimedia-multimedia -i 1 -q -h -d --allow-duplicates [10:50:52] I might play with regexp and attempting to make it display mirc colors like grrrit-wm another time, for now let's see if it's useful [15:19:52] (03PS1) 10Gergő Tisza: WIP Create model & providers for file usage information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107588 [15:20:20] (03CR) 10jenkins-bot: [V: 04-1] WIP Create model & providers for file usage information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107588 (owner: 10Gergő Tisza) [16:19:39] (03PS1) 10Gilles: Display the favicon of the foreign file repo when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 [16:34:39] (03CR) 10Gilles: "I'm very open to the idea of redoing the CSS placement of the icons... I wasn't sure how dear you guys hold the li:before :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [17:04:00] Story #73 Restore Full Screen Function for Media Viewer changed by Mark Holmquist - Comment added: https://gerrit.wikimedia.org/r/99021 core patch... [17:04:37] WHAT [17:04:39] HOLY [17:04:41] WHAT [17:04:58] gi11es-away: Are you responsible for this silliness [17:11:14] Task #108 Wrap up improvements to 'upload-wizard_tests.py' [UNPLANNED] changed by Aaron Arcos - Status changed from Awaiting Final Code Review to Ready for Testing [17:11:16] Task #108 Wrap up improvements to 'upload-wizard_tests.py' [UNPLANNED] changed by Aaron Arcos - Status changed from Ready for Testing to In Testing [17:11:18] Task #108 Wrap up improvements to 'upload-wizard_tests.py' [UNPLANNED] changed by Aaron Arcos - Status changed from In Testing to Ready for Signoff [17:11:20] Task #108 Wrap up improvements to 'upload-wizard_tests.py' [UNPLANNED] changed by Aaron Arcos - Status changed from Ready for Signoff to Accepted [17:31:19] aarcos: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/108 can has story points? I don't know if it's worthwhile [17:43:42] (03CR) 10Aarcos: [C: 031] "Some easy to add unit tests are missing, ;-)." (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [17:44:28] Bah [17:51:40] Story #73 Restore Full Screen Function for Media Viewer changed by Mark Holmquist - Status changed from Awaiting Final Code Review to In Development,Owner set to Mark Holmquist [17:51:42] Story #73 Restore Full Screen Function for Media Viewer changed by Mark Holmquist - Status changed from In Development to Ready for Development,Owner changed from Mark Holmquist to ... [17:52:13] marktraceur: yes [17:53:18] gi11es: Well cool [17:53:37] gi11es: We have something that the FR-tech department uses - they call it slander. I wonder if I can have them point it at us. [17:54:46] Story #73 Restore Full Screen Function for Media Viewer changed by Mark Holmquist - Description changed [17:55:08] There's still a bunch of improvements to make in the core patch there...I guess that's my day gone down the drain, whee [18:01:36] gi11es: Troubles? [18:09:12] fyi it's just one command to get the bot running, using the rss2irc package [18:09:43] I don't know what the process is to get something like this running on our own servers like the other bots [18:10:03] you can find the command in the irc logs, I paste it earlier today [18:10:07] *pasted [18:11:08] Oh cool. [18:11:29] We can totally run that on wmflabs in a heartbeat [18:11:39] gi11es: Do you have an account on wikitech.wm.org? [18:11:44] I do [18:12:09] gi11es: Is it something robotic but helpfully predictable like "GDubuc (WMF)"? [18:12:23] I believe it's just "gilles" let me check [18:12:25] Oh, no, shell name [18:12:28] Yeah, probably [18:13:04] tgr: What's your username there, I may as well add you while I'm here [18:13:48] yes my account on labs/wikitech is "gilles" [18:14:11] I know, added already [18:14:34] gi11es: You're root on our labs instances, use it wisely [18:15:06] fork bomb party, woohoo [18:15:27] gi11es: You'll take down a test wiki and our unused IRC standup bot, congrats [18:16:13] marktraceur: User:Gergő_Tisza [18:18:37] (03CR) 10Gergő Tisza: "Is the favicon intentionally limited to foreign api repos? As far as I cam see it would make just as much sense for local and shared-DB." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [18:18:50] 4 instances, which one should I put this on? [18:20:39] tgr: Hm, I wonder if it will like that... [18:20:46] gi11es: -alpha is what we tend to use [18:21:14] don't blame me, it was the policy at the time i registered [18:21:30] tgr: Well, that should be OK [18:21:35] tgr: Done, you're in [18:21:47] couldn't use labs for half a year once because they had some bug in how DNS entries handled unicode [18:23:58] marktraceur: btw why was the standupbot decomissioned? [18:23:59] Hah [18:24:07] (03CR) 10Gilles: "Mingle card said "remote repo" that's why I took that direction, I thought it was synonymous of "foreign". I haven't looked at how the dat" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [18:24:09] tgr: Because we don't do IRC standups anymore [18:24:51] the ordering thing would be useful with hangout as well IMO [18:25:47] Except Fabrice (who runs the hangouts) doesn't run IRC [18:26:42] gi11es: awight and I are chatting in -fundraising about slander [18:29:17] mingle-bro reborn on alpha [18:30:38] LO, and he is reborn [18:31:26] reBROn [18:31:45] Oh, no, this bodes poorly for the quality of discourse in this channel [18:31:53] brodes* [18:33:59] m1.medium, etc. are these actually running on aws? [18:34:17] gi11es: No, I think we have an OpenStack cluster [18:35:01] oh right, it's just borrowed/common labelling [18:36:01] (03CR) 10Gergő Tisza: "Mingle card said "remote repo" that's why I took that direction, I thought it was synonymous of "foreign". I haven't looked at how the dat" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [18:37:47] (03CR) 10MarkTraceur: "I think showing the en.wiki logo for files on en.wiki would be good." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [18:43:09] (03CR) 10Gergő Tisza: "About data fetching for local, again siteinfo API would work, but it is probably easier to just use the actual favicon. (MediaWiki puts a " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [18:52:36] libel: config [18:52:36] Configuration: [{"jobs": "mingle: {'source': 'https://wikimedia.mingle.thoughtworks.com/projects/multimedia/feeds/L*Qlz2vMzc6-mzoQItWjww.atom', 'class': 'mingle'}", "irc": {"maxlen": 200, "host": "irc.freenode.net", "realname": "Multimedia Mingle to IRC bridge", "nick": "libel", "pass": "ntahoercuthaontuehneshoaoljqrchktnh", "port": 6667, [18:52:36] "channel": "#wikimedia-multimedia"}, "poll_interval": 60}] [18:52:54] I haven't registered it [18:53:37] oh good. config looks good, thanks for doing that! [18:53:43] Yup [18:54:05] should I retire the bro? short career :) [18:54:12] Damn do I ever need to put some porcelain on the tool [18:54:14] gi11es: Maybe. I still haven't seen the feed work [18:54:22] mingle-bro: help [18:54:29] who ar yu [18:55:16] poll_interval on libel, is that minutes or seconds? [18:55:28] gi11es: seconds [18:55:29] Seconds [18:55:45] neat, the bro couldn't do more often than once per minute [18:56:42] #81: (GD) Test -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/81 [18:56:54] woot [18:57:00] initials, fancy [18:57:20] Oh, it worked for *you* [18:57:21] It gets hilarious when the card properties are abbreviated... [18:57:28] GOD DAMN TEST [18:57:34] farewell, mingle-bro [18:58:22] #73: (MH) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/73 [18:58:59] Sweetness [19:01:12] marktraceur: pauhleeesze improve the damn bot if you find the time [19:01:25] awight: I may! [19:01:35] It's one of those things where I was so relieved once it worked that I totally dropped development :/ [19:01:42] I think step 0 may be to have it not show its password, step 1 may be to auto-register with nickserv [19:01:57] ARGH. yeah there is even code to do that, no clue why it's misfiring [19:02:17] marktraceur: https://github.com/adamwight/slander/blob/master/brain.py#L30 [19:02:18] Hm [19:02:21] Will look. [19:03:16] marktraceur: *sigh* it's the double-quotes. I must have changed the output format in my sleep or something [19:03:35] yeah. I think was dumping yaml previously. [19:04:34] Heh. [19:04:39] I can fix it if you want [19:04:55] awight: There's only IRC pass, right? No other password? We can just delete it from the object... [19:05:17] either way [19:05:24] There can also be a SVN password [19:05:49] Ah. [19:06:03] and... I like the idea that the brain can be agnostic of the config format and just hit pass|p*w* with a sharpie [19:07:28] Heh [19:07:35] But, it's prone to error [19:07:36] So [19:07:39] Better to be safe IMO [19:30:42] (03CR) 10MarkTraceur: "Or it could just get returned as part of the local file repo info!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [19:40:23] (03CR) 10Gergő Tisza: "For local files, we could just request siteinfo and repoinfo in the same API call, if we are intent on doing this via the API (I don't see" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [19:43:29] (03CR) 10Gergő Tisza: "I just don't see why would we be better off with FileSource="own work". {{own}} is crappy metadata and relabeling it won't change that. (I" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/107368 (owner: 10Amruthasangeeth) [19:43:34] (03CR) 10MarkTraceur: "I don't understand why it would be at all difficult to fetch a favicon - it's just a string setting AFAIK. Return it in siteinfo, which ge" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [19:44:41] Ugh, I should stop responding to things [19:48:06] Dare I ask why the bot is named "libel" ? -.o [19:48:43] (03CR) 10Gergő Tisza: "I mean, you would have to go through the exact same process on the server side - figure out the API endpoint of the remote, then call site" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [19:50:20] quiddity: FR-tech's is called "slander", it seemed appropriate [19:51:45] heh [20:04:47] (03CR) 10Gergő Tisza: A way to blacklist flickr users. (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [20:05:46] (03PS9) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [20:16:21] #110: (MH) S:AFCR|R:#MQ|I:#J2-S1|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/110 [20:18:22] #110: (MH) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/110 [20:18:22] #110: (MH) https://gerrit.wikimedia.org/r/99021 FYI -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/110 [20:18:22] #73: (MH) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/73 [20:18:22] #73: (MH) O:MH|S:ID|DDS:1J2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/73 [20:18:51] (03CR) 10MarkTraceur: "Removing my -2, core library is back under review and should be merged in the coming days." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105124 (owner: 10Theopolisme) [20:21:37] (03CR) 10Aarcos: [C: 04-1] "I guess, I meant -1, sorry." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [20:33:42] marktraceur: this seems to help, https://github.com/adamwight/slander/commit/60d24dc6abc38bbf3d08c7af4688ada06ac71e81 [20:40:30] marktraceur: aa crap so sorry I didn't see your PR [20:41:05] you're fast! [20:45:18] marktraceur and team: While writing the e2e tests I see that the sunrise image inside the MV in beta has a real width, this is HTM for the image: [20:46:33] Is this expected? I think we are setting the width and playing with the height but maybe I am missing something? Can we round up this number if correct anyways? [20:57:07] awight|domestic: I try. :) [20:57:39] aarcos: We're setting it on the element, I think...I don't know where the height came from. I can look for it. [20:57:42] Oh, wait [20:57:57] ...let me look, yeah [21:00:50] aarcos: It's possible that mlb.LightboxImage.autoResize gets called, then [21:01:25] Yeah, it does. [21:01:41] But it's basically of null effect [21:01:59] aarcos: You could "easily" override that function and do nothing in it [21:03:13] ok, just being paranoid, I will fix once I am done with the e2e tests, tx ! [21:09:42] awight|domestic: I've given you another patch on the registration PR [21:15:26] marktraceur: can you cast a quick glance at https://gerrit.wikimedia.org/r/#/c/107588/ ? [21:15:36] Yes [21:19:25] (03CR) 10Gergő Tisza: "https://gerrit.wikimedia.org/r/#/c/107712/ should take of non-DB repos. (DB is more work, before starting it I'll wait out whether anyone " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [21:28:38] (03CR) 10MarkTraceur: [C: 04-1] "Itty bitty issues, mostly because things aren't done probably, but it's looking sane so far." (0313 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107588 (owner: 10Gergő Tisza) [21:28:58] thx! [21:34:24] Yup! [21:36:51] (03PS9) 10MarkTraceur: Enable fullscreening with jquery.fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105124 (owner: 10Theopolisme) [21:37:43] (03CR) 10jenkins-bot: [V: 04-1] Enable fullscreening with jquery.fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105124 (owner: 10Theopolisme) [21:38:39] Some slow ass-shit happening on Gerrit today [21:38:52] (03CR) 10MarkTraceur: "Rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105124 (owner: 10Theopolisme) [21:39:36] (03PS10) 10MarkTraceur: Enable fullscreening with jquery.fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105124 (owner: 10Theopolisme) [21:39:50] (03CR) 10MarkTraceur: "Fix rebase-related issue" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105124 (owner: 10Theopolisme) [21:40:14] (03CR) 10jenkins-bot: [V: 04-1] Enable fullscreening with jquery.fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105124 (owner: 10Theopolisme) [21:42:47] I'm having fun registering the bot now. [21:45:46] #111: (MH) S:AFCR|R:#MQ|I:#J2-S1|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/111 [21:46:46] #73: (MH) N:FFSFfMV Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/73 [21:47:46] #73: (MH) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/73 [21:49:47] #112: (MH) S:RfE|R:#MQ|I:#J2-S2|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/112 [21:50:46] #73: (MH) N:FfiMV Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/73 [21:51:46] #8: (e) PC:0 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/8 [21:58:47] #8: (MH) This story is Too Long. -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/8 [22:24:18] (03CR) 10Gergő Tisza: [C: 032] Fix resize functions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107548 (owner: 10MarkTraceur) [22:24:46] (03Merged) 10jenkins-bot: Fix resize functions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107548 (owner: 10MarkTraceur) [22:24:59] ...maybe [22:25:10] I mean, it looked like a bug, but it didn't really change anything [22:27:33] fabr/win 41 [22:27:35] Balls [22:42:32] quiddity: Hey Nick, would you be willing to wikify the announcement for Commons and English Village Pump and post on wikipage on Officewiki? [22:42:51] This would leave me more time for final approvals and checking Brion's draft :) [22:42:51] sure [22:43:13] Thanks! Feel free to push back if I'm asking too much of you :! [22:43:23] fabriceflorin, I'll deal with that, and send you a link when it's ready [22:43:40] Merci beaucoup! [22:47:21] fabriceflorin: Hey, poke, are there any thoughts from the community about the speed of the media viewer since we started bucketing? [22:48:24] marktraceur: I haven't heard anything from the community about speed improvements. But then again, I haven't asked, because I was so busy on other projects. But once the RfC is out, we could reach out to folks later this week, if you like. [22:48:32] 'kay [22:49:19] I'm adding this to my to-do list for next week, when the heat of the RfC should have died down and freed me up to get back to Media Viewer. [22:56:52] 'kay [22:56:56] So incoming patch [22:57:01] But I'm not sure it fixes everything [22:57:07] There's still some weird shit happening I think [22:57:11] I have no idea why [22:57:53] (03PS5) 10MarkTraceur: Fix resize engine for fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105840 [22:57:55] (03CR) 10jenkins-bot: [V: 04-1] Fix resize engine for fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105840 (owner: 10MarkTraceur) [22:58:10] Ah fuck [22:58:27] WHAT [22:58:57] I JUST REBASED IT [22:58:57] AGH [22:59:15] (03PS6) 10MarkTraceur: Fix resize engine for fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105840 [22:59:17] (03CR) 10jenkins-bot: [V: 04-1] Fix resize engine for fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105840 (owner: 10MarkTraceur) [22:59:43] I will destroy you Jenkins [23:02:22] Eff it, I'll wait until more things are merged [23:03:46] #73: (MH) https://gerrit.wikimedia.org/r/105840 should fi... S:AFCR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/73 [23:21:30] Marktraceur: I also got bitten by the all-wide bug fabrice was talking about, do you want to take a look? [23:21:54] Yeeeeessss [23:22:01] quiddity: I just made a few tweaks to the announcement, at robla 's suggestion. Would you mind updating the wiki version based on the google doc? [23:22:17] sure thing, 30 secs from now [23:23:33] Cool, thanks! I'm making one final tweak on the main draft, then will start getting it ready on Commons. [23:26:20] fabriceflorin, done. [23:26:44] Man, you're fast :) Muchas gracias! [23:27:36] Only whilst the coffee is fresh ;) [23:28:19] Hehe. Can you check the Background page one last time onwiki, to make sure there are no copy errors or broken links? It hasn't gotten as much love as the main draft, since it was only written yesterday. Be bold and fix anything that seems askew. [23:30:14] ok [23:34:54] (03PS1) 10MarkTraceur: Try to fix resizing again [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107739 [23:34:59] aarcos: Yet Another Attempt at a solution ^ [23:38:46] fabriceflorin, done. Looks fine, no changes needed. [23:40:05] Thanks! Adding one more sentence to the RfC to link to Brion's doc and I should be ready to start posting on Commons. So realistically, it looks more like 4pm PT for the first announcement. :)