[08:24:29] #153: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... DTS:0F2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/153 [11:53:29] #126: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126 [12:14:29] #126: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126 [13:48:29] #126: (GD) I know that the existing profiling code does si... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126 [14:28:29] #126: (GD) Actually now that I've thought more about it, i... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126 [14:33:29] #126: (GD) I've decided not to include gender and metadata... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126 [14:56:05] (03PS1) 10Gilles: Track detailed content loading network performance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 [14:56:40] (03CR) 10jenkins-bot: [V: 04-1] Track detailed content loading network performance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [14:57:40] (03PS2) 10Gilles: Track detailed content loading network performance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 [14:58:29] #126: (GD) https://gerrit.wikimedia.org/r/111197 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126 [15:04:34] (03CR) 10Gilles: "I didn't set out to rewrite the profiling code, but when I was done with my new class, the old code seemed redundant. The new code doesn't" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [15:06:29] #152: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/152 [16:42:48] (03PS16) 10Inchikutty: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [17:26:30] #180: (AA) S:A|SP:0|P:Mh|R:#Q|I:#J2-S3|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:27:29] #180: (AA) T:TM(|R:(s|I:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:29:29] #180: (AA) S:IA -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:29:29] #180: (AA) T:S -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:31:29] #180: (AA) T:SI( -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:33:29] #180: (AA) T:Td -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:36:29] #180: (AA) T:SI( -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:36:29] #180: (AA) T:Td -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:54:29] #180: (AA) T:SI( -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:55:29] #180: (AA) T:Td -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:55:29] #180: (AA) T:SI( -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:55:29] #180: (AA) T:Td -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:57:29] #180: (AA) T:SI( -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:57:29] #180: (AA) T:Td -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:57:29] #180: (AA) T:SI( -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:59:29] #180: (AA) T:TM( -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [17:59:29] #180: (AA) T:Td -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [18:01:24] gi11es-away: u there? [18:07:29] #180: (AA) T:SI( -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [18:07:29] #180: (AA) T:TM -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [18:10:22] (03CR) 10MarkTraceur: "I think that was an issue with the empty function - will fix now!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [18:10:29] #180: (AA) T:Td -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [18:10:29] #180: (AA) T:SI( -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [18:11:11] (03PS1) 10MarkTraceur: Fix categories empty method [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111225 [18:11:15] tgr: ^^ [18:11:22] Too-simple bug [18:11:29] #180: (AA) T:TM -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [18:11:29] #180: (AA) I:#J2-S3 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [18:11:29] #180: (AA) R:#Q -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [18:12:29] #180: (AA) S:A -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/180 [18:13:33] Oh, hm, I need to do the SoS [18:24:29] #181: (AA) R:#Q|I:#J2-S3|T:TM Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/181 [18:25:29] #181: (AA) S:A -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/181 [18:41:30] #182: (AA) S:A|R:#Q|I:#J2-S3|T:TM Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/182 [19:13:17] (03CR) 10Gergő Tisza: "All API calls (pre- and post refactor) use mw.Api which does not expose the XHR object. We could change its behavior, but probably a core " (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [19:18:45] (03CR) 10Gergő Tisza: "Btw we have some API calls (gender check is the one I remember, but I think there is one more) which we do as JSONP because in InstantComm" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [19:20:44] tgr: FYI I'm using the topic "ui-refactor", maybe helpful for keeping track of patches [19:22:09] i'll try not to forget [19:22:12] Heh [19:22:26] * tgr wasn't very disciplined about setting the topic so far [19:22:50] tgr: Are we going to drink the kool-aid and make everything its own class, or are we going to fight back a bit and keep some really simple stuff in the controller exclusively? [19:23:22] * rdwrer starts with license information, either way [19:24:38] i would start with ripping out the big groups of functionality like the metadata panel or the fading icons and break up to smaller parts as needed [19:24:57] Oh, I was going to pick at it until it made sense [19:25:04] and leave it together in case if doubt [19:25:13] True [19:25:17] OK, big patch it is [19:25:30] it is easy to go overboard when refactoring [19:29:04] (03CR) 10Gergő Tisza: Add imageinfo, thumbnail info, repoinfo provider (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110496 (owner: 10Gergő Tisza) [19:36:36] (03PS8) 10Gergő Tisza: Add imageinfo, thumbnail info, repoinfo provider [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110496 [19:38:45] (03PS2) 10Gergő Tisza: Renaming things for consistency: DataProvider -> Provider [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111150 [19:38:59] (03PS3) 10Gergő Tisza: Replace old API code with providers + fix a few provider bugs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111151 [19:39:06] (03PS3) 10Gergő Tisza: Add provider to for actual image loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111154 [19:39:07] Oh my [19:39:36] I think I will also put file reuse into its own class right away [19:41:00] (03CR) 10Gergő Tisza: [C: 032] Fix categories empty method [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111225 (owner: 10MarkTraceur) [19:42:36] (03Merged) 10jenkins-bot: Fix categories empty method [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111225 (owner: 10MarkTraceur) [20:47:05] (03CR) 10Aarcos: "This looks very solid, thanx !, I just have cosmetic suggestions and maybe one test to add." (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110496 (owner: 10Gergő Tisza) [20:47:30] #184: (F) T:ES Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/184 [20:47:35] (03PS1) 10MarkTraceur: Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 [20:47:40] Big ol' patch [20:47:45] And now noms [20:48:07] (03CR) 10jenkins-bot: [V: 04-1] Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [20:48:14] Ah fuck. [20:53:26] (03CR) 10Aarcos: [C: 031] "LGTM, merge at your convenience." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111150 (owner: 10Gergő Tisza) [21:18:27] (03CR) 10Aarcos: Replace old API code with providers + fix a few provider bugs (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111151 (owner: 10Gergő Tisza) [21:30:03] (03CR) 10Aarcos: "This is very similar to LightboxImage.getImageElement()? Maybe they should be merged?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111154 (owner: 10Gergő Tisza) [22:01:26] (03PS2) 10MarkTraceur: Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 [22:01:35] Probably works better now! [22:01:53] Definitely* [22:02:09] (03CR) 10jenkins-bot: [V: 04-1] Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [22:02:15] Whaaaat [22:02:56] (03PS3) 10MarkTraceur: Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 [22:03:25] (03CR) 10jenkins-bot: [V: 04-1] Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [22:13:11] (03PS4) 10MarkTraceur: Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 [22:13:17] Finally [22:13:25] God, I need to get jshint running in geany. [22:17:05] Heh, having a modern node installation might help [22:46:02] (03PS5) 10MarkTraceur: Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 [22:46:33] (03CR) 10jenkins-bot: [V: 04-1] Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [22:46:42] Oh FFS [22:47:22] (03PS6) 10MarkTraceur: Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 [22:50:25] Hm, what next... [22:50:36] Buttons maybe [23:06:29] #137: (AA) Test running under: https://wmf.ci.cloudbee... DTE:0F2|S:RfS -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/137 [23:06:29] #137: (AA) S:A -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/137 [23:22:29] #137: (AA) B:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/137 [23:28:45] (03CR) 10MarkTraceur: [C: 04-1] "setLocationData didn't make it to the new class" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [23:45:55] (03PS1) 10MarkTraceur: Refactor button things into a separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 [23:46:24] (03CR) 10jenkins-bot: [V: 04-1] Refactor button things into a separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 (owner: 10MarkTraceur) [23:46:30] Christ. [23:46:56] (03PS9) 10Gergő Tisza: Add imageinfo, thumbnail info, repoinfo provider [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110496 [23:51:49] (03PS3) 10Gergő Tisza: Renaming things for consistency: DataProvider -> Provider [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111150 [23:52:04] (03PS4) 10Gergő Tisza: Replace old API code with providers + fix a few provider bugs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111151 [23:58:44] (03PS2) 10MarkTraceur: Refactor button things into a separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372