[00:01:31] #151: (MH) I'm having trouble getting Chromium installed f... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/151 [00:57:34] Hrm [01:00:08] (03CR) 10MarkTraceur: "It seems like this would be caused by a race condition - specifically, the fullscreen event firing too late for the updateControls method " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111134 (owner: 10MarkTraceur) [01:00:26] tgr: If you have a minute to look at that patch, it's a really confusing issue on Chromium [01:00:46] in 15 minutes or so [01:20:30] #147: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/147 [01:34:29] (03PS1) 10Gergő Tisza: Refactor thumbnail size calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111950 [01:35:03] (03CR) 10jenkins-bot: [V: 04-1] Refactor thumbnail size calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111950 (owner: 10Gergő Tisza) [01:46:44] (03PS2) 10Gergő Tisza: Refactor thumbnail size calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111950 [01:46:46] (03PS3) 10Gergő Tisza: Some more metadata fetch reorganizing to get rid of the dependency on UI state [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111427 [01:46:48] (03PS5) 10Gergő Tisza: Add Thumbnail model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111397 [01:46:50] (03PS5) 10Gergő Tisza: Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 [01:51:30] #196: (GT) https://gerrit.wikimedia.org/r/111950 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/196 [01:54:51] (03CR) 10Gergő Tisza: "I don't even see a fullscreen button." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111134 (owner: 10MarkTraceur) [01:57:00] (03CR) 10Gergő Tisza: "nvm, core was outdated." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111134 (owner: 10MarkTraceur) [02:00:30] #170: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/170 [02:18:22] (03CR) 10Gergő Tisza: "On my machine this is a CSS issue: the metadata panel does get the (screen size - 75px) offset, but it is relative to a parent which is at" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111134 (owner: 10MarkTraceur) [02:44:00] (03PS5) 10Gergő Tisza: Show main metadata in fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111134 (owner: 10MarkTraceur) [02:49:04] (03CR) 10Gergő Tisza: "Uploaded pure CSS version." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111134 (owner: 10MarkTraceur) [02:58:55] (03CR) 10Gergő Tisza: [C: 04-1] "Now I get "cannot call method 'recordEntry' of undefined"." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [03:02:30] #155: (GT) I'll work a bit more on the third patch - the r... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155 [03:04:30] #196: (GT) R:(s|I:(s|T:SI( -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/196 [03:04:30] #196: (GT) R:#Q|I:#F2-S1 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/196 [03:05:23] (03CR) 10Gergő Tisza: "Size calculation refactoring done in https://gerrit.wikimedia.org/r/#/c/111950/" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111397 (owner: 10Gergő Tisza) [07:33:17] (03CR) 10Gilles: [C: 032] Show main metadata in fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111134 (owner: 10MarkTraceur) [07:33:56] (03Merged) 10jenkins-bot: Show main metadata in fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111134 (owner: 10MarkTraceur) [07:34:30] #151: (GD) DDE:0F2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/151 [07:36:30] #183: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... O:GD|DTS:0F2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/183 [07:37:30] #142: (GD) * DTS:0F2|O:GD|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 [07:57:14] (03CR) 10Gilles: "That one I can't reproduce nor figure out. Let me know when you have the chance to debug it and get more information." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [08:38:46] (03CR) 10Gilles: Refactor thumbnail size calculation (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111950 (owner: 10Gergő Tisza) [08:42:20] (03CR) 10Gilles: [C: 032] Refactor thumbnail size calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111950 (owner: 10Gergő Tisza) [08:58:15] (03CR) 10Gilles: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111950 (owner: 10Gergő Tisza) [09:05:30] #196: (GD) That one is good to go, +2ed, but is waiting on... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/196 [09:11:42] (03CR) 10Gilles: [C: 032] Add Thumbnail model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111397 (owner: 10Gergő Tisza) [09:12:16] (03Merged) 10jenkins-bot: Add Thumbnail model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111397 (owner: 10Gergő Tisza) [09:14:51] (03CR) 10Gilles: [C: 032] Some more metadata fetch reorganizing to get rid of the dependency on UI state [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111427 (owner: 10Gergő Tisza) [09:15:23] (03Merged) 10jenkins-bot: Some more metadata fetch reorganizing to get rid of the dependency on UI state [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111427 (owner: 10Gergő Tisza) [09:22:29] #142: (GD) Doesn't work for me, I also tried disabling the... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 [09:22:30] #142: (GD) S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 [10:31:35] (03CR) 10Gilles: [C: 04-1] Preload prev/next images (036 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 (owner: 10Gergő Tisza) [10:32:29] #155: (GD) S:R -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155 [10:33:30] #176: (GD) O:GD|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/176 [11:06:10] (03CR) 10Gilles: Refactor panel-related things into another class (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [12:25:30] #193: (P) R:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/193 [12:26:30] #193: (P) R:#UW|I:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/193 [12:26:30] #193: (P) R:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/193 [12:26:30] #193: (P) I:#B -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/193 [12:35:31] (03PS1) 10Zfilipin: Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112014 [12:56:31] #147: (P) Need link icon and share panel assets. -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/147 [12:56:31] #147: (P) We should also discuss next week the whether th... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/147 [13:28:13] (03PS1) 10Pginer: Icons for share link and assessments [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112024 [13:30:31] #147: (P) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/147 [13:50:30] #45: (P) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/45 [13:51:30] #167: (P) Need zoom icon, drag cursor icon and navigation... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/167 [13:52:30] #167: (P) Need clarifications on how to support multiple ... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/167 [13:53:32] #199: (P) It could benefit from a small ?media viewer?... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/199 [13:53:32] #170: (P) Need ?media file? icon for file notificatio... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/170 [13:55:33] #170: (P) General question: Do we want to communicate dif... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/170 [14:42:51] (03PS15) 10Gilles: Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [14:42:53] (03CR) 10jenkins-bot: [V: 04-1] Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [14:47:17] (03PS16) 10Gilles: Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [14:47:48] (03CR) 10jenkins-bot: [V: 04-1] Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [14:54:08] (03PS17) 10Gilles: Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [14:54:40] (03CR) 10jenkins-bot: [V: 04-1] Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [14:56:18] (03PS18) 10Gilles: Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [15:00:43] (03CR) 10Gilles: [C: 031] "I'm happy with your changes, go ahead and merge if you have no concerns with mine." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [16:10:15] (03CR) 10Cmcmahon: [C: 032] Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112014 (owner: 10Zfilipin) [17:51:00] fabr [17:51:01] Grr [17:51:34] #142: (GT) Disabling should not be necessary. Did you upda... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 [18:09:24] (03PS19) 10MarkTraceur: Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 [18:10:41] (03CR) 10MarkTraceur: [C: 032] "I fixed a few whitespace errors, fixed variable declaration order, and made sure EventLogging is a soft dependency. Otherwise it was fine." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [18:11:13] (03Merged) 10jenkins-bot: Refactor panel-related things into another class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111260 (owner: 10MarkTraceur) [18:11:32] #186: (MH) DDE:0F2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/186 [18:12:33] #151: (MH) On beta O:MH|DTS:0F2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/151 [18:32:30] #196: (MH) B:B -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/196 [18:51:16] (03CR) 10Gergő Tisza: "I cannot reproduce it either. Maybe my files got into a dirty state somehow..." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [18:51:24] (03PS10) 10Gergő Tisza: Track detailed content loading network performance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [18:51:26] (03CR) 10jenkins-bot: [V: 04-1] Track detailed content loading network performance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [18:52:54] (03CR) 10Gergő Tisza: "Rebased (apparently not enough), added status to schema, fixed some minor jsduck errors." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [18:56:33] #124: (MH) O:(s|S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 [19:02:16] (03PS5) 10MarkTraceur: Refactor button things into a separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 [19:02:22] (03CR) 10MarkTraceur: "Rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 (owner: 10MarkTraceur) [19:02:46] (03CR) 10jenkins-bot: [V: 04-1] Refactor button things into a separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 (owner: 10MarkTraceur) [19:04:36] (03PS1) 1001tonythomas: Fix z-index on popup [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/112044 [19:05:44] (03CR) 1001tonythomas: "Couldnt test in my localhost. But as per https://bugzilla.wikimedia.org/show_bug.cgi?id=61023#c1" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/112044 (owner: 1001tonythomas) [21:06:59] (03PS6) 10MarkTraceur: Refactor button things into a separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 [21:07:03] Betterpatch, yay [21:07:32] (03CR) 10jenkins-bot: [V: 04-1] Refactor button things into a separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 (owner: 10MarkTraceur) [21:07:44] Hm, not better enough [21:08:09] (03CR) 10MarkTraceur: Refactor button things into a separate class (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 (owner: 10MarkTraceur) [21:12:36] (03PS11) 10Gergő Tisza: Track detailed content loading network performance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [21:18:12] (03CR) 10Gergő Tisza: [C: 032] "Monster rebase, with some files being rewritten in one branch and split into smaller files in the other. I'm going to merge this to get ou" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [21:18:43] (03Merged) 10jenkins-bot: Track detailed content loading network performance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [21:27:18] (03PS1) 10Gergő Tisza: Fix perf log type for userinfo [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112071 [21:27:57] (03CR) 10Gergő Tisza: [C: 032] "Self-merging, trivial fix." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112071 (owner: 10Gergő Tisza) [21:28:34] (03Merged) 10jenkins-bot: Fix perf log type for userinfo [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112071 (owner: 10Gergő Tisza) [21:31:30] #200: (F) S:IA|P:Ch|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/200 [21:37:31] (03PS6) 10Gergő Tisza: Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 [21:39:00] (03CR) 10Gergő Tisza: [C: 04-1] "Just a rebase, comments still need fixing." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 (owner: 10Gergő Tisza) [22:09:37] (03PS7) 10MarkTraceur: Refactor button things into a separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 [22:09:44] Additional refactoring, tests passing [22:09:45] Huzzah [22:26:30] #147: (MH) O:MH|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/147 [23:05:47] (03PS1) 10Gergő Tisza: Add license to test images [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112137 [23:28:03] So I think I'm going to pull all of the file reuse things into one patch [23:28:11] It seems stupid to do them all piecemeal [23:29:32] #148: (MH) O:MH|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [23:33:51] (03CR) 10Cmcmahon: [C: 032] "updated by request of Commons admins" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112137 (owner: 10Gergő Tisza) [23:33:59] (03Merged) 10jenkins-bot: Add license to test images [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112137 (owner: 10Gergő Tisza)