[00:31:28] fabriceflorin, pginer, would it maybe be useful to have a similar interface to the embed buttons (HTML/Wikitext) in the share pane, for deciding between file page link and original file? [00:31:43] 'cause that would super make things easier I think [00:32:56] The problem is to communicate the meaning of the options [00:33:19] Hrm. [00:33:23] OK, back to just one choice then [00:38:22] rdwrer: I think it's best to keep things simple in the Share panel initially. We can add more functionality if users ask for it, but less is more for the casual users :) [00:38:32] Righto [00:40:07] Note that I have renamed the 'Share this file' card #147 to be 'Use this file', since it describes the entire panel and the button we use to call it up. I also updated it with more details about as discussed in our meeting: [00:40:07] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/147 [00:40:56] And I updated the 'Embed files' card #148 with recommended contents to be displayed next to the embedded images: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [00:42:07] This card includes recommended HTML and Wikitext code. I believe this will address the needs of content creators more effectively than we do now, which leads to constant complaints from community members. Even if editors end up not using the required attributions, they have no excuse not to provide them, as they would now truly embedded along with the image, as long as they use the proposed code. [00:44:14] rdwrer pginer : I just sent you guys an email summarizing all these proposed specs for Use, Embed and Download attributions. Let me know if they work for you, from both design and development perspectives. [01:14:21] (03PS1) 10Gergő Tisza: Fix runaway prev/next issue [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112617 [01:41:25] (03PS15) 10Gergő Tisza: Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 [02:03:12] Hm, I guess I should start doing things like inheriting oojs-ui classes in our UI classes! [02:03:38] Though that should maybe be a later patch [02:05:16] rdwrer: Details. :-) [02:06:30] Yeah [02:06:39] Just getting it working, and using the oojs-ui stuff, is priority [02:08:08] * James_F nods. [02:09:19] James_F: Ugh, Trevor left? [02:09:24] I had t3h questions. [02:10:04] rdwrer: Yeah, he was summoned by his better half. [02:10:07] rdwrer: (Not Roan.) [02:10:16] I was about to say [02:10:19] Arright [02:10:26] Can ask tomorrow I suppose [02:10:56] Mostly just a matter of which classes are actually useful [02:11:01] There are a lot of them [02:14:32] Yeah. [02:14:36] Seen the demo? [02:14:42] James_F: Hahahah, I get massive errors when I pull Roan's patch [02:14:53] I saw the demo page, yeah [02:14:53] Yeah, I need to fix it. :-( [02:14:59] demos/widgets.html or whatever [02:15:00] Demo page has useful classes. [02:15:08] But only widget ones [02:15:16] I want to have bigger interfaces too [02:15:20] Ones I don't have to buiiiild [02:15:36] Timo's meant to be working on those. :-) [02:15:47] Ah. [02:15:58] * rdwrer continues building interfaces then [02:16:10] Layouts and dialogs and… [02:16:36] Well so [02:16:37] https://lh4.googleusercontent.com/q2uafYtSIdk_9Tg-RLDnOvAqUOHtd1_mLlh8TJk0rMiskCdnctpD4VBjOUWCWgJSISucamZD37mo6LFbYDZhvxEST8b92d8ZORn4Us1oRB3WTz-jWlpTRDhUZA [02:16:44] The pane in the bottom right [02:17:13] You mean the wikitext box? [02:17:25] I'm using ButtonSelectWidgets for the share/download/embed things (with loads of styling), and different input widgets for the rest of the content, but the actual *panel*...it's not clear what to use for that [02:17:33] Maybe Layout, but I'm not sure, there's not really a demo [02:17:47] Oh, yeah. Blame Krinkle. [02:17:51] I will [02:17:53] Constantly [02:17:57] Good man. [02:18:01] Also, he should be in here. [02:18:17] *shrug* not super important, I know where to find him [02:18:22] tinc etc etc [02:18:29] Kk. [07:53:10] (03CR) 10Gilles: [C: 032] Fix runaway prev/next issue [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112617 (owner: 10Gergő Tisza) [07:53:48] (03Merged) 10jenkins-bot: Fix runaway prev/next issue [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112617 (owner: 10Gergő Tisza) [08:33:07] (03CR) 10Gilles: [C: 04-1] Add TaskQueue class (037 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112581 (owner: 10Gergő Tisza) [08:58:11] (03CR) 10Gilles: [C: 04-1] Preload prev/next images (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 (owner: 10Gergő Tisza) [13:02:50] (03PS11) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [13:02:53] (03CR) 10jenkins-bot: [V: 04-1] Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [13:07:55] (03PS12) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [13:25:49] (03PS1) 10Gilles: Get rid of lightboxHooks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112670 [13:35:32] (03CR) 10Gilles: "I meant that the spinner at the top-right is useless, but the progress bar is definitely useful." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111688 (owner: 10Aarcos) [14:14:39] (03PS1) 10Zfilipin: Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112676 [14:24:09] (03PS2) 10Gilles: WIP Prototype low to hight resolution transition. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111688 (owner: 10Aarcos) [14:24:11] (03CR) 10jenkins-bot: [V: 04-1] WIP Prototype low to hight resolution transition. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111688 (owner: 10Aarcos) [15:04:33] (03PS3) 10Gilles: WIP Prototype low to hight resolution transition. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111688 (owner: 10Aarcos) [15:04:35] (03CR) 10jenkins-bot: [V: 04-1] WIP Prototype low to hight resolution transition. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111688 (owner: 10Aarcos) [18:08:28] (03CR) 10Jhall: [C: 032] Added basic readme file to test/browser folder [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112453 (owner: 10Zfilipin) [18:09:47] (03CR) 10Jhall: [C: 031] Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112676 (owner: 10Zfilipin) [18:09:57] (03Merged) 10jenkins-bot: Added basic readme file to test/browser folder [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112453 (owner: 10Zfilipin) [18:11:53] gi11es-away: Did you get attention from ops about image pre-loading? [19:03:35] (03CR) 10Gergő Tisza: [C: 031] "Looks good, haven't tested." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112670 (owner: 10Gilles) [19:09:09] gi11es-away: FYI I talked about the pre-loading business in the scrum of scrums, Faidon said he needs more time [19:33:02] (03PS16) 10Gergő Tisza: Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 [19:33:04] (03PS3) 10Gergő Tisza: Add TaskQueue class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112581 [19:33:06] (03PS1) 10Gergő Tisza: Preload fullscreen image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 [19:50:53] Huh, turns out the message nastiness isn't as bad as I thought it would be. Huzzah! [20:41:23] (03PS4) 10Gergő Tisza: Add TaskQueue class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112581 [20:59:35] (03CR) 10Mattflaschen: "Some old comments that I had in draft." (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84344 (owner: 10Rahul21) [21:53:07] (03PS5) 10Gergő Tisza: Add TaskQueue class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112581 [21:53:38] (03CR) 10Gergő Tisza: Add TaskQueue class (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112581 (owner: 10Gergő Tisza) [21:53:53] (03PS17) 10Gergő Tisza: Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 [21:54:04] (03PS2) 10Gergő Tisza: Preload fullscreen image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 [22:37:18] Is anyone else seeing the "mw.mmv.performance is not a constructor" message on like every third page load? [23:07:26] tgr: Have you seen "mw.mmv.performance is not a constructor" at all? [23:07:49] no [23:08:01] missing dependency? [23:08:46] i use debug mode and filter heavily so i might have missed the warning [23:08:48] Maybe so [23:08:55] but the performance library works for me [23:08:57] I only get it in debug mode, I think [23:09:29] It may be we're using it in a dependency of mmv that doesn't have it listed