[01:59:56] (03PS18) 10Gergő Tisza: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [02:00:58] (03CR) 10Gergő Tisza: "A few minor code layout fixes." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [02:04:50] (03CR) 10Gergő Tisza: [C: 031] "Nice work, Anu! I think the current code is fine; next step is to set up a prototype for this and followup patches, and get feedback on ho" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [02:30:43] (03PS13) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [02:32:20] (03CR) 10Gergő Tisza: [C: 032] "Only rebases since previous +2." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 (owner: 10Inchikutty) [07:59:56] #118: (P) For close icon we can use: https://www.dropbox.... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118 [08:18:57] #210: (GD) O:GD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/210 [08:18:57] #210: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/210 [08:26:02] (03PS1) 10Gilles: Hide mouse cursor when buttons are faded out in fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113921 [08:26:56] #210: (GD) https://gerrit.wikimedia.org/r/113921 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/210 [08:26:56] #210: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/210 [08:31:56] #213: (GD) S:ID|O:GD|P:Ch|R:#Q|I:#F2-S2|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/213 [08:37:54] (03PS1) 10Gergő Tisza: Switch to core's version of moment.js [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113922 [08:47:32] tgr: Seems mergeable, are we go? [08:47:40] Minimal amount of time with weird cross-repo state [08:48:24] yes, thx [08:48:54] module name is different though, so there should be no conflict either way [08:49:09] Right [08:49:15] But still, weird juxtaposition [08:49:33] (03CR) 10MarkTraceur: [C: 032] Switch to core's version of moment.js [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113922 (owner: 10Gergő Tisza) [08:49:41] 'kay, [08:50:07] (03Merged) 10jenkins-bot: Switch to core's version of moment.js [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113922 (owner: 10Gergő Tisza) [08:50:56] #142: (GT) This one reported by YuviPanda: https://dpaste... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 [09:01:57] (03PS1) 10Gilles: Make metadata animation more subtle [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113929 [09:02:56] #213: (GD) https://gerrit.wikimedia.org/r/113929 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/213 [09:02:56] #213: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/213 [09:32:55] #202: (GD) O:GD|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/202 [09:35:55] #202: (GD) N:Saammuf -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/202 [09:36:55] #202: (GD) Actually the issue isn't that author and source... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/202 [10:47:00] (03PS1) 10Gilles: Reduce Wikidata author vcard to creator part [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113937 [10:47:55] #202: (GD) https://gerrit.wikimedia.org/r/113937 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/202 [10:48:55] #202: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/202 [11:53:54] (03CR) 10Mdale: [C: 032 V: 032] "looks good." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108646 (owner: 10Brian Wolff) [12:45:55] #146: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [13:22:55] #214: (GD) O:GD|SP:0|S:ID|R:#Q|I:#F2-S2|T:SI( Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/214 [13:24:55] #146: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [14:01:55] #146: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [14:01:55] #146: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [14:33:54] #146: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [14:55:55] #146: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [14:55:55] #146: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [14:55:55] #146: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [15:02:57] (03PS1) 10Gilles: Blurred thumbnail preview + progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 [15:03:55] #146: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [15:04:02] (03CR) 10jenkins-bot: [V: 04-1] Blurred thumbnail preview + progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 (owner: 10Gilles) [15:26:07] (03PS1) 10Gilles: Make the image and navigation buttons unselectable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113970 [15:26:55] #214: (GD) https://gerrit.wikimedia.org/r/113970 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/214 [15:26:55] #214: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/214 [15:29:13] (03PS1) 10Rillke: Typography [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/113971 [15:37:30] (03PS2) 10Gilles: Blurred thumbnail preview + progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 [15:57:06] (03PS2) 10Nemo bis: Typography [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/113971 (owner: 10Rillke) [16:00:48] (03CR) 10M4tx: [C: 031] Typography [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/113971 (owner: 10Rillke) [16:01:32] (03CR) 10Yuvipanda: [C: 032] Typography [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/113971 (owner: 10Rillke) [16:01:42] (03Merged) 10jenkins-bot: Typography [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/113971 (owner: 10Rillke) [17:06:24] (03PS1) 10Aude: Fix compatibility of ApiTestCaseVideoUpload with ApiTestCase [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/113985 [17:51:06] (03CR) 10Hoo man: [C: 032] "Trivial one :)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/113985 (owner: 10Aude) [17:51:09] (03Merged) 10jenkins-bot: Fix compatibility of ApiTestCaseVideoUpload with ApiTestCase [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/113985 (owner: 10Aude) [18:27:01] great news: my buddy chase is going to join the ops team [18:27:42] Huzzah! [18:27:43] :-) [18:28:04] What does that bring us back up to - 3 opsen? :P [18:28:26] 16ish :P [18:28:36] ...better. [18:28:47] There were so many /parts recently, I wasn't sure [18:29:23] (03CR) 10Gergő Tisza: "Looks good to me, but IMO it would be better to the vcard cleaning on the API side, so that other projects can benefit as well (see bug 57" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113937 (owner: 10Gilles) [18:38:21] gi11es: Did Faidon reply helpfully enough that I can remove the blocker on them? [18:38:33] nope [18:38:59] 'kay, will bitch about it more then. [18:39:03] I still need an official yay or nay on pregenerating thumbs [18:39:39] oh, he replied 12 minutes ago... I didn't notice [18:40:00] Heh [18:40:16] Toooo slowwww [18:40:28] answer is satisfactory, we can remove the blocker [18:40:36] Oh, 'kay [18:41:43] Done and done [19:04:43] tgr: are we in charge of that API? I didn't explore that path because I didn't know if others relied on the full-form vcards in those API results [19:05:59] gi11es: yes, it's from CommonsMetadata, which is the MM team's project to make image metadata like attribution available [19:06:30] cool, then I'll try to clean up the vcards on the other end as another changeset [19:06:55] i'm not sure whether anyone actually relies on it... several people were interested, but i haven't heard of people actually using it yet [19:07:27] still, i think it makes sense, and CMD also uses DOM parsing, so the effort is not much larger [19:39:19] (03PS2) 10Gergő Tisza: Make the image and navigation buttons unselectable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113970 (owner: 10Gilles) [19:39:33] (03CR) 10Gergő Tisza: "Spaces to tabs" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113970 (owner: 10Gilles) [19:42:12] (03CR) 10Gergő Tisza: [C: 032] "Great idea! That was annoying indeed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113970 (owner: 10Gilles) [19:42:45] (03Merged) 10jenkins-bot: Make the image and navigation buttons unselectable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113970 (owner: 10Gilles) [21:08:13] WAT. [21:08:19] The avatars are creepy [21:41:42] (03PS11) 10Inchikutty: [WIP] UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 [21:57:32] (03CR) 10Gergő Tisza: "The progress bar doesn't show up for me." (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 (owner: 10Gilles) [21:57:53] (03CR) 10Gergő Tisza: [C: 04-1] Blurred thumbnail preview + progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 (owner: 10Gilles) [22:11:35] (03PS21) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [22:17:53] (03PS1) 10Aarcos: Fix failing test after refactoring. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114087 [22:24:08] * rdwrer reviews the lazy-load patch [22:25:00] (03PS12) 10Inchikutty: [WIP] UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 [22:45:13] Hm [22:45:38] gi11es: It's a stupid use case, but multiple images on the same page with different captions will be unaddressable after your patch [22:45:42] I'm cool with that, just hope you know [22:48:53] (03CR) 10Gergő Tisza: [C: 032] "Thanks! Didn't think that one through." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114087 (owner: 10Aarcos) [22:49:25] (03Merged) 10jenkins-bot: Fix failing test after refactoring. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114087 (owner: 10Aarcos) [22:53:56] #148: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [22:54:45] fabriceflorin: ^^ thanks for that - are we saying "no other sizes" for wikitext? (I'm a fan of this idea) [22:57:01] rdwrer: You're welcome. I would still recommend including the sizes for wikitext, because we want to encourage editors to be bold and use images more creatively, in different sizes. This feature would make it easy for them to experiment. [22:58:04] rdwrer: Of course, if this is making life really hard for you, this is not a hard requirement, but a nice touch to invite more creativity on our sites :) [22:59:29] I mean [22:59:47] fabriceflorin: tgr's mail sums it up...we want to give people more options, but that support doesn't currently exist in the software [23:00:04] Like...ugh, let me pull up the bloody vision doc and show you [23:01:02] https://docs.google.com/a/wikimedia.org/presentation/d/1iK9LnokNbTIEwCI1x4Vt6ZJULiayaxSydJ7AcvbPTUE/edit#slide=id.g29711edf5_11 [23:01:05] Right [23:01:06] Pretty! [23:01:09] I like the idea [23:01:16] But we don't do anything that would let people do this yet [23:01:25] No grid system, no slots for images [23:01:38] We need to build that before telling the community to go nuts with different image sizes [23:02:10] And even then it won't be the same...we'll have VE then, and integration with it for inserting images via a URL (I hope), plus the sizes look like they'll pretty much be set [23:02:27] People who really want to mess with image sizes can take the thumbnail code and modify it themselves, they're smart [23:03:44] Do what makes sense for you, we can do this in stages. [23:03:51] 'kay. [23:04:13] In a meeting now, so can't respond for about an hour. But I trust you guys to do the right thing. We keep each other honest :) [23:15:43] (03PS1) 10Aarcos: Get rid of mw.mmvTestHelpers.resetViewer() [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114098 [23:31:14] (03PS4) 10MarkTraceur: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 [23:31:58] (03CR) 10jenkins-bot: [V: 04-1] WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [23:44:28] (03CR) 10MarkTraceur: "Little issues, will test, fix, and merge maybe!" (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113786 (owner: 10Gilles) [23:49:30] https://gerrit.wikimedia.org/r/#/c/113759/ is quite an interesting idea [23:51:36] Whoa cool [23:53:56] (03PS3) 10MarkTraceur: Lazy-load mmv [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113786 (owner: 10Gilles) [23:53:58] (03CR) 10jenkins-bot: [V: 04-1] Lazy-load mmv [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113786 (owner: 10Gilles) [23:54:05] The lazy-load patch is going in, everyone hang...on...to...CRAP. [23:55:22] OK now actually. [23:55:23] (03PS4) 10MarkTraceur: Lazy-load mmv [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113786 (owner: 10Gilles) [23:55:37] (03CR) 10MarkTraceur: "Big money big money no whammy no whammy" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113786 (owner: 10Gilles) [23:57:00] Woohoo. [23:57:24] (03CR) 10MarkTraceur: [C: 032] Lazy-load mmv [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113786 (owner: 10Gilles) [23:57:43] * rdwrer crosses fingers [23:57:58] (03Merged) 10jenkins-bot: Lazy-load mmv [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113786 (owner: 10Gilles) [23:58:33] Ugh [23:58:36] Docs are messed up [23:59:55] #136: (MH) DDE:1F2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136