[00:20:38] (03CR) 10Aarcos: "Except for the suggestion below the rest looks very good." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113312 (owner: 10Gergő Tisza) [00:23:39] #221: (F) S:IA|P:Sh|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/221 [00:25:57] (03CR) 10Aarcos: [C: 031] "This looks good to me, you can merge at your convenience providing no one else has other objections." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 (owner: 10Gergő Tisza) [00:31:39] #148: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [00:32:43] #148: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [00:34:40] #220: (F) SP:0 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/220 [00:35:39] #218: (F) SP:0 Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/218 [00:36:39] #219: (F) SP:0 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/219 [00:43:42] #222: (F) S:IA|P:Sh|ES:#MVF|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/222 [00:44:42] #210: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/210 [00:46:59] #222: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/222 [01:07:18] Do we have a test SVG with black on transparency? [01:10:06] File:Piratey transparent background.svg [01:12:39] #223: (F) S:IA|P:Sh|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/223 [01:14:39] #224: (AA) P:Mh|R:#Q|T:B Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/224 [01:35:38] #225: (F) S:IA|P:Sh|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/225 [01:38:38] #226: (F) S:IA|P:Ch|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/226 [01:39:38] #225: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/225 [01:49:38] #227: (F) S:IA|P:Ch|ES:#MVF|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/227 [01:50:39] #8: (e) PC:0 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/8 [01:52:38] #228: (F) S:IA|P:Ch|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/228 [02:00:38] #229: (F) S:IA|P:Mh|ES:#MVF|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/229 [02:07:38] #230: (F) S:IA|P:Mh|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/230 [02:49:11] (03PS1) 10Aarcos: Improve e2e tests to check metadata content [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114398 [02:52:39] #119: (AA) https://gerrit.wikimedia.org/r/#/c/114398 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/119 [03:05:38] #231: (F) S:IA|P:Mh|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/231 [03:06:06] (03CR) 10Gergő Tisza: "Shouldn't most of this be in Gherkin? You loose much of the benefit of being BDD if non-coders cannot check what the tests do." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114398 (owner: 10Aarcos) [03:10:37] #232: (GT) P:Sh|S:IA|R:#Q|T:Td Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [03:10:38] #232: (GT) P:Mh -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [03:11:38] #233: (GT) P:Mh|S:IA|R:#Q|T:Td Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/233 [03:24:21] (03PS1) 10Gergő Tisza: Use cross-origin img attribute instead of data URI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 [03:24:23] (03CR) 10jenkins-bot: [V: 04-1] Use cross-origin img attribute instead of data URI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 (owner: 10Gergő Tisza) [03:30:13] (03PS2) 10Gergő Tisza: Use cross-origin img attribute instead of data URI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 [03:33:38] #207: (GT) https://gerrit.wikimedia.org/r/#/c/114403/ -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/207 [03:34:38] #207: (GT) I'll create a new card for that. -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/207 [03:37:38] #234: (GT) O:GT|P:Mh|S:ACR|R:#Q|I:#F2-S2|T:Td Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/234 [03:55:37] #234: (GT) R:(s|I:(s|T:SI( -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/234 [03:55:37] #234: (GT) RS:#UdUtartsi -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/234 [03:55:37] #234: (GT) PiG:1 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/234 [03:56:37] #234: (GT) R:#Q -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/234 [03:56:37] #234: (GT) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/234 [08:12:55] (03CR) 10Gilles: [C: 04-1] Use cross-origin img attribute instead of data URI (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 (owner: 10Gergő Tisza) [08:17:12] (03CR) 10Gilles: [C: 032] Preload fullscreen image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 (owner: 10Gergő Tisza) [08:17:14] (03CR) 10jenkins-bot: [V: 04-1] Preload fullscreen image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 (owner: 10Gergő Tisza) [08:20:01] (03CR) 10Gilles: Avoid double requests when measuring performance of image load (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113130 (owner: 10Gilles) [08:24:41] (03CR) 10Gilles: [C: 032] Fix fileUsage test breaking behavior [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114361 (owner: 10Gergő Tisza) [08:25:20] (03CR) 10jenkins-bot: [V: 04-1] Fix fileUsage test breaking behavior [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114361 (owner: 10Gergő Tisza) [08:29:23] (03PS2) 10Gilles: Fix fileUsage test breaking behavior [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114361 (owner: 10Gergő Tisza) [08:29:38] (03CR) 10Gilles: [C: 032] Fix fileUsage test breaking behavior [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114361 (owner: 10Gergő Tisza) [08:31:27] (03CR) 10jenkins-bot: [V: 04-1] Fix fileUsage test breaking behavior [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114361 (owner: 10Gergő Tisza) [08:33:48] (03PS3) 10Gilles: Fix fileUsage test breaking behavior. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114361 (owner: 10Gergő Tisza) [08:34:35] (03CR) 10Gilles: [C: 032] Fix fileUsage test breaking behavior. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114361 (owner: 10Gergő Tisza) [08:35:12] (03Merged) 10jenkins-bot: Fix fileUsage test breaking behavior. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114361 (owner: 10Gergő Tisza) [08:36:43] (03CR) 10Gilles: [C: 032] Get article path for foreign DB repos too [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114188 (owner: 10MarkTraceur) [08:38:05] (03Merged) 10jenkins-bot: Get article path for foreign DB repos too [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114188 (owner: 10MarkTraceur) [08:40:37] #217: (GD) Make sure to say 'Uploaded by', so people don'... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/217 [08:41:38] #217: (GD) S:R -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/217 [08:44:25] (03PS7) 10Gilles: Preload fullscreen image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 (owner: 10Gergő Tisza) [08:45:19] (03CR) 10Gilles: [C: 032] Preload fullscreen image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 (owner: 10Gergő Tisza) [08:45:37] #208: (GD) O:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/208 [08:45:56] (03Merged) 10jenkins-bot: Preload fullscreen image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 (owner: 10Gergő Tisza) [08:46:37] #208: (GD) DDE:2F2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/208 [08:46:37] #208: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... O:GD|DTS:2F2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/208 [08:47:37] #126: (GD) B:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126 [08:48:38] #126: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... O:GD|DTS:2F2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126 [08:50:38] #154: (GD) B:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/154 [08:51:38] #154: (GD) Discussed with Faidon S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/154 [08:51:38] #154: (GD) DDE:2F2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/154 [08:51:38] #154: (GD) Conclusion is to revisit the pergeneration ques... DTS:2F2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/154 [08:52:38] #154: (GD) S:A -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/154 [08:52:38] #154: (GD) Discussion happened, nothing actionable right n... DTE:2F2|S:RfS -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/154 [08:54:37] #185: (GD) Is this still true? I have a feeling this was c... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/185 [08:57:38] #188: (GD) S:IA Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/188 [08:57:38] #224: (GD) S:IA -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/224 [08:58:37] #38: (GD) S:IA -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/38 [08:58:37] #215: (GD) S:IA -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/215 [08:59:37] #216: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/216 [08:59:37] #216: (GD) S:IA -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/216 [09:00:37] #70: (GD) S:IA -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/70 [09:34:59] (03PS1) 10Gilles: Fix preloadFullscreenThumnail breakage [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114443 [09:36:18] (03CR) 10Gilles: [C: 032] "Self-approval because this significantly breaks beta at the moment. Can be revisited if the code isn't correct/ideal." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114443 (owner: 10Gilles) [09:36:53] (03CR) 10Gilles: "Sorry for the one-line commit message, I was doing this in a hurry and didn't notice." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114443 (owner: 10Gilles) [09:36:58] (03Merged) 10jenkins-bot: Fix preloadFullscreenThumnail breakage [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114443 (owner: 10Gilles) [09:40:37] #235: (GD) S:IA|P:Sh|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/235 [10:04:38] #236: (GD) S:IA|P:Mh|R:#Q|T:B Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/236 [10:12:38] #237: (GD) S:IA|P:Ch|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/237 [10:15:38] #79: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79 [10:19:39] #238: (GD) S:IA|P:Ch|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/238 [10:27:38] #148: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [10:33:38] #240: (GD) S:IA|P:Mh|R:#Q|T:B Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/240 [10:35:40] #241: (GD) S:IA|P:Ch|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/241 [10:41:38] #242: (GD) S:IA|P:Mh|R:#Q|T:B Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/242 [10:58:39] #243: (GD) S:IA|P:Sh|R:#Q|T:B Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/243 [11:17:38] #234: (GD) S:R -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/234 [11:54:17] (03CR) 10Ori.livneh: "\o/" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113786 (owner: 10Gilles)