[01:55:43] (03CR) 10Gergő Tisza: [C: 032] Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116128 (owner: 10Inchikutty) [01:57:34] (03Merged) 10jenkins-bot: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116128 (owner: 10Inchikutty) [02:13:28] (03CR) 10Gergő Tisza: [C: 04-1] Embedding leaflet maps based on OSM data to UploadWizard (032 comments) [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [04:15:05] (03CR) 10Aarcos: [C: 04-1] Add test for clicking prev/next (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116079 (owner: 10Gilles) [06:02:32] #276: (GT) P:Sh|S:IA|I:#B|T:Td Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/276 [06:05:31] #276: (GT) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/276 [06:05:47] (03CR) 10Gergő Tisza: Add test for clicking prev/next (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116079 (owner: 10Gilles) [08:12:26] (03CR) 10Gilles: Add test for clicking prev/next (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116079 (owner: 10Gilles) [08:27:34] (03PS2) 10Gilles: Add test for clicking prev/next [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116079 [08:27:37] (03CR) 10Gilles: Add test for clicking prev/next (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116079 (owner: 10Gilles) [08:33:16] (03PS2) 10Gilles: Add events for image views and "use this file" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116072 [09:47:16] rdwrer: first time I see something hosted on gitorious, is it because the analytics team uses it and you've cloned a sample project? [09:57:04] rdwrer: also, http://multimedia-metrics.wmflabs.org is blank now. I'm asking analytics for limn0 access [10:02:31] #274: (GD) I:#F2-S4 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/274 [10:02:31] #274: (GD) O:GD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/274 [10:02:31] #274: (GD) S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/274 [10:23:32] #167: (P) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/167 [11:25:57] (03PS1) 10Gilles: Test to check that events are not trapped after the viewer is closed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116470 [11:27:31] #274: (GD) https://gerrit.wikimedia.org/r/116470 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/274 [11:27:31] #274: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/274 [13:48:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [13:52:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [14:03:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [14:25:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [14:25:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [14:27:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [14:28:30] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [14:31:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [14:33:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [14:51:30] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [14:52:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [14:53:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [14:56:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [15:23:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [15:23:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [15:32:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [15:38:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [15:46:32] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [15:57:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [15:58:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [16:17:19] (03PS1) 10Gilles: Network performance measurement CORS improvements [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116491 [16:19:31] #232: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [16:19:31] #232: (GD) https://gerrit.wikimedia.org/r/116491 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [17:03:31] #261: (P) I would like also to avoid users thinking the f... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/261 [17:20:31] #270: (P) I think it makes sense as a continuation of the... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/270 [17:23:31] #199: (P) I would present this as a simple expand actio... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/199 [17:28:32] (03PS1) 10MarkTraceur: Clear registered events on unattach [extensions/MultimediaViewer] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116504 [17:29:18] (03CR) 10MarkTraceur: [C: 032] Clear registered events on unattach [extensions/MultimediaViewer] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116504 (owner: 10MarkTraceur) [17:29:56] (03Merged) 10jenkins-bot: Clear registered events on unattach [extensions/MultimediaViewer] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116504 (owner: 10MarkTraceur) [17:33:09] (03PS1) 10MarkTraceur: Create fake user when userinfo request fails [extensions/MultimediaViewer] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116506 [17:33:32] (03CR) 10MarkTraceur: [C: 032] Create fake user when userinfo request fails [extensions/MultimediaViewer] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116506 (owner: 10MarkTraceur) [17:33:50] (03PS1) 10MarkTraceur: Fix JS error happening when closing "use this file" dialog [extensions/MultimediaViewer] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116507 [17:33:59] (03CR) 10MarkTraceur: [C: 032] Fix JS error happening when closing "use this file" dialog [extensions/MultimediaViewer] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116507 (owner: 10MarkTraceur) [17:34:10] tgr: Deploying these now [17:34:18] If there's anything you want to sneak in under the wire [17:34:19] (03Merged) 10jenkins-bot: Create fake user when userinfo request fails [extensions/MultimediaViewer] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116506 (owner: 10MarkTraceur) [17:34:19] We can [17:34:25] Just...it should be important [17:34:40] cool [17:35:05] no, these two and the keydown unattach are the only two I can think of [17:35:25] (03Merged) 10jenkins-bot: Fix JS error happening when closing "use this file" dialog [extensions/MultimediaViewer] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116507 (owner: 10MarkTraceur) [17:35:36] 'kay [17:46:37] (03PS10) 10MarkTraceur: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 [17:46:48] (03CR) 10jenkins-bot: [V: 04-1] WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [18:01:09] Are there any other fires [18:01:10] Because [18:01:19] I don't want our product to burn down while I get dressed [18:08:56] Hi everyone [18:09:24] apsdehal: Morning! How are you? [18:11:29] I am fine, It long I haven't been here. [18:11:47] apsdehal: It happens :0 [18:11:48] :)* [18:12:31] Sure you guys have done a lot development past days. Cheers to you all [18:13:15] apsdehal: Yeah, lots of stuff happens when you have 5-6 people working on an extension :) [18:13:29] (03CR) 10Aarcos: [C: 031] "Looks good to me, merge at you convenience providing the other have no issues left." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116079 (owner: 10Gilles) [18:16:37] Yes will see to further contribute to project, [18:18:31] apsdehal: You're always welcome to :) [18:19:33] (03CR) 10Aarcos: [C: 031] "Just a small typo, otherwise LGTM. Merge at your convenience." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116072 (owner: 10Gilles) [19:55:27] (03PS2) 10Aarcos: Test to check that events are not trapped after the viewer is closed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116470 (owner: 10Gilles) [19:56:06] (03CR) 10Aarcos: Test to check that events are not trapped after the viewer is closed (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116470 (owner: 10Gilles) [19:56:31] (03CR) 10Aarcos: "Made some small changes based on my comments, feel free to merge if you agree with them." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116470 (owner: 10Gilles) [19:56:33] (03CR) 10jenkins-bot: [V: 04-1] Test to check that events are not trapped after the viewer is closed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116470 (owner: 10Gilles) [21:36:25] (03PS1) 10Gergő Tisza: Add rejection logging to providers [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116628 [21:36:27] (03PS1) 10Gergő Tisza: [WIP] Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 [21:37:02] (03CR) 10jenkins-bot: [V: 04-1] Add rejection logging to providers [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116628 (owner: 10Gergő Tisza) [21:37:31] #268: (GT) https://gerrit.wikimedia.org/r/#/c/116628/ -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/268 [21:37:31] #268: (GT) S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/268 [21:37:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [21:43:49] (03PS2) 10Gergő Tisza: [WIP] Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 [21:43:51] (03PS2) 10Gergő Tisza: Add rejection logging to providers [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116628 [21:44:31] #271: (GT) B:B -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/271 [21:55:05] (03CR) 10Gergő Tisza: [V: 032] Network performance measurement CORS improvements [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116491 (owner: 10Gilles) [21:55:15] Argh [21:55:27] Refactor...was mostly effective but still frustratingly large [21:55:37] (03PS11) 10MarkTraceur: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 [21:55:39] (03CR) 10jenkins-bot: [V: 04-1] WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [21:55:46] Hm, test [21:55:47] s. [21:56:31] #232: (GT) DDE:0M2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [21:58:36] (03CR) 10Gergő Tisza: [C: 032] Network performance measurement CORS improvements [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116491 (owner: 10Gilles) [21:59:13] (03Merged) 10jenkins-bot: Network performance measurement CORS improvements [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116491 (owner: 10Gilles) [22:35:26] (03PS12) 10MarkTraceur: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 [22:35:36] aarcos: I am officially passing this off, if you want to write tests for it [22:35:54] (03PS13) 10MarkTraceur: Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 [22:35:56] (03CR) 10jenkins-bot: [V: 04-1] Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [22:36:03] rdwrer: ACK ! [22:36:11] Oh, hm, failures [22:36:14] I will fix those [22:36:23] (03CR) 10jenkins-bot: [V: 04-1] Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [22:36:27] tx ! [22:36:56] I will take over, no worries, ;-). [22:37:04] They're fast fixes [23:07:31] #178: (GT) S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/178 [23:07:31] #178: (GT) I:#F2-S4 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/178 [23:44:42] (03PS14) 10MarkTraceur: Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 [23:46:29] (03CR) 10jenkins-bot: [V: 04-1] Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [23:55:48] (03PS15) 10MarkTraceur: Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 [23:55:52] Finally [23:56:04] aarcos: There may be remaining useful refactoring, definitely need more tests [23:56:07] All yours [23:56:13] * rdwrer goes to stat1 to do some effing analytics [23:56:26] ack [23:57:02] (03CR) 10jenkins-bot: [V: 04-1] Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [23:57:14] ...wat [23:57:31] #147: (MH) https://gerrit.wikimedia.org/r/112928 Also i... S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/147 [23:57:34] I am not going to fix this maybe [23:58:24] Unless it's like [23:58:27] Blatantly my fault [23:58:31] #148: (MH) https://gerrit.wikimedia.org/r/112928 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [23:58:44] jslint and doc-test [23:58:46] ALl yours