[00:03:27] (03CR) 10Gergő Tisza: [WIP] Handle image loading rejections (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [00:31:31] rdwrer: Brilliant plan? [00:31:38] Yeah [00:31:44] It's, um, top-loading mmv.bootstrap [00:31:51] Unrelated to other things basically [00:31:57] But will help with some parts of embed/share [00:32:13] rdwrer: Oh, OK. Congrats on this important revelation :) [00:32:44] Yup [00:39:25] In other news, apparently we stopped using MediaViewerPerf at all. News to me? I dunno. Fixing things [00:42:16] (03PS6) 10Gergő Tisza: [WIP] Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 [00:43:42] Oh, hm. I thought the new schema was more complete than this [00:43:44] Bollocks. [00:44:55] Will deal with it tomorrow I guess [00:44:58] 'night all [01:00:42] (03CR) 10Aarcos: "Took care of some of the comments, I will continue with the others but help is always welcome, ;-)." (0312 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [01:00:55] (03PS1) 10Aarcos: Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118417 [01:01:29] (03CR) 10jenkins-bot: [V: 04-1] Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118417 (owner: 10Aarcos) [01:02:31] (03CR) 10Gergő Tisza: "I don't think IE9 should be grade A (I imagine grade A support would mean that we (will at some point) actively test for it, and try to ac" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115368 (owner: 10Pginer) [01:14:21] (03PS11) 10Aarcos: Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [01:44:00] (03CR) 10Gergő Tisza: Add share and embed panel, replace reuse (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [07:20:59] (03PS3) 10Gergő Tisza: Extract embed formatting into separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117639 [07:21:34] (03CR) 10jenkins-bot: [V: 04-1] Extract embed formatting into separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117639 (owner: 10Gergő Tisza) [07:23:26] (03PS12) 10Gergő Tisza: Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 [07:23:59] (03Abandoned) 10Gergő Tisza: Extract embed formatting into separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117639 (owner: 10Gergő Tisza) [07:24:01] (03CR) 10jenkins-bot: [V: 04-1] Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [07:27:08] (03CR) 10Gergő Tisza: "After discussing with Aaron, we squashed the children into this to avoid having to rebase all the time. They mostly just move code around," [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [07:28:58] (03CR) 10Gergő Tisza: "I am not convinced the EmbedFileInfo model is useful. It just contains most of the imageinfo and lightbox models, but not enough to make t" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [11:38:27] (03CR) 10Gilles: "I didn't mean to start a conversation about that wiki page, which Pau already said was outdated. I'm talking about this changeset and what" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115368 (owner: 10Pginer) [11:46:52] rdwrer: deleted [15:15:21] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [15:35:03] Huzzah [20:17:34] In the process of loading up new perf data [20:17:38] Hopefully it works wellish [21:04:21] (03PS5) 10Gergő Tisza: Make the panel animation more subtle [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115368 (owner: 10Pginer) [22:08:53] (03CR) 10Gergő Tisza: "Sometimes the thumbnail stucks in blurry state and the panel never appears. Not sure if it is related, but I haven't seen it before." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115368 (owner: 10Pginer) [22:29:56] (03PS6) 10Gergő Tisza: Make the panel animation more subtle [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115368 (owner: 10Pginer) [22:30:27] (03CR) 10Siebrand: "Ugh, still reviewed... Don't know where you'll be resubmitting, but please take this into account :)." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118417 (owner: 10Aarcos) [22:33:35] rdwrer: you around? [22:34:27] I am! [22:34:28] Oops [22:34:30] BRT [22:34:32] (03CR) 10Gergő Tisza: [C: 031] "Fixed #2, the other two are not issues with the code (the first might be, but it is a pain to debug, and will be hopefully much easier onc" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115368 (owner: 10Pginer) [23:24:30] wb, fabriceflorin [23:24:46] thanks, good to be here. [23:57:07] tgr, aarcos, gi11es - https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 I have found some issues with Vagrant that I need to work through, someone else should test this [23:58:35] rdwrer: what is the issue? [23:59:07] I dunno, I have to recompile my kernel or something similarly stupid [23:59:48] wow