[00:20:30] tgr: I wasn't sure we wanted to dump more JS into the world right away, figured we'd wait for another patch [00:21:57] rdwrer: i'm not sure what that is referring to [00:22:05] The client-side config patch [00:22:18] You said to take out the check for the server-side config and let the client deal with it [00:22:27] oh, ok [00:22:45] yes, that was a stupid idea [00:22:57] No, it's a good idea, just needs another patch :) [00:22:59] shpould be communicated to ambassadors and whatnot [00:23:39] True [00:23:45] also, we have #362 for it [00:23:50] more or less [00:24:00] (03PS6) 10MarkTraceur: Add client-side flag for disabling viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118774 [00:24:01] Yeah [00:24:40] (03CR) 10jenkins-bot: [V: 04-1] Add client-side flag for disabling viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118774 (owner: 10MarkTraceur) [00:25:26] *90* failed!? [00:25:36] dafuq [00:26:04] Maybe oojsui in core changed...breakingly [00:26:22] that usually happens when there is a JS error and something is not unmocked [00:26:43] I didn't change anything, though [00:27:19] probably MV gets disabled somehow [00:27:32] It looks like an oojsui change [00:27:38] Investigating in -ve [00:28:13] wrong config settings on the test server, i would say [00:28:36] since it is not a pilot wiki [00:30:01] nvm, this does seem like a VE issue [00:44:50] * rdwrer heads home [00:44:58] I'll resubmit the patch from there and see if it passes [00:47:31] tgr: Fixed, sorry for that. [01:21:31] (03PS1) 10Gergő Tisza: Get more license info [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119680 [01:22:10] (03CR) 10jenkins-bot: [V: 04-1] Get more license info [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119680 (owner: 10Gergő Tisza) [01:23:00] (03PS2) 10Gergő Tisza: Get more license info [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119680 [04:12:27] (03PS7) 10MarkTraceur: Add client-side flag for disabling viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118774 [06:42:58] hi [06:43:51] If anyone available, do reply [08:54:42] (03CR) 10Gilles: [C: 04-1] Improve embed credit line (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119554 (owner: 10Gergő Tisza) [08:56:51] (03CR) 10Gilles: "Thanks for doing that! Not sure how far you want to take it, let us know when you want it reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119639 (owner: 10Robmoen) [09:15:36] (03CR) 10Gilles: [C: 04-1] Fix some text selection issues with share/embed (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119649 (owner: 10Aarcos) [10:07:00] (03CR) 10Gilles: [C: 04-1] Get more license info (036 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119680 (owner: 10Gergő Tisza) [10:08:52] (03CR) 10Gilles: [C: 032] Add client-side flag for disabling viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118774 (owner: 10MarkTraceur) [13:55:19] (03PS1) 10Pginer: Reuse dialog styling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119746 [16:58:04] (03CR) 10Robmoen: "No worries. If this doesn't get reviewed right away, I may keep adding to it. I was hoping to continue going through the extension for t" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119639 (owner: 10Robmoen) [17:01:21] (03CR) 10MarkTraceur: "https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/UploadWizard+topic:bug/47161,n,z" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119639 (owner: 10Robmoen) [17:03:42] (03CR) 10Krinkle: [C: 04-1] "Use /*jshint instead of /*jslint." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119639 (owner: 10Robmoen) [17:11:05] (03PS1) 1001tonythomas: Removed deprecated "window.gM" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/119780 [17:19:35] (03PS2) 10Krinkle: Remove unused "window.gM" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/119780 (owner: 1001tonythomas) [17:19:38] (03CR) 10Krinkle: [C: 031] Remove unused "window.gM" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/119780 (owner: 1001tonythomas) [17:22:11] (03CR) 10Siebrand: [C: 032] "Good riddance!" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/119780 (owner: 1001tonythomas) [17:22:34] (03Merged) 10jenkins-bot: Remove unused "window.gM" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/119780 (owner: 1001tonythomas) [17:39:16] (03Abandoned) 10Robmoen: Delint and general mw.UploadWizardUpload cleanup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119639 (owner: 10Robmoen) [19:14:33] I'm going to need to triple-check, but so far it seems that on a cold cache media viewer beats opening the commons page by a large margin [19:14:47] 4.4 seconds versus 0.8 [19:15:28] with a browser at a resolution of 1280x1024 [19:15:54] in practice your cache won't be entirely cold since you are arriving to commons from another wikimedia site [19:16:56] I can simulate that [19:17:17] opening the article first in the same session [19:18:38] i think that would be more fair since opening the article does a bunch of JS caching and it is not included in the MMV time either (i suppose?) so it should not be included for Commons [19:19:09] the Commons-specific scripts which you only get when arriving there are a different question [19:21:53] btw do you think there is a way to get the metadata panel into varnish? [19:22:49] that's the big disadvantage compared to the file page (once the thumbnail rendering issue gets fixed), that it is pregenerated, while we put the lightbox together on the fly from a bunch of API calls [19:22:50] I don't know how hard that would be with our setup, it's question for ops [19:23:30] with the article pre-visit I'm getting on my latest run 1.6 seconds for page load and 1.5 for mmv [19:24:22] in mmv's case we're loading still loading the JS on demand in that run [19:24:33] still pretty good [19:24:59] yeah, I'll run my code through a fine comb to check that there's no mistake, but so far looks like our worst case scenario is as fast as the status quo [19:25:05] for a logged-in user i expect mmv would beat the file page even more, since there is no varnish caching [19:25:25] it's logged in I'm comparing, because it has to be https in both cases to be safe [19:25:34] to be fair [19:25:37] not safe [19:25:44] since https slows things down a bit [19:26:06] we'll have to wait until mmv works logged out for a loggedout showdown [19:26:44] i see [20:57:40] (03CR) 10Gergő Tisza: Fix some text selection issues with share/embed (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119649 (owner: 10Aarcos) [21:00:26] (03CR) 10Gergő Tisza: [C: 032] "Seems like this is stuck in integration limbo." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118774 (owner: 10MarkTraceur) [21:04:02] (03PS8) 10Gergő Tisza: Add client-side flag for disabling the viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118774 (owner: 10MarkTraceur) [21:04:17] (03CR) 10Gergő Tisza: [C: 032] "Maybe this way..." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118774 (owner: 10MarkTraceur) [21:13:55] (03PS2) 10Aarcos: Fix some text selection issues with share/embed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119649 [21:15:29] (03CR) 10Gergő Tisza: [C: 032] Reuse dialog styling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119746 (owner: 10Pginer) [21:16:06] (03Merged) 10jenkins-bot: Reuse dialog styling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119746 (owner: 10Pginer) [21:16:56] (03PS9) 10Gergő Tisza: Add client-side flag for disabling the viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118774 (owner: 10MarkTraceur) [21:16:59] (03CR) 10Aarcos: "PTAL" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119649 (owner: 10Aarcos) [21:18:06] (03CR) 10Gergő Tisza: [C: 032] Add client-side flag for disabling the viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118774 (owner: 10MarkTraceur) [21:20:03] rdwrer: looks like jenkins hates you [21:33:31] tgr: Re: what? [21:33:48] Timing is fun. [22:02:10] rdwrer: re 118774, which does not get merged [22:02:23] May be that Zuul got drunk again [22:02:35] I'll try again after submitting the config change for beta [22:02:40] maybe, but other changesets work [22:07:57] (03CR) 10Gergő Tisza: Improve embed credit line (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119554 (owner: 10Gergő Tisza) [22:08:36] (03PS4) 10Gergő Tisza: Improve embed credit line [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119554 [22:18:23] tgr, have a sec to +1 https://gerrit.wikimedia.org/r/119886 ? [22:19:41] rdwrer: do we want to keep some beta site with non-pilot settings? [22:19:49] We could [22:19:50] Up to you [22:20:03] I figured it would be easier to just go for it [22:20:05] might be useful, i think [22:20:29] enwiki and commons should have pilot settings, but dewiki or something could stay [22:20:47] in case we need to test changes which affect opted-out wikis [22:20:56] dewiki and...enwikibooks. [22:21:23] Oh, no such thing on beta [22:21:41] enwikisource [22:22:20] sounds good to me [22:22:37] Just gotta find the db name [22:23:01] Agh, what, that's a stub too [22:48:02] (03CR) 10Gergő Tisza: Get more license info (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119680 (owner: 10Gergő Tisza) [23:03:27] (03PS3) 10Gergő Tisza: Get more license info [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119680 [23:03:36] (03PS4) 10Gergő Tisza: Get more license info [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119680 [23:04:26] (03CR) 10jenkins-bot: [V: 04-1] Get more license info [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119680 (owner: 10Gergő Tisza) [23:07:15] (03PS5) 10Gergő Tisza: Get more license info [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119680 [23:43:28] (03PS10) 10MarkTraceur: Add client-side flag for disabling the viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118774 [23:43:44] (03CR) 10MarkTraceur: [C: 032] "Per tgr" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118774 (owner: 10MarkTraceur) [23:46:21] (03CR) 10MarkTraceur: "Oh, Jenkins dislikes me because there's an unmerged dependency." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118774 (owner: 10MarkTraceur) [23:49:46] (03CR) 10Gergő Tisza: [C: 032] Add feature flags for Media Viewer (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119396 (owner: 10MarkTraceur) [23:50:23] (03Merged) 10jenkins-bot: Add feature flags for Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119396 (owner: 10MarkTraceur) [23:51:01] (03Merged) 10jenkins-bot: Add client-side flag for disabling the viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118774 (owner: 10MarkTraceur)