[00:26:32] (03PS1) 10Brian Wolff: Fix starttime <= endtime comparision [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/122273 [01:34:58] (03CR) 10Gergő Tisza: [C: 032] Display black overlay while the viewer JS is loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 (owner: 10Gilles) [01:35:44] (03Merged) 10jenkins-bot: Display black overlay while the viewer JS is loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 (owner: 10Gilles) [02:16:07] (03CR) 10Gergő Tisza: [C: 04-1] "I have appended this code to LocalSettings.php to test:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [03:50:01] (03CR) 10Gergő Tisza: "When I simply try to click very quickly on a normal page, the lightbox works. The click happens before the bootstrap module is loaded, but" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [04:40:26] (03CR) 10Mdale: [C: 032 V: 032] "looks good, thanks Brian." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/122273 (owner: 10Brian Wolff) [05:31:59] (03CR) 10Gergő Tisza: "I also tested replaying ctrl-clicks after fixing the recursion, and it doesn't work - it is replayed as a normal click." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [05:41:37] (03PS6) 10Gergő Tisza: Replay early thumb link clicks when bootstrap is ready to receive them [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [05:41:40] (03CR) 10jenkins-bot: [V: 04-1] Replay early thumb link clicks when bootstrap is ready to receive them [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [05:44:15] (03PS7) 10Gergő Tisza: Replay early thumb link clicks when bootstrap is ready to receive them [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [05:48:07] (03CR) 10Gergő Tisza: "This should take care of the concerns apart from the white screen. That one is is caused by mw.loader.using, not the event handling, and i" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [08:35:52] (03PS8) 10Gilles: Replay early thumb link clicks when bootstrap is ready to receive them [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 [08:36:15] (03CR) 10Gilles: "This should take care of the white screen" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [12:15:24] (03CR) 10Gilles: "Ops merged the ?download change! We can now get rid of the download attribute and target=_blank. Just adding "?download" to any image URL " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [12:41:48] (03CR) 10Zfilipin: Test to compare the performance of MMV and the Commons File: page (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [12:54:31] (03CR) 10Gilles: Test to compare the performance of MMV and the Commons File: page (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [12:55:16] marktraceur: is theopolisme a volunteer or staff? [12:55:57] I have a jquery.fullscreen.js bugfix sent to guthub, I want to make sure it gets merged quickly [12:56:03] *github [13:00:52] (03PS1) 10Gilles: Fixes various bugs in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 [13:18:05] (03PS2) 10Gilles: Fixes various bugs in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 [13:18:33] (03CR) 10jenkins-bot: [V: 04-1] Fixes various bugs in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 (owner: 10Gilles) [13:30:49] (03PS3) 10Gilles: Fixes various bugs in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 [13:31:18] (03CR) 10jenkins-bot: [V: 04-1] Fixes various bugs in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 (owner: 10Gilles) [13:56:55] (03PS4) 10Gilles: Fixes various bugs in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 [14:20:45] (03PS5) 10Gilles: Fixes various bugs in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 [15:05:03] (03PS1) 10Gilles: Disable IE < 9 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122422 [16:06:51] (03PS15) 10Gilles: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [16:06:54] (03CR) 10jenkins-bot: [V: 04-1] Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [16:09:13] (03PS16) 10Gilles: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [16:12:07] (03CR) 10Gilles: "Added support for ?download. Run "vagrant provision" and update to the latest core if ?download links don't work on your vm." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [16:30:02] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [16:32:16] gi11es: He's a volunteer, was working with us as part of GCI [17:42:19] (03PS9) 10Gergő Tisza: Replay early thumb link clicks when bootstrap is ready to receive them [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [17:43:47] (03CR) 10Gergő Tisza: "Added the IE fix from 122398" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [17:46:56] (03CR) 10Gergő Tisza: [C: 032] "That's one scary looking callback tower :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [17:48:25] (03Merged) 10jenkins-bot: Replay early thumb link clicks when bootstrap is ready to receive them [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [18:07:13] (03CR) 10Gergő Tisza: Fixes various bugs in IE (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 (owner: 10Gilles) [18:20:11] (03PS1) 10Gergő Tisza: Remove the temporary click handler once the final one is installed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122446 [18:27:33] (03PS2) 10Gergő Tisza: Disable IE < 9 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122422 (owner: 10Gilles) [18:28:56] (03CR) 10Gergő Tisza: "Rebased so it can be tested together with head.js" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122422 (owner: 10Gilles) [19:08:18] (03PS17) 10Aarcos: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 [19:10:26] (03CR) 10Aarcos: [C: 031] "Added a missing "download" param, otherwise looks good to me, merge at your convenience." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [19:11:37] (03CR) 10Aarcos: Download tab, basic download and preview (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [19:23:55] Ooh, heisenbug. [19:24:13] * marktraceur seeing "too much recursion" error, so turns on breakpoint-on-uncaught-exceptions, then cannot get the error again [19:24:25] I don't *think* it's in my code, but I'm looking. [19:28:21] Ah, it was [19:28:31] #subclassingishard [19:46:39] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [20:58:28] marktraceur: how would you rate the likelihood of him looking at the merge request quickly without extra pinging, on a scale of 1 to 10? :) [20:59:06] gi11es: Uh...who? Oh, theo. [20:59:27] gi11es: Maybe 6. I really like Theo, but he might not be around during the school year. [21:02:14] (03CR) 10Gilles: "The dependency has been merged. Is this good to go, Gergo?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121613 (owner: 10Gilles) [21:04:16] (03CR) 10Gergő Tisza: [C: 032] Display thumbnail placeholder ASAP [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121613 (owner: 10Gilles) [21:05:45] (03Merged) 10jenkins-bot: Display thumbnail placeholder ASAP [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121613 (owner: 10Gilles) [21:07:05] (03CR) 10Gilles: Fixes various bugs in IE (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 (owner: 10Gilles) [21:09:04] (03CR) 10Gilles: [C: 032] Remove the temporary click handler once the final one is installed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122446 (owner: 10Gergő Tisza) [21:09:32] (03Merged) 10jenkins-bot: Remove the temporary click handler once the final one is installed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122446 (owner: 10Gergő Tisza) [21:11:15] tgr: could you try reviewing https://gerrit.wikimedia.org/r/#/c/120738/17 today? (download) I think aaron and I are completely done [21:11:35] sure [21:11:43] * marktraceur looks at aar...damn [21:19:06] (03CR) 10Gergő Tisza: "I tried to test this in IE6-8 but failed miserably (couldn't get the vbox network settings right). Will this work together with mmv.head.j" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122422 (owner: 10Gilles) [21:24:10] (03CR) 10Gilles: [C: 04-1] "It's probably a good idea to disable mmv.head in the same fashion. I didn't think of doing it because that other changeset was in review. " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122422 (owner: 10Gilles) [21:38:09] (03PS1) 10Gergő Tisza: Use mw-mmv CSS prefix consistently for all things [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122572 [21:49:54] (03PS2) 10MarkTraceur: Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 [21:49:57] (03CR) 10jenkins-bot: [V: 04-1] Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 (owner: 10MarkTraceur) [21:53:43] (03PS2) 10Krinkle: [WIP] Test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121905 [22:25:11] (03Abandoned) 10Krinkle: [WIP] Test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121905 (owner: 10Krinkle) [22:44:46] (03CR) 10Gergő Tisza: [C: 04-1] "Fails in weird ways sometimes, e.g. here:" (038 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [23:06:44] (03CR) 10Gergő Tisza: Download tab, basic download and preview (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [23:25:29] (03PS3) 10MarkTraceur: Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 [23:26:08] (03CR) 10MarkTraceur: Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 (owner: 10MarkTraceur) [23:26:15] (03CR) 10jenkins-bot: [V: 04-1] Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 (owner: 10MarkTraceur) [23:26:17] I hope I didn't cock up that rebase too much [23:41:56] (03PS4) 10MarkTraceur: Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 [23:42:26] (03CR) 10jenkins-bot: [V: 04-1] Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 (owner: 10MarkTraceur) [23:49:30] (03PS1) 10Gergő Tisza: Refactor dropdown size calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122611 [23:50:02] (03CR) 10jenkins-bot: [V: 04-1] Refactor dropdown size calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122611 (owner: 10Gergő Tisza) [23:51:36] (03PS2) 10Gergő Tisza: Refactor dropdown size calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122611 [23:52:43] (03CR) 10Gergő Tisza: Download tab, basic download and preview (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos)