[00:02:32] (03PS4) 10Gergő Tisza: Add tooltips to metadata buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 [00:02:34] (03PS5) 10Gergő Tisza: Feedback button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 [00:02:36] (03PS5) 10Gergő Tisza: Make survey open in popup window instead of normal one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 [00:02:38] (03PS7) 10Gergő Tisza: Create StripeButtons class, convert reuse button to use it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 [00:02:40] (03PS5) 10Gergő Tisza: Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 [00:02:42] (03PS5) 10Gergő Tisza: Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 [00:28:42] (03CR) 10Gergő Tisza: Hide metadata top button texts (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 (owner: 10Gergő Tisza) [00:37:52] (03CR) 10Aarcos: Create StripeButtons class, convert reuse button to use it (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 (owner: 10Gergő Tisza) [00:38:15] (03CR) 10Aarcos: [C: 04-1] Create StripeButtons class, convert reuse button to use it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 (owner: 10Gergő Tisza) [00:53:55] (03PS6) 10Gergő Tisza: Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 [00:54:31] (03CR) 10Gergő Tisza: Hide metadata top button texts (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 (owner: 10Gergő Tisza) [01:23:52] (03CR) 10Gergő Tisza: Create StripeButtons class, convert reuse button to use it (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 (owner: 10Gergő Tisza) [01:24:31] (03PS8) 10Gergő Tisza: Create StripeButtons class, convert reuse button to use it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 [01:26:06] (03PS6) 10Gergő Tisza: Feedback button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 [01:26:12] (03PS6) 10Gergő Tisza: Make survey open in popup window instead of normal one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 [01:26:17] (03PS6) 10Gergő Tisza: Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 [01:26:21] (03PS5) 10Gergő Tisza: Add tooltips to metadata buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 [01:38:51] (03CR) 10Gergő Tisza: "This got merged into the parent somehow when I was fooling around with interactive rebase. I will leave it like that since this is only a " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 (owner: 10Gergő Tisza) [02:02:57] (03PS6) 10Gergő Tisza: Add tooltips to metadata buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 [02:05:18] (03CR) 10Gergő Tisza: "Fixed anyway since it happened to more than one changeset." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 (owner: 10Gergő Tisza) [02:05:33] (03PS6) 10Gergő Tisza: Only show file description page button for logged-in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 [02:08:22] (03PS7) 10Gergő Tisza: Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 [05:26:38] (03CR) 10Gilles: [C: 031] Create StripeButtons class, convert reuse button to use it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 (owner: 10Gergő Tisza) [11:51:58] (03CR) 10Pginer: Feedback button (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 (owner: 10Gergő Tisza) [12:14:24] (03PS1) 10Pginer: Optimized SVGs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123607 [12:22:39] (03PS1) 10Pginer: Split button line adjustment The download button used a dashed black line to separate options. It has been changed to a dark green line to better fit the style. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123609 [15:30:01] gi11es: Given you're busy for the first 30 minutes and we don't have a room anyway, do we want to push the planning meeting back a day? [15:30:39] Oh, robla's out tomorrow...and I am too...what am I talking about [15:32:19] I guess we could cannibalize the metrics time slot for the fact that nobody's using any conference rooms then [15:32:42] * marktraceur will ask tgr and arcos when he gets in [15:34:48] whatever works for you guys [15:35:54] I'm on some shitty communal wifi today because I'm having issues with my ISP, I hope it'll be decent enough for the hangouts [15:36:08] and I don't think my line will be fixed by tomorrow anyway, sadly [15:37:03] also, that ghetto wifi disconnects automatically every hour, so if I disappear I'm likely to reappear a few seconds later [15:39:03] (03CR) 10Gilles: Split button line adjustment The download button used a dashed black line to separate options. It has been changed to a dark green line to b (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123609 (owner: 10Pginer) [15:40:15] (03CR) 10Gilles: [C: 032] Optimized SVGs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123607 (owner: 10Pginer) [15:41:04] (03Merged) 10jenkins-bot: Optimized SVGs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123607 (owner: 10Pginer) [15:48:40] (03CR) 10Gilles: [C: 04-1] Feedback button (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 (owner: 10Gergő Tisza) [15:53:03] (03CR) 10Gilles: [C: 04-1] "Different dimensions, but still cut off: https://www.dropbox.com/s/6a58zff1d1t1v5v/Screenshot%202014-04-03%2017.50.52.png" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 (owner: 10Gergő Tisza) [15:59:39] (03CR) 10Gilles: "And the two buttons become vertically misaligned (doesn't happened in the parent changeset, seen in Firefox): https://www.dropbox.com/s/v" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 (owner: 10Gergő Tisza) [16:00:30] roblaAWAY: "You're not allowed to join this video call." [16:09:31] marktraceur: is the meeting still starting 20 minutes from now? [16:10:28] Eurm [16:10:31] Seems unlikely [16:12:37] gi11es: I'll confer with the fellas when they get in [16:31:02] gi11es: Postponed for an hour [16:31:06] See you at 10:30! [16:31:09] ok [17:06:42] Share/Embed/Download tabs don't respond on beta !!!, looking [17:07:38] It may be that we're developing with a too-old version of oojs-ui [17:07:59] Hm, the classes get set but the events don't get handled it looks like [17:08:07] I'd bet the event names changed [17:14:39] (03CR) 10Gergő Tisza: Feedback button (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 (owner: 10Gergő Tisza) [17:26:15] It doesn't work locally either [17:26:20] * greg-g waves [17:26:24] is "April 10 - Media Viewer - First limited pilot release: Enable by default on MediaWiki.org " still the plan? [17:26:35] greg-g: Yes, barring unforeseen disasters [17:26:38] * marktraceur knocks on all the wood [17:26:52] * greg-g finds some more [17:26:53] cool, thanks [17:27:11] greg-g: More info to come in about 1.5 hours, I guess [17:27:22] tgr, arcos, gi11es, it's about that time then, eh? [17:27:50] * greg-g nods [17:30:51] marktraceur: keegan and I are in [18:29:14] gi11es: we lost u, coming back? [20:09:47] is today's deploy out already? [20:10:11] i am testing the link sharing feature and it seems to work on Commons but not on huwiki [20:12:43] It should be. [20:13:22] tgr: Not working at *all* on mw.org [20:13:24] So broken [20:13:25] Much fail [20:13:26] Wow [20:20:18] this works fine for me: https://www.mediawiki.org/wiki/Lightbox_demo#mediaviewer/File:Swallow flying drinking.jpg [20:20:24] even in incognito [20:21:23] the oojs-ui stuff is broken though [20:21:47] funnily enough, it works if you click multiple tabs really fast [20:22:49] is there a bugzilla entry for it? [20:24:34] Not yet, I'm in the middle of something else [21:17:15] (03CR) 10Nikerabbit: "Please be aware of bug 59234." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123607 (owner: 10Pginer) [21:36:49] tgr: Are you debugging? Any luck? [21:37:07] no [21:37:24] i can do that [21:37:31] you mean the oojs-ui one? [21:38:13] Yeah, I was just gonna start bothering the VE team [21:48:42] (03CR) 10Aarcos: [C: 031] "This LGTM, merge at your convenience if no more issues left." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 (owner: 10Gergő Tisza) [22:09:03] (03CR) 10Gergő Tisza: [C: 032] Create StripeButtons class, convert reuse button to use it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 (owner: 10Gergő Tisza) [22:09:08] (03CR) 10jenkins-bot: [V: 04-1] Create StripeButtons class, convert reuse button to use it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 (owner: 10Gergő Tisza) [22:11:43] (03PS3) 10Gergő Tisza: Refactor dropdown size calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122611 [22:11:45] (03CR) 10jenkins-bot: [V: 04-1] Refactor dropdown size calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122611 (owner: 10Gergő Tisza) [22:17:43] (03CR) 10Aarcos: Create StripeButtons class, convert reuse button to use it (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 (owner: 10Gergő Tisza) [22:21:41] (03PS4) 10Gergő Tisza: Refactor dropdown size calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122611 [22:22:38] (03CR) 10Gergő Tisza: Refactor dropdown size calculation (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122611 (owner: 10Gergő Tisza) [22:23:02] (03CR) 10Gergő Tisza: [C: 04-2] "Still need to check the merge per Aaron's comment." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122611 (owner: 10Gergő Tisza) [22:26:39] (03CR) 10Gergő Tisza: Feedback button (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 (owner: 10Gergő Tisza) [22:28:08] (03PS7) 10Gergő Tisza: Feedback button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 [22:28:10] (03CR) 10jenkins-bot: [V: 04-1] Feedback button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 (owner: 10Gergő Tisza) [22:31:40] (03PS9) 10Gergő Tisza: Create StripeButtons class, convert reuse button to use it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 [22:36:35] (03CR) 10Aarcos: [C: 031] "Code-wise this LGTM, good to go once merge issues are resolved and no more concerns from the rest." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 (owner: 10Gergő Tisza) [22:38:22] (03PS2) 10Gergő Tisza: Split button line adjustment [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123609 (owner: 10Pginer) [22:40:11] gi11es: Off-hand, did you talk to ops about the thumbnail size buckets? :) [22:46:15] (03CR) 10Aarcos: [C: 04-1] Make survey open in popup window instead of normal one (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 (owner: 10Gergő Tisza) [22:47:00] (03PS1) 10Gergő Tisza: Revert "Optimized SVGs" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123799 [22:57:21] (03PS1) 10Gergő Tisza: Add XML prolog to SVG files [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123801 [22:58:07] (03Abandoned) 10Gergő Tisza: Revert "Optimized SVGs" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123799 (owner: 10Gergő Tisza) [22:58:36] marktraceur: could you review https://gerrit.wikimedia.org/r/#/c/123801/ ? [22:59:22] (03PS2) 10MarkTraceur: Add XML prologue to SVG files [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123801 (owner: 10Gergő Tisza) [22:59:28] tgr: prolog is a programming language. :) [23:00:13] no, it's actually called a prolog [23:00:20] don't ask me what the word means [23:00:32] Oh huh. [23:00:44] (03PS3) 10MarkTraceur: Add XML prolog to SVG files [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123801 (owner: 10Gergő Tisza) [23:00:56] (03CR) 10MarkTraceur: [C: 032] "http://www.tizag.com/xmlTutorial/xmlprolog.php TIL" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123801 (owner: 10Gergő Tisza) [23:01:41] (03Merged) 10jenkins-bot: Add XML prolog to SVG files [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123801 (owner: 10Gergő Tisza) [23:04:00] (03PS10) 10Gergő Tisza: Create StripeButtons class, convert reuse button to use it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 [23:08:57] (03CR) 10Aarcos: [C: 04-1] Add metadata button to go to file description page directly (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [23:12:28] (03CR) 10Aarcos: [C: 031] Add tooltips to metadata buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 (owner: 10Gergő Tisza) [23:13:23] (03PS11) 10Gergő Tisza: Create StripeButtons class, convert reuse button to use it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 [23:14:20] (03PS8) 10Gergő Tisza: Feedback button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 [23:15:00] (03CR) 10Aarcos: [C: 031] Only show file description page button for logged-in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 (owner: 10Gergő Tisza) [23:21:59] (03CR) 10Aarcos: [C: 04-1] Hide metadata top button texts (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 (owner: 10Gergő Tisza) [23:37:42] (03PS7) 10Gergő Tisza: Make survey open in popup window instead of normal one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 [23:38:15] (03PS8) 10Gergő Tisza: Make survey open in popup window instead of normal one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 [23:38:21] (03CR) 10jenkins-bot: [V: 04-1] Make survey open in popup window instead of normal one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 (owner: 10Gergő Tisza) [23:38:33] (03CR) 10Gergő Tisza: Make survey open in popup window instead of normal one (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 (owner: 10Gergő Tisza) [23:43:16] (03CR) 10Gergő Tisza: "The misalignment issue should be fixed. The cutoff sounds like a problem with the surveymonkey page, I have no control over that. (For me " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 (owner: 10Gergő Tisza) [23:43:42] (03PS7) 10Gergő Tisza: Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 [23:57:44] (03CR) 10Gergő Tisza: Add metadata button to go to file description page directly (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza)