[04:49:07] (03PS1) 10Ori.livneh: Register ResourceLoader modules the conventional way [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124283 [04:53:32] (03CR) 10Ori.livneh: "Fixes this exception on the beta cluster: " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124283 (owner: 10Ori.livneh) [08:31:02] (03CR) 10Gilles: [C: 032] Show a tooltip for the repo link button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123899 (owner: 10Gergő Tisza) [08:41:30] (03CR) 10Gilles: [C: 04-1] Register ResourceLoader modules the conventional way (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124283 (owner: 10Ori.livneh) [08:47:14] (03CR) 10jenkins-bot: [V: 04-1] Register ResourceLoader modules the conventional way [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124283 (owner: 10Ori.livneh) [08:49:45] (03Merged) 10jenkins-bot: Show a tooltip for the repo link button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123899 (owner: 10Gergő Tisza) [09:05:58] (03PS2) 10Gilles: Register ResourceLoader modules the conventional way [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124283 (owner: 10Ori.livneh) [09:06:21] (03CR) 10jenkins-bot: [V: 04-1] Register ResourceLoader modules the conventional way [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124283 (owner: 10Ori.livneh) [09:16:27] (03PS3) 10Gilles: Register ResourceLoader modules the conventional way [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124283 (owner: 10Ori.livneh) [09:17:14] (03CR) 10Gilles: [C: 031] Register ResourceLoader modules the conventional way [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124283 (owner: 10Ori.livneh) [09:19:05] (03CR) 10Gilles: Fix z-index bug in Firefox that would make navigation buttons appear on top of the metadata panel (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123838 (owner: 10Gilles) [09:21:19] (03PS2) 10Gilles: Fix z-index bug in Firefox that would make navigation buttons appear on top of the metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123838 [09:27:11] (03CR) 10Gilles: [C: 032] Rename setRepoInlineStyle to setInlineStyle [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124018 (owner: 10Gergő Tisza) [09:28:12] (03Merged) 10jenkins-bot: Rename setRepoInlineStyle to setInlineStyle [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124018 (owner: 10Gergő Tisza) [09:28:38] (03CR) 10Gilles: [C: 032] Hide buttons while loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124020 (owner: 10Gergő Tisza) [09:29:10] (03Merged) 10jenkins-bot: Hide buttons while loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124020 (owner: 10Gergő Tisza) [09:36:31] (03CR) 10Gilles: [C: 04-1] Add site/language conditions for feedback button (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123917 (owner: 10Gergő Tisza) [09:48:28] (03CR) 10Gilles: [C: 04-1] Show tooltip when all sorts of conditions are met (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124032 (owner: 10Gergő Tisza) [15:29:43] marktraceur: https://gitorious.org/analytics/multimedia-limn/merge_requests/1 [15:41:19] Wuh oh. [15:41:43] gi11es: I'm still on "vacation" [15:41:49] But I'll deal with it later [15:41:58] gi11es: Is it in code review in Mingle, and is there a link to the MR? [16:50:57] * marktraceur is miraculously able to join the meeting [16:51:37] Probably not the retrospective though [17:12:44] marktraceur: added it to https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/198 [17:13:25] marktraceur: any reason not to move the two gitorious repos to something like /limn/ and /limn/sql/ in Media Viewer's existing gerrit repo? [17:16:33] (03CR) 10MarkTraceur: "Why is this only a Commons icon? We have a system for finding the favicon for remote repos and we should be using it." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [17:18:40] (03CR) 10Gergő Tisza: "I thought we *are* using it. Do you have an example of it not working?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [17:27:36] gi11es: the IE issue might be very easy to fix, actually [17:27:50] tgr: it's always been easy to fix... [17:27:55] i have a patch around but i still cannot test on my virtual boxes [17:28:11] yeah, i mean easy to fix without breaking BC in OOJS [17:28:44] send me the diff, I can test it [17:28:55] will push after the meeting [17:35:04] gi11es: limn stuff shouldn't be in a MW extension repo [17:35:37] Because then people wanting to run the data analysis will need to download the extension and people wanting to run the extension will need to download the limn stuff [17:35:40] Which is silly [17:38:59] then how hard is it to make a new gerrit repo for our limn stuff? [17:53:51] (03PS1) 10Gergő Tisza: Workaround for OOJS ES3 incompatibility [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124365 [17:54:26] gi11es: ^^ + https://gerrit.wikimedia.org/r/124363 [17:55:20] (03PS2) 10Gergő Tisza: Workaround for OOJS ES3 incompatibility [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124365 [18:11:20] (03PS4) 10Gergő Tisza: Add site/language conditions for feedback button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123917 [18:19:52] (03CR) 10Ori.livneh: [C: 031] "Gilles's updates LGTM" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124283 (owner: 10Ori.livneh) [18:33:52] (03CR) 10Gergő Tisza: "Doing things in the global namespace is a poor practice; a typo in a variable name can have much worse consequences that way. Namespaces r" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124283 (owner: 10Ori.livneh) [18:36:44] (03CR) 10Gergő Tisza: Show tooltip when all sorts of conditions are met (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124032 (owner: 10Gergő Tisza) [19:12:17] (03CR) 10Ori.livneh: "Poor practice or not, it is how the entry-points of the other 149 extensions that are deployed to the cluster are structured, so if you'd " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124283 (owner: 10Ori.livneh) [19:14:32] gi11es: I think they already exist... [19:16:49] (03CR) 10MarkTraceur: "Oh, sorry, I misread the patch. It's still annoying that this is super commons-centric, but I guess I'll live with it." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [19:36:19] (03Abandoned) 10Ori.livneh: Have TMH load MwEmbedSupport modules when needed [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108658 (owner: 10Ori.livneh) [20:20:53] (03CR) 10Gergő Tisza: "Will do. FWIW I think I have seen this pattern in a few other extensions, although Wikibase is the only example I can recall right now ( h" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124283 (owner: 10Ori.livneh) [21:11:04] (03PS3) 10Gergő Tisza: Show tooltip when all sorts of conditions are met [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124032 [21:11:06] (03PS1) 10Gergő Tisza: Add named timeouts to mw.mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124463 [21:11:32] (03CR) 10Gergő Tisza: "Extracted timer handling stuff into a parent commit." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124032 (owner: 10Gergő Tisza) [21:11:43] (03CR) 10jenkins-bot: [V: 04-1] Show tooltip when all sorts of conditions are met [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124032 (owner: 10Gergő Tisza) [21:12:11] (03CR) 10jenkins-bot: [V: 04-1] Add named timeouts to mw.mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124463 (owner: 10Gergő Tisza) [21:15:47] (03PS4) 10Gergő Tisza: Show tooltip when all sorts of conditions are met [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124032 [21:15:49] (03PS2) 10Gergő Tisza: Add named timeouts to mw.mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124463 [21:16:20] (03CR) 10jenkins-bot: [V: 04-1] Show tooltip when all sorts of conditions are met [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124032 (owner: 10Gergő Tisza) [21:16:48] (03CR) 10jenkins-bot: [V: 04-1] Add named timeouts to mw.mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124463 (owner: 10Gergő Tisza) [21:16:56] (03PS5) 10Gergő Tisza: Show tooltip when all sorts of conditions are met [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124032 [21:17:26] (03CR) 10jenkins-bot: [V: 04-1] Show tooltip when all sorts of conditions are met [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124032 (owner: 10Gergő Tisza) [21:21:25] (03PS6) 10Gergő Tisza: Show tooltip when all sorts of conditions are met [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124032 [21:21:27] (03PS3) 10Gergő Tisza: Add named timeouts to mw.mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124463 [21:53:42] (03CR) 10Gergő Tisza: [C: 032] Fixes various bugs in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 (owner: 10Gilles) [21:53:48] (03CR) 10jenkins-bot: [V: 04-1] Fixes various bugs in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 (owner: 10Gilles) [22:03:29] (03PS9) 10Gergő Tisza: Fixes various bugs in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 (owner: 10Gilles) [22:06:14] (03CR) 10Gergő Tisza: [C: 032] "The metadata panel fade-in does not work on Chrome, but that is not related to this changeset." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 (owner: 10Gilles) [22:06:43] (03Merged) 10jenkins-bot: Fixes various bugs in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122398 (owner: 10Gilles) [22:15:32] (03CR) 10Gergő Tisza: [C: 04-1] Select html embed by default for logged-out users (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121064 (owner: 10Gilles) [23:36:02] (03CR) 10Ori.livneh: "In the interim, this patch does, I think, resolve this issue on beta: and would therefore unbl" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124283 (owner: 10Ori.livneh)