[00:00:37] seems to be very random, when i look at it in an incognito tab, the panel works [00:00:45] Should we go back to wmf20? [00:00:55] resourceloader caching issue sounds about right [00:00:57] Like clearly wmf22 is better [00:01:02] But wmf21 is borked [00:01:19] would it help? [00:01:20] It’s a bit embarrassing, the app is really broken. Let me check other sites besides enwiki. [00:01:36] the code of wmf21 does not seem to be the problem [00:02:36] I cannot reproduce the problem on frwiki. [00:03:02] oh wow, the pannel does seem quite broken on enwiki for me [00:03:30] I just don't see any issues on the panel [00:03:48] see the screenshot [00:03:53] But not with ?debug=true. Which is consistent with RL cache being borked [00:03:57] Not a problem on Catalan Wikipedia either, seems to be mostly related to English. [00:04:21] marktraceur: For me, the background is transparent, and you can't scroll it into view (and the download link is broken) [00:05:02] also not broken in incognito, so I guess its probably locally cached [00:05:05] On that basis, I think we can live with it. Hungarian is working fine too, and the first pilots is what I’m most worried about. [00:05:18] OK fine [00:05:34] https://en.wikipedia.org/wiki/Even_If_and_Especially_When?uselang=de#mediaviewer/File:EvenIfAndEspeciallyWhen.jpg works fine [00:05:37] I do get a Uncaught TypeError: Cannot call method 'getMainText' of undefined [00:05:54] https://de.wikipedia.org/wiki/Wikipedia:Hauptseite?uselang=en#mediaviewer/Datei:Rhombodera basalis 2 Luc Viatour cropped.jpg also works [00:05:58] But it would be important to figure out what’s causing this, so we can nail it on Monday. I would like to start the discussion on enwiki sooner rather than later. [00:06:14] so this is somehow specific to english wikipedia in english interface language [00:08:08] OK if I add a high priority bug for this in this sprint, so we deal with it first? [00:08:23] Sure [00:08:49] OK, I will keep it succinct, but attach the scary screenshot, which says it all. [00:12:12] we have the bug card already [00:14:49] tgr: OK. Want me to add my scary screenshot to it? [00:25:42] tgr, marktraceur: running mw.loader.store.clear() fixed the issue for me, so looks like an issue with RL's LocalStorage module cache not properly invalidating things [00:32:51] i think that is just a coincidence, the RL cache was purged a few minutes ago [00:34:16] Hmm, could be [00:55:21] So it may be a coincidence that I wasn't seeing the issue [00:55:40] If the only way you can see it is by having en_US as your UI language [00:55:45] Because I have en_GB [00:56:36] yeah [00:56:59] i even tried en_xxx and it worked like that [00:57:05] marktraceur: damn americans taking over the world [00:57:21] bawolff: Fuckin' splitters man [00:57:26] inb4 en_CA [00:57:37] Actually can we make that [00:57:39] apparently at some point things are just blindly cached by iflang string, and the cache entry on enwiki got screwed up somehow [00:57:45] And just append ", eh?" to every stirng [00:57:46] string [00:58:10] bawolff: Next April 1st, you and me [00:58:26] Hmm? [00:58:53] en_CA, a language file with all of the 'en' strings, just with ", eh" appended [00:59:15] lol, I like it [00:59:36] Nothing beats the lolcat parser though for april fools dev jokes [00:59:46] LOLCODE [00:59:48] I knew it well [00:59:59] (it was actually part of a final project for one of my uni CS courses) [01:00:22] I think I may still have the honour of the only IDE that supports it? [01:00:52] Agh, no. http://sourceforge.net/projects/eclipse-lol/ [01:01:21] "eclipse-lol" also used in many URLs to reviews of Eclipse [07:26:15] (03PS1) 10Gilles: Fix deprecated condition in E2E test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125375 [07:29:26] (03Abandoned) 10Gilles: Fix deprecated condition in E2E test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125375 (owner: 10Gilles) [07:35:48] (03CR) 10Gilles: [C: 04-1] "With this change if the author is a link, it's incorrectly escaped:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [09:31:50] (03PS1) 10Gilles: Restore article scroll after closing Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 [09:32:21] (03CR) 10jenkins-bot: [V: 04-1] Restore article scroll after closing Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [09:35:47] (03CR) 10Gilles: [V: 032] "The usual doc test segfault" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [09:54:19] (03PS2) 10Gilles: Restore article scroll after closing Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 [14:06:05] (03PS1) 10Gilles: Load oojs-ui on demand when "use this file" is clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 [14:06:41] (03CR) 10jenkins-bot: [V: 04-1] Load oojs-ui on demand when "use this file" is clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 (owner: 10Gilles) [14:07:52] (03PS2) 10Gilles: Load oojs-ui on demand when "use this file" is clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 [14:15:08] (03PS3) 10Gilles: Load oojs-ui on demand when "use this file" is clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 [14:31:16] (03PS1) 10Gilles: Load moment.js on demand [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 [14:31:48] (03CR) 10jenkins-bot: [V: 04-1] Load moment.js on demand [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 (owner: 10Gilles) [14:32:40] (03PS2) 10Gilles: Load moment.js on demand [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 [14:58:54] (03PS4) 10Gilles: Load oojs-ui on demand when "use this file" is clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 [14:58:56] (03PS3) 10Gilles: Load moment.js on demand [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 [15:28:37] (03PS1) 10Pginer: Spacing adjustment for repository link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125407 [15:29:10] (03CR) 10jenkins-bot: [V: 04-1] Spacing adjustment for repository link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125407 (owner: 10Pginer) [15:30:20] (03PS2) 10Pginer: Spacing adjustment for repository link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125407 [16:23:38] (03CR) 10MarkTraceur: "Weird, the test should have caught this. Will fix between meetings, 'round 11:00 PDT" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [18:18:20] gi11es: Can you still reproduce the link issue with the "misc fixes" patch? I cannot, with external and wikilinks [18:28:02] marktraceur: Exit interview? I am in Browne [18:28:37] Oh sure [18:46:23] (03CR) 10Gergő Tisza: [C: 032] Spacing adjustment for repository link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125407 (owner: 10Pginer) [18:50:05] (03Merged) 10jenkins-bot: Spacing adjustment for repository link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125407 (owner: 10Pginer) [18:52:34] (03CR) 10MarkTraceur: "I cannot reproduce this issue...what kind of link is causing the problem?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [19:21:41] (03CR) 10Gergő Tisza: [C: 04-1] Load oojs-ui on demand when "use this file" is clicked (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 (owner: 10Gilles) [19:27:37] (03CR) 10Gergő Tisza: [C: 04-1] Load moment.js on demand (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 (owner: 10Gilles) [19:57:52] tgr_: I guess gi11es is maybe out of commission, can you look at https://gerrit.wikimedia.org/r/125342 and tell me if you're seeing the same issue he was? [19:57:56] I couldn't reproduce at all [21:12:12] tgr: Any luck? [21:12:52] uh, sorry, did not notice the message [21:12:59] let me see [21:14:33] (03PS1) 10Gergő Tisza: Fix icon positioning for secondary repo link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125510 [21:17:18] marktraceur tgr : Looks like enwiki is working fine again. Thanks for fixing it so quickly! How did you do it? https://en.wikipedia.org/wiki/Main_Page#mediaviewer/File:Kapelludden - chapel ruins.jpg [21:18:11] fabriceflorin: mwalker did it [21:18:28] the details are beyond me, something about ResourceLoader caching [21:19:06] tgr Cool. Please pass on my thanks to him. Does he work here in the office? [21:19:13] marktraceur: any idea where that error shows up? [21:19:25] tgr: gi11es' comment is all I have [21:19:39] fabriceflorin: Yeah, Matt Walker, he's currently refilling his water in the kitchen [21:19:43] He's a fundraiser [21:20:13] Oh, that Matt — well, he’s my hero today, will drop him a note :) [21:22:36] marktraceur: looking at this changeset, i don't see any possibility of breaking HTML parsing [21:23:14] the original truncating patch could have done that, but that's merged already, so i don't think there is anything to loose by merging this [21:25:15] hm, no [21:25:22] that's not quite true [21:37:52] tgr: What's the verdict? [21:38:14] can't reproduce, links work for me [21:38:24] Well, dafuq. [21:38:31] Maybe I'll try with the same image. dunno [21:38:34] looking at the code, if there is a bug, it has to be in the truncate part [21:38:53] this change looks completely safe [21:39:47] Hm, it's an interwiki link. I'll try that [21:45:09] i imagine the picture is https://www.mediawiki.org/wiki/Lightbox_demo#mediaviewer/File:Charles J. Faulkner 1806-1884 - Brady-Handy.jpg since that's the only test image we have by Brady, although the file name text does not match [21:45:18] but that works for me [21:46:30] Interwiki links work fine for me [22:06:23] tgr: I guess I'll leave it for gi11es to add information. Ah well. [22:22:12] (03CR) 10Gergő Tisza: [C: 04-1] "There is a bunch of scrolling-related code in lightboxinterface.js (and its tests) which I think is unnecessary after this." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [22:26:31] (03CR) 10Gergő Tisza: Restore article scroll after closing Media Viewer (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [22:41:16] (03CR) 10MarkTraceur: [C: 032] Fix icon positioning for secondary repo link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125510 (owner: 10Gergő Tisza) [22:41:39] tgr: Does that fix close the card, d'you think? [22:43:35] * marktraceur considers wandering home and working from there... [22:47:26] Yeah, I'm going home [22:47:31] See y'all next week [23:00:16] (03PS1) 10Cmcmahon: update test to pass with new locator [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125526 [23:01:16] (03CR) 10Cmcmahon: [C: 032] "self-merging for basic maintenance to keep the build green" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125526 (owner: 10Cmcmahon) [23:08:10] (03PS1) 10Gergő Tisza: Adjust OOjs UI TextInputWidget text style [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125530