[09:38:10] (03CR) 10Gilles: "Local wiki upload, with this hardcoded template as the file's description: http://pastebin.com/2nm7e1Mv" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [09:41:09] (03CR) 10Gilles: [C: 032] Adjust OOjs UI TextInputWidget text style [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125530 (owner: 10Gergő Tisza) [09:41:45] (03Merged) 10jenkins-bot: Adjust OOjs UI TextInputWidget text style [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125530 (owner: 10Gergő Tisza) [09:55:19] (03PS5) 10Gilles: Load oojs-ui on demand when "use this file" is clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 [09:55:21] (03PS4) 10Gilles: Load moment.js on demand [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 [09:55:32] (03CR) 10Gilles: Load moment.js on demand (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 (owner: 10Gilles) [09:55:40] (03CR) 10Gilles: Load oojs-ui on demand when "use this file" is clicked (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 (owner: 10Gilles) [11:32:16] (03PS3) 10Gilles: Restore article scroll after closing Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 [11:32:47] (03CR) 10jenkins-bot: [V: 04-1] Restore article scroll after closing Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [11:33:55] (03CR) 10Gilles: "I've reintroduced pushState for modern browsers. However I found out afterwards that the scroll reset wasn't due to that, but was an unrel" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [11:34:47] (03PS4) 10Gilles: Restore article scroll after closing Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 [11:37:54] (03CR) 10Gilles: "This has been dragging for several weeks now, if you guys don't get around to doing the final review in the next couple of days, I'll +2 i" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [14:31:33] Wow, http://pastebin.com/2nm7e1Mv is way more complex than I expected it to be [15:17:13] (03CR) 10Gilles: "Upon closer inspection, if I go to the file page, it's not getting interpreted either: https://www.dropbox.com/s/7ndvk7rdu36n3kg/Screensho" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [15:20:29] (03PS4) 10Gilles: Miscellaneous fixes to truncatable text fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [15:21:12] (03CR) 10jenkins-bot: [V: 04-1] Miscellaneous fixes to truncatable text fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [15:23:23] (03CR) 10Gilles: [C: 032 V: 032] Miscellaneous fixes to truncatable text fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [15:24:16] (03Merged) 10jenkins-bot: Miscellaneous fixes to truncatable text fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [15:43:45] gi11es: What browser are you seeing this on? [15:44:00] marktraceur: I think it's a non-issue, see my last comment [15:44:02] latest firefox [15:44:04] I see that [15:44:07] But like...it's so weird [15:44:11] Because I don't see what you see [15:44:17] I wonder if it's a bug in firefox [15:44:24] handling maybe [15:44:32] that gets filtered [15:44:49] I figured, but maybe the way the DOM API handles it makes things funky [15:45:06] "Isolates a part of text that might be formatted in a different direction from other text outside it" may or may not encapsulate other elements [15:45:07] I wouldn't worry about it, since my File: page looks the same way [15:45:12] Not really clear [15:47:53] Anyway [15:48:06] I'll just be blissfully ignorant about it until it becomes my problem [15:49:27] https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/ is interesting, it's yoyoing [15:49:54] I guess it's just timeout issues [15:50:04] We'll see if the next run fails [16:05:38] I'll see if I can make it run manually [16:17:28] gi11es: I think the point is it only runs twice a day [16:17:34] I think we get charged per run... [16:22:20] (03CR) 10MarkTraceur: "I was about to say "gee it would be great if we could do this during a time when there's just no other network activity" but now I'm think" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 (owner: 10Gilles) [16:25:01] I saw your message too late, the run was successful [16:27:17] Yay! [16:27:53] gi11es: About every other run has been successful, though. I'll look forward to the afternoon test [16:33:16] (03PS1) 10Gilles: [WIP] Track more user actions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125746 [16:33:50] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Track more user actions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125746 (owner: 10Gilles) [17:04:18] fabriceflorin: https://gerrit.wikimedia.org/r/84625 [17:05:57] (03CR) 10MarkTraceur: "Re: Brain dump, actually now that I think about it it would be super hard to predict when we have no network activity especially for long " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 (owner: 10Gilles) [17:14:42] marktraceur: those intermittent failures of the browser test are unfortunate connection issues (to the best of my knowledge) between the Jenkins host and the Sauce Labs host. we get "too many connection resets" unfortunately often. RSN we'll have our first runs in the WMF Jenkins using Firefox headless, I'll put MMV at the head of the queue for that [17:15:39] Sighsauce. [17:15:45] Er, sigh Sauce [17:16:08] marktraceur: yeah. such is browsers [17:16:12] chrismcmahon: maybe we could retry failed tests and only alert if it fails the second time? [17:16:22] Ass-pensive probably [17:17:31] tgr marktraceur I've done that in other testrunners but it would be wacky in the current Jenkins arrangement. We'll bypass both Cloudbees and Sauce pretty soon though, I think by the end of April for at least some tests. [17:29:26] (03CR) 10MarkTraceur: [C: 032] "Thanks!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 (owner: 10Gilles) [17:30:00] (03Merged) 10jenkins-bot: Load oojs-ui on demand when "use this file" is clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 (owner: 10Gilles) [17:30:26] Mumble grumble the lazy-loading code should be abstracter [17:31:48] i was thinking about making a proper container class where you can add children instead of having the container create them directly [17:31:59] and then you could have a lazy-loading container [17:33:47] Sounds about right, not sure we have time now, but useful thoughts [17:39:02] (03CR) 10MarkTraceur: [C: 04-1] "Haven't tested, code style issues inline" (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 (owner: 10Gilles) [18:01:10] (03CR) 10Gergő Tisza: [C: 04-1] "Still resets the scroll position like this:" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [18:04:31] (03PS5) 10Gergő Tisza: Restore article scroll after closing Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [18:05:22] (03CR) 10Gergő Tisza: [C: 04-1] "Added bug reference to commit message. Previous comments are still valid." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [18:16:19] (03CR) 10MarkTraceur: "Tested now. Lots of fields seem to stay the default, but it looks like they were that way before, so I'm going to say it's fine." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 (owner: 10Gilles) [18:27:03] fabriceflorin: There are several user-facing changes that are Ready for Testing, in case you have time to test them today [18:32:47] marktraceur: OK, will test them today. Should I just check them on beta, based on the list now on Mingle? [18:34:21] Yeah [19:17:29] tgr: I can't reproduce your scroll issue in firefox nor chrome [19:17:44] are you sure you're running the latest version of the patch with cache disabled? [19:17:59] fairly sure [19:18:27] i'll just merge and look into it later [19:18:43] it is an improvement over the current situation at any rate [19:21:32] (03CR) 10Gergő Tisza: [C: 032] "Gilles can't reproduce the issue I mentioned in the comment; I'll double-check later, but even if it is reproducible it is less broken tha" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [19:23:16] (03Merged) 10jenkins-bot: Restore article scroll after closing Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [20:26:33] Gasp, theopolisme is visiting on Thursday! [20:26:37] Excitiiiiing [21:10:11] tgr: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/448 I'm wondering which "other SVG icons" are "working" [21:10:18] "work[ing] fine" [21:13:47] huh [21:14:01] looks like the ones that are working are actually png icons [21:14:16] Oh. [21:14:21] Well that makes sense [21:14:36] Because they *actually* have a maximum size. :) [21:15:06] svg icons do report a maximum size though [21:15:08] I will first mark this as a bug in the mediawiki image scaling code, I think [21:15:17] Then I will ignore that bug and fix it on our side [21:15:24] and as far as i can remember we did respect them at some point [21:15:54] or maybe not [21:16:19] I don't think so [21:16:27] That sysadmin logo has been my test image on mw.org for a while [21:16:32] And I don't remember it ever working right [21:16:39] hm [21:16:50] not even sure what should be the expected behavior here [21:17:21] I mean...show the maximum size, if it's small enough [21:18:21] Hm [21:19:57] So... http://www.mediawiki.org/w/api.php?action=query&format=json&titles=File:MediaWiki-sysadmins-icon.svg&prop=imageinfo&iiprop=url|size [21:20:03] Looks like it has a max size [21:20:07] And a URL that it passes [21:20:10] So...quick fix! :) [21:21:22] i think the problem is just that we always request a window-sized thumbnail and assume that we won't get larger than the max size anyway [21:23:27] Right. [21:23:35] tgr: So I'm filing the bug and then adding the check [21:41:50] fabriceflorin: There are now 14 people on the CC for that email, can we please send it to wikitech-l and make it less confusing [21:44:09] marktraceur: At Howie’s request, I had no choice but to give the community team a chance to comment, as this product impacts several different teams at a high level. That’s the issue with products that are owned by multiple projects. I think we will reach resolution, but it will invitably take time. [22:01:13] fabriceflorin: That's not my concern, my concern is that we're unnecessarily complicating the CC field and keeping this internal when it may not need to be [22:04:30] marktraceur: I think the Cc: field will get smaller soon, once everyone has chimed in and smaller groups get to work on their assigned tasks. Before we go external with this, Philippe would like us to have a clear understanding as a foundation as to what we want to get out of this. So again, this project is bigger than you and me, let’s give our colleagues a chance to chime in with their recommendations and we can take it from there [22:07:17] * marktraceur itchy about a slight community/Foundation split feeling in there [22:30:47] Argh failure [22:36:56] (03PS1) 10Gergő Tisza: Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 [22:37:34] (03CR) 10jenkins-bot: [V: 04-1] Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza) [22:38:25] (03PS2) 10Gergő Tisza: Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 [22:44:34] (03PS1) 10MarkTraceur: Don't display too-big thumbnails [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125893 [22:45:05] (03CR) 10jenkins-bot: [V: 04-1] Don't display too-big thumbnails [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125893 (owner: 10MarkTraceur) [22:49:10] (03PS2) 10MarkTraceur: Don't display too-big thumbnails [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125893 [23:08:15] marktraceur: Hey Mark, I noticed that you stopped posting daily scrum notes on 03/25. The rest of us are still updating on our end, and you may want to do the same, as it’s a helpful way to see what the team is doing. https://www.mediawiki.org/wiki/Multimedia/Scrum_notes [23:08:35] Ugh, yeah, I'm terrible at that [23:11:03] fabriceflorin: Done for today, will set up reminders for more different days [23:12:26] marktraceur: Cool. I’m just as bad as you are, so I know how you feel. What did it for me was to schedule a daily reminder in my calendar. I now find the practice helpfulf for my own time management :) [23:12:41] Considering my distaste for Calendar... [23:12:51] I'm fixing up the bot that used to poke me on IRC for this purpose [23:14:04] (03CR) 10Gergő Tisza: [C: 04-1] Don't display too-big thumbnails (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125893 (owner: 10MarkTraceur) [23:18:09] Or...maybe I'm not! [23:18:15] It doesn't like the new python version. [23:18:18] * marktraceur schemes [23:21:08] (03PS3) 10Gergő Tisza: Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 [23:29:25] tgr_: Is displaying an SVG an issue? [23:30:04] yes, older browsers don't handle it [23:30:18] Sigh [23:30:25] True. [23:30:55] * marktraceur does that [23:32:10] also, maybe security issues [23:32:46] currently you have no way of embedding SVG in a page so if we supply one that would need security review [23:33:34] Right [23:39:12] Woohoo, I crashed my browser [23:39:21] I feel like I just won the lottery [23:39:23] (03PS1) 10Dan-nl: UploadWizard is missing a SpecialPageAlias for Campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913