[00:01:21] (03PS1) 10MarkTraceur: Do not load too-big thumbnails [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125918 [00:01:25] tgr: Taaaaake two. [00:01:28] :) [00:01:54] (03CR) 10jenkins-bot: [V: 04-1] Do not load too-big thumbnails [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125918 (owner: 10MarkTraceur) [00:02:03] Argh [00:02:36] (03PS2) 10MarkTraceur: Do not load too-big thumbnails for SVGs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125918 [00:04:23] Better [00:27:25] marktraceur: I tested and accepted all cards in the testing column — except this one, which I do not know how to test: #426 Only load oojs-ui when Use this File is clicked. Nicely done! [00:37:42] Thanks! [00:37:49] We should be fine to test that ourselves [01:08:18] marktraceur: Sounds good. Thanks for letting me know when there are new things I can test. The next few days will be busy for me, due to interviews for the DCE role. But I will make time to check things out as quickly as possible. [01:08:30] marktraceur: Overall, the current release looks pretty darn good, if you ask me. Very few issues raised so far, and most of them are being addressed already. You’re already monitoring the talk page, but here’s the survey results page, FYI: https://www.mediawiki.org/wiki/Multimedia/Media_Viewer/Survey#Results [01:10:19] over and out for today. see you tomorrow! [01:53:20] (03PS1) 10Gergő Tisza: Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 [01:54:53] (03CR) 10jenkins-bot: [V: 04-1] Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 (owner: 10Gergő Tisza) [02:07:41] (03PS4) 10Gergő Tisza: Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 [02:07:43] (03PS2) 10Gergő Tisza: Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 [02:08:49] (03CR) 10jenkins-bot: [V: 04-1] Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 (owner: 10Gergő Tisza) [02:18:12] (03PS3) 10Gergő Tisza: Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 [02:44:16] (03PS1) 10Gergő Tisza: Choose feedback survey based on user language [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125936 [02:44:48] (03CR) 10jenkins-bot: [V: 04-1] Choose feedback survey based on user language [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125936 (owner: 10Gergő Tisza) [02:48:53] (03PS2) 10Gergő Tisza: Choose feedback survey based on user language [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125936 [12:07:18] (03CR) 10Gilles: "Yep, there are plenty of date formats that looks basic which moment.js doesn't recognize." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 (owner: 10Gilles) [12:08:27] (03PS5) 10Gilles: Load moment.js on demand [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 [12:13:33] (03PS6) 10Gilles: Load moment.js on demand [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 [12:13:42] (03CR) 10Gilles: Load moment.js on demand (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 (owner: 10Gilles) [12:21:17] (03CR) 10Gilles: "Should this be abandoned? It seems like you switched to https://gerrit.wikimedia.org/r/#/c/125918/" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125893 (owner: 10MarkTraceur) [12:23:10] (03CR) 10Gilles: [C: 04-1] Do not load too-big thumbnails for SVGs (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125918 (owner: 10MarkTraceur) [13:35:41] (03CR) 10Gilles: [C: 04-1] Add routing classes (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza) [13:35:59] (03CR) 10Gilles: [C: 04-1] Replace current URL generation logic with routing classes (036 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 (owner: 10Gergő Tisza) [13:55:20] (03CR) 10Gilles: [C: 04-1] Choose feedback survey based on user language (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125936 (owner: 10Gergő Tisza) [14:09:29] (03PS1) 10Gilles: Fix E2E scroll assertion logic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125992 [14:25:34] (03PS1) 10Gilles: Add history back button test to E2E [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125997 [16:25:33] (03PS2) 10Gilles: Track more user actions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125746 [17:33:20] (03CR) 10Gergő Tisza: "> Yep, there are plenty of date formats that looks basic which moment.js doesn't recognize." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 (owner: 10Gilles) [18:20:58] (03CR) 10MarkTraceur: Do not load too-big thumbnails for SVGs (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125918 (owner: 10MarkTraceur) [18:21:10] (03PS3) 10MarkTraceur: Do not load too-big thumbnails for SVGs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125918 [19:25:12] (03PS5) 10Gergő Tisza: Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 [19:26:08] (03CR) 10jenkins-bot: [V: 04-1] Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza) [19:27:23] (03CR) 10Gergő Tisza: Add routing classes (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza) [19:28:05] (03PS6) 10Gergő Tisza: Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 [19:28:31] (03CR) 10jenkins-bot: [V: 04-1] Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza) [19:32:33] (03PS4) 10Gergő Tisza: Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 [19:33:26] (03CR) 10jenkins-bot: [V: 04-1] Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 (owner: 10Gergő Tisza) [19:35:58] (03PS5) 10Gergő Tisza: Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 [19:36:30] (03CR) 10jenkins-bot: [V: 04-1] Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 (owner: 10Gergő Tisza) [20:02:11] fabrhttps://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer#Link_to_Media_Viewer_on_Commons [20:02:17] Oh, he's not here. [21:34:56] tgr: FYI I'm taking https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/452 [21:51:35] (03PS7) 10Gergő Tisza: Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 [22:00:27] (03PS1) 10MarkTraceur: Fix issues with file page link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126143 [22:04:47] (03PS6) 10Gergő Tisza: Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 [22:05:20] (03CR) 10jenkins-bot: [V: 04-1] Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 (owner: 10Gergő Tisza) [22:07:07] (03CR) 10Gergő Tisza: Replace current URL generation logic with routing classes (036 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 (owner: 10Gergő Tisza) [22:07:44] (03PS7) 10Gergő Tisza: Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 [22:24:12] tgr: Should we try to get the file page fix out for the SWAT, y'think? [22:24:15] Up to you [22:25:36] today? [22:25:50] that's 16:00? [22:26:30] Yeah, I think so [22:26:40] But like...you need to review it, so if it's not ready by then it's KO [22:26:44] OK even [22:30:45] marktraceur: can you add a setup/teardown to save/restore the real value of wgMediaViewerOnClick? [22:30:56] Hmm. [22:31:04] "yes" but qunit doesn't really have that concept [22:31:13] So it'd be as manual and messy as this, roughly [22:31:26] it does [22:31:31] ...what? [22:31:38] via the environment [22:32:04] http://api.qunitjs.com/QUnit.testStart/ you mean? [22:32:13] in the MW framework it looks like QUnit.newMwEnvironment({setup:..., teardown:...}) [22:32:17] Ohhhh [22:32:23] OK, can do. [22:32:53] in general second parameter to http://api.qunitjs.com/module/ [22:37:30] (03PS2) 10MarkTraceur: Fix issues with file page link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126143 [22:37:32] Much more better. :) [22:40:22] there is an empty line with whitespaces that jshint will probably complain about, looks good to me otherwise [22:41:49] If jshint complains, I will deal with it. [22:41:56] in the long term we probably want a separate entry point when opening the viewer from JS, but that's not a backportable change [22:42:01] By taking it out back and shooting...wait, what, why didn't vim catch that [22:42:16] (03PS3) 10MarkTraceur: Fix issues with file page link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126143 [22:42:23] (fixed) [22:43:18] (03PS1) 10Gergő Tisza: [WIP] Add position handling to URLs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126153 [22:43:59] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add position handling to URLs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126153 (owner: 10Gergő Tisza) [22:46:50] (03CR) 10Gergő Tisza: [C: 032] Fix issues with file page link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126143 (owner: 10MarkTraceur) [22:47:24] (03Merged) 10jenkins-bot: Fix issues with file page link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126143 (owner: 10MarkTraceur) [22:47:59] where is this going, wmf21? [22:49:28] Uhhh 22 I think [22:51:40] tested there, seems all good to me [23:00:49] 'kayyyy [23:04:21] (03PS1) 10MarkTraceur: Fix issues with file page link [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126158 [23:05:56] (03CR) 10Mwalker: [C: 032] Fix issues with file page link [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126158 (owner: 10MarkTraceur) [23:17:08] marktraceur: fabriceflorin: we should deploy https://gerrit.wikimedia.org/r/#/c/125936 and a config change in tomorrow's SWAT if we want to launch with localized surveys [23:17:40] tgr: sounds good. I will create the different surveys now. [23:17:40] should i take that? one of the outcomes of the last retrospective was to spread SWATs [23:18:29] tgr: We don't have to deploy, mwalker or ori would [23:18:34] Just stick it on the calendar [23:18:41] even better [23:18:58] We should probably train you and/or gi11es to deploy though [23:19:06] * marktraceur wonders if roblaAWAY is interested in this concept [23:19:19] but i should create a patch for the deploy branch, right? [23:21:47] Yeah, a cherry pick [23:23:41] fabriceflorin: The expand link now works for everyone. [23:25:59] marktraceur: Wonderful, thank you! I can confirm this on my browsers, where the share and embed links also work as intended. Nicely done! [23:26:11] Excellent. [23:26:15] ...wait [23:26:21] The share/embed fix is working now? [23:26:35] Oh, no, that was the case earlier. Never mind :) [23:28:54] marktraceur tgr : Actually, I am wrong, the share and embed links still are missing the ‘File’ prefix. But if you use a properly formatted link with ‘#mediaviewer/File:’ in it, it works as intended. So the main thing we need to fix now is the Embed and Share links, which I hope we can do by this Thursday. Do we need a ticket for that? [23:29:03] OK [23:29:06] Uh [23:29:12] I think there is one, and it's in testing on beta. [23:30:10] i thought the URLs themselves have been working for a while [23:30:29] just the expand button didnt [23:31:12] Hm [23:31:21] tgr: Visiting a URL works, but us generating the URL doesn't always [23:31:27] Are you suggesting that #371 will add the missing ‘File:’ prefix? Or is there another ticket for that? https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/371 If you click on the Share link icon, it is still missing ‘File:’ [23:31:33] yeah [23:32:04] Oh good, so tgr has it under control, then :) Do you think we can deploy this on Thursday? [23:32:08] Aha. [23:32:10] Probably [23:32:19] Lemme...oh this is the routing thing [23:32:24] That'll be a big review, but it's possible [23:32:26] #371 will fix it [23:32:31] if its merged by then [23:32:42] If not we can backport. Latest Monday. [23:32:49] Cool. I have just prepared a landing page to invite comments from the Commons community, and will email Commons shortly to invite them to test these features — as well as post on their Village Pump. [23:33:23] fabriceflorin: I think there is still no response on some comments on our talk page. [23:33:53] OK, I will go respond to these comments first, before promoting to a wider audience. [23:42:39] marktraceur: do you know of a way to get language fallbacks in JS? [23:43:00] Uhhh [23:43:01] No. [23:43:14] I don't think it's possible without an API call because LangEng is bad at frontend [23:43:22] * marktraceur unashamed of this opinion. [23:45:56] i wonder if ResourceLoaderGetConfigVars is cached per-language [23:46:51] it has a langcode in its urls so probably yes