[00:41:59] (03PS2) 10Gergő Tisza: [WIP] Use sinon.js mocks to test the thumbnail fetching [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 [00:42:01] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use sinon.js mocks to test the thumbnail fetching [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [01:27:48] (03PS3) 10Gergő Tisza: [WIP] Use sinon.js mocks to test the thumbnail fetching [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 [01:28:25] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use sinon.js mocks to test the thumbnail fetching [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [01:39:09] (03PS4) 10Gergő Tisza: [WIP] Use sinon.js mocks to test the thumbnail fetching [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 [01:57:56] (03PS5) 10Gergő Tisza: Use sinon.js mocks to test the thumbnail fetching [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 [02:07:27] (03PS6) 10Gergő Tisza: Use sinon.js mocks to test the thumbnail fetching [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 [02:59:26] holaaaaaaaaa [03:03:22] Hi! [03:05:37] hi [03:05:54] ves [03:06:14] puros estadounidenses o canadienses [03:06:37] :) [03:06:38] hola [03:06:44] hola [03:06:56] y que edad tienes [03:07:08] 13 y tu [03:07:13] 12 [03:07:26] de donde ees [03:07:31] eres [03:08:20] holaa [03:08:36] hola [03:08:53] como estan vale [03:08:56] venezuela(maracaibo) [03:08:56] y tu [03:09:01] uds no hablan ? [03:09:06] bien [03:09:19] no so de aqui [03:09:33] ablan igles [03:09:52] chaoo [03:09:58] chao [03:10:18] :-[ [03:10:22] chaito :I) [03:10:35] ;-) [17:58:30] fabriceflorin: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/460 so refresh my memory - is our proposed solution to add the click handler on those links, breaking the link= option, or...what? [18:00:38] marktraceur: I am not sure what the technical solution is, but the end user should be able to see these images in Media Viewer. At the same time, we don’t want to break things, so we may need to ask advice from the community members who use this template. What would you recommend, from your perspective? [18:01:50] I would recommend that the expectation is unreasonable [18:02:10] I can explain that to Eloquence and howief if you'd like (ohai Eloquence) [18:02:44] If the person adding the image is saying that they want the image link to go to the article instead of the file page, we shouldn't mess with that [18:04:59] Or to the file page explicitly? Hm I'm not sure I get this [18:21:47] tgr: don't you have access to the ops list archives? [18:22:09] I know that non-wmf readers of our list couldn't read the backlog, but I left that message for you guys [18:22:13] gi11es: if i do, then i am unaware of it [18:22:21] but let me check [18:22:36] tgr: you might just have to join the ops list [18:22:59] I have access to it anyway, and that's all I did [18:25:57] the lists description says NDA required... not sure i can just go and join [18:27:53] I didn't do anything special, it did require these guys to approve my request, but since you're an employee I don't see why they wouldn't [18:27:56] (03PS1) 10MarkTraceur: Link to creativecommons.org for CC licenses [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127282 [18:28:02] they certainly didn't ask me to sign an NDA [18:28:54] Really? [18:28:58] I thought we did for all new folk [18:29:19] I mean they didn't ask me for an NDA to join the ops mailing list... [18:29:22] Ah. [18:29:26] I'm sure my contract contained an NDA [18:29:27] It might be a general staff NDA [18:29:31] right [18:30:28] the stats look quite nice [18:30:44] the geometric thing is retroactive, right? [18:30:58] yeah [18:31:17] the maps are definitely a lot more logical [18:31:53] image hits take longer than image misses [18:32:00] maybe something is swapped there? [18:37:45] let me check [18:39:30] also, can we display somewhere on the graphs these are geometric mean etc? right now it just says statistical mean, which is a different thing [18:40:01] if that is fixed, i think you should advertise these on wikitech-l [18:40:25] i think they are very interesting even if one does not particularly care about MediaViewer [18:40:34] yes I suspect limn might have inverted them [18:40:46] they're not declared in the same order as the columns appear on the table [18:40:59] the limn config does declare which column it should read, but... [18:41:07] (03PS1) 10MarkTraceur: Use indexpageids [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127284 [18:41:13] tgr: yes I'm going to update the explanation on the graphs [18:41:35] I just didn't have time to write the patch for that yesterday [18:41:38] (03CR) 10jenkins-bot: [V: 04-1] Use indexpageids [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127284 (owner: 10MarkTraceur) [18:41:47] it would be interesting to see cache hit/miss maps as well, there are varnishes outside the USA so those might be significally different geographically [18:41:48] I'll check if swapping the order in the limn config swaps the graphs [18:43:07] gi11es: what do you think of the ops discussion? should we take on caching and/or query batching? [18:43:31] tgr: I think we should at least cache for 24 hours [18:43:39] I think that'll satisfy faidon for the launches [18:44:07] batching makes sense in theory, but since we have to measure the benefits, etc. it's quite time-consuming [18:44:13] caching the imaginfo for a day will make people unhappy [18:44:30] i don't think any of the other apis would be an issue [18:45:32] then again, extmetadata is the main thing we use there, and it is already cached for 12h on the server side, if it is a cross-domain image, which most are [18:46:37] but it would still make the life of community members painful when they are updating templates so metadata is parsed correctly from local images [18:47:13] (03PS2) 10MarkTraceur: Use indexpageids [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127284 [18:51:41] marktraceur, the Commons icon next to 'Learn more on Wikimedia Commons' is an ICO scaled up, so it doesn't look crisp. [18:51:44] Known issue? [18:53:09] superm401: Yeah, I think we fixed it - can you reproduce on mw.org?+ [18:56:31] tgr: I confirm the swap due to the order of definitions in the limn data source [18:56:39] I'll send a merge request to marktraceur shortly [18:57:50] marktraceur, nope, no longer fuzzy. [18:57:52] Thanks. [19:00:11] gi11es: For some reason the image (hit) is consistently higher than the image (miss) line. [19:00:23] marktraceur: that's what I'm fixing now [19:00:23] Except for a few catastrophic spikes [19:00:27] Oh, 'kay [19:00:39] marktraceur: https://gitorious.org/analytics/multimedia-limn/merge_requests/8 [19:00:42] * marktraceur flails arms, goes back to more different bugs [19:00:47] Oh, sure, will fix soon [19:01:00] turns out that the order of datasource column definition matters if you don't specify indexes [19:01:20] (despite the fact that the columns are named) [19:08:54] tgr: OK, this is totally a bug, but let me say, what a silly place to put a metadata class [19:09:27] (in https://hu.wikipedia.org/wiki/Wikip%C3%A9dia:Javaslatok_kiemelt_k%C3%A9pekre/Arch%C3%ADvum_2013) [19:09:37] i don't think 99% of the template editors know what classes are for [19:10:00] they are just randomly copy-pasted when people base templates on similar ones [19:12:47] Heh [19:12:49] Helpful [19:12:59] In any case I cannot repro on mw.org or locally [19:13:08] Maybe it got magically fixed in wmf22 [19:33:22] marktraceur: I don’t understand your point about #460. The problem as I understand it as that when you click on images ‘In the news’ on enwiki’s main page, you are taken to the file page, not to a separate section as you seem to imply. The recommended behavior is to show that image in Media Viewer instead of going to the file page. Does that goal make sense to you? https://en.wikipedia.org/wiki/Main_Page [20:02:30] fabriceflorin: The cause of this issue is the problem [20:02:42] fabriceflorin: The template uses a link= parameter that just so happens to go to the file page [20:02:51] I cannot in good conscience override a link= parameter [20:03:00] Because more often than not it won't go to the file page. [20:03:05] The template should get fixed [20:03:35] marktraceur: Ah, I see. Maybe we could ask community members what they think. [20:04:23] fabriceflorin: Literally the options are 1. Have the template authors fix their broken assumption 2. Break link= options for everyone [20:04:42] Or 3. Break link= options in a stupid case that should never happen anyway [20:05:00] But I don't see why we should need to spend time on that, when the people making the mistake could do it more easily [20:05:05] marktraceur: Thanks. I’m on a call now, but will respond when I’m done. [20:05:37] You don't need to respond promptly if you can't [20:05:41] IRC isn't going anywhere [20:05:51] ok, thx. [20:06:15] (03CR) 10Gergő Tisza: Link to creativecommons.org for CC licenses (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127282 (owner: 10MarkTraceur) [20:07:05] (03CR) 10MarkTraceur: Link to creativecommons.org for CC licenses (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127282 (owner: 10MarkTraceur) [20:16:30] marktraceur: we should ask enwp admins to fix this, if they don't want to, we can always just detect special classes, say .use-mmv and .dont-use-mmv, so that people can fine-tune which images to display [20:16:46] :/ [20:17:04] I'll post on the template talk page [20:19:16] that said, an argument could be made that main page images should just take the user to the article and not to the lightbox [20:19:30] as a reader, that's more in line with what i would expect [20:20:40] Well yeah [20:20:48] Just noticed this: when I try to download a file that’s in a format like TIFF via the mediaviewer, it’s a like funky. e.g. https://commons.wikimedia.org/wiki/Category:Harriet_Tubman#mediaviewer/File:General affidavit of Harriet Tubman (1898), front.tif [20:20:51] That's probably why there's a link param in that template in the first place [20:20:57] It’s displaying the file extension of the original file, even though it only lets you download in JPG. And there is no option for downloading the original file format. [20:22:09] Hm. [20:22:23] I guess we give you a download link for the full size thumbnail [20:22:54] Right, so the displayed format is wrong. [20:22:58] Hm. [20:23:08] Not sure if that's intentional, tbh [20:23:10] I think an original file option in the menu would be nice. [20:23:12] for the fullsize, the link is wrong [20:23:38] for the other sizes, the displayed format is wrong [20:23:57] i'll file a card [20:25:09] marktraceur: iirc that template was written lazily, so even if you don't pass a link parameter to the template, the wikicode will have one [20:25:09] tgr: The link is correct, since it says “original size” but not “original file”. You can get a full-size JPG thumbnail of a TIFF in the normal interface as well, so that’s fine. [20:25:18] the author probably thought [[File:foo.png]] and [[File:Foo.png|link=File:Foo.png]] is the same thing [20:25:42] Yeah [20:25:55] tgr: That's the essence of my message on the talk page but yeah [20:25:56] Anyway [20:26:25] Dmcdevit: still, downloading the original file should be possible [20:26:35] maybe we need a separate option for that? [20:26:37] tgr: Also for #466 I'm not able to reproduce when using debug=true, so it's probably either a race condition (a gadget messing with the classes?) or a caching issue [20:27:13] marktraceur: let's see if it goes away in a week then [20:27:26] I could also try to convince greg-g to let us touch the files :DDDD [20:27:27] Right, agreed. But I don’t think a full-size thumbnail is wrong. So there are two issues: (1) displayed format is wrong for all current options, and (2) original file download should be possible. [20:27:37] it is not much of an issue since it only affects archived featuring discussions [20:27:40] Hm I can't grin at him in person, he's not at his desk. [20:27:53] OH, I won't worry about it then [20:29:02] marktraceur: https://twitter.com/iamdevloper/status/450905958139834368/photo/1 [20:30:16] greg-g: I know I know [20:30:22] I thought it was affecting more useful thing [20:30:23] s [20:30:27] But it's not so it's OK [20:30:33] I haven't read anything other than your ping [20:30:50] "...t stop the site from throwing 503s at every request" [20:31:00] :) [20:31:07] But yeah it's fine [20:31:32] ? [20:31:37] really, I'll read up if needed [20:31:41] No it's fine [20:31:50] No deploy needed [20:31:53] No touching files [20:31:53] kk [20:32:00] * greg-g wanders back out [20:35:44] Ooh, tgr, some CMD work for you: https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer#.22Created_on_1828.22 [20:35:57] Parsing the microformat that tells us what parts of the date are available [20:36:30] I was about to reply saying there was no way it would be detectable but it actually looks sane [20:36:46] i dont think this is CMD-related [20:36:55] more like moment.js [20:37:11] or do we actually misread/ignore the date there? [20:37:21] Oh? [20:37:33] I think it's our message saying "Created on", not moment's [20:38:02] So we could make one for non-specific dates [20:38:19] And one for more specific ones maybe - "Created on $date at $time" [20:38:51] sounds like something that each extension should not have to solve on its own [20:39:00] Well yeah [20:39:15] But this is a Commons machine-readable data format [20:39:17] AFAICT [20:39:29] So at least giving us the data is a CMD thing [20:39:39] Actually implementing the messages could maybe be a core thing [20:39:42] well, CMD just passes the string [20:40:02] if it parsed it, it would have to return machine-readable partial dates [20:40:02] Including the microformat stuff? Hm, OK, that should be fine then [20:40:09] not sure we want to go there [20:40:20] I thought it might have been getting stripped [20:40:31] there is no sane PHP representation for partial dates [20:40:45] no, it returns the time tag as well [20:41:01] 'kay, then never mind. :) [20:41:07] i'll ping the language team about this [20:41:44] i guess there could be a core message saying "in year" [20:41:54] and "in year month" [20:42:03] and "on year month day" [20:42:31] Sure [20:42:35] but someone will surely point out dozens of localizations for which this is still not generic enough [20:42:41] Ugh. [20:42:55] I think there are already a bunch of time-related core messages [20:43:21] Created in the context of recent changes or something [20:43:25] and then there is the issue of handling partial dates in javascript, not sure if moment does that [20:44:50] Almost certainly not [20:44:52] Arright [20:44:58] It can stay on the backlog [20:45:34] on a first glance it does not [20:46:12] i vaguely recall looking for something that does, when i looked at moment.js alternatives, and they all were obscenely large [20:46:21] not that moment is not [20:46:36] but even more [20:47:41] tgr: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/465 I'm going to remove this if that's cool [20:47:48] Since it's a dupe [20:48:42] sure [20:49:01] Done [20:49:08] i'll pull in the two originals for this week, since this seems to be the major complaint [20:49:35] or at least i hope that this is the major complaint, because the alternative is that images actually do not load [20:50:02] One's blocked on design [20:51:18] tgr: What does 458 look like, estimation-wise? [20:53:13] two points, i suppose? need to move some stuff from metadataPanel.set to an earlier call, probably [20:56:47] Set [21:18:19] fabriceflorin: Still on the call? [21:27:30] (03PS1) 10MarkTraceur: Show scrollbars in survey window in Firefox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127372 [21:36:51] (03CR) 10Gergő Tisza: [C: 032] Link to creativecommons.org for CC licenses (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127282 (owner: 10MarkTraceur) [21:36:52] Hi marktraceur — yes, I’m here, done with the call. [21:37:20] (03Merged) 10jenkins-bot: Link to creativecommons.org for CC licenses [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127282 (owner: 10MarkTraceur) [21:37:32] Would you like me to test anything on beta? [21:38:14] marktraceur: fabriceflorin: shouldn't we make CC deed links open in a new window? [21:38:42] (probably should have asked this before merging...) [21:40:51] tgr: I think it would be a nice touch to open in a separate window, though it’s not a must-have. I notice that Commons file pages go straight to the deed page in the same window. But the context is different than Media Viewer’s immersive experience, so I would recommend the separate window going forward. https://creativecommons.org/licenses/by-sa/3.0/deed.en [21:42:19] wiki links have consistent style for internal/external [21:42:58] with MediaViewer you never know what is a button and what is a link that will navigate you away [21:43:11] and if it will, whether you will remain on the same wiki or not [21:44:29] (03CR) 10Gergő Tisza: [C: 032] Show scrollbars in survey window in Firefox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127372 (owner: 10MarkTraceur) [21:44:57] fabriceflorin: #460 is the issue at hand [21:44:58] (03Merged) 10jenkins-bot: Show scrollbars in survey window in Firefox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127372 (owner: 10MarkTraceur) [21:45:53] I posted to the template and told them to fix their template [21:46:42] is suppose #468 should be backported? [21:46:55] Maybe? [21:46:59] It doesn't seem too critical [21:47:06] But we could backport on Monday [21:47:38] i'll add a SWAT request [21:47:51] not a big deal, but also zero chance of breaking stuff [21:48:03] But not on Friday [21:48:04] So [21:49:13] marktraceur: Regarding #460, it sounds like this is something that the community needs to fix, not us. But could you please let me know what exactly the community needs to do to fix that template — or its use of that template? How should the script be fixed so that Media Viewer can display the image? Once we have that technical info, it will be easier to explain to community members what we recommend they do. [21:49:33] fabriceflorin: https://en.wikipedia.org/wiki/Template_talk:In_the_news/image [21:49:45] You don't need to explain, I already did [21:50:12] (03PS1) 10Gergő Tisza: Show scrollbars in survey window in Firefox [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127374 [21:50:39] (03PS1) 10Gergő Tisza: Show scrollbars in survey window in Firefox [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127375 [21:50:48] Wonderful, just what I was looking for. Will ask Keegan to help us contact the right people and ask if they would consider fixing this. Anything else you need from me? [21:51:02] ...we don't need to contact people [21:51:10] (03CR) 10jenkins-bot: [V: 04-1] Show scrollbars in survey window in Firefox [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127375 (owner: 10Gergő Tisza) [21:51:14] The talk page is the right place unless I'm vastly mistaken [21:51:52] marktraceur: OK, let’s wait and see if anyone responds or acts on this. If they don’t, we’ll poke around a bit more. [21:52:00] (03PS2) 10Gergő Tisza: Show scrollbars in survey window in Firefox. [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127375 [21:52:34] (03CR) 10Gergő Tisza: "Edited commit msg to re-run segfaulted tests." [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127375 (owner: 10Gergő Tisza) [21:54:04] Yeah, marktraceur is right [21:54:18] We don't need to contact people, much less to ask them to fix things that are our problem [21:54:43] ... [21:54:49] Keegan: The point is that it's not our problem [21:54:59] But the talk page for the template that needs fixing seems like the best place [21:54:59] Yeah *not our [21:55:02] Oh, kay [21:55:03] Missed the not ;) [22:03:31] marktraceur keegan : Sounds like we have a plan. But if the problem doesn’t get fixed, we may need to nudge folks. Even though it’s not technically our problem, people will think that it is and blame us anyway. [22:12:13] OK I'm going to unschedule it and comment. [22:37:09] (03CR) 10Gergő Tisza: "I fail to see the point of this. $.each is basically a for loop itself, and could be replaced by a plain for loop if needed. Not that ther" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127284 (owner: 10MarkTraceur) [22:38:54] (03PS1) 10Gergő Tisza: Restore article scroll after closing Media Viewer [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127381 [23:29:27] (03PS1) 10Gergő Tisza: Show metadata panel immediately [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384