[01:17:00] (03CR) 10Gergő Tisza: "Ah, I thought that's just somet broken legacy code... I never saw it working. Maybe it only doesn't work on Chrome? Or is it just too quic" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [02:14:00] (03PS1) 10Gergő Tisza: Test change [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127590 [02:14:02] (03CR) 10jenkins-bot: [V: 04-1] Test change [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127590 (owner: 10Gergő Tisza) [02:15:05] (03CR) 10Gergő Tisza: [C: 032] "Don't mind me, just testing." [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127590 (owner: 10Gergő Tisza) [02:15:07] (03CR) 10jenkins-bot: [V: 04-1] Test change [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127590 (owner: 10Gergő Tisza) [02:16:51] (03CR) 10Gergő Tisza: Test change [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127590 (owner: 10Gergő Tisza) [02:17:05] (03CR) 10Gergő Tisza: [C: 032 V: 032] Test change [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127590 (owner: 10Gergő Tisza) [02:17:07] (03CR) 10jenkins-bot: [V: 04-1] Test change [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127590 (owner: 10Gergő Tisza) [05:44:08] (03PS1) 10Gergő Tisza: Try HTML in dashboard description [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127595 [05:44:11] (03CR) 10jenkins-bot: [V: 04-1] Try HTML in dashboard description [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127595 (owner: 10Gergő Tisza) [05:45:01] (03CR) 10Gergő Tisza: [C: 032 V: 032] Try HTML in dashboard description [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127595 (owner: 10Gergő Tisza) [05:45:03] (03CR) 10jenkins-bot: [V: 04-1] Try HTML in dashboard description [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127595 (owner: 10Gergő Tisza) [05:51:50] (03PS1) 10Gergő Tisza: Remove HTML from description *sigh* [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127596 [05:51:52] (03CR) 10jenkins-bot: [V: 04-1] Remove HTML from description *sigh* [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127596 (owner: 10Gergő Tisza) [05:52:29] (03CR) 10Gergő Tisza: [C: 032 V: 032] Remove HTML from description *sigh* [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/127596 (owner: 10Gergő Tisza) [08:53:42] (03CR) 10Gilles: "It's fast, but definitely visible both in Firefox and Chrome. The bar fades to black and back to its normal color when if jumps. If I can " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [10:05:52] (03CR) 10Gilles: "Considering your conclusions shown in the commit message, have you looked into alternatives to sinon? Like https://github.com/keronsen/jac" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [10:36:05] (03CR) 10Gilles: [C: 04-1] "19 more lines of code, an extra API parameter (presumably slightly increasing the amount of server-side time needed to generate/return the" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127284 (owner: 10MarkTraceur) [10:39:31] (03CR) 10Gilles: [C: 032] Collect license handling code, remove unused data attribute [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127390 (owner: 10Gergő Tisza) [10:40:08] (03Merged) 10jenkins-bot: Collect license handling code, remove unused data attribute [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127390 (owner: 10Gergő Tisza) [10:41:24] (03CR) 10Gilles: [C: 032] Show 'view terms' when we can't figure out the license [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127393 (owner: 10Gergő Tisza) [10:42:12] (03Merged) 10jenkins-bot: Show 'view terms' when we can't figure out the license [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127393 (owner: 10Gergő Tisza) [10:42:42] (03CR) 10Gilles: [C: 032] Use short license name from template if we don't recognize it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127391 (owner: 10Gergő Tisza) [10:43:12] (03CR) 10jenkins-bot: [V: 04-1] Use short license name from template if we don't recognize it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127391 (owner: 10Gergő Tisza) [10:47:02] (03CR) 10Gilles: [C: 04-1] Display correct file type on download button (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127400 (owner: 10Gergő Tisza) [11:38:02] (03PS1) 10Reedy: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/127617 [11:38:45] (03PS1) 10Reedy: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127618 [11:39:56] (03PS1) 10Reedy: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127619 [11:40:14] (03CR) 10Reedy: [C: 032] Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127618 (owner: 10Reedy) [11:40:21] (03Merged) 10jenkins-bot: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127618 (owner: 10Reedy) [11:45:26] (03CR) 10Reedy: [C: 032] Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127619 (owner: 10Reedy) [11:45:54] (03Merged) 10jenkins-bot: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127619 (owner: 10Reedy) [16:32:33] (03Abandoned) 10MarkTraceur: Use indexpageids [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127284 (owner: 10MarkTraceur) [17:17:45] (03PS1) 10MarkTraceur: Use original URL when setting download for original [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127655 [17:17:51] Something something testing [17:17:57] Or something [17:22:12] (03CR) 10jenkins-bot: [V: 04-1] Use original URL when setting download for original [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127655 (owner: 10MarkTraceur) [17:26:27] Nice work on the new Multimedia gerrit dashboard, BTW. :-) [17:28:10] James_F: 'twas tgr! [17:28:27] marktraceur: Kudos to tgr then. :-) [17:28:35] And how. It looks supernice. [17:28:46] what did i do? [17:29:05] The Gerrit dashboards! [17:29:07] They're cool [17:30:03] yeah, a nice feature [17:30:32] would be more useful if the gerrit interface had a convenient link to them [17:31:03] but at least we can have many dashboards with one bookmark [17:32:38] (03PS2) 10MarkTraceur: Use original URL when setting download for original [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127655 [17:32:45] Friggin unit tests man [17:43:35] tgr: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/473 I think we need to augment the core API for this to work...is it a blocker? Should/could we do it later? [17:45:55] yeah, we should backlog it unless it is very easy to do [17:46:19] 'kay [17:46:31] i was hoping to fix the download extension display issue this way, but we can just pass the extension of the initial thumbnail or something [17:46:35] Done [17:48:09] fabriceflorin: I'm seeing weirdness on Mingle - are we in Q3 cycle 1 or cycle 2? [17:49:12] marktraceur: We’re still in Q4 - Cycle 1, until next week. The plan is to start Cycle 2 on April 30. [17:49:23] ...huh [17:49:32] "Current cycle" is set to Q3C1 [17:49:41] I'll fix [17:49:50] Oh, no it's not [17:50:05] I still see it set as ‘#250 2013-14 - Q4 - Cycle 1’, so it looks good on my end. [17:50:26] Weird. [17:50:41] I set two sprints to "current cycle" and got Q3C1 [17:50:43] Mingle can be finnecky. Hopefully we won’t have these issues with Phabricator. [17:50:45] But working now [17:50:57] Glad it’s working again … [17:51:26] When did Q4C1 start? April 20? [17:51:32] Er. March 20?\ [17:52:26] (yes, that's the case) [17:52:46] Have fixed the sprint assignments...dunno why they're all messed up [17:59:04] tgr: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/467 can haz estimate? [18:00:32] it was around 2 points i think [18:00:49] 'kay, set [18:04:12] (03CR) 10Gergő Tisza: "I can look into other mock frameworks (I looked at Jack but the documentation is not working), but I am not sure a slightly more expressiv" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [18:04:16] thx [18:12:48] (03CR) 10Gergő Tisza: "Dschwen's recommendation was that we show both an "original size" and an "original file" option when the two are different. Don't know if " (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127655 (owner: 10MarkTraceur) [18:19:13] (03CR) 10MarkTraceur: "Until then, are we going to try to merge this or should we abandon/-2 it?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [18:22:00] (03CR) 10MarkTraceur: [C: 031] "Seems fine to me - should go out in the SWAT today, I guess?" [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127381 (owner: 10Gergő Tisza) [18:28:08] tgr, fabriceflorin, gi11es - do we want to put our names up as guinea pigs for the phabricator migration? [18:28:27] Given it seems to be picking up speed and I don't think we use any of the missing Mingle features anyway [18:28:30] AFAICT [18:28:39] See http://fab.wmflabs.org/T44 [18:29:37] I think we want to try it, but may want to wait until we are further along in the Media Viewer release and other urgent issues before experimenting with it. We have lots on our plate for the next few weeks. [18:31:02] imo we should do this for uploadwizard and stick with mingle for mediaviewer [18:31:24] the wmflabs link is borked [18:36:20] Sure [18:37:43] (03CR) 10Gergő Tisza: "Thinking about it again, maybe" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [18:47:25] tgr: Could also use estimation on https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/472 [18:47:42] (and I sent it back to CR because that's where it is f'real) [18:47:47] (03CR) 10Gergő Tisza: "Added #478 about the bug reports." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [18:48:19] tgr: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/474 not sure where the patch is [18:48:38] i think gi11es merged these [18:48:49] 472 i mean [18:49:00] No, there are two unmerged [18:49:24] oh, i see [18:51:36] i set it to one point [18:51:44] 'kay [18:52:38] (03CR) 10Gergő Tisza: [C: 032] "Removing old reviews, adding new one since the build segfaulted." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127391 (owner: 10Gergő Tisza) [18:53:12] (03Merged) 10jenkins-bot: Use short license name from template if we don't recognize it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127391 (owner: 10Gergő Tisza) [18:59:42] Huzzah [19:02:22] (03CR) 10Gergő Tisza: "Yeah, that's the plan." [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127381 (owner: 10Gergő Tisza) [19:13:15] (03CR) 10Gilles: [C: 04-1] "Related to Gergo's point: if done the way this changeset currently does, "Download original size" is now a bit misleading. "Download origi" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127655 (owner: 10MarkTraceur) [19:41:39] (03PS1) 10Gilles: Bigger, badder, animated progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127695 [19:52:27] (03PS2) 10Gilles: Show metadata panel immediately [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [19:52:58] (03CR) 10jenkins-bot: [V: 04-1] Show metadata panel immediately [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [20:12:25] https://en.wikipedia.org/wiki/Template_talk:In_the_news/image main page image is fixed [20:12:45] fabriceflorin: ^^ [20:13:45] marktraceur: Wonderful! Thanks so much for making this possible. Keegan will be glad to hear this too. [20:14:17] cool [20:26:11] (03CR) 10Gergő Tisza: "Badass :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127695 (owner: 10Gilles) [20:27:30] hey there, https://www.mediawiki.org/wiki/Extension:MultimediaViewer needs update and screenshot to show your excellent progress [20:28:10] spagewmf: Grazie for the ping, I'll probably do that to shield others from out-of-focus [20:33:15] sure, no rush. BTW mw.org has links to office chats but not to this channel. [20:42:04] Oh, hm. [20:42:32] It's confusing that there used to be a Beta Features/Multimedia Viewer page and now it's gone. I think Beta features used to link to https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer . I think that page should say clearly "The MultimediaViewer full-screen gallery used to be a _BetaFeature_, now it's built-in; you can disable it in Preferences > Appearance" [20:42:58] Hm [20:43:02] fabriceflorin: ^^ [20:43:07] I'll let you deal with the product page [20:43:12] I'll update the extension page [20:44:13] Typography_refresh claimed it was the first beta feature to graduate, are they stealing your thunder? :) [20:44:24] marktraceur: Good point from spagewmf — the same idea was also suggested in the Typography refresh retrospective. [20:44:36] in their retrospective they talked about handling the graduation of feature from Beta feature https://www.mediawiki.org/wiki/Typography_refresh/Retrospective [20:44:39] spagewmf: They were the first [20:44:48] spagewmf: Yeah, they kinda beat us to it, but they also have the arrows in the back to prove it :) [20:45:15] Somebody has to go first... [20:45:28] I was hoping hovercard would add to gallery would have hovercard would add to gallery... I N C E P T I O N [20:45:46] fabriceflorin: I think that wasn't a product of them being the first through the breach, though - there were a lot of things wrong with the refresh [20:46:25] anyway, congratulations! I noticed some minor glitches with the OOjesus dialog, I'll file bugs with screenshots [20:46:48] marktraceur Let’s ask pginer for a simple solution that works well on the Beta Features page. From your standpoint, is there a way to add a special list of features that have graduated at the bottom of that preferences page, with links to their product overview and discussion pages? [20:48:26] * spagewmf hides after stirring up programming work :) [20:49:20] spagewmf: No need to hide, we really appreciate this suggestion! Had to be done sooner rather than later, since it’s confusing users. Thanks for doing this :) [20:57:13] Uh [20:57:23] Well shit he left. [21:06:13] fabriceflorin: Not currently because we don't have that list at all [21:06:20] At least not in a computery place [21:06:25] Just in a human-y place [21:20:09] I marked the extension as "stable". This may not be The Right Thing. [21:54:16] Hi guys, just testing freenode webchat. [21:54:25] Cool beans [21:56:02] hi [21:56:10] Hi dhorn , welcome to our chat room! [21:56:13] Hooray! [21:56:14] Salut, dhorn [21:56:53] (03PS1) 10Gergő Tisza: Disable preloading of fullscreen-sized image [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127801 [21:57:21] hey toughpigs :) [21:57:49] (03PS1) 10Gergő Tisza: Disable preloading of fullscreen-sized image [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127802 [22:18:46] (03PS1) 10Gergő Tisza: Show error trace in console when catching an error in bootstrap [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127807 [22:18:48] (03PS1) 10Gergő Tisza: Split the progress bar into a component of its own [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127808 [22:18:50] (03PS1) 10Gergő Tisza: Replace progressbar with positionless one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127809 [22:19:48] (03CR) 10jenkins-bot: [V: 04-1] Split the progress bar into a component of its own [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127808 (owner: 10Gergő Tisza) [22:20:16] (03CR) 10jenkins-bot: [V: 04-1] Replace progressbar with positionless one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127809 (owner: 10Gergő Tisza) [22:24:41] (03PS2) 10Gergő Tisza: Split the progress bar into a component of its own [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127808 [22:24:56] (03PS2) 10Gergő Tisza: Replace progressbar with positionless one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127809 [22:25:13] (03CR) 10jenkins-bot: [V: 04-1] Split the progress bar into a component of its own [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127808 (owner: 10Gergő Tisza) [22:25:45] (03CR) 10jenkins-bot: [V: 04-1] Replace progressbar with positionless one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127809 (owner: 10Gergő Tisza) [22:26:41] (03PS3) 10Gergő Tisza: Split the progress bar into a component of its own [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127808 [22:27:20] (03CR) 10jenkins-bot: [V: 04-1] Split the progress bar into a component of its own [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127808 (owner: 10Gergő Tisza) [22:28:00] (03PS4) 10Gergő Tisza: Split the progress bar into a component of its own. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127808 [22:28:42] (03PS3) 10Gergő Tisza: Replace progressbar with positionless one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127809 [22:29:17] (03CR) 10jenkins-bot: [V: 04-1] Replace progressbar with positionless one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127809 (owner: 10Gergő Tisza) [22:33:42] (03Abandoned) 10Jforrester: Revert "Add feature flags for Media Viewer" in wmf17 [extensions/MultimediaViewer] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/119397 (owner: 10MarkTraceur) [22:36:02] Fuck, have to install Ruby 1.9 manually because selenium is whining [22:37:08] (03PS4) 10Gergő Tisza: Replace progressbar with positionless one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127809 [22:46:12] (03CR) 10Gergő Tisza: [C: 04-1] "history-navigation logs URL changes unrelated to MMV." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125746 (owner: 10Gilles) [22:53:52] marktraceur: RVM is your friend [22:55:02] Eff it [22:56:47] tgr: I now have two new surveys in French and German that should be ready to go tomorrow, once I hear back from our partners in Europe. Should I create a Mingle ticket for that task, or can I just let you know the URLs? Either way, you may want to pencil us in for tomorrow’s SWAT. What time is it? [22:57:24] i'll add a ticket so i don't forget [22:57:29] 16 PM [22:57:35] tgr: Do you want Roan to do your backports for you? [22:58:14] yes, please [22:58:27] the commits are done, just need to be deployed [22:58:50] um, are we talking about today's SWAT or tomorrow's? [22:59:14] (03CR) 10Catrope: [C: 032] Show scrollbars in survey window in Firefox [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127374 (owner: 10Gergő Tisza) [22:59:19] (03CR) 10Catrope: [C: 032] Show scrollbars in survey window in Firefox. [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127375 (owner: 10Gergő Tisza) [22:59:24] (03CR) 10Catrope: [V: 032] Show scrollbars in survey window in Firefox [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127374 (owner: 10Gergő Tisza) [22:59:29] (03CR) 10Catrope: [V: 032] Show scrollbars in survey window in Firefox. [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127375 (owner: 10Gergő Tisza) [22:59:43] (03CR) 10Catrope: [C: 032 V: 032] Restore article scroll after closing Media Viewer [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127381 (owner: 10Gergő Tisza) [23:00:09] (03CR) 10Catrope: [C: 032 V: 032] Disable preloading of fullscreen-sized image [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127801 (owner: 10Gergő Tisza) [23:00:31] (03CR) 10Catrope: [C: 032 V: 032] Disable preloading of fullscreen-sized image [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127802 (owner: 10Gergő Tisza) [23:00:39] tgr: Today's. [23:05:34] James_F : Thanks for doing the backports for us, much appreciated :) [23:06:00] fabriceflorin: tgr did all the work, I just want things to go smoothly. :-) [23:06:25] James_F: Either way, we appreciate the teamwork … [23:06:32] * James_F grins. [23:06:35] Always happy to help. [23:09:39] (03CR) 10MarkTraceur: "My tests are timing out locally as well, on WMF internet via Ethernet." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 (owner: 10Gilles) [23:10:08] fabriceflorin: Hey, re: https://gerrit.wikimedia.org/r/127477 - can you make the lightbox demo pages smaller so the beta tests don't time out every single time? [23:10:17] We could probably have like twenty files on the page and test just as effectively [23:10:27] Instead of the current page which has approximately 19 billion files [23:10:37] Understandably that takes a while to parse and fetch and render [23:12:33] marktraceur: Sure, I can make the demo pages smaller on sites where it’s an issue. Where are you getting the timeouts? Note that it might be useful to keep a large one somewhere, to see what the worst case looks like. [23:12:56] Beta at least [23:13:03] But like...the loading times here aren't based on our code [23:13:17] It's just the parser struggling to render an obscene amount of files [23:13:29] Especially on the beta cluster, that just straight up won't work [23:14:11] OK, let me start with beta. Are there any files you care about there for testing purposes, or should we just keep some of the pretty pictures from 2013? [23:14:24] Having pictures of different kinds are best [23:14:29] SVG, gif, jpg, png [23:14:48] A few thumbnails, then maybe a gallery of five pictures, and each should have different captions and so no [23:14:51] so on* [23:15:12] OK, I will edit down a ‘mixed platter’ of different types on Beta. [23:19:41] marktraceur: How’s this? http://en.wikipedia.beta.wmflabs.org/wiki/Lightbox_demo [23:19:51] Much better [23:20:00] Cool. Enjoy ... [23:22:21] Ugh, tests still time out [23:26:17] (03PS3) 10Gergő Tisza: Show metadata panel immediately. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 [23:28:27] (03CR) 10Gergő Tisza: [C: 031] "The opacity transition definitely does not work for me (I set it to 5s to test). Must be a Linux thing." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [23:30:48] chrismcmahon: Any tips to make them not time out? I'm not sure what the issue is here... [23:31:56] Getting undefined method `close' for nil:NilClass (NoMethodError) [23:35:55] marktraceur: what test(s)? [23:36:03] The MMV cucumber tests [23:39:35] marktraceur: ah. I forgot there was just one of those. and the one is currently not recognizing anything useful after logging in on beta labs. [23:40:11] ah wait, I think I have an old version, updating... [23:40:49] We don't actually log in anymore [23:48:14] (03PS2) 10Gergő Tisza: Display correct file type on download button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127400 [23:48:18] (03CR) 10Gergő Tisza: Display correct file type on download button (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127400 (owner: 10Gergő Tisza) [23:48:46] (03CR) 10jenkins-bot: [V: 04-1] Display correct file type on download button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127400 (owner: 10Gergő Tisza) [23:49:35] marktraceur: looks like y'all deleted the image the test expects to find on beta: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Lightbox_demo&action=history [23:49:42] Well shit. [23:49:49] Which one is it... [23:49:53] Kerala [23:50:56] 'kay [23:51:02] marktraceur: this week I'll look into robustifying this test. it's pretty fragile [23:51:05] I'll add it back in [23:51:26] (03PS3) 10Gergő Tisza: Display correct file type on download button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127400 [23:52:22] marktraceur: test is looking explicitly for Kerala and Academy_of_Sciences jpgs [23:52:43] Hm, Academy of Sciences...oh, the aquarium one [23:52:48] chrismcmahon: imo looking for a specific image is all right, we just shouldn't use the demo page for that [23:53:07] there should be a test page with big red warnings