[00:00:09] Cool. Romaine is good people. [00:30:23] (03PS1) 10Gergő Tisza: Ensure click playback happens at the right time [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130264 [00:32:20] (03PS2) 10Gergő Tisza: Ensure click playback happens at the right time [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130264 (https://bugzilla.wikimedia.org/64345) [01:40:14] (03PS1) 10Gergő Tisza: Do not handle clicks if MediaViewer could not be loaded. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130272 (https://bugzilla.wikimedia.org/63801) [06:58:29] (03PS1) 10Gergő Tisza: Small changes to default dashboard [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/130293 [06:59:05] (03CR) 10Gergő Tisza: [C: 032 V: 032] Small changes to default dashboard [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/130293 (owner: 10Gergő Tisza) [07:08:04] (03CR) 10Gilles: [C: 032] Ensure click playback happens at the right time [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130264 (https://bugzilla.wikimedia.org/64345) (owner: 10Gergő Tisza) [07:08:43] (03Merged) 10jenkins-bot: Ensure click playback happens at the right time [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130264 (https://bugzilla.wikimedia.org/64345) (owner: 10Gergő Tisza) [07:09:32] (03CR) 10Gilles: [C: 04-1] Do not handle clicks if MediaViewer could not be loaded. (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130272 (https://bugzilla.wikimedia.org/63801) (owner: 10Gergő Tisza) [07:10:01] (03CR) 10Gilles: [C: 032] Handle window.localStorage === null case correctly. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130230 (https://bugzilla.wikimedia.org/64525) (owner: 10Gergő Tisza) [07:10:33] (03Merged) 10jenkins-bot: Handle window.localStorage === null case correctly. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130230 (https://bugzilla.wikimedia.org/64525) (owner: 10Gergő Tisza) [07:30:17] (03CR) 10Gilles: [C: 032] Adjust invite animation for Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130107 (owner: 10Pginer) [07:30:56] (03Merged) 10jenkins-bot: Adjust invite animation for Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130107 (owner: 10Pginer) [07:34:24] (03CR) 10Gilles: [C: 032] Enable survey in Spanish [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130233 (owner: 10Gergő Tisza) [07:34:58] (03Merged) 10jenkins-bot: Enable survey in Spanish [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130233 (owner: 10Gergő Tisza) [07:38:46] (03Abandoned) 10Gilles: Don't show "expand view" when Media Viewer is disabled [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126217 (owner: 10Gilles) [07:50:25] (03PS1) 10Gilles: Catch exceptions raise by localStorage write operations [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 [07:59:37] (03CR) 10Gilles: [C: 032] Make progress bar less erratic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129564 (owner: 10Gergő Tisza) [08:00:12] (03Merged) 10jenkins-bot: Make progress bar less erratic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129564 (owner: 10Gergő Tisza) [08:02:46] (03CR) 10Rillke: "Since one most likely never wants the code to throw unhandled errors, stopping script execution, when localStorage is full or any other st" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [08:09:47] (03CR) 10Gilles: [C: 04-1] "I'm seeing the following on Firefox:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129875 (owner: 10Gergő Tisza) [08:32:23] (03CR) 10Gilles: "It's hard to say how the code will evolve, we might want to do something in the catch section at a later point. And the repetition won't a" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [08:46:07] (03CR) 10Gilles: Refactor progressbar & blur handling (039 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129875 (owner: 10Gergő Tisza) [08:49:04] (03CR) 10Rillke: "Are there browser tests with localStorage disabled [sorry for my laziness]? Not so much concerned about the code size but about simply "fo" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [09:11:25] (03CR) 10Gilles: "Good point, mmv.ui.stripButtons.test.js has things that are kind of like that, but they're not exactly testing the lack of localStorage. I" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [10:03:33] (03PS2) 10Gilles: Catch exceptions raised by localStorage write operations [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 [15:43:13] Hey, bd808, reading https://www.mediawiki.org/wiki/Gerrit/git-review it claims that a pre-commit hook would be installed [15:43:56] `git review -s` will install it (or at least try to) [15:44:21] but running "$ ls -a -l" on ./.git/hooks/ there is no such hook for me [15:44:25] The pre-commit hook adds the Change-Id: line [15:44:57] no, that's the commit-msg [15:44:57] -hook [15:45:43] Yup, you're right. And the wiki page is wrong [15:45:46] so the documentation on mw is wrong and it should read "commit-msg" hook ? [15:46:03] * rillke is going to change the wiki [15:47:09] * bd808 loves that people fix documentation here [16:08:13] marktraceur: I can't hear or see you guys on hangout anymore [16:08:44] gi11es: Investigating [16:11:18] gi11es: We're getting pretty low audio quality from you [16:36:38] bd808, I am looking for a good IDE. Is there something that is capable to parse mw's doxygen comments and does auto-suggest with help-tooltips ? [16:36:55] * bd808 uses vim [16:37:13] I think Reedy uses PhpStorm? [16:37:34] You might ping him. I think he has an open source license for it. [16:38:06] thank you :) [16:42:43] phpstorm is probably the best option for a full-blown IDE [16:43:43] {{marktraceur free software rant}} [16:44:25] marktraceur: What are you using? [16:44:44] rillke: vim; if I wanted a full IDE I would need to do some investigating [16:45:16] I like Geany; Eclipse/PHP might work [17:29:06] (03PS1) 10Gergő Tisza: Make the custom dashboard default [extensions/MultimediaViewer] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/130387 [17:29:11] (03CR) 10jenkins-bot: [V: 04-1] Make the custom dashboard default [extensions/MultimediaViewer] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/130387 (owner: 10Gergő Tisza) [17:29:53] (03CR) 10Gergő Tisza: [C: 032 V: 032] Make the custom dashboard default [extensions/MultimediaViewer] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/130387 (owner: 10Gergő Tisza) [17:34:40] Sent a mail to the analytics list about surveys [17:35:17] http://lists.wikimedia.org/pipermail/analytics/2014-April/001911.html [17:55:01] gi11es: https://gerrit.wikimedia.org/r/130392 FYI [17:55:14] I should probably stick that feed into this channel. [17:56:39] (03PS1) 10Gergő Tisza: Enable survey in Spanish [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130395 [17:57:00] (03PS1) 10Gergő Tisza: Enable survey in Spanish [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130396 [17:58:04] (03CR) 10jenkins-bot: [V: 04-1] Enable survey in Spanish [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130395 (owner: 10Gergő Tisza) [17:58:36] (03CR) 10jenkins-bot: [V: 04-1] Enable survey in Spanish [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130396 (owner: 10Gergő Tisza) [18:01:06] Done [18:01:16] It won't help me at all but whatever. :) [18:01:35] (03PS2) 10Gergő Tisza: Enable survey in Spanish. [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130395 [18:02:07] (03CR) 10jenkins-bot: [V: 04-1] Enable survey in Spanish. [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130395 (owner: 10Gergő Tisza) [18:02:25] did jsduck get updated? [18:03:09] On Jenkins? [18:03:24] suddenly it is complaining about a bunch of new things [18:03:32] yes [18:04:06] Hm [18:09:42] tgr: The mmv.ui.canvas.js errors were errors that JSduck 4 didn't spot but should have (it's never been a supported mechanism to document things like that, it just happened to work). [18:10:10] James_F: Is there a quirks mode or something, or should we Just Fix Them? [18:10:21] Just Fix. [18:10:28] yeah, nothing wrong with the errors, it's the timing that's annoying since I am trying to backport stuff [18:10:35] But sorry, this should have been caught last month when we fixed the other repos. [18:10:49] I totally had no idea you were using jsduck. [18:11:05] Which given your entry on https://doc.wikimedia.org/ is unforgiveable; sorry. [18:11:07] * marktraceur high-fives James_F [18:11:18] Participation ribbons for everyone [18:13:48] * James_F fixed MW-core, OOjs, OOjs UI, VE-core and VE-MW. [18:13:55] * James_F sighs. [18:14:04] One more would have been easy (and less stressful for all). [18:14:11] Whoa, TIL GuidedTour is on doc.wikimedia.org [18:14:37] Y'all got less docs than me [18:15:11] James_F: I can submit a fix, I'd like to mess with our groups anyway [18:15:27] marktraceur: OK. [18:21:56] marktraceur: https://gerrit.wikimedia.org/r/#/c/130406/ FYI. [18:28:47] Not sure that's applicable [18:28:49] For us [18:32:18] (03PS1) 10MarkTraceur: Fix for jsduck 5.x, rearrange categories [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130414 [18:32:20] tgr: ^^ [18:32:27] James_F, also. [18:34:37] ooh, nice [18:34:51] (03CR) 10Gergő Tisza: [C: 032] Fix for jsduck 5.x, rearrange categories [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130414 (owner: 10MarkTraceur) [18:35:24] (03Merged) 10jenkins-bot: Fix for jsduck 5.x, rearrange categories [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130414 (owner: 10MarkTraceur) [18:35:54] https://doc.wikimedia.org/MultimediaViewer/master/ looks way cooler now [18:36:42] Also no errors which is an improvement [18:36:57] * marktraceur wades into the ocean of code review [18:37:04] Maybe we can get this stuff sort of out the door [18:37:21] marktraceur: :-) [18:37:34] tgr: I'm seriously super tired of looking at the jsduck vagrant card, can we just accept it and move on with our lives [18:38:05] Like I assume you've been using it and you haven't had issues [18:39:27] (03PS1) 10Jforrester: Fix for jsduck 5.x, rearrange categories [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130418 [18:39:49] (03PS1) 10Jforrester: Fix for jsduck 5.x, rearrange categories [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130419 [18:40:07] James_F: Y U backport? [18:43:05] marktraceur: I haven't but others had [18:43:14] just stash it in the backlog [18:43:26] tgr: I thought it got merged? [18:43:27] marktraceur: You'll need it to work for the other backports… [18:43:53] I don't think we have any backports open but seriously V+2ing a backport with doc failures is not out of the question [18:44:07] James_F: thanks [18:44:42] but yeah, we can just hit Jenkins on the head and force publish [18:46:10] marktraceur: it got merged, and it works when you set up a new mediawiki-vagrant box [18:46:32] apparently it doesn't always work when enabling it on an old box [18:46:44] Minor issue [18:46:57] also I guess the version should be updated now? [18:47:20] For Vagrant? [18:47:21] but that's no reason for it to be sitting on the board all the time, just backlog it [18:47:53] the JSDuck version in the mediawiki-vagrant puppet config [18:48:04] Backlogged [18:50:43] gi11es: At some point in the near future are we going to run the generate script after merging so we don't keep all of these massive files in VC? [18:51:19] (03CR) 10MarkTraceur: [C: 032 V: 032] Fix typo on Finnish wikipedia [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/130057 (owner: 10Gilles) [18:52:27] (03CR) 10MarkTraceur: [C: 032 V: 032] Add more pilot sites [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/130297 (owner: 10Gilles) [18:52:38] (03PS2) 10Gergő Tisza: Do not handle clicks if MediaViewer could not be loaded. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130272 (https://bugzilla.wikimedia.org/63801) [18:53:47] (03CR) 10MarkTraceur: [C: 032 V: 032] Add more pilot sites [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/130298 (owner: 10Gilles) [18:55:17] * marktraceur runs the scripts with the new pilots [18:55:21] Gonna take a bit [18:56:48] (03CR) 10MarkTraceur: [C: 032 V: 032] Fix typo on Finnish wikipedia [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/130056 (owner: 10Gilles) [19:11:30] (03CR) 10Gergő Tisza: Catch exceptions raised by localStorage write operations (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [19:13:40] (03CR) 10Gergő Tisza: [C: 04-1] Catch exceptions raised by localStorage write operations [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [19:19:24] (03PS1) 10Gergő Tisza: Enable survey in Dutch [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130427 [19:21:08] marktraceur: could you review ^^ and https://gerrit.wikimedia.org/r/130428 ? [19:43:11] (03CR) 10Rillke: Catch exceptions raised by localStorage write operations (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [19:46:45] (03CR) 10Gergő Tisza: Catch exceptions raised by localStorage write operations (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [19:47:47] Yeah [20:03:45] fabriceflorin: There's a question on the Analytics list I think you're best equipped to answer, are you subscribed to it? [20:24:57] So our action scripts now take longer than our perf scripts [20:25:06] Which is t3h bad. [20:35:20] (03CR) 10MarkTraceur: [C: 032] "Wow, this makes for some mighty readable testing. Ta very much :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129425 (owner: 10Gilles) [20:35:23] (03CR) 10jenkins-bot: [V: 04-1] Preload Media Viewer js/css when hovering thumbs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129425 (owner: 10Gilles) [20:36:52] (03PS6) 10MarkTraceur: Preload Media Viewer js/css when hovering thumbs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129425 (owner: 10Gilles) [20:37:12] (03CR) 10MarkTraceur: [C: 032] Preload Media Viewer js/css when hovering thumbs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129425 (owner: 10Gilles) [20:37:56] (03Merged) 10jenkins-bot: Preload Media Viewer js/css when hovering thumbs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129425 (owner: 10Gilles) [20:38:01] (03CR) 10MarkTraceur: [C: 032] Enable survey in Dutch [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130427 (owner: 10Gergő Tisza) [20:38:34] (03Merged) 10jenkins-bot: Enable survey in Dutch [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130427 (owner: 10Gergő Tisza) [20:39:59] tgr: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/442 is this also backloggable so I don't have to stare at it? :) [20:40:53] that one is actually done [20:40:59] OK accepting. [20:41:07] although it wouldn't hurt if somebody tested it [20:41:19] Yes but WHO!? [20:41:31] * marktraceur exists to cause problems in plans [20:41:34] am I the only one using vagrant? [20:41:49] I think we've proven that based on the inordinate amount of time that other patch spent in CR [20:41:52] CR/testing [20:42:19] anyway I am more confident about it than about the JSDuck thing which was a horrible hack, so I'll just accept then [20:46:59] (03CR) 10MarkTraceur: [C: 032 V: 032] Add percentiles to the Geo data [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/130308 (owner: 10Gilles) [20:48:14] (03CR) 10MarkTraceur: [C: 04-1] "Little typo" (032 comments) [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/130323 (owner: 10Gilles) [20:49:37] marktraceur: Thanks for cross-posting the discussion about surveys on the analytics list. I will subscribe to it and respond later, after I’m caught up with today’s priorities. Which include reviewing all the cards now in testing on Mingle for this sprint :) [20:50:25] fabriceflorin: The question was about the multiple language surveys [20:50:42] I'll link you to the message. [20:50:57] fabriceflorin: http://lists.wikimedia.org/pipermail/analytics/2014-April/001922.html [20:52:06] Oh, I thought it was about the Upload Wizard survey. Thanks for the link to this multiple language survey discussion, will respond to that as well — once I’m caught up with my tasks. [20:53:10] Well it's also about the UW survey, this is a separate question in the same thread [20:54:12] Got it. Thanks for passing it on! [20:57:12] (03PS2) 10Gergő Tisza: Refactor progressbar & blur handling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129875 [21:00:06] (03PS1) 10Gergő Tisza: Enable survey in Dutch [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130484 [21:00:39] (03CR) 10jenkins-bot: [V: 04-1] Enable survey in Dutch [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130484 (owner: 10Gergő Tisza) [21:02:32] (03CR) 10MarkTraceur: [C: 032] Adds new performance metrics [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130089 (owner: 10Gilles) [21:03:07] tgr, gi11es: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/508 has some comments about additional stuff to add...are those preserved in some other card? I've merged the first pass. [21:03:08] (03PS1) 10Gergő Tisza: Enable survey in Dutch [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130485 [21:03:10] (03CR) 10jenkins-bot: [V: 04-1] Adds new performance metrics [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130089 (owner: 10Gilles) [21:03:24] Er. Lies, but it will be merged soon [21:03:28] (03PS3) 10MarkTraceur: Adds new performance metrics [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130089 (owner: 10Gilles) [21:04:21] (03CR) 10jenkins-bot: [V: 04-1] Enable survey in Dutch [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130485 (owner: 10Gergő Tisza) [21:04:23] (03CR) 10jenkins-bot: [V: 04-1] Adds new performance metrics [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130089 (owner: 10Gilles) [21:09:03] (03PS4) 10MarkTraceur: Adds new performance metrics [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130089 (owner: 10Gilles) [21:10:03] (03CR) 10MarkTraceur: [C: 032] "Trivial fix for categories.json" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130089 (owner: 10Gilles) [21:11:31] (03Merged) 10jenkins-bot: Adds new performance metrics [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130089 (owner: 10Gilles) [21:12:59] (03PS1) 10Gergő Tisza: Ensure click playback happens at the right time [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130491 (https://bugzilla.wikimedia.org/64345) [21:13:34] (03CR) 10jenkins-bot: [V: 04-1] Ensure click playback happens at the right time [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130491 (https://bugzilla.wikimedia.org/64345) (owner: 10Gergő Tisza) [21:13:46] (03PS1) 10Gergő Tisza: Ensure click playback happens at the right time [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130492 (https://bugzilla.wikimedia.org/64345) [21:14:18] (03CR) 10jenkins-bot: [V: 04-1] Ensure click playback happens at the right time [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130492 (https://bugzilla.wikimedia.org/64345) (owner: 10Gergő Tisza) [21:15:20] (03PS1) 10Gergő Tisza: Handle window.localStorage === null case correctly. [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130493 (https://bugzilla.wikimedia.org/64525) [21:15:50] (03PS1) 10Gergő Tisza: Handle window.localStorage === null case correctly. [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130494 (https://bugzilla.wikimedia.org/64525) [21:15:57] (03CR) 10jenkins-bot: [V: 04-1] Handle window.localStorage === null case correctly. [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130493 (https://bugzilla.wikimedia.org/64525) (owner: 10Gergő Tisza) [21:16:27] (03CR) 10jenkins-bot: [V: 04-1] Handle window.localStorage === null case correctly. [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130494 (https://bugzilla.wikimedia.org/64525) (owner: 10Gergő Tisza) [21:23:46] (03CR) 10MarkTraceur: [C: 04-1] "Gilles, rebase and add the script yourself - I'll make the appropriate cron scripts when you've done so." [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/130325 (owner: 10Gilles) [21:26:07] (03PS9) 10Gergő Tisza: Use sinon.js to test the thumbnail fetching [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 [21:26:33] (03CR) 10Gergő Tisza: [C: 032] "Per Gilles." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [21:26:42] marktraceur and tgr : I just tested and accepted a half-dozen cards on the current cycle wall. I wasn’t able to test the others, because they require technical knowledge I don’t have. So could you guys test them yourselves, please? [21:26:47] (03CR) 10MarkTraceur: [C: 031] "Seems good but I'm waiting for the dependency to get sorted." [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/130327 (owner: 10Gilles) [21:26:58] Woot [21:27:11] (03Merged) 10jenkins-bot: Use sinon.js to test the thumbnail fetching [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [21:27:12] I also looked for, but couldn’t find these metrics improvements yet: #508, #510, #515 — do let me know when they’re up. Lastly, I will wait until the Dutch and Spanish surveys are up to accept those cards. [21:27:15] fabriceflorin: Yeah, I was mostly hoping you'd get the stuff that was producty out of the way [21:27:24] I have a bunch of them merged but maybe not deployed [21:27:31] I figured I'd merge all of them then deploy [21:27:39] Cool. Please let me know if you want me to test anything else. [21:27:44] fabriceflorin: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/471 [21:29:13] fabriceflorin: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/497 [21:30:41] #497 and #521 are scheduled for SWAT, I'll test them live afterwards [21:31:09] *nod* [21:31:47] I'd ask you to test the survey stuff but I can just do it [21:32:03] is there any reason for not having a ready for testing -> accepted transition? [21:32:15] * marktraceur makes that [21:32:25] thx [21:32:44] I was unsure whether we are setting any important magic properties [21:33:01] tgr: [21:33:01] Transition Cut through the red tape was successfully created. [21:33:19] No, it's just bureaucracy [21:33:29] Cut out the middleman^H^H^Hstep! [21:34:25] marktraceur: Thanks for these two new cards (#471 and #497). I tested them both, and accepted them. The PDF test is here on Beta, couldn’t reproduce the problem reported in Bugzilla: http://en.wikipedia.beta.wmflabs.org/wiki/Lightbox_demo#PDF_Test [21:35:29] the PDF has to be the only image on the page [21:36:04] I'll just test it on Meta after the SWAT [21:41:55] tgr: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/435 not sure how to test this but I'm pretty confident it's working [21:42:21] Good enough for government? [21:42:23] work? [21:42:27] (argh typing) [21:42:39] i'll check [21:50:53] good thing too [21:51:02] tgr: It's not working? [21:51:16] jQuery was helpfully adding a cachebreaker parameter to the JSONP requests [21:51:24] Awesome. [21:51:27] ty jquery [21:51:54] we don't have many of those, just the users API, so not a huge deal [21:52:06] Yeah [21:52:10] But the rest are cached right? [21:52:25] will see [21:52:28] (and presumably we can file a task about hitting jquery, hard, over the head to let us cache JSONP stuff) [21:52:38] I wanted to test the users request because that's more convenient [21:54:52] fabriceflorin: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/521 if you have access to an IE installation it would be handy to whip it out [21:55:09] The bug has clear repro steps [21:55:37] I have a Windows machine at home, though not completely clear what needs to be tested. Can you elaborate? [21:56:00] Oh, I see the repro steps on Bugzilla, will try those. [21:56:02] can be tested on firefox too [21:56:17] Ta very much [21:56:21] set about:config storage.dom.enabled=false [21:56:25] Wait, tgr - latest Firefox? Because I never saw...ah. [21:56:26] We also have a crosstesting.com account, might be better than my old clunker. [21:56:30] or maybe dom.storage.enabled? [21:56:36] I'll do that then, never mind [21:56:37] Going to Product Manager meeting now, will be back in an hour. [21:56:45] something like that has to be done on IE too [21:57:44] tgr: Oh, hm, I'll unaccept then. Worked fine for me. [21:58:18] Accepted (22) [21:58:19] Wow. [22:30:18] https://gerrit.wikimedia.org/r/130272 tgr - I'm seeing the black screen even when mmv fails to load [22:30:28] I'm taking a particular glee in it too [22:31:04] Load page, kill webserver, click on image [22:31:05] Black screen of doomw [22:31:13] will look at it in a sec [22:31:37] turns out making jQuery cacheable is quite challanging [22:32:08] either that I am doing it really wrong [22:37:04] Unescapable [22:38:59] (03PS1) 10Gergő Tisza: Disable JSONP cache breaking in jQuery [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130513 [22:41:59] marktraceur: I suppose mw.loader just hangs in that case [22:42:42] I tested it by adding some JS errors to mmv.js, if they are bad enough to be unparseable, mw.loader errors out [22:43:33] we could easily add a timeout, not sure we should though [22:49:33] (03CR) 10Gergő Tisza: Add preferences link after "help" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129296 (owner: 10MarkTraceur) [23:02:41] Yeah, mw.loader should just fail [23:02:46] * marktraceur adds errors. [23:04:22] (03PS3) 10MarkTraceur: Do not handle clicks if MediaViewer could not be loaded. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130272 (https://bugzilla.wikimedia.org/63801) (owner: 10Gergő Tisza) [23:04:42] (03CR) 10MarkTraceur: [C: 032] "Trivial-ish rebase." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130272 (https://bugzilla.wikimedia.org/63801) (owner: 10Gergő Tisza) [23:05:23] (03Merged) 10jenkins-bot: Do not handle clicks if MediaViewer could not be loaded. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130272 (https://bugzilla.wikimedia.org/63801) (owner: 10Gergő Tisza) [23:19:02] (03CR) 10EBernhardson: [C: 032] Fix for jsduck 5.x, rearrange categories [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130418 (owner: 10Jforrester) [23:19:09] (03CR) 10EBernhardson: [C: 032] Fix for jsduck 5.x, rearrange categories [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130419 (owner: 10Jforrester) [23:20:13] (03CR) 10EBernhardson: [C: 032 V: 032] Enable survey in Spanish. [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130395 (owner: 10Gergő Tisza) [23:20:25] (03CR) 10EBernhardson: [C: 032 V: 032] Enable survey in Spanish [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130396 (owner: 10Gergő Tisza) [23:20:27] (03Merged) 10jenkins-bot: Fix for jsduck 5.x, rearrange categories [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130418 (owner: 10Jforrester) [23:20:35] (03CR) 10EBernhardson: [C: 032 V: 032] Enable survey in Dutch [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130484 (owner: 10Gergő Tisza) [23:20:44] (03CR) 10EBernhardson: [C: 032 V: 032] Enable survey in Dutch [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130485 (owner: 10Gergő Tisza) [23:20:52] (03CR) 10EBernhardson: [C: 032 V: 032] Ensure click playback happens at the right time [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130491 (https://bugzilla.wikimedia.org/64345) (owner: 10Gergő Tisza) [23:20:56] (03Merged) 10jenkins-bot: Fix for jsduck 5.x, rearrange categories [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130419 (owner: 10Jforrester) [23:21:00] (03CR) 10EBernhardson: [C: 032 V: 032] Ensure click playback happens at the right time [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130492 (https://bugzilla.wikimedia.org/64345) (owner: 10Gergő Tisza) [23:21:07] (03CR) 10EBernhardson: [C: 032 V: 032] Handle window.localStorage === null case correctly. [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130493 (https://bugzilla.wikimedia.org/64525) (owner: 10Gergő Tisza) [23:21:14] (03CR) 10EBernhardson: [C: 032 V: 032] Handle window.localStorage === null case correctly. [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130494 (https://bugzilla.wikimedia.org/64525) (owner: 10Gergő Tisza) [23:21:29] (03Merged) 10jenkins-bot: Enable survey in Spanish. [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130395 (owner: 10Gergő Tisza) [23:21:45] (03CR) 10jenkins-bot: [V: 04-1] Enable survey in Spanish [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130396 (owner: 10Gergő Tisza) [23:21:47] (03CR) 10jenkins-bot: [V: 04-1] Enable survey in Dutch [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130485 (owner: 10Gergő Tisza) [23:22:16] (03Merged) 10jenkins-bot: Enable survey in Dutch [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130484 (owner: 10Gergő Tisza) [23:22:47] (03Merged) 10jenkins-bot: Ensure click playback happens at the right time [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130491 (https://bugzilla.wikimedia.org/64345) (owner: 10Gergő Tisza) [23:22:51] (03CR) 10jenkins-bot: [V: 04-1] Ensure click playback happens at the right time [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130492 (https://bugzilla.wikimedia.org/64345) (owner: 10Gergő Tisza) [23:23:56] (03Merged) 10jenkins-bot: Handle window.localStorage === null case correctly. [extensions/MultimediaViewer] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130493 (https://bugzilla.wikimedia.org/64525) (owner: 10Gergő Tisza) [23:23:59] (03CR) 10jenkins-bot: [V: 04-1] Handle window.localStorage === null case correctly. [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130494 (https://bugzilla.wikimedia.org/64525) (owner: 10Gergő Tisza) [23:29:33] (03PS2) 10Ori.livneh: Handle window.localStorage === null case correctly. [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130494 (https://bugzilla.wikimedia.org/64525) (owner: 10Gergő Tisza) [23:29:39] (03CR) 10Ori.livneh: [C: 032] Handle window.localStorage === null case correctly. [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130494 (https://bugzilla.wikimedia.org/64525) (owner: 10Gergő Tisza) [23:30:17] (03PS2) 10EBernhardson: Enable survey in Spanish [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130396 (owner: 10Gergő Tisza) [23:30:29] (03CR) 10EBernhardson: [V: 032] Enable survey in Spanish [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130396 (owner: 10Gergő Tisza) [23:31:35] (03CR) 10jenkins-bot: [V: 04-1] Enable survey in Spanish [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130396 (owner: 10Gergő Tisza) [23:32:05] (03Merged) 10jenkins-bot: Handle window.localStorage === null case correctly. [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130494 (https://bugzilla.wikimedia.org/64525) (owner: 10Gergő Tisza) [23:35:20] (03PS3) 10EBernhardson: Enable survey in Spanish [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130396 (owner: 10Gergő Tisza) [23:35:35] (03CR) 10EBernhardson: [C: 032 V: 032] Enable survey in Spanish [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130396 (owner: 10Gergő Tisza) [23:36:11] (03PS2) 10EBernhardson: Enable survey in Dutch [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130485 (owner: 10Gergő Tisza) [23:36:21] (03PS2) 10EBernhardson: Ensure click playback happens at the right time [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130492 (https://bugzilla.wikimedia.org/64345) (owner: 10Gergő Tisza) [23:36:24] (03Merged) 10jenkins-bot: Enable survey in Spanish [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130396 (owner: 10Gergő Tisza) [23:37:01] (03PS3) 10EBernhardson: Enable survey in Dutch [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130485 (owner: 10Gergő Tisza) [23:37:13] (03CR) 10EBernhardson: [V: 032] Enable survey in Dutch [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130485 (owner: 10Gergő Tisza) [23:37:27] (03PS3) 10EBernhardson: Ensure click playback happens at the right time [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130492 (https://bugzilla.wikimedia.org/64345) (owner: 10Gergő Tisza) [23:37:32] (03CR) 10EBernhardson: [V: 032] Ensure click playback happens at the right time [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/130492 (https://bugzilla.wikimedia.org/64345) (owner: 10Gergő Tisza) [23:38:47] (03PS4) 10MarkTraceur: Add preferences link after "help" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129296