[00:04:55] (03PS1) 10Gergő Tisza: Fix Commons tooltip for messages using GRAMMAR such as he [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130783 [00:07:55] (03CR) 10Gergő Tisza: [C: 032] Fix "use this file" arrow CSS for RTL [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130599 (owner: 10Gilles) [00:08:30] (03Merged) 10jenkins-bot: Fix "use this file" arrow CSS for RTL [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130599 (owner: 10Gilles) [00:21:38] (03CR) 10Krinkle: Create base UI module. (033 comments) [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 (owner: 10Robmoen) [00:24:24] (03CR) 10Krinkle: Create base UI module. (033 comments) [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 (owner: 10Robmoen) [00:37:43] (03CR) 10Gergő Tisza: "Tested, the popup does not show up when setItem throws exceptions. The metadata panel wiggles all the time, though. Less annoying than the" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [01:13:17] (03PS1) 10Gergő Tisza: Reanimate metadata panel when viewer is reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130798 [01:13:36] (03CR) 10jenkins-bot: [V: 04-1] Reanimate metadata panel when viewer is reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130798 (owner: 10Gergő Tisza) [02:39:21] (03PS1) 10Gergő Tisza: Handle elements in {{Information}} template [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/130807 [08:33:10] (03CR) 10Gilles: "Are you sure you're not getting confused by the fact that the invite only stops happening if you open the scroll area once?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [08:40:06] (03CR) 10Gilles: [C: 032] Reanimate metadata panel when viewer is reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130798 (owner: 10Gergő Tisza) [08:40:49] (03CR) 10Gilles: [C: 032] Fix Commons tooltip for messages using GRAMMAR such as he [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130783 (owner: 10Gergő Tisza) [08:41:29] (03Merged) 10jenkins-bot: Fix Commons tooltip for messages using GRAMMAR such as he [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130783 (owner: 10Gergő Tisza) [08:43:00] greg-g: I don't know, I haven't been told that I do [09:09:26] (03CR) 10Gergő Tisza: "The logic would go something like this:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [09:50:00] (03CR) 10Gilles: [C: 032] Disable JSONP cache breaking in jQuery [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130513 (owner: 10Gergő Tisza) [09:50:33] (03Merged) 10jenkins-bot: Disable JSONP cache breaking in jQuery [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130513 (owner: 10Gergő Tisza) [09:58:33] (03CR) 10Gilles: [C: 032] "You propose a user-facing change compared to what is happening, basically never show the invite animation (not even the first time the use" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [09:58:35] (03CR) 10jenkins-bot: [V: 04-1] Catch exceptions raised by localStorage write operations [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [09:58:37] (03CR) 10jenkins-bot: [V: 04-1] Reanimate metadata panel when viewer is reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130798 (owner: 10Gergő Tisza) [10:03:10] (03PS4) 10Gilles: Catch exceptions raised by localStorage write operations [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 [10:03:53] (03CR) 10Gilles: [C: 032] Catch exceptions raised by localStorage write operations [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [10:04:25] (03Merged) 10jenkins-bot: Catch exceptions raised by localStorage write operations [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130294 (owner: 10Gilles) [10:07:27] (03PS2) 10Gilles: Reanimate metadata panel when viewer is reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130798 (owner: 10Gergő Tisza) [10:09:37] (03CR) 10Gilles: Reanimate metadata panel when viewer is reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130798 (owner: 10Gergő Tisza) [10:09:42] (03CR) 10Gilles: [C: 032] Reanimate metadata panel when viewer is reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130798 (owner: 10Gergő Tisza) [10:10:14] (03Merged) 10jenkins-bot: Reanimate metadata panel when viewer is reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130798 (owner: 10Gergő Tisza) [15:04:47] (03PS1) 10Gilles: Add the 95th percentile [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/130842 [15:08:32] (03PS1) 10Gilles: Add the 95th percentile [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/130843 [15:15:07] (03CR) 10Gilles: [C: 032] Handle elements in {{Information}} template [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/130807 (owner: 10Gergő Tisza) [15:15:13] (03Merged) 10jenkins-bot: Handle elements in {{Information}} template [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/130807 (owner: 10Gergő Tisza) [15:56:42] gi11es: gotcha, it just came up in conversation yesterday "I wonder if Gilles has deploy rights yet" :) [15:56:50] want them? I think you should :) [15:57:26] * marktraceur had emailed roblaAWAY a while back about this [15:57:29] No answer AFAIK [15:58:23] Sorry for not following up, all. [16:55:30] * bd808 remembers reading email about "what should we do to train new deployers" related to conversation above [17:25:40] hi folks....sorry for not following up on the deploy rights conversation myself. For the access part, it's just a matter of Gilles filing an RT ticket, which I'll then be asked to approve (which I will) [17:31:49] then when it comes to the training, we should probably go with a suggestion bd808 had on this front (a monthly deploy session) [17:32:16] ...though I think we could also do ride-alongs as interim training [17:33:27] I think that's what we did when Roan trained me and gwicke [17:33:33] Or at least similar [17:33:46] And like, I could sign up to run a SWAT and have gi11es and tgr watching. [17:35:33] (03CR) 10MarkTraceur: [C: 04-1] "Minor issue/question" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129875 (owner: 10Gergő Tisza) [17:35:40] One thing I'd love to see come out of ride alongs/training is some "how to deploy" documentation that is actually readable. What we have now is very comprehensive but not so easy to digest. [17:35:57] (03CR) 10MarkTraceur: "Otherwise this looks fine, can test and merge as soon as the issue is addressed" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129875 (owner: 10Gergő Tisza) [20:16:21] OK, folks: We’re now live on both Dutch and French Wikipedias ! We checked the Ganglia and Gdash stats with robla and everything looks good from an ops and performance standpoint: https://www.mediawiki.org/wiki/Multimedia/Metrics#Ops [20:20:47] Our community partners in both sites are ready to address user feedback on these local pages: https://www.mediawiki.org/wiki/Multimedia/Media_Viewer/Release_Plan#Large_Wikis [20:34:45] gi11es: Did you change #489 on purpose even though the patch is still open? [20:43:53] tgr, fabriceflorin - I'm going to loosely interpret #542, and here is why: [20:44:02] I have most of the open patches and a lot of them have -1 on them [20:44:11] The rest, I cannot review anyway [20:45:16] Of the four not owned by me that are unreviewed, one is WIP, another is irrelevant and should be abandoned (marking as such now), and the other two are massive [20:45:44] (03Abandoned) 10MarkTraceur: Adding "url" to the "ajax" object inside /test/jasmine/spec/mw.Api.edit.spec.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83374 (owner: 10Rahul21) [20:49:24] Anyway my point is I'm going to fix CR issues on the little jshint/jquery patches [20:49:34] So we don't have to tear out our hair too much when we work on it later [20:53:45] (03PS4) 10MarkTraceur: Add events for upload page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84213 [20:54:20] And the eventlogging patch so's we can have metrics. [21:09:43] (03PS4) 10Gergő Tisza: Refactor progressbar & blur handling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129875 [21:09:54] (03CR) 10Gergő Tisza: Refactor progressbar & blur handling (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129875 (owner: 10Gergő Tisza) [21:15:54] (03PS1) 10Gergő Tisza: Handle elements in {{Information}} template [extensions/CommonsMetadata] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130971 [21:22:13] Hi marktraceur : Regarding your earlier comment on #52, I think it’s fine to loosely interpret that ticket, which is mostly a placeholder for now. I think we generally want to wrap our heads around the Upload Wizard code base, so we can start thinking of which parts need the most work — and which low hanging fruits can be improved without spending an inordinate amount of time on the project :) [21:22:31] !#542 is what I meant to say :) [21:22:31] You are not authorized to perform this, sorry [21:22:44] #542 is what I meant to say ... [22:16:35] (03PS5) 10MarkTraceur: Add events for upload page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84213 [22:19:27] (03CR) 10MarkTraceur: "Patchset incoming" (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86811 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [22:19:30] (03PS2) 10MarkTraceur: jquery audit on mw.IframeTransport.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86811 (https://bugzilla.wikimedia.org/53245) [22:19:33] (03CR) 10jenkins-bot: [V: 04-1] jquery audit on mw.IframeTransport.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86811 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [22:22:12] (03PS3) 10MarkTraceur: jquery audit on mw.IframeTransport.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86811 (https://bugzilla.wikimedia.org/53245) [22:23:36] (03CR) 10MarkTraceur: "Easy fix; patchset incoming" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86787 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [22:23:43] (03PS3) 10MarkTraceur: jshint fixes for mw.UploadWizardLicenseInput.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86787 (https://bugzilla.wikimedia.org/47161) [22:23:46] (03CR) 10jenkins-bot: [V: 04-1] jshint fixes for mw.UploadWizardLicenseInput.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86787 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [22:25:49] (03PS4) 10MarkTraceur: jshint fixes for mw.UploadWizardLicenseInput.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86787 (https://bugzilla.wikimedia.org/47161) [22:26:10] (03CR) 10MarkTraceur: "Rebase" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86787 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [22:26:36] (03CR) 10MarkTraceur: "Rebase" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86811 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [22:33:16] (03PS2) 10MarkTraceur: jshint fixes for mw.UploadWizardUpload.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) [22:33:19] (03CR) 10jenkins-bot: [V: 04-1] jshint fixes for mw.UploadWizardUpload.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [22:33:25] (03CR) 10MarkTraceur: "Patch should be up" (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [22:44:29] (03PS3) 10MarkTraceur: jshint fixes for mw.UploadWizardUpload.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) [22:44:37] (03CR) 10MarkTraceur: "Rebase" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [22:45:27] (03CR) 10jenkins-bot: [V: 04-1] jshint fixes for mw.UploadWizardUpload.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [22:58:00] (03PS4) 10MarkTraceur: jshint fixes for mw.UploadWizardUpload.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) [22:59:00] (03CR) 10MaxSem: [C: 032] Handle elements in {{Information}} template [extensions/CommonsMetadata] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130971 (owner: 10Gergő Tisza) [22:59:06] (03Merged) 10jenkins-bot: Handle elements in {{Information}} template [extensions/CommonsMetadata] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130971 (owner: 10Gergő Tisza) [23:11:48] (03CR) 10MarkTraceur: [C: 032] Refactor progressbar & blur handling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129875 (owner: 10Gergő Tisza) [23:12:23] (03Merged) 10jenkins-bot: Refactor progressbar & blur handling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129875 (owner: 10Gergő Tisza) [23:36:36] (03CR) 10MarkTraceur: "Typo in the commit message" (031 comment) [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/130842 (owner: 10Gilles) [23:41:56] (03CR) 10MarkTraceur: [C: 032 V: 032] Add the 95th percentile [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/130842 (owner: 10Gilles) [23:46:25] (03CR) 10MarkTraceur: [C: 032 V: 032] Add the 95th percentile [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/130843 (owner: 10Gilles) [23:49:52] (03PS6) 10Jforrester: [WIP] Create OOjs-style base UI module [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 (owner: 10Robmoen)