[00:53:02] (03CR) 10MarkTraceur: "Patch incoming" (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [00:53:12] (03PS3) 10MarkTraceur: Use link title as fallback for caption [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 [00:53:15] (03CR) 10jenkins-bot: [V: 04-1] Use link title as fallback for caption [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [00:55:21] (03PS4) 10MarkTraceur: Use link title as fallback for caption [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 [00:55:29] (03CR) 10MarkTraceur: "Bit of a rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [00:55:55] (03CR) 10jenkins-bot: [V: 04-1] Use link title as fallback for caption [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [01:46:03] (03PS5) 10MarkTraceur: Use link title as fallback for caption [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 [01:46:48] (03CR) 10jenkins-bot: [V: 04-1] Use link title as fallback for caption [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [01:47:22] (03PS6) 10MarkTraceur: Use link title as fallback for caption [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 [01:58:41] (03CR) 10Gergő Tisza: [C: 031] "Haven't tried but I think title text is not escaped, so we need to do that ourselves." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [01:59:08] (03CR) 10Gergő Tisza: [C: 04-1] Use link title as fallback for caption [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [04:19:46] is there a canonical way to display a File object's thumbnail programically? [04:20:02] or do I just mess with Html::element the thumb URL manually? [08:31:15] marktraceur: I don't know what happened with #489. maybe I got lost in the sea of tabs and thought I'd merged it [08:41:41] (03CR) 10Gilles: [C: 032] jshint fixes for mw.UploadWizardLicenseInput.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86787 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [08:41:51] (03Merged) 10jenkins-bot: jshint fixes for mw.UploadWizardLicenseInput.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86787 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [08:43:36] (03CR) 10Gilles: [C: 032] jquery audit on mw.IframeTransport.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86811 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [08:43:44] (03Merged) 10jenkins-bot: jquery audit on mw.IframeTransport.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86811 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [08:49:13] (03CR) 10Gilles: [C: 04-1] jshint fixes for mw.UploadWizardUpload.js (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [08:50:54] (03CR) 10Gilles: jshint fixes for mw.UploadWizardUpload.js (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [08:52:15] (03CR) 10Gilles: "I see that the schema https://meta.wikimedia.org/wiki/Schema:UploadWizardUploadActions contains "username" and "language". I don't see the" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84213 (owner: 10MarkTraceur) [10:43:04] (03PS1) 10Gilles: Fix wrong tsv url for image performance map [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/131039 [12:49:50] ohaio [12:50:15] https://www.mediawiki.org/wiki/Multimedia/Media_Viewer/Release_Plan#Large_Wikis [12:50:29] This lacks any information about the upcoming roll-out [12:52:10] gi11es, marktraceur: I'm guessing the next rollout happens on May 8 if no meteorite hits the Bay area? [13:22:29] twkozlowski: 2nd batch is scheduled for may 8th, yes, as described on the "timeline" section below on the same page [13:23:08] I think fabrice is keeping that page very up-to-date with links to the announcements, discussion pages, etc. that are communicated to us by the community leaders of each language wiki [13:28:23] community leaders... [13:33:04] I don't know what the appropriate term is, but my understanding is that most, if not all language wikipedia are run by non-profits that have appointed people in charge and community representatives [13:34:28] we've reached out to these people, asked them what the best approach is to announce the upcoming launch and gather community feedback and/or let them do the community outreach themselves [13:34:59] if you feel like it wasn't announced properly on a given wikipedia, feel free to bring it up on the mailing list [13:35:23] fabrice, keegan and the people they;re in touch with for that wikipedia will look into it [13:35:44] gi11es: I was surprised there wasn't any announcement about MV being enabled on Commons [13:36:10] (As far as I can see in the Village Pump there) [13:36:18] https://commons.wikimedia.org/wiki/Commons:Village_pump#Media_Viewer_Launching_Soon [13:36:48] Broken. [13:36:50] there's a link to this on the page you linked to earlier, next to Commons: https://www.mediawiki.org/wiki/Multimedia/Media_Viewer/Release_Plan#Large_Wikis [13:37:23] Yes, and there is no such section on the page [13:37:33] deleted maybe? it's definitely not that way on purpose [13:38:11] No, it appears no one posted to Commons yet [13:38:26] I checked the Spanish Wikipedia and it had an announcement posted on Apr 26 [13:38:35] alright, in that case I assume that it was about to get done or someone forgot to, I'll send an email to the mailing list [13:38:45] I'm sure fabrice will take care of it when he gets to the office [13:39:03] Thanks [13:40:09] thanks for pointing it out [13:50:00] just a heads-up that Wiki Loves Earth has probably started, and there is one report (in German) that a user repeatedly get stasherror trying to upload: https://commons.wikimedia.org/wiki/Commons:Forum#UploadWizard_w.C3.A4hrend_Wettbewerben [13:50:39] plus there are also two related recent tickets created in Bugzilla (last page hangs) [13:50:58] andre__: Make sure to ping the user, otherwise he might miss your reply. [13:51:17] @Häferl, with Echo [13:51:20] Is there a button to click for that? [13:51:28] Echo... how do I use that? :P [13:51:41] I see an "edit" button. [13:51:45] andre__: You reply to them like {{ping|Häferl}}: Blablabla [13:52:00] then sign your reply with ~~~~ and they get an Echo notification [13:52:09] and e-mail if they set it. [13:52:10] twkozlowski, am I expected to manually write {{ping|Häferl}} ? [13:52:15] Yes. [13:52:18] sigh [13:52:26] I kind of refuse to learn more markup. [13:52:34] You can write @[[User:Häferl|Häferl]], too [13:52:39] I'm just a stupid users, expecting a button or some logic for that. [13:52:41] andre__: What additional markup is it? [13:52:42] *user [13:52:49] it's just a template {{ }} [13:52:50] remembering {{ping}}? [13:52:58] it's not additional markup. [13:53:08] 15:52 twkozlowski: You can write @[[User:Häferl|Häferl]], too [13:53:11] everything I have to write additionally is additional for me. [13:53:30] if I reply to a person, I'd expect some WikIEditor button or so that says "ping user you reply to"? [13:53:44] and not my brain having to remember {{ping|foo}} [13:53:57] You don't need to remember that. [13:54:09] If you don't, there is a bigger chance they will miss your reply, though. [13:54:47] I look forward to a comfortable discussion implementation in MediaWiki. Maybe I'll even start to believe in Flow. :) [16:22:03] marktraceur: using you as surrogate to get gerrit change on Deploy calendar for next week's thursday deploy [16:22:23] Sounds like fun [16:23:24] enormous quantities of [17:49:06] Hm, I have no idea what I'm going to do today [17:49:34] I guess there's at least one metrics patch I can merge and deploy [17:49:45] And maybe I can knock out 220 [17:49:51] But that strikes me as minimal [18:20:41] fabriceflorin: Deployment pushback coming your way [18:21:03] fabriceflorin: pushback is the wrong word, but, have time for a quick phone call? [18:24:53] summary: we discussed at the deployment meeting, and there's general discomfort with doing the commons deployment while so many people are at the Hackathon [18:25:56] I think everyone agrees that we can deploy to Japanese Wikipedia and the other big sites on the list as scheduled [18:27:07] we would then also delay the last batch to give commons its own window the week after the Hackathon [19:45:38] robla greg-g Keegan : Thanks for the clarification about the idea of pushing back Commons a week because of the Hackathon. I’m fine with this, and we were prepared to pushback if we got some community concerns anyway. Greg, do you still want to talk about it by phone, or should we just make a decision here on IRC? [19:47:43] robla : Are you proposing we only deploy on Commons on May 15, but not on Enwiki, Dewiki, Itwiki and Ruwiki? Or do you propose that we do Commons all the way at the end, on May 22? If so, do you think it needs its own window? Or could it go out along with all other wikis? [19:49:38] marktraceur: You may want to start thinking about #504, the basic zoom feature, as I am pretty sure we’re going to have to bite the bullet and develop it this month: too many people are asking for it for us to ignore this reasonable request. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/504 [20:00:39] (03CR) 10Gergő Tisza: "I'm a little late to the party but here are some comments." (036 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130089 (owner: 10Gilles) [20:03:40] fabriceflorin: I'd sort of like to have a higher-level analysis of whether this is so important that we should continue to spend a lot of time on it or if we can hold off until coming weeks when we have no MMV cards scheduled [20:05:23] * robla catches up here [20:09:57] fabriceflorin: hey, sorry, was chatting with James in real life. Yeah, here is fine. [20:11:19] May 8 would be the currently set of Wikipedias (Japanese, Portuguese, etc) [20:11:34] The proposal as I understand it: https://etherpad.wikimedia.org/p/mvrelease [20:11:42] oh, even better [20:12:41] :) [20:13:22] fabriceflorin: ^ [20:13:40] * robla agrees with the plan on Etherpad ^ [20:14:19] basically, commons is a weird case, so we want to keep a closer eye on it than most deploys [20:15:34] the May 8 batch is basically more of the same from an code and operations perspective (we think), so as long as we have a good handle on the performance, it's no biggy. [20:15:59] * greg-g nods [20:47:08] (03PS1) 10Gergő Tisza: Add WIP section, fix bug with merged section [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/131217 [20:47:11] (03CR) 10jenkins-bot: [V: 04-1] Add WIP section, fix bug with merged section [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/131217 (owner: 10Gergő Tisza) [20:47:38] (03CR) 10Gergő Tisza: [C: 032 V: 032] Add WIP section, fix bug with merged section [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/131217 (owner: 10Gergő Tisza) [20:47:40] (03CR) 10jenkins-bot: [V: 04-1] Add WIP section, fix bug with merged section [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/131217 (owner: 10Gergő Tisza) [20:48:31] (03CR) 10Gergő Tisza: [C: 032 V: 032] Add WIP section, fix bug with merged section [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/131217 (owner: 10Gergő Tisza) [21:01:44] robla greg-g marktraceur keegan : sounds good. I will update our release plan to reflect the propsed dates on Etherpad, then announce this on the multimedia and commons mailing lists. Thanks for thinking through this carefully :) https://etherpad.wikimedia.org/p/mvrelease [21:03:41] we just talked by phone: we're all good :) [21:04:08] * greg-g called right when fabriceflorin sent that message at 14:01 :) [21:04:48] It’s worth noting that May 29th was the original date I had proposed for final release a few months ago, before Howie asked us to accelerate the schedule. I am glad we’re back to this more sensible release plan. :) [21:08:42] Got it [21:08:44] Fucking hell [21:08:56] officewiki is triggering CORS for image requests! [21:08:58] Weird stuff [21:09:49] Hmmm. Let me know if you need any help. I’m tied up on a call for an hour, but free afterwards. [21:10:19] tgr: Any idea why we'd be setting CORS to true on a local image? [21:10:31] CORS? [21:10:33] 'cause like...the URL we request is https://office.wikimedia.org/w/thumb.php?f=Lila_Announcement_New_York_Times.jpg&width=640 [21:10:58] fabriceflorin: Cross-Origin Resource Sharing [21:11:18] It's used to make requests from the JS on en.wikipedia.org to the API on commons.wikimedia.org, for example [21:11:22] But we shouldn't need that here [21:11:25] Thanks. Sounds technical, glad you guys are on it :) [21:29:35] fabriceflorin: oh, when you get back, do you know the status of Telugu WP? I assume the "?" next to Telugu is a maybe. [21:30:39] We are confirmed with Telugu for next week and want to keep them in the loop, because hey can help us find out if there are serious performance issues in regions with slow connections. [21:30:50] marktraceur, fyi, I saw this red error message a couple times on public prod wikis [21:30:58] will keep an eye on it if I can give you a clean repro [21:31:22] greg-g Also, Kannada is now confirmed for May 15, but would be pushed to the following week, based on your new plan. [21:32:50] fabriceflorin: gotcha, thankya! [21:35:19] greg-g: No prob. I will update all this by 3:30pm: https://www.mediawiki.org/wiki/Multimedia/Media_Viewer/Release_Plan#Large_Wikis [21:36:00] fabriceflorin: cool, I updated the https://www.mediawiki.org/wiki/Multimedia/Media_Viewer/Release_Plan#Timeline part of that page just now [21:36:20] Thanks! Will fill up the rest after my call. [21:46:57] Eloquence: That's not good [21:54:21] marktraceur: we preload images with AJAX so that we get 1) time stats, 2) a progress bar [21:54:45] tgr: But we don't need CORS if it's not actually cross-origin... [21:55:01] and we need CORS for the AJAX request, so we need CORS for the image tag as well, otherwise it would mess up caching [21:55:19] not sure whether need for cross-domain stuff or headers though [21:55:27] I think both [21:56:31] the performance metric would probablyy need it for local images, to get non-standard headers like X-Varnish [21:56:46] Hrm [21:56:56] of course we don't care about officewiki metrics, so we might be able to disable it there [22:01:52] on second thought, we are not setting any headers, just reading them [22:02:11] so the request should not become a CORS one, only if it is cross-domain [22:02:42] the performance logger still needs the CORS headers on the response and silently fails to read certain data if they are not there [22:02:53] tgr: Whatever the CORS settings are doing, they're doing it to this request and it's wrong [22:02:56] but the request itself should be a normal one [22:03:56] I guess the problem is that setting cors=anonymous on the second request means that credentials are stripped [22:04:31] Aha. [22:05:29] you can leave off that property and it will work, question is, how to detect we are requesting a private image? [22:05:52] Hm. [22:06:12] could be decided based on 'thumb.php' being part of the URL but eww [22:06:34] maybe filerepoinfo returns that? [22:06:42] Maybe... [22:07:26] No, it doesn't [22:08:02] the easiest way might be to just check the sampling ratio, and if it is 0, just do a normal image request and no AJAX [22:08:26] that would mean the progress bar doesn't work, but we can probably live with that [22:08:50] That sounds sub-par... [22:09:25] then you just have to check whether thumb.php/image_auth.php is part of the URL [22:09:42] which would fail in nasty ways if someone sets up rewrite rules [22:15:06] if you want progress bar information, you need AJAX preloading; if you do AJAX preloading, you need to set the crossorigin property of the on certain browsers, otherwise it will be double-loading instead of preloading; the only thing you can do is to set it to 'use-credentials', but you don't want to do that for non-private wikis because it increases the request size [22:16:02] so if you want progress bar info and don't want double downloading, you need to be able to tell if the wiki is private, I don't think there is a way around that [22:16:27] could be set as a resourceloader variable or something [22:16:43] or we could add it to the filerepoinfo [22:18:17] Hm [22:18:32] Not even sure how to tell on the backend. [22:21:34] I seem to recall Tim saying something like FileRepo::getZoneUrl('public') would be empty in that case [22:22:06] Hm [22:22:10] https://gerrit.wikimedia.org/r/#/c/96920/ [22:22:24] "FileRepo::getZoneUrl('thumb') on such wikis should be ignored and may return false." [22:22:35] the wording is not exactly reassuring [22:23:30] No indeed [22:30:59] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/562 has the thoughts [22:31:05] Expand if you want :) [22:39:32] bd808: We're on it thanks :) [22:39:53] * bd808 is late to reading da emailz [22:44:44] Eloquence: the error message is shown every time a request fails, could be a genuine network problem [22:51:07] fabriceflorin: updated local announcement on de :-) [22:52:05] se4598: Thanks so much for doing this! Having an extra week will give us more time to get feedback from beta testers :) [23:53:26] (03CR) 10MarkTraceur: [C: 032 V: 032] Fix wrong tsv url for image performance map [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/131039 (owner: 10Gilles)