[06:29:35] (03CR) 10Gilles: [C: 032] Use localized namespace name in embed wikitext [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131325 (https://bugzilla.wikimedia.org/64710) (owner: 10Gergő Tisza) [06:30:07] (03Merged) 10jenkins-bot: Use localized namespace name in embed wikitext [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131325 (https://bugzilla.wikimedia.org/64710) (owner: 10Gergő Tisza) [06:31:55] marktraceur: it's working, was just checking to be sure [06:34:16] (03PS1) 10Gilles: Increase the threshold where a load is considered to be coming from the browser cache [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 [06:34:48] (03CR) 10jenkins-bot: [V: 04-1] Increase the threshold where a load is considered to be coming from the browser cache [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [06:39:18] (03Abandoned) 10Gilles: For local repos, use display name from config variable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131266 (https://bugzilla.wikimedia.org/64800) (owner: 10Rillke) [06:40:35] (03CR) 10Gergő Tisza: "I'm having second thoughts about this... filerepoinfo does not have a language. Maybe we should go in the other direction, use wgSiteName," [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131266 (https://bugzilla.wikimedia.org/64800) (owner: 10Rillke) [07:08:04] (03PS2) 10Gilles: Increase the threshold where a load is considered to be coming from the browser cache [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 [07:52:42] (03PS1) 10Gilles: Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 [07:52:51] (03CR) 10Gilles: "https://gerrit.wikimedia.org/r/131435" (036 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/130089 (owner: 10Gilles) [07:54:27] (03CR) 10jenkins-bot: [V: 04-1] Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 (owner: 10Gilles) [08:01:58] (03PS2) 10Gilles: Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 [08:02:30] (03CR) 10jenkins-bot: [V: 04-1] Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 (owner: 10Gilles) [08:14:43] (03PS3) 10Gilles: Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 [08:15:19] (03CR) 10jenkins-bot: [V: 04-1] Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 (owner: 10Gilles) [08:18:53] (03PS4) 10Gilles: Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 [09:22:32] marktraceur: data on the graphs stops at may 1st/may 2nd, worth checking if the cron jobs are running properly [15:45:15] gi11es: marktraceur: when should I worry/how often do the bugs reported in bugzilla get reviewed/added to your team's work items? I'm specifically thinking of these: UploadWizard related: (https://bugzilla.wikimedia.org/show_bug.cgi?id=64685 and https://bugzilla.wikimedia.org/show_bug.cgi?id=64148) and API/Storage: https://bugzilla.wikimedia.org/show_bug.cgi?id=64883 [15:58:18] (03PS1) 10Rillke: UploadWizard: Use promises instead of plain callbacks [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131487 [16:01:42] greg-g: We pull them in every once in a while, and selectively. We're no longer doing formal bug triaging meetings, but we also have a full plate for the foreseeable future, barring any major blow-uppy bugs. [16:02:09] please define major blow-uppy [16:02:15] :) [16:02:26] greg-g: Like, fatals. [16:02:34] there's one that looks regression-like re UW and Wiki Loves * [16:02:43] * marktraceur winces [16:03:10] I think... [16:03:12] Oh FFS [16:03:20] Who's on out-of-focus duty, gi11es? [16:03:28] :) [16:03:29] sorry [16:03:33] No no [16:03:34] It's fine [16:04:52] marktraceur: I'd like WMF to avoid coming across as "Deploying some MultimediaViewer feature is more important than people repeatedly having issues uploading via UW in this community contest" in the end. I'm a little bit afraid of that, I must admit :) [16:15:57] (ditto) [16:29:39] (03PS1) 10Rillke: UploadWizard: Use prefix for class names for css-scoping [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131493 [16:29:42] (03CR) 10jenkins-bot: [V: 04-1] UploadWizard: Use prefix for class names for css-scoping [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131493 (owner: 10Rillke) [16:36:05] (03PS2) 10Rillke: UploadWizard: Use prefix for class names for css-scoping [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131493 [16:38:13] (03CR) 10Gergő Tisza: "I wonder if this should be higher? I did 3-4 reloads on my machine and already got a 9ms latency for a cached call." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [16:42:12] (03PS3) 10Rillke: UploadWizard: Use prefix for class names for css-scoping [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131493 [16:52:42] andre__, greg-g - I'd also like to avoid that. [16:53:38] (03CR) 10Gergő Tisza: "Maybe the logs could be used to determine a good cutoff period - look for a gap between the small and the large times." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [16:54:21] (03CR) 10Gergő Tisza: Increase the threshold where a load is considered to be coming from the browser cache (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [17:12:01] * marktraceur actually looks at the bugs. [17:13:09] OK, https://bugzilla.wikimedia.org/show_bug.cgi?id=64685 is a Yuvi bug, I'll bother him and see if we can't get things moving [17:13:25] But also I think it's not critical; they've worked around it and I don't foresee any other related issues [17:22:48] gi11es: Re-poke about bugs [17:33:24] marktraceur: that comment might be welcome to add to the report, in some nice wording :) [17:33:38] sometimes it's more about the feeling of getting attention. you know... [17:36:32] andre__: "attention" is hard to define here [17:36:39] Me talking about solutions won't help [17:40:43] (03CR) 10Krinkle: [C: 032] UploadWizard: Use promises instead of plain callbacks [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131487 (owner: 10Rillke) [17:41:02] (03Merged) 10jenkins-bot: UploadWizard: Use promises instead of plain callbacks [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131487 (owner: 10Rillke) [17:41:43] tgr: https://bugzilla.wikimedia.org/show_bug.cgi?id=64710 there's a critical question here about *what language* to localize to [17:41:50] This is why I left it English initially [17:44:55] marktraceur: interface language I suppose? [17:45:17] oh, nevermind, had another ticket in mind [17:45:30] tgr: But interface language may not be the language of the wiki being copied to [17:45:42] if it is a local wiki, it has to be content language [17:45:51] And we don't really have any indication of what wikis get copied to [17:45:57] if it is a Commons image, it has to be English, I suppose [17:46:07] I'll fix that [17:46:15] We shouldn't special-case Commons [17:46:45] yeah, in general when it is a remote image, English is the only safe choice [17:46:58] But it can *always* be a remote image [17:47:02] Unless it's a private wiki [17:48:30] this only causes a problem if you have a remote with a content language other than English [17:48:43] and a local wiki with a different non-English content language [17:48:46] right? [17:48:58] Um. [17:49:43] tgr: This causes hypothetical problems that we don't have data to negate in any wiki that can be used as a remote repo, which is all of them that aren't private, for any wiki which could have non-English or non-current-user's-UI-language content languages, which is also all of them [17:50:56] technically true, but seems like it would never happen in practice [17:51:16] wikis other than commons don't get used as repos much [17:51:33] some chapters use a Wikipedia as repo, but then the content language is the same [17:51:40] Well OK [17:51:43] Feasible use case: [17:52:19] that said, wikitext copied from Commons would always have File:, and that would be the majority, so I guess there is not much point in translating the rest [17:52:23] (03CR) 10Krinkle: [C: 032] "That's useful.. :D The rule is empty." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131493 (owner: 10Rillke) [17:52:39] (03Merged) 10jenkins-bot: UploadWizard: Use prefix for class names for css-scoping [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131493 (owner: 10Rillke) [17:52:53] tgr: An enwiki user browses frwiki with French set as their UI language, to avoid context-switching. Jean-Fred took a beautiful picture and put it on Commons, then used it in a French article. The user copies the wikitext with [[Fichier: in it to enwiki, where it won't work. [17:53:37] File: always works. [17:53:48] yeah, good point [17:54:40] we could do something horrible like {{subst:ns:File}} [17:54:49] * marktraceur winces [17:55:47] at any rate the current state is wrong, I'll revert [17:55:59] and maybe bring this up on the list [17:56:27] 'kay [17:56:39] I sort of like {{subst:ns:File}} but also sort of don't. [17:56:55] I'm torn, really. It's an elegant solution but it makes the wikitext look slightly less elegant [17:58:09] (03PS1) 10Gergő Tisza: Revert "Use localized namespace name in embed wikitext" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131509 [17:58:56] (03PS2) 10Gergő Tisza: Revert "Use localized namespace name in embed wikitext" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131509 (https://bugzilla.wikimedia.org/64710) [18:04:04] (03CR) 10Gergő Tisza: [C: 04-1] "I'm not sure this will work. As far as I can tell, window.Geo is set by the CentralNotice extension, and the relevant loader line is:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 (owner: 10Gilles) [18:11:09] (03CR) 10MarkTraceur: [C: 04-1] "tgr, is this a -1? It sounds like there are enough issues with it..." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [18:31:22] (03CR) 10Gergő Tisza: "I don't think image size has any effect, fast responses will come from Varnish, so only the response size matters." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [18:40:32] https://bugzilla.wikimedia.org/show_bug.cgi?id=64910 in other news [18:40:41] More artifacts of us assuming things about language [18:45:12] this is an mw.Title bug [18:45:19] well, arguably not a bug [18:45:49] but it's the result of new mw.Title('Benutzer:Vorderstrasse', 2) [18:46:43] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/570 [18:46:55] tgr: It's not a bug because why would frwiki need to know about German namespaces [18:47:08] It's our fault for asking for the URL and then not using it [18:49:16] Is this because we "fixed" https://bugzilla.wikimedia.org/show_bug.cgi?id=63908 ? [18:49:31] there should be a way to construct an mw.Title object from full page name + namespace id [18:49:37] not that we actually need it [18:50:21] we did not fix that one [18:50:28] that's for local images [18:50:58] Yeah. [18:51:15] tgr: There's a way to do that, but it's only possible localized to the current wiki, which is the problem [18:51:36] I guess we could *display* the localized version, then link to the URL even if it's different [18:52:16] what we really should do is create mw.InterwikiTitle [18:52:21] or something like that [18:52:45] Eep [18:52:49] the way external titles are handled now is a hack [18:53:02] tgr: Do we need to handle external titles that way? [18:53:19] not need to, but it would sure be nicer [18:53:32] Showing the French "Benutzer:Whatever" will not be super-helpful; "Utilisateur:Whatever" they at least understand what they're going to [18:53:36] then we could just store the full url inside the object [18:54:15] we can show localized prefixes if we want to [18:54:19] not sure we do [18:54:49] but the logic is simple, if the namespace id is nonzero, split at the first :, and replace the first part with the local namespace prefix [18:54:55] Oh, hm, we...crap. [18:55:01] Yeah [18:55:02] That. [18:55:13] I keep forgetting how crappy namespace handling is in Mediawiki [20:28:45] (03PS1) 10Gergő Tisza: Do not log a metadata event when the user presses the wrong key [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131586 [20:29:23] (03CR) 10jenkins-bot: [V: 04-1] Do not log a metadata event when the user presses the wrong key [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131586 (owner: 10Gergő Tisza) [20:31:39] (03PS2) 10Gergő Tisza: Do not log a metadata event when the user presses the wrong key [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131586 [20:41:42] (03CR) 10MarkTraceur: [C: 032 V: 032] Fix userAgent query for versus tsv [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/131249 (owner: 10Gilles) [20:48:08] (03PS1) 10Rillke: UploadWizard: Don't throw JS errors; instead report them in UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) [20:53:59] (03CR) 10MarkTraceur: [C: 032 V: 032] Make sure the data is cut off at midnight [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/131253 (owner: 10Gilles) [20:54:37] (03PS2) 10Rillke: UploadWizard: Don't throw JS errors; instead report them in UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) [21:07:19] (03PS3) 10Rillke: UploadWizard: Don't throw JS errors; instead report them in UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) [21:09:06] (03PS4) 10Rillke: UploadWizard: Don't throw JS errors; instead report them in UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) [22:07:09] (03PS1) 10Gergő Tisza: Extract metadata panel scroll/log/animate logic into separate component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131618 [22:07:57] (03CR) 10jenkins-bot: [V: 04-1] Extract metadata panel scroll/log/animate logic into separate component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131618 (owner: 10Gergő Tisza) [22:29:26] (03PS2) 10Gergő Tisza: Extract metadata panel scroll/log/animate logic into separate component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131618 [22:40:23] (03CR) 10MarkTraceur: "Patch coming" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [22:40:32] (03PS5) 10MarkTraceur: jshint fixes for mw.UploadWizardUpload.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) [22:40:35] (03CR) 10jenkins-bot: [V: 04-1] jshint fixes for mw.UploadWizardUpload.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [22:41:55] (03PS6) 10MarkTraceur: jshint fixes for mw.UploadWizardUpload.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) [22:53:44] (03PS2) 10MarkTraceur: jshint fixes for mw.UploadWizardDeed.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86777 (https://bugzilla.wikimedia.org/47161) [22:53:59] (03CR) 10MarkTraceur: "Rebase - fix for the comment incoming" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86777 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [22:55:31] (03CR) 10Krinkle: "Two pending for this file:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86777 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [22:58:03] (03PS3) 10MarkTraceur: jshint fixes for mw.UploadWizardDeed.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86777 (https://bugzilla.wikimedia.org/47161) [22:58:10] (03CR) 10MarkTraceur: jshint fixes for mw.UploadWizardDeed.js (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86777 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [22:58:17] (03CR) 10MarkTraceur: "Fixed issues" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86777 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [23:05:14] (03PS2) 10MarkTraceur: jquery audit of mw.ApiUploadHandler.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86803 (https://bugzilla.wikimedia.org/53245) [23:13:00] (03CR) 10Krinkle: jquery audit of mw.ApiUploadHandler.js (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86803 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [23:14:01] (03CR) 10MarkTraceur: jquery audit of mw.ApiUploadHandler.js (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86803 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [23:14:31] (03CR) 10Krinkle: [C: 04-1] "This left one coding style issue (see jshint build, find "Deed.js"), but also introduced something that's more than a coding style issue." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86777 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [23:43:41] (03PS2) 10MarkTraceur: jshint fixes for mw.UploadWizardDetails.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86779 (https://bugzilla.wikimedia.org/47161) [23:43:58] (03CR) 10MarkTraceur: "Rebase" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86779 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [23:46:26] (03CR) 10MarkTraceur: "Patch incoming" (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86779 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [23:46:31] (03PS3) 10MarkTraceur: jshint fixes for mw.UploadWizardDetails.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86779 (https://bugzilla.wikimedia.org/47161)