[03:46:32] (03PS7) 10Gilles: Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 [03:53:41] (03CR) 10Gilles: Improve DurationLogger test code (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 (owner: 10Gilles) [04:05:01] (03CR) 10Gilles: [C: 04-1] UploadWizard: Don't throw JS errors; instead report them in UI (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [04:49:36] (03PS1) 10Gilles: Improve post-fullscreen panel/image sizing logic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131930 [04:52:52] tgr: you need to add points to your cards, it's always missing from stuff you add during the sprint [04:53:43] I regularly add estimations when I spot them, but I'm not in the best position to estimate how much you spent on it, and it's a lot of cards [05:02:33] (03CR) 10Lupo: Accept files whose name are invalid titles (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [05:22:07] (03CR) 10Lupo: Accept files whose name are invalid titles (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [05:50:37] (03CR) 10Gergő Tisza: [C: 04-1] "Two tiny issues." (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 (owner: 10Gilles) [07:29:39] (03PS1) 10Shirayuki: i18n: consistency tweaks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/131934 [07:32:32] (03PS2) 10Shirayuki: i18n: consistency tweaks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/131934 [07:37:10] (03PS3) 10Shirayuki: i18n: consistency tweaks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/131934 [08:00:30] gi11es: added [08:24:57] (03PS9) 10Rillke: UploadWizard: Don't throw JS errors; instead report them in UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) [08:31:34] (03CR) 10Rillke: UploadWizard: Don't throw JS errors; instead report them in UI (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [08:52:05] (03PS8) 10Gilles: Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 [08:52:11] (03CR) 10Gilles: Improve DurationLogger test code (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 (owner: 10Gilles) [09:03:19] (03CR) 10Gilles: [C: 04-1] "I'm not sure what's wrong, but on Firefox I see the error message flash into view, then it disappears. It only reappears if I click inside" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [09:30:07] (03CR) 10Rillke: "Same for a tile like" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [10:13:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [10:21:19] (03CR) 10Siebrand: [C: 032] i18n: consistency tweaks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/131934 (owner: 10Shirayuki) [10:21:29] (03Merged) 10jenkins-bot: i18n: consistency tweaks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/131934 (owner: 10Shirayuki) [11:18:43] (03PS1) 10Gilles: Add a global image views graph with all wikis in one graph [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/131954 [11:41:57] (03CR) 10Rillke: Accept files whose name are invalid titles (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [11:42:46] (03PS5) 10Rillke: Accept files whose name are invalid titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) [12:12:36] (03CR) 10Krinkle: UploadWizard: Don't throw JS errors; instead report them in UI (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [12:34:03] (03Abandoned) 10Rillke: Accept files whose name are invalid titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [12:45:19] (03PS3) 10Siebrand: Copy contents of campaign fields on copy-metadata [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83414 (https://bugzilla.wikimedia.org/40147) (owner: 10Rillke) [12:45:24] (03CR) 10Siebrand: [C: 032] Copy contents of campaign fields on copy-metadata [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83414 (https://bugzilla.wikimedia.org/40147) (owner: 10Rillke) [12:45:34] (03Merged) 10jenkins-bot: Copy contents of campaign fields on copy-metadata [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83414 (https://bugzilla.wikimedia.org/40147) (owner: 10Rillke) [12:46:25] (03CR) 10Siebrand: [C: 032] Test titles in Details step. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50953 (https://bugzilla.wikimedia.org/42554) (owner: 10Nischayn22) [12:46:28] (03CR) 10jenkins-bot: [V: 04-1] Test titles in Details step. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50953 (https://bugzilla.wikimedia.org/42554) (owner: 10Nischayn22) [12:47:12] (03CR) 10Siebrand: [C: 032] Fix miscellaneous jshint issues [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131686 (https://bugzilla.wikimedia.org/47161) (owner: 10Gilles) [12:47:20] (03Merged) 10jenkins-bot: Fix miscellaneous jshint issues [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131686 (https://bugzilla.wikimedia.org/47161) (owner: 10Gilles) [13:29:13] (03CR) 10Rillke: "I260ba883548975 has been submitted to have main functionality of this in Core." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [16:14:11] marktraceur / gi11es: Did you know about https://gerrit.wikimedia.org/r/#/c/131933/ before it happened? Seems a quite major change to just sail past without even a bug… [16:14:48] James_F: first time I see this [16:15:18] ...wow [16:15:20] gi11es: It went out in this morning's SWAT. [16:15:32] I was just reading the Deployments calendar. [16:16:36] James_F: It says "Local Consensus" but without a link? [16:16:53] marktraceur: I couldn't find it with a quick look, but maybe I looked in the wrong places? [16:18:48] Sigh [16:20:28] Oh, I was reading the wrong thing [16:20:31] James_F: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#What_sorcery_is_this.3F_Mischeviously_broken_file_red_links. [16:21:55] marktraceur: Ah. OK then. Still would have been polite to mention it to you lot. [16:24:07] Yeah it would have been [16:24:13] But like...we aren't the only gatekeepers [16:24:20] anomie has the power to merge that for a good reason [16:27:39] If someone made a deployment change to VE or Parsoid without mentioning it to our teams we'd be displeased. [16:27:53] I don't think Multimedia is different just because you're a newer team. [16:29:00] James_F: No, we're different because we're a team with a wider purview [16:29:36] James_F: A better analogy would be if someone merged a change to mediawiki core without consulting Brion personally [16:29:40] Like of course they did [16:29:45] Shit needs to get done and brion is busy [16:30:32] Multimedia is much narrower than all of MediaWiki, and the Multimedia team is much wider than one person. [16:31:32] Technically true. [16:31:48] Not just technically. [16:34:44] Heh, yeah [16:35:09] James_F: There's no exact analogy, the point is that multimedia is way wider than VE or Parsoid [16:35:24] OK, "skins". [16:35:43] People making changes to skins almost invariably talk to MatmaRex and Trevor. [16:35:59] Not all the time, but almost, because they know it'd be rude to not mention changes to them, [16:36:16] Because those people have clear ownership, I guess, and exercise it [16:36:35] We haven't really exercised our ownership of the upload pipeline yet. Working on it though! [16:36:45] * James_F nods [17:33:07] gi11es: https://gerrit.wikimedia.org/r/84213 is a thing. [17:35:31] (marktraceur: are you not coming into the office?) [17:36:33] greg-g: No, I'm WFH, why? [17:36:41] Want a BART buddy? [17:37:49] marktraceur: I was, but I can go it alone. [17:37:55] Heh [17:38:01] greg-g: Could meet you at 24th street [17:38:11] that sounds dangerous/annoying [17:39:17] Heh [17:52:54] So I'm going to deal with jQuery upgrade shit. [18:12:13] Hm. [18:12:34] The hashchange library uses the deprecated $.browser object [19:19:47] Wow [19:19:47] https://github.com/cowboy/jquery-hashchange/pulls [19:19:57] Like five commits adding 1.9 support [19:20:00] gj internet [19:28:20] (03PS1) 10MarkTraceur: Fix up one issue with jQuery 1.9 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132020 [19:28:35] Krinkle|detached: https://gerrit.wikimedia.org/r/132020 [21:42:08] (03PS10) 10Rillke: UploadWizard: Don't throw JS errors; instead report them in UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) [21:53:00] (03CR) 10Rillke: "> I'm not sure what's wrong, but on Firefox I see the error" (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke)