[00:23:02] <quiddity>	 marktraceur, et al -  re: http://lists.wikimedia.org/pipermail/wikitech-l/2014-May/076522.html - Would you or anyone else in here, support or object to having wikibugs in here, and being the main channel for (TimedMediaHandler? MultimediaViewer? UploadWizard? other?)  bugs?
[00:24:44] <marktraceur>	 Sure.
[02:44:44] <tgr>	 Keegan: do I have to do anything special if I want to add a section to the MediaViewer FAQ?
[02:44:54] <tgr>	 I'm not familiar with content translation
[02:45:26] <Keegan>	 You do not. After you save, I'll update the translation mark
[06:21:27] <warpath>	 I was told to nag here regarding [[bug:65406]] :D
[07:21:56] <gi11es>	 marktraceur: seems high priority, here's the changeset to review: https://gerrit.wikimedia.org/r/#/c/133844/
[08:10:55] <grrrit-wm>	 (03CR) 10Steinsplitter: [C: 031] Wait until iframe is fully loaded before submitting form [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke)
[08:27:51] <grrrit-wm>	 (03CR) 10Rillke: Wait until iframe is fully loaded before submitting form (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke)
[09:02:54] <grrrit-wm>	 (03PS2) 10Gilles: Highlight chevron when the wrong direction is pressed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133893 
[09:15:44] <hashar>	 gi11es: bonjour!
[09:16:01] <gi11es>	 hashar: what's up?
[09:16:14] <hashar>	 gi11es: Zeljkof ne revient que la semaine prochaine.  Pas trop de sur de quand on jouera les browsers tests avec Safari :-/
[09:16:55] <gi11es>	 hashar: c'était pas urgent à ce point là, à mon avis le jour où ce sera dispo on aura juste à copier-coller le job et le faire tourner sur safari
[09:17:09] <gi11es>	 actuellement la probabilité que ce test marche sur chrome et ne marche pas sur safari est faible
[09:17:37] <gi11es>	 ça test pas toutes les fonctionnalités de media viewer en profondeur, juste la base
[09:18:00] <hashar>	 good enough for now :]
[09:18:35] <hashar>	 j'ai bon espoir d'y arriver avant fin juin en tout cas
[09:25:01] <grrrit-wm>	 (03PS1) 10Gilles: Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 
[09:25:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles)
[09:43:51] <grrrit-wm>	 (03PS1) 10Gilles: Take sampling factor into account [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/134065 
[09:45:01] <grrrit-wm>	 (03PS2) 10Gilles: Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 
[09:46:39] <grrrit-wm>	 (03CR) 10Gilles: "This needs backporting. If there are no concerns and you +2 it, please backport it today Gergo, so that the action graphs start looking no" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles)
[10:31:52] <grrrit-wm>	 (03CR) 10Steinsplitter: "This patch can be merged immediately because the feature is completely broken." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke)
[10:39:33] <grrrit-wm>	 (03CR) 10Rillke: "Actually it works in Internet Explorer 11. I think I am going to advertise for that browser on COM:VP :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke)
[11:34:27] <dan-nl>	 hey gi11es, have been trying to set-up tests for one of my commits. it works locally, but not via jenkins … any ideas? https://gerrit.wikimedia.org/r/#/c/133409/
[12:18:01] <dan-nl>	 gi11es: are you reviewing gwtoolset patches this week?
[12:59:35] <grrrit-wm>	 (03PS1) 10Odder: Change preference name for enabling MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134080 
[13:00:33] <grrrit-wm>	 (03CR) 10Odder: "https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/622" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134080 (owner: 10Odder)
[13:24:47] <grrrit-wm>	 (03CR) 10Rillke: [C: 04-1] Change preference name for enabling MediaViewer (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134080 (owner: 10Odder)
[13:25:26] <grrrit-wm>	 (03CR) 10Nemo bis: "I'm not so convinced: for me, MediaWiki core has a "media viewer" too (thumbnails and file pages). I think you only need to change the wor" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134080 (owner: 10Odder)
[13:37:21] <grrrit-wm>	 (03PS2) 10Odder: Change preference name for enabling MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134080 
[13:38:07] <grrrit-wm>	 (03CR) 10Odder: Change preference name for enabling MediaViewer (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134080 (owner: 10Odder)
[13:48:37] <grrrit-wm>	 (03CR) 10Rillke: [C: 031] "Thank you." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134080 (owner: 10Odder)
[13:49:29] <grrrit-wm>	 (03CR) 10Rillke: "> for me, MediaWiki core has a "media viewer"" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134080 (owner: 10Odder)
[13:49:39] <grrrit-wm>	 (03CR) 10Rillke: [C: 031] Change preference name for enabling MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134080 (owner: 10Odder)
[13:50:08] <rillke>	 sorry ^^ (why does gerrit not remember my +1 ....)
[14:15:25] <marktraceur>	 gi11es: Now that's something I can definitely do... :)
[14:49:04] <grrrit-wm>	 (03CR) 10Aaron Schulz: "If the job was already there then it should be tried 3 times before being deleted (about 1 day apart, given the claim TTL). If it failed t" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133994 (https://bugzilla.wikimedia.org/61401) (owner: 10Brian Wolff)
[15:14:45] <marktraceur>	 Has anyone been keeping track of those month-long surveys we've been doing?
[15:14:56] <marktraceur>	 Or have some of them become month-and-a-quarter-long? :)
[16:18:19] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] Wait until iframe is fully loaded before submitting form (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke)
[16:18:40] <marktraceur>	 Reviewed; there are some minor issues, rillke
[16:33:16] <rillke>	 thanks
[16:33:24] <marktraceur>	 Of course
[16:34:26] <rillke>	 marktraceur: http://jshint.com/ and enter   return 'javascript:void(0)';
[16:34:52] <rillke>	 One warning l.13 - Script URL.
[16:35:02] <marktraceur>	 Hm.
[16:35:15] <marktraceur>	 gi11es: What was the convention we'd come up with for this?
[16:35:46] <rillke>	 Oh, you have some secret convention?
[16:36:13] <marktraceur>	 Not secret AFAIK
[16:37:02] <rillke>	 So, did you write them down?
[16:37:11] <rillke>	 Specifically for iframes?
[16:37:21] <marktraceur>	 They might be on a CC page, sec.
[16:40:19] <grrrit-wm>	 (03PS3) 10Rillke: Wait until iframe is fully loaded before submitting form [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) 
[16:51:53] <gi11es>	 dan-nl: marktraceur has that duty this week
[16:52:04] <marktraceur>	 Oh hm
[16:52:09] <marktraceur>	 Sorry I missed it
[16:52:23] <gi11es>	 tons of out-of-focus this week, like last
[16:52:31] <marktraceur>	 Yeah
[16:52:41] <marktraceur>	 I doubt I'll be able to finish the tests for the core stuff
[16:52:46] <gi11es>	 and yes, void(0) is the classic one
[16:52:47] <marktraceur>	 I'll upload a WIP patch soon
[16:52:52] <marktraceur>	 rillke: ^^
[16:53:00] <marktraceur>	 But I guess it's not a convention, let's talk to Krinkle.
[16:53:05] <marktraceur>	 Oh lol he's in here.
[16:53:10] <marktraceur>	 But -dev is more helpful.
[16:54:25] <dan-nl>	 gi11es: thanks. marktraceur please let me know if you have any ?'s … have 4 patches in gerrit and need some help with some title tests i created
[16:55:12] <marktraceur>	 dan-nl: 'kay
[16:56:38] <grrrit-wm>	 (03CR) 10Rillke: Wait until iframe is fully loaded before submitting form (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke)
[16:59:25] <grrrit-wm>	 (03CR) 10Krinkle: Wait until iframe is fully loaded before submitting form (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke)
[17:08:42] <fabriceflorin>	 gi11es marktraceur tgr : Hi guys, any idea why the metrics dashboards seem to be stuck with old data from Friday? Is there anything we could fiddle with to get new data to show up? http://multimedia-metrics.wmflabs.org/dashboards/mmv 
[17:10:42] <grrrit-wm>	 (03PS4) 10Rillke: Wait until iframe is fully loaded before submitting form [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) 
[17:11:49] <rillke>	 So is this guaranteed to work on IE 6-10, marktraceur ^^
[17:14:35] * rillke  doesn't quite understand what the issue with javascript:false was; it was valid and it worked ...

[17:16:16] <tgr>	 rillke: it's confusing because it looks like it's supposed to do something but it actually does not
[17:16:24] <tgr>	 why set src in the first place?
[17:16:59] <rillke>	 Ask NeilK, he wrote the code.
[17:18:39] <tgr>	 personally, I suspect this is one of those NIH syndrome cases
[17:19:50] <tgr>	 there is probably no need to reinvent file uploading, there are dozens of libraries which do it and unlike our homebrewn version they actually do it correctly
[17:20:16] <rillke>	 The feature is broken and yes, I was to lazy to run browser tests in IE 6-11, ... so I just used what worked.
[17:21:08] <tgr>	 yeah, there probably should be a way to run tests on a gerrit id
[17:21:21] <tgr>	 Jenkins tests, I mean
[17:21:28] <tgr>	 I'll file a bug about that
[17:22:33] <marktraceur>	 tgr: Yeah, reinventing file uploading...ugh. See https://www.mediawiki.org/wiki/Requests_for_comment/More_general_frontend_uploading_tools
[17:22:40] <marktraceur>	 In particular https://www.mediawiki.org/wiki/Requests_for_comment/More_general_frontend_uploading_tools#Use_a_third-party_uploading_library_as_our_base
[17:23:01] <grrrit-wm>	 (03PS1) 10Hashar: Code hygiene: pass flake8 python linter [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/134128 
[17:24:29] <grrrit-wm>	 (03PS2) 10Hashar: Code hygiene: pass flake8 python linter [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/134128 
[17:24:44] <grrrit-wm>	 (03CR) 10Hashar: "PS2 ignores E501 as well (lines too long)" [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/134128 (owner: 10Hashar)
[17:25:43] <rillke>	 https://github.com/blueimp/jQuery-File-Upload/blob/master/js/jquery.iframe-transport.js#L42
[17:26:01] <rillke>	 thanks for the pointer  marktraceur
[17:26:40] * rillke  is going out to see the warning popups

[17:27:43] <grrrit-wm>	 (03CR) 10Rillke: [C: 04-1] "https://github.com/blueimp/jQuery-File-Upload/blob/master/js/jquery.iframe-transport.js#L42" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke)
[17:31:42] <tgr>	 rillke: based on some quick googling, about:blank seems to be the most cross-browser thing to do here
[17:31:53] <tgr>	 unless you want to do browser sniffing
[17:32:02] <rillke>	 tgr: https://github.com/blueimp/jQuery-File-Upload/blob/master/js/jquery.iframe-transport.js#L42
[17:32:09] <marktraceur>	 Oof.
[17:34:18] <marktraceur>	 rillke: Pretty sure random jquery plugins are not paragons of best practices
[17:34:28] <tgr>	 rillke: see for example https://drupal.org/node/285533 about that
[17:35:14] <marktraceur>	 But okay you've done about:blank now
[17:35:16] <tgr>	 maybe not a problem if the iframe is never visible
[17:35:39] <marktraceur>	 tgr, Krinkle - is about:blank something we could settle on?
[17:35:47] <marktraceur>	 For iframes, anyway.
[17:36:06] <marktraceur>	 Obviously for links it would be useless and we should just enforce that rule.
[17:36:57] <Krinkle>	 marktraceur: I wouldn't, I think about:blank is not stable cross-browser
[17:37:03] <Krinkle>	 just don't set it at all
[17:37:22] <Krinkle>	 the default behaviour is to allow free writing to the iframe, e.g. origin-less / part of your own document
[17:37:25] <tgr>	 it's not really a settle on type of question, it's a what works question
[17:37:39] <Krinkle>	 if you want it to load url, set a src.
[17:37:39] <Krinkle>	 its like <script> in a way
[17:37:43] <tgr>	 apparently no src will fail on IE6 on HTTPS
[17:37:45] <Krinkle>	 and yes, <script> can also have src="" and contents at the same time
[17:37:55] <tgr>	 javascript:false is troublesome on IE10
[17:38:07] <tgr>	 javascript: even more so
[17:38:20] <Krinkle>	 If this loads in IE6, that'd be a miracle.
[17:38:29] <Krinkle>	 Or is this not where I think it is.
[17:38:41] <Krinkle>	 Oh, it is.
[17:39:28] <Krinkle>	 If you need a src, then about:blank I guess (if that works for the browsers you need to support).
[17:39:39] <tgr>	 about:blank is actually a standard thing: http://tools.ietf.org/html/rfc6694#section-3
[17:39:55] <tgr>	 which of course still doesn't mean it works in all browsers
[17:39:56] <Krinkle>	 Yes, but since when are browsers standards compliant?
[17:39:58] <Krinkle>	 hehe :)
[17:40:14] <Krinkle>	 the W3 spec says it as well
[17:40:53] <tgr>	 anyway, about:blank still doesn't work on IE6 apparently: http://aspnetresources.com/blog/always_set_iframe_source
[17:40:53] <YuviPanda>	 hello, marktraceur and quiddity. I know that grrrit-wm already sends events here, and am wondering which bugzilla components / products you'd be interested in sending here
[17:40:56] <YuviPanda>	 just cleaning up -dev
[17:41:22] <marktraceur>	 YuviPanda: UW, MMV, TMH, core components Image handling, Uploads
[17:41:37] <YuviPanda>	 marktraceur: alright, let me prepare a patch
[17:41:57] <marktraceur>	 Sweetness
[17:42:12] <marktraceur>	 fabriceflorin: Any other bugzilla components I forgot?
[17:42:13] <tgr>	 also CMD
[17:42:17] <marktraceur>	 RighT!
[17:42:29] <marktraceur>	 YuviPanda: CommonsMetadata, the extension
[17:42:44] <tgr>	 GWToolset, maybe?
[17:43:41] <fabriceflorin>	 marktraceur: I’m not sure if it’s helpful, but here is a list of all the multimedia bugs we are now tracking: https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=dorem&list_id=315285&namedcmd=Multimedia%20-%20All%20Bugs&remaction=run&sharer_id=14593
[17:44:00] <marktraceur>	 Aha!
[17:44:05] <fabriceflorin>	 marktraceur: I can sort through that and list all the components, if you like.
[17:44:10] <marktraceur>	 That's perfect, it will give YuviPanda a useful list of components
[17:44:19] <marktraceur>	 YuviPanda: File management, GlobalUsage, ImageMap, OggHandler, PagedTiffHandler, PdfHandler, Score, TimedMediaHandler, Uploading, UploadWizard, VipsScaler
[17:44:25] <fabriceflorin>	 marktraceur: OK, happy to help. 
[17:44:26] <marktraceur>	 {{done}} {{bam}}
[17:45:17] <marktraceur>	 Aw, no CMD on that list though
[17:45:20] <marktraceur>	 Nor MMV
[17:45:25] <marktraceur>	 Not as helpful
[17:45:32] <tgr>	 re iframes, if we don't care about IE6 then just don't set the source
[17:45:32] <fabriceflorin>	 Note it’s missing Media Viewer and CommonsMetaData, as well as GWToolset. There may be more missing …
[17:45:39] <marktraceur>	 Ah.
[17:45:49] <tgr>	 if we do care about it, do browser sniffing
[17:45:50] <marktraceur>	 tgr: Ehhhh it's UW, we do care
[17:45:58] <marktraceur>	 At least we have and haven't changed our minds
[17:46:10] * marktraceur  should maybe send that email too

[17:46:37] <tgr>	 marktraceur: Krinkle said it doesn't work with IE6 anyway, unless I am misunderstanding
[17:46:52] <marktraceur>	 Eloquence: We were chatting about this in Zurich, yeah? Do you want to be involved in deciding our lower bound for IE support in UW?
[17:47:07] <tgr>	 but if we do care, then use javascript:false for IE6, make sure it's not used for IE10
[17:47:50] <rillke>	 tgr: What's the issue with  javascript:false in IE 10 ?
[17:48:11] <rillke>	 The iframes are hidden ...
[17:48:15] <tgr>	 rillke: apparently it sets the content of the iframe to "false"
[17:48:28] <tgr>	 if it is completely hidden, that might be all right
[17:48:49] <rillke>	 so it displays "false" -- other browsers do this as well
[17:48:57] <rillke>	 this isn't an issue
[17:49:54] <YuviPanda>	 marktraceur: Is OggHandler under extensions? Can't find it
[17:49:59] <marktraceur>	 Hm
[17:50:07] <YuviPanda>	 nor under Medeiawiki
[17:50:08] <marktraceur>	 YuviPanda: Probably just ignore it, I haven't seen that before
[17:50:10] <YuviPanda>	 maybe it's just part of tmh
[17:50:11] <YuviPanda>	 ok
[17:50:24] <YuviPanda>	 did you decide if you wanted GWToolset?
[17:50:47] <marktraceur>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=65487
[17:50:53] <marktraceur>	 YuviPanda: Yes we do.
[17:51:43] <YuviPanda>	 marktraceur: interesting because I don't see it on https://bugzilla.wikimedia.org/enter_bug.cgi?product=MediaWiki%20extensions
[17:52:41] <tgr>	 rillke: in general I would prefer using the standard way on browsers that support it
[17:53:11] <tgr>	 about:blank/no src has well defined behavior
[17:53:11] <YuviPanda>	 marktraceur: https://gerrit.wikimedia.org/r/#/c/134140/ am testing it now
[17:53:11] <grrrit-wm>	 (03CR) 10Krinkle: jQuery 1.9 compatibility fixes (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles)
[17:53:33] <marktraceur>	 YuviPanda: It probably got removed but the bug still exists for some reason
[17:53:41] <tgr>	 I wouldn't be terribly surprised if javascript:false triggered a GET request on some browsers
[17:53:52] <tgr>	 like e.g. src="" on images does
[17:53:53] <YuviPanda>	 marktraceur: can you poke a bug somewhere?
[17:54:28] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "" removeProp('disabled') " doesn't exist." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles)
[17:54:48] * marktraceur  just did

[17:55:05] <tgr>	 rillke: but given that we plan to get rid of this code eventually anyway, I don't feel strongly about it
[17:55:09] <YuviPanda>	 hmm
[17:58:50] <YuviPanda>	 marktraceur: poke again? I had it as Mediawiki instead of MediaWiki
[17:58:50] <grrrit-wm>	 (03CR) 10Krinkle: jQuery 1.9 compatibility fixes (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles)
[17:58:50] <marktraceur>	 :)
[17:59:15] * marktraceur  looks around for wikibugs

[17:59:40] <YuviPanda>	 oh what now
[18:00:07] <YuviPanda>	 hmm
[18:00:10] * marktraceur  giggles

[18:00:50] <YuviPanda>	 marktraceur: wikibugs!
[18:00:55] <grrrit-wm>	 (03CR) 10Catrope: jQuery 1.9 compatibility fixes (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles)
[18:01:01] <marktraceur>	 Woot
[18:01:11] <YuviPanda>	 marktraceur: pokey?
[18:01:17] <marktraceur>	 Done
[18:01:27] <wikibugs>	 3MediaWiki extensions / 3UploadWizard: UploadWizard fails badly with jshint - 10https://bugzilla.wikimedia.org/47161#c68 (10Mark Holmquist) Stop failing yuvi
[18:01:31] <marktraceur>	 Yay!
[18:01:57] <grrrit-wm>	 (03PS1) 10Hashar: Tox environement to run flake8 python linter [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/134144 
[18:02:10] <YuviPanda>	 marktraceur: woot!
[18:02:24] <YuviPanda>	 marktraceur: can you look at the patch once to make sure I got everything right?
[18:02:56] <marktraceur>	 Sure, where is it?
[18:03:05] <grrrit-wm>	 (03CR) 10Hashar: "From there we can get a Jenkins job invoking the flake8 env: https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Test_your_pyt" [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/134144 (owner: 10Hashar)
[18:03:49] <YuviPanda>	 marktraceur: https://gerrit.wikimedia.org/r/#/c/134140/
[18:04:15] <marktraceur>	 Python as a config language
[18:04:31] <YuviPanda>	 marktraceur: too lazy to move to YAML
[18:04:38] <marktraceur>	 I should smack you.
[18:05:00] <YuviPanda>	 marktraceur: the primary maintainer also prefers it this way, plus we are gonna move to phab anyway
[18:05:06] <marktraceur>	 Fair
[18:05:07] <marktraceur>	 Phair.
[18:06:14] <YuviPanda>	 marktraceur: cool. let me +2 the patch
[18:06:28] <YuviPanda>	 lol, I don't have +2 rights
[18:06:36] <marktraceur>	 Hahaha
[18:06:43] <YuviPanda>	 it's running anyway :P
[18:06:55] <marktraceur>	 #deploybutnotmerge
[18:08:39] <YuviPanda>	 marktraceur: I had +2 apparently
[18:08:45] <YuviPanda>	 just hit 'add comment' instead or 'r'
[18:09:20] <marktraceur>	 Heh
[18:09:46] <YuviPanda>	 marktraceur: oh, ugh. I don't think I added GWToolset
[18:10:20] <marktraceur>	 Bahahah
[18:11:34] <YuviPanda>	 marktraceur: is it under extensions?
[18:11:57] <marktraceur>	 Yeah
[18:11:58] <YuviPanda>	 yeah it is
[18:16:58] <YuviPanda>	 marktraceur: should've moved over now
[18:17:08] <marktraceur>	 'kay
[18:17:51] <marktraceur>	 rillke: Are you switching back to false, or...
[18:17:56] <marktraceur>	 You have a -1 on the patch still
[18:18:22] <marktraceur>	 dan-nl: I don't understand, why did you ask for review on an abandoned patch
[18:19:02] <dan-nl>	 it wasn't abandoned at first ...
[18:19:22] <marktraceur>	 That doesn't particularly change the current situation :)
[18:19:31] <dan-nl>	 k, what do i need to do?
[18:19:47] <marktraceur>	 dan-nl: Well, tell me what you want - is this reviewable or something you don't want merged anymore?
[18:20:05] <dan-nl>	 do you mean this one https://gerrit.wikimedia.org/r/#/c/133409/? it's now closed
[18:20:23] <dan-nl>	 the new one is https://gerrit.wikimedia.org/r/#/c/134073/, which is open and needs review
[18:20:26] <rillke>	 I am switching back; just took a screenshot and did some testing ... once the VM was started I wanted to use it, marktraceur
[18:20:29] <marktraceur>	 Aha.
[18:20:40] <marktraceur>	 (to both)
[18:20:47] <marktraceur>	 dan-nl: On it
[18:21:04] <grrrit-wm>	 (03CR) 10Rillke: Wait until iframe is fully loaded before submitting form (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke)
[18:21:33] <dan-nl>	 thanks, didn't see a way to remove you from the abandoned patch … thought that since it's closed i didn't need to do anything else. sorry about the confusion ...
[18:21:48] <marktraceur>	 *nod*
[18:21:59] <marktraceur>	 The issue was you linking to it directly here, it caused confusion :)
[18:22:00] <Eloquence>	 marktraceur, I trust y'all to figure it out; let's just make sure that we seamlessly fall back to the preferred no-JS upload experience (I'm guessing Commons:Upload) for browsers we don't support.
[18:22:20] <marktraceur>	 Sure
[18:22:37] * marktraceur  will start up some sort of email thread

[18:22:44] <marktraceur>	 I guess that makes two so far today
[18:22:49] <marktraceur>	 Maybe we can make it a hat trick
[18:24:07] <Eloquence>	 actually this could probably be done by the code in https://commons.wikimedia.org/wiki/MediaWiki:Gadget-UploadWizard.js
[18:24:47] <Eloquence>	 mh, maybe not, given that there might be other popular entrypoints
[18:25:03] <marktraceur>	 e.g. campaign links...
[18:25:13] <Eloquence>	 yeah
[18:25:19] <marktraceur>	 Which I think is the biggest potential issue for browser support anyway
[18:25:24] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] Fix documentation on token for transcodereset action [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133405 (https://bugzilla.wikimedia.org/65197) (owner: 10Brian Wolff)
[18:25:32] <grrrit-wm>	 (03PS5) 10Rillke: Wait until iframe is fully loaded before submitting form [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) 
[18:25:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix documentation on token for transcodereset action [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133405 (https://bugzilla.wikimedia.org/65197) (owner: 10Brian Wolff)
[18:27:27] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Unrecognized value for parameter 'intoken': transcodereset - 10https://bugzilla.wikimedia.org/65197#c5 (10Brad Jorsch) 5PAT>3RES/FIX The auto-generated documentation has been clarified. This should be deployed to WMF wikis with 1.24wmf6, see https://www.mediawi...
[18:31:51] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Thanks for all the hard work, rillke :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke)
[18:32:12] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Fix "JQMIGRATE: Use of jQuery.fn.data('events') is deprecated" in TimedMediaHandler - 10https://bugzilla.wikimedia.org/65428#c5 (10Tisza Gergő) Hard to tell how exactly it should be done without knowing how you track when all plugins are loaded, but probably someth...
[18:41:27] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Fix "JQMIGRATE: Use of jQuery.fn.data('events') is deprecated" in TimedMediaHandler - 10https://bugzilla.wikimedia.org/65428#c6 (10Michael Dale) there is no master for-loop other then the triggered event ... i.e the core get sources implementation should not have t...
[18:52:41] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Fix "JQMIGRATE: Use of jQuery.fn.data('events') is deprecated" in TimedMediaHandler - 10https://bugzilla.wikimedia.org/65428#c7 (10Tisza Gergő) If you have some sort of plugin registry (i.e. you know the full list of plugins, even if you don't know which plugins wi...
[19:30:12] <wikibugs>	 3MediaWiki extensions / 3OggHandler: OggHandler should pass jshint - 10https://bugzilla.wikimedia.org/65487#c5 (10Antoine "hashar" Musso) Made it pass jshint with the very conservative patch: https://gerrit.wikimedia.org/r/#/c/134164/
[19:44:44] <greg-g>	 hey multimedia team, have ya'll taken a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=53770 yet? curious if there's anything specific platform/core should help with.
[19:46:50] <marktraceur>	 greg-g: Maybe it will be fixed when Aaron's sha1 patch goes in?
[19:46:56] <marktraceur>	 That should happen in the next few weeks FWIW
[19:48:33] <marktraceur>	 Urgh, I fear Steinsplitter is getting too angry at the wrong things, and not usefully so
[19:48:54] <greg-g>	 yeah, a comment on the bug with status might be helpful, but.. yeah
[19:50:20] <marktraceur>	 I don't have a status, I suspect gi11es has a better handle on what the actual issue might be
[19:50:47] <bawolff>	 Steinsplitter is generally a reasonable guy, he's just a bit angsty
[19:50:55] <andre__>	 After getting asked three times if it's still a problem without any action from developers (and several times pinging them) I can understand frustration.
[19:51:08] <andre__>	 well, bawolff to the rescue for commenting and investigating at least :)
[19:51:36] <bawolff>	 Did I investigate, I thought i just said I have no idea what's wrong
[19:51:47] <andre__>	 bawolff, I count that as investigating already ;)
[19:52:25] <andre__>	 marktraceur: ignoring the ticket because of a rant which has a point normally doesn't help to decrease frustration, but investigating and ignoring the rant might. :)
[19:52:46] <andre__>	 and yeah, Steinsplitter is a reasonable guy.
[19:53:12] <marktraceur>	 andre__: I'm not ignoring, just comminting
[19:53:15] <marktraceur>	 commenting
[19:53:22] <andre__>	 marktraceur, I like. Thanks! :)
[19:53:34] <marktraceur>	 Oh, not commenting on the bug, just commenting here. :P
[19:53:42] <marktraceur>	 I can't add to the conversation right now
[19:53:45] <andre__>	 yeah, that's a pity. :)
[19:54:51] <bawolff>	 Anyways, since steinsplitter commented on the mailing list about too many open bugs in that component, we've now recategorized or closed about a third of them ;)
[19:55:17] <marktraceur>	 I dunno about that being the best solution...
[19:56:44] <andre__>	 heh. understandable. I guess I come across as impatient too, sorry....
[19:57:47] <bawolff>	 Oh hmm, stein says originally that "I cannot delete the broken version of this file"
[19:58:09] <bawolff>	 Which is understandable as the broken version probably doesn't exist on our servers as it suffered from that race condition bug that was subsequently fixed
[20:50:41] <wikibugs>	 3MediaWiki extensions / 3UploadWizard: JPEGs on Commons: Several versions uploaded but only one record in history - 10https://bugzilla.wikimedia.org/64883#c20 (10Bawolff (Brian Wolff)) (In reply to Rainer Rillke @commons.wikimedia from comment #15) > > e.g. https://commons.wikimedia.org/wiki/File:0054%D7%A8%...
[20:56:57] <wikibugs>	 3MediaWiki extensions / 3UploadWizard: Error: invalid magic word 'ns' - 10https://bugzilla.wikimedia.org/65386#c5 (10Tisza Gergő) 5RES/?>3VER Recently this occurred again, and the cache update did not help this time but an apache restart did. Weird.
[20:57:50] <grrrit-wm>	 (03PS4) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 
[20:59:30] <wikibugs>	 3MediaWiki extensions / 3UploadWizard: UploadWizard should not allowing upload two different files with same name at same time - 10https://bugzilla.wikimedia.org/54750#c6 (10Bawolff (Brian Wolff)) Note, potential dupe at bug 64883 (But this one was here first).  (In reply to Lokal_Profil from comment #5) > W...
[20:59:41] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Duh. Went through all the EventLogging/ResourceLoader initialization logic with a debugger and it turned out to be just a missing dependen" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza)
[21:02:44] <grrrit-wm>	 (03CR) 10Gergő Tisza: Basic funnel data logging for UploadWizard (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza)
[21:29:09] <marktraceur>	 tgr: https://gerrit.wikimedia.org/r/127460 is an attempt at writing a first-pass test for that bignasty sha1 patch; it's failing now for some reason
[21:30:42] <tgr>	 marktraceur: failing on your machine?
[21:30:51] <marktraceur>	 Yeah
[21:31:02] <marktraceur>	 Oh hm
[21:31:09] <marktraceur>	 Merge conflict, go figure
[21:31:18] * marktraceur  fixes

[21:41:58] <wikibugs>	 3MediaWiki extensions / 3UploadWizard: UploadWizard should not allowing upload two different files with same name at same time - 10https://bugzilla.wikimedia.org/54750#c7 (10Rainer Rillke @commons.wikimedia) *** Bug 64883 has been marked as a duplicate of this bug. ***
[21:41:58] <wikibugs>	 3MediaWiki extensions / 3UploadWizard: JPEGs on Commons: Several versions uploaded but only one record in history - 10https://bugzilla.wikimedia.org/64883#c21 (10Rainer Rillke @commons.wikimedia) 5PAT>3RES/DUP   *** This bug has been marked as a duplicate of bug 54750 ***
[21:42:22] <grrrit-wm>	 (03PS7) 10Rillke: UploadWizard: Check for duplicate titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) 
[21:42:49] <marktraceur>	 \o/ more out of focus that I can actually do.
[21:43:10] <marktraceur>	 Oh oops I failed to post some drafts
[21:43:13] <wikibugs>	 3MediaWiki extensions / 3UploadWizard: UploadWizard should not allowing upload two different files with same name at same time - 10https://bugzilla.wikimedia.org/54750 (10Rainer Rillke @commons.wikimedia) a:3Rainer Rillke 
[21:43:24] <grrrit-wm>	 (03CR) 10MarkTraceur: UploadWizard: Check for duplicate titles (036 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke)
[21:44:06] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "See PS6; nothing changed since then but Gerrit is hard" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke)
[21:45:06] <marktraceur>	 tgr: If you're lucky you'll get to ride-along for the deployment on Thursday...
[21:47:39] <rillke>	 marktraceur: 'for' -- Unnecessary quotes ?
[21:48:31] <marktraceur>	 Oh, got me there
[21:48:36] <marktraceur>	 But the others should be OK
[21:50:21] <grrrit-wm>	 (03CR) 10MarkTraceur: UploadWizard: Check for duplicate titles (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke)
[22:06:45] <grrrit-wm>	 (03PS8) 10Rillke: UploadWizard: Check for duplicate titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) 
[22:08:12] <grrrit-wm>	 (03PS9) 10Rillke: UploadWizard: Check for duplicate titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) 
[22:09:19] <grrrit-wm>	 (03CR) 10Rillke: UploadWizard: Check for duplicate titles (037 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke)
[22:14:37] <marktraceur>	 rillke: I don't think it's working for me...uploading two files with the same filename doesn't trigger any errors
[22:14:50] <marktraceur>	 Two files with the same filename but different extensions
[22:14:59] <tgr>	 I did a little housekeeping of schemas, and marked a few as inactive: https://meta.wikimedia.org/wiki/Template:MediaViewer_schemas
[22:15:09] <tgr>	 please correct if wrong
[22:15:50] <bawolff>	 marktraceur: I think his fix is for two files with exact same name
[22:16:12] <bawolff>	 People on commons consider it a bug that you can't upload 2 files with same name but different extension via upload wizard
[22:17:23] <marktraceur>	 Yeah...
[22:17:50] <marktraceur>	 tgr: Seems right
[22:19:15] <marktraceur>	 bawolff: I don't get it for that either
[22:19:23] * marktraceur  reads more

[22:20:59] <marktraceur>	 Oh got it
[22:21:13] <marktraceur>	 You need to change both titles on the details page or the bug isn't repro'able
[22:21:29] <marktraceur>	 Maybe that's a problem? I can get teh old error by changing the name to the filename of the first file
[22:22:39] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "I think it's an issue that you can still get the old error by uploading a file named Foobar.jpg and changing another file's name to Foobar" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke)
[22:23:47] <bawolff>	 I did just run stats. There's a little less than 20 thousand such uploaded files, so users are managing to do this
[22:24:05] <marktraceur>	 Probably through special:upload :)
[22:24:15] <tgr>	 marktraceur: are you testing locally?
[22:24:22] <bawolff>	 not counting Special:Upload
[22:24:42] <bawolff>	 well only counting things that have an upload comment of 'Uploaded by UploadWizard'
[22:24:49] <marktraceur>	 Yeah, tgr
[22:24:58] <marktraceur>	 bawolff: Oh, weird.
[22:25:19] <bawolff>	 19,511 to be precise
[22:25:23] <tgr>	 this issue is probably triggered by a race condition between two PHP threads, so it might be very sensitive to configuration / machine setup
[22:25:31] <marktraceur>	 ...hm
[22:26:17] <tgr>	 when it is not triggered, you probably get a duplicate warning from the API and UW reports the error normally
[22:26:45] <bawolff>	 aren't upload wizard warnings recieved prior to the publish stash step?
[22:29:47] <tgr>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=65338#c11 has some details
[22:30:22] <fabriceflorin>	 marktraceur tgr bawolff: On that topic, I was able to upload the same files twice last week, but had to change them to a different format (PNG instead of JPG). I was glad that ‘feature’ was available, because I accidentally gave the JPGs the same name (‘copy title’ was selected by default and messed things up for me). After I deleted those JPG files, there was no way for me to re-upload them without changing their format. 
[22:30:23] <fabriceflorin>	 Here’s an example of a JPG file reuploaded as a PNG:  https://commons.wikimedia.org/wiki/File:Upload_Wizard_-_Design_Mockup_-_1.png 
[22:30:48] <bawolff>	 fabriceflorin: Use special:Upload ;)
[22:31:05] <bawolff>	 (since uploadwizard doesn't let you reupload deleted files)
[22:32:02] <tgr>	 this is a different bug
[22:32:22] <tgr>	 the one where UW gives up on any warning
[22:32:36] <bawolff>	 bug 46741
[22:33:01] <fabriceflorin>	 bawolff: Thanks for the tip about Special Upload. I didn’t know this was an option. Much appreciated. Should we let users know about this special page if they experience the same problem I had? https://commons.wikimedia.org/wiki/Special:Upload
[22:33:02] <tgr>	 yup, thanks
[22:33:25] <tgr>	 actually, we should probably schedule that bug for the next few weeks, too
[22:33:44] <bawolff>	 "Please try the new upload wizard, but if it doesn't work then please try the old upload wizard"
[22:34:10] <marktraceur>	 new*
[22:34:33] <marktraceur>	 s/old/older/ s/new/old/
[22:34:59] <bawolff>	 And if that really doesn't work, try the version where commons didn't re-write the entire thing in sort-of-crusty js :P
[22:36:28] <fabriceflorin>	 bawolff: Yes, maybe it could be in a special ‘troubleshooting’ section of the FAQ. But wait, is there a real FAQ for Upload Wizard? The only thing I’m finding is a confusing help forum that is likely to scare away new users: https://commons.wikimedia.org/wiki/Commons:Upload_help 
[22:37:29] <marktraceur>	 fabriceflorin: Exactly, it matches the rest of UploadWizard. :0
[22:37:33] <marktraceur>	 :) even
[22:38:22] <marktraceur>	 fabriceflorin: https://commons.wikimedia.org/wiki/Commons:FAQ exists; maybe too general
[22:50:09] <grrrit-wm>	 (03PS5) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 
[22:53:35] <fabriceflorin>	 marktraceur: Thanks, I saw Commons FAQ, but think it is indeed too generic for helping people through the upload process. I think writing a special version of a focused FAQ could be an easy improvement for users who are not familiar with this workflow. I will add a card for that on Mingle. 
[22:55:50] <marktraceur>	 fabriceflorin: Given we don't use Mingle to track product stuff, maybe not necessary?
[22:57:01] <fabriceflorin>	 marktraceur: Well, it has one development implication: to provide the link in Upload Wizard. It is also helpful for me to see these cards, as one of the team members, even if they have few development points.
[22:57:57] <Eloquence>	 fabriceflorin, https://commons.wikimedia.org/wiki/Commons:Upload_Wizard_FAQ
[22:58:10] <Eloquence>	 there's also a general overview at https://commons.wikimedia.org/wiki/Commons:Upload_Wizard
[22:58:42] <fabriceflorin>	 Eloquence: Thank you! I will add this to the ticket, to recommend we link there instead of the confusing help forum. Then we can add a link to the help forum inside the FAQ.
[22:59:33] <marktraceur>	 It's like literally a minute of our time I think
[22:59:36] <marktraceur>	 0.001 points
[22:59:42] <fabriceflorin>	 Cool. 
[22:59:49] <fabriceflorin>	 We can do this next week, then.
[23:00:21] <Eloquence>	 fabriceflorin, it would be useful for someone with deep commons expertise to actually add FAQ entries for some of the more finer points of the upload process that are sometimes raised on upload help.
[23:00:49] <Eloquence>	 s/more//
[23:00:50] <fabriceflorin>	 Eloquence: I agree. I will take on that task in coming weeks, with guidance from our community partners.
[23:01:42] <grrrit-wm>	 (03PS10) 10Rillke: UploadWizard: Check for duplicate titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) 
[23:02:25] <grrrit-wm>	 (03CR) 10Rillke: "``.getName()`` then :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke)
[23:03:20] <fabriceflorin>	 The FAQ ticket has been added to our Upload Wizard queue: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/625
[23:05:11] <marktraceur>	 rillke: It still doesn't work on titles that haven't been modified
[23:11:00] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "This still won't work when the filenames aren't modified - if I upload blah.png and blah.jpg, they'll get all the way to the end and give " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke)
[23:15:18] <rillke>	 marktraceur, if I upload Abcdef.jpg and Abcdef.png, I cannot publish either of them because I get a warning ...
[23:15:54] <marktraceur>	 rillke: I think this is a matter of "local configuration differences"
[23:16:22] <marktraceur>	 rillke: Wait - you got the warning *you* added, or something else?
[23:16:30] <marktraceur>	 Because if you get your warning that's weird.
[23:16:42] <marktraceur>	 There may be a race condition but shouldn't be, the uploads shouldn't ever start
[23:16:49] <rillke>	 I get "This title has been specified for more than one file you're going to upload. Underscores are treated as spaces, a file extension is added automatically."
[23:17:01] <rillke>	 for the second file in the list
[23:18:16] <marktraceur>	 Which is what you added.
[23:18:17] <marktraceur>	 Weeeeird.
[23:18:33] <marktraceur>	 rillke: So I guess the bug report is that those checks should always happen before *any* files go to the server
[23:19:25] <rillke>	 At least no file with exactly the mw-title should go through so we don't have to split history
[23:20:01] <rillke>	 marktraceur, is your png file a png or is it a JPEG?
[23:20:11] <marktraceur>	 I...assume it's a PNG
[23:20:38] <marktraceur>	 Yeah, it's a PNG
[23:21:14] <rillke>	 what's the undecipherable error?
[23:21:58] <marktraceur>	 Uhhhh
[23:22:01] <marktraceur>	 Let me repro it, sec
[23:22:39] <marktraceur>	 <api-error-internal_api_error_DBQueryError>
[23:22:46] <marktraceur>	 Oh that might be related to my local setup
[23:22:47] <marktraceur>	 Sec
[23:23:41] <marktraceur>	 No, it's not
[23:24:07] <marktraceur>	 Er...probably
[23:24:50] <marktraceur>	 OK now I get one uploaded successfully
[23:24:56] <marktraceur>	 But the other still fails with the old warning
[23:27:42] <rillke>	 sorry, this was my ISP
[23:33:47] <rillke>	 marktraceur, just to clarify; you are uploading blah.png and blah.jpg, and release rights for them, this works (and should work); then, in the details step you add description but leave the titles unchanged, then clicked "next"?
[23:33:57] <marktraceur>	 Yup
[23:34:17] <marktraceur>	 Works fine for the first one (it gets uploaded), then the second one gets returned as a duplicate title (accurately), but neither should get sent at all
[23:34:32] <marktraceur>	 I guess you need to add your checks to the submit event
[23:53:45] <marktraceur>	 tgr: https://meta.wikimedia.org/wiki/Schema:UploadWizardStep may have some overlap with the existing schemata?
[23:54:43] <tgr>	 I didn't want to go around changing existing stuff
[23:55:04] <marktraceur>	 Ah.
[23:55:13] <tgr>	 the idea with the steps is to log a sequence of events and piece them together on the server side
[23:55:24] <marktraceur>	 bd
[23:55:31] <rillke>	 Hmm, I don't get it;   grep -r "detailsSubmit"   only returns one occurrence; and before this is executed    wizard.detailsValid()  is run where the validation I added should take place. So to which submit event should I add the handler?
[23:55:46] <marktraceur>	 ...weird
[23:55:59] <tgr>	 there was a long thread about it on the list
[23:56:01] <marktraceur>	 rillke: Can you verify that it's getting fired on submit?
[23:56:21] <rillke>	 it's fired from a click event
[23:56:34] <tgr>	 so the processing will be probably very different from the old schema
[23:56:36] <rillke>	 when you finally click "next"
[23:57:10] <marktraceur>	 rillke: Right, can you make sure? Throw an error or alert() or something
[23:58:25] <rillke>	 I have a stack trace with firebug here; is this wrong?
[23:59:09] <marktraceur>	 rillke: Can you pastebin it?