[00:28:10] (03CR) 10Gergő Tisza: [C: 032] Icon adjustments [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138482 (owner: 10Pginer) [00:29:03] fabriceflorin: is it intentional that we do not show the tooltip for the straight-to-Commons icon? [00:29:39] (03Merged) 10jenkins-bot: Icon adjustments [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138482 (owner: 10Pginer) [00:31:00] tgr : I believe we already show a tooltip for the link to Commons. So we want to keep that tooltip, and add the other tooltips as well, as part of #546 Add tooltips to Media Viewer. [00:31:14] we dont, actually [00:32:12] tgr : If I go to MediaWiki.org, and hover over the Commons icon at the lower right, I see a tooltip that says “More details on Wikimedia Commons”. https://www.mediawiki.org/wiki/Multimedia/Media_Viewer/Release_Plan#mediaviewer/File:Media_Viewer_Desktop_-_Large_Image_Opaque_Info.png [00:32:44] hm [00:32:51] Sorry for picking an image that’s a bit confusing, since it’s a mockup that shows the same buttons as part of the image. [00:32:51] we do not all the time, then? [00:33:25] tgr : We should be doing this all the time, if we aren’t already. Want me to add this to the #546 card, to make it clear? [00:33:55] no, I was just wondering if this was bug or feature [00:34:02] but apparently bug [00:34:29] tgr: OK, then. I will still put note on the card, to avoid any confusion. [00:35:15] it seems to be a bug in the new "show Commons link to anons" feature [00:35:19] I'll fix [00:36:05] (03PS2) 10MarkTraceur: WIP Remove jquery.hashchange, add hasher [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134954 [00:36:21] (WIP because I want to clean up some older patches...) [00:36:44] (03PS4) 10MarkTraceur: Feature detection, magical stuff [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134655 [00:36:53] (03CR) 10jenkins-bot: [V: 04-1] WIP Remove jquery.hashchange, add hasher [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134954 (owner: 10MarkTraceur) [00:37:42] (03PS3) 10Gergő Tisza: Show Commons link to logged out users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138305 [01:07:54] (03CR) 10Mdale: [C: 031 V: 032] Fix js bug where error report was always for first link. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108172 (owner: 10Brian Wolff) [01:10:46] (03CR) 10Brian Wolff: "FWIW: After reading through more of the code, I'm more confident in this patch, and wouldn't describe it as "vodoo" anymore. Its still doi" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137529 (https://bugzilla.wikimedia.org/66143) (owner: 10Brian Wolff) [01:20:48] 3MediaWiki extensions / 3TimedMediaHandler: Links in TimedText when doing a Pop up video wrong colour (CSS gets overriden) - 10https://bugzilla.wikimedia.org/66398 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3normal a:3None The links in TimedText are too dark if viewing in a pop up window Example, [[... [04:01:03] 3MediaWiki extensions / 3MultimediaViewer: Image dimensions in IE10 are skewed - 10https://bugzilla.wikimedia.org/66244#c2 (10Tisza Gergő) Apparently .mw-mmv-image-inner-wraper does not inherit the parent height in IE10, despite the height:100% rule. [07:34:29] 3MediaWiki extensions / 3TimedMediaHandler: last edited note incorrect on timedText namespace page - 10https://bugzilla.wikimedia.org/66384#c3 (10Bawolff (Brian Wolff)) Huh. in javascript wgRevisionId; gives a 0. Which is odd... ---- Probably really TimedMediaHandler's fault then. [07:44:29] 3MediaWiki extensions / 3MultimediaViewer: Add logic to deal with known non descript field values - 10https://bugzilla.wikimedia.org/66247#c4 (10Derk-Jan Hartman) well in short term we could perhaps add another machine readable annotation, to make it more readable. [07:49:59] 3MediaWiki extensions / 3MultimediaViewer: MMV hash doesn't work on pages that were redirected - 10https://bugzilla.wikimedia.org/66246#c2 (10Derk-Jan Hartman) Doesn't work for me. Mac Safari 7, logged in user. It seems that the hash gets dropped, I can't even find it back in the request log of the browser... [08:19:29] 3MediaWiki extensions / 3MultimediaViewer: MMV hash doesn't work on pages that were redirected - 10https://bugzilla.wikimedia.org/66246#c3 (10Tisza Gergő) Hashes are never sent to the webserver. Is there any error message in the JS console? I can't imagine how a redirect (which is not a HTTP redirect, just a... [08:25:15] 3MediaWiki extensions / 3MultimediaViewer: Add logic to deal with known non descript field values - 10https://bugzilla.wikimedia.org/66247#c5 (10Tisza Gergő) One way this could be handled were to leave the author field empty (the approximate date of when the work was created does not belong there), make the... [11:18:59] 3MediaWiki extensions / 3TimedMediaHandler: mw.MwEmbedSupport.style should only load on the pages that need it - 10https://bugzilla.wikimedia.org/58086#c4 (10Nemo) (In reply to Ori Livneh from comment #2) > My preference -- for this and for > the JavaScript payload which accompanies it -- would be to expose... [11:35:00] 3MediaWiki extensions / 3GWToolset: Do not overwrite content from community members/bots on re-upload - 10https://bugzilla.wikimedia.org/63638#c10 (10Andre Klapper) 5PATC>3NEW The two patches mentioned here have been merged and deployed. Can somebody elaborate what else is needed here? [12:21:14] 3MediaWiki extensions / 3UploadWizard: Error handling: api-error-unknownerror - 10https://bugzilla.wikimedia.org/66366#c3 (10Andre Klapper) Also brought up here: https://commons.wikimedia.org/w/index.php?title=Commons:Village_pump&oldid=126246147#Uploader_working_horribly [12:34:29] 3MediaWiki extensions / 3MultimediaViewer: graphics viewer - 10https://bugzilla.wikimedia.org/66408#c1 (10Andre Klapper) s:5major>3normal Hi namles, thanks for taking the time to report this! unfortunately this report is not very useful because it does not describe the problem well. If you have time an... [12:35:01] 3MediaWiki extensions / 3CommonsMetadata: No proper handling of multivalued fileds - 10https://bugzilla.wikimedia.org/57259#c7 (10Jean-Fred) What’s the current status of this patch? The issue described at bug:64888 is very problematic. I had not noticed that bug before, but frankly I would have been incline... [13:38:44] 3MediaWiki extensions / 3MultimediaViewer: Add logic to deal with known non descript field values - 10https://bugzilla.wikimedia.org/66247#c6 (10Derk-Jan Hartman) Then you loose the information that the author is "confirmed" to be unknown, versus 'not known to Commons/not entered'. [14:13:10] euh, we have links in timedtext ? [14:13:21] are those even getting sanitized then ? [14:19:52] hehe, we should put this at the top of every wikitech update [14:19:53] http://xkcd.com/1172/ [16:14:20] 3MediaWiki / 3File management: MimeMagic: ZIP types not properly detected - 10https://bugzilla.wikimedia.org/66428 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3normal a:3None Created attachment 15612 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15612&action=edit ZIP-type file with... [16:15:46] 3MediaWiki / 3File management: MimeMagic: ZIP types not properly detected - 10https://bugzilla.wikimedia.org/66428#c1 (10Rainer Rillke @commons.wikimedia) 5NEW>3ASSI a:3Rainer Rillke  Created attachment 15613 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15613&action=edit This file will be det... [16:21:44] 3MediaWiki / 3File management: MimeMagic: ZIP types not properly detected - 10https://bugzilla.wikimedia.org/66428#c2 (10Bawolff (Brian Wolff)) Cc ing csteipp. I suspect this might be exploitable... [16:30:31] 3MediaWiki extensions / 3UploadWizard: Multiple selection not reliably working. [probably chunked upload exploding] - 10https://bugzilla.wikimedia.org/65696 (10Steinsplitter) 5UNCO>3NEW [16:34:15] 3MediaWiki extensions / 3CommonsMetadata: No proper handling of multivalued fileds - 10https://bugzilla.wikimedia.org/57259#c8 (10Tisza Gergő) That specific issue should be fixed; CommonsMetadata handles multivalued fields correctly internally, but only returns one value due to limitations of the API format.... [16:38:15] 3MediaWiki extensions / 3CommonsMetadata: No proper handling of multivalued fileds - 10https://bugzilla.wikimedia.org/57259#c9 (10Raimond Spekking) (In reply to Tisza Gergő from comment #8) > The caching for CommonsMetadata is pretty complicated (there is a memcached > layer on both the frontend and backend... [17:43:21] (03Abandoned) 10MarkTraceur: Don't display too-big thumbnails [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125893 (owner: 10MarkTraceur) [18:21:28] tgr: https://gerrit.wikimedia.org/r/#/c/129847/6/resources/mmv/mmv.bootstrap.js won't the title attribute already be escaped for HTML? [18:21:43] Almost just out of curiosity [18:22:12] Also I use htmlToTextWithLinks later in the cycle, so it's OK [18:22:38] usually titles are not escaped [18:23:00] if you do escape them, you see > and such in the browser native popup [18:23:06] um [18:23:31] i mean they are escaped in the HTML source, but not as far as the DOM JS interface sees them [18:23:44] might remember wrong though [18:25:04] Hm [18:25:20] Ugh, it's not title, it's alt [18:25:22] Fail sauce [18:30:36] tgr: I'm going to hesitantly say that probably documenting the unsafeness and escaping before I put it into the DOM is OK [18:31:14] Unless that's a practice that we shouldn't do ever, in which case we have fixes to make [18:31:26] as long as it is escaped in the DOM / embed text, sure [18:34:01] Yeah, it is using htmlToTextWithLinks there [19:07:04] (03PS7) 10MarkTraceur: Use link title as fallback for caption [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 [19:29:37] fabriceflorin: Do we know where, in relation to other buttons, the view-file button should go? [19:36:03] marktraceur: Sorry for not responding sooner, went out to grab lunch. The ticket #630 for ‘View original file’ includes a mockup that shows the proposed location of the button, in the lower right corner side bar area: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/630 [19:37:06] It's OK [19:37:29] Wait [19:37:39] fabriceflorin: That mockup does not show the icon in the bar. [19:38:01] It says "next to Use This File", has pginer weighed in on that? [19:38:40] marktraceur: Pau made a good case that we shouldn’t put it in the lower bar at the meeting — and keep it in the sidebar instead. So I recommend we follow his lead. [19:38:51] Ugh I didn't hear that [19:38:57] We need to re-estimate it then [19:39:08] Because that makes it like 2 points potentially [19:39:32] Maybe more if I want to do it right [19:42:50] Sorry if you missed that part of the meeting. I also proposed the toolbar, but Pau pointed out the icon is more likely to be noticed in the sidebar, as suggested by the metrics (we log *a lot* more clicks on Close, Next and Previous). On that basis, I think it’s worth spending the extra point, if it can be done today. [19:43:35] http://multimedia-metrics.wmflabs.org/dashboards/mmv#actions-graphs-tab [19:43:36] Ah, that's what he said. [19:43:41] Wait. [19:43:58] fabriceflorin: Isn't it possible people just don't need the toolbar actions as much? [19:44:12] I mean, close/next/previous are pretty basic things [19:44:24] But use, survey, and learn more....aren't [19:45:09] marktraceur: Yes, it is possible. No metrics result is perfect. But I defer to our designer to guide our direction for button placement. And we did discuss it in the meeting, so I would feel bad changing our minds without his participation. [19:45:38] Right [19:45:53] I'm happy to defer to his judgment if his judgment is well-formed [19:46:14] But if it's based on faulty methodology I'd rather not go blindly down the road, especially a road that takes more time than anticipated [19:48:07] His main recommendation was that image-related functions belong in the image, while metadata-related functions belong in the toolbar. I think that is a reasonable point. But we could reconsider if this will prevent us from shipping this feature tomorrow. Can you spend the extra point today? [19:48:29] But ah..."download image" is in the toolbar [19:48:52] I'll talk to him about it when he comes back on [19:49:59] marktraceur: Good, please keep me in the loop. From my standpoint, the most important outcome is that we implement a practical solution today, so we can show results to the community on Thursday about this important feature request. [19:50:42] This channel will be the loop, so keep it here for more smooth jazz^W^W^Wthe design decision [19:51:32] * marktraceur will investigate the crappy situation for the sidebar [19:52:42] Sounds good. How far along are you in the toolbar implementation? How much longer would it take to implement the button in the image? If it’s only a matter of an hour or two, this should not be the primary criteria for deciding which solution to implement. I will email this thread now to Pau, to invite him to join us here. [19:52:54] I'm basically done with the toolbar thing [19:53:20] The sidebar has no framework, so either I implement it crappily or I build the framework as I go [19:53:26] I'd prefer the latter, but...well [19:55:47] 3MediaWiki extensions / 3TimedMediaHandler: Warning: trim() expects parameter 1 to be string, array given in OggHandler.php on line 116 - 10https://bugzilla.wikimedia.org/66448 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None Warning: trim() expects parameter 1 to be string, array given in /usr... [20:00:05] pginer: Ohai [20:00:10] So summary [20:00:15] hi [20:00:22] I misunderstood and started implementing the view-file button in the toolbar [20:00:34] But I hear you suggested using the right sidebar [20:00:53] Which is good and all, but I'd like to hear (again, sorry) why you thought to do that [20:01:28] The action is more of a direct action on the image [20:02:00] 3MediaWiki extensions / 3TimedMediaHandler: mw.MwEmbedSupport.style should only load on the pages that need it - 10https://bugzilla.wikimedia.org/58086#c5 (10Matthew Flaschen) The fix should take care of the clear cases up front (e.g. categories, Special:ListFiles, Special:Upload (the one flagged in the comm... [20:02:02] Well, like a navigation action, I guess [20:02:04] in the same way that you make it fullscreen, you take this image and open it in a different window [20:02:17] yes [20:02:34] Which is similar to the navigation action you take to go to the file page, which is in the toolbar [20:02:52] There's a lot of weirdness, I guess [20:03:01] If we're aiming towards fixing the weirdness, that's fine :) [20:03:46] That was connected to the download process [20:04:48] So we are providing a different model: instead of “previewing what you are going to download”, “take this image out of the chrome” [20:05:12] No, the "Learn more on WM Commons" button is not a download thing [20:05:25] OK [20:05:35] I'm actually going to stop and just go do it in the sidebar [20:05:37] I thought you were talking about the “preview” in the share panel [20:05:39] Thanks for explaining :) [20:06:07] The Commons link is mainly access to more metadata (hence the metadata panel location) [20:06:09] np [20:08:11] Thanks, pginer and marktraceur : glad you resolved that issue together. So is it OK to let the community know this button will be in the image area? Can this be done today? [20:08:28] … and launched on Thursday on enwiki? [20:08:51] Prrrrrobably. [20:08:57] I'll do what I can, it looks optimistic [20:09:12] marktraceur: Cool. Thanks for your flexibility. [20:13:22] (03PS1) 10Gergő Tisza: Toggle metadata panel on up/down keypress [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138674 [20:15:33] fabriceflorin: are you moving tickets into / out of this sprint or should we? [20:15:55] tgr : I am happy to move the tickets we just discussed into this sprint. [20:16:37] cool [20:17:34] And the removals? [20:18:11] just push everything unrelated to next week, I suppose? [20:18:26] we can go into details in the sprint planning meeting [20:18:31] Sure [20:19:32] pginer: could you comment on one of #703/#704 from a design standpoint? [20:27:14] marktraceur: opinions about creating an mmv.Config class to store all settings? I am looking at the anon optout thing and would rather not shoehorn more functionality into mmv.js [20:27:18] marktraceur or tgr : could one of you take care of adding a tooltip for the ‘View original file' button, please? I put in that request in both #546 and #630, so that we don’t lose track of it. [20:27:42] tgr: I added comments to the card [20:27:52] pginer: thanks! [20:28:08] tgr: Sure [20:28:13] No big opinions, just positive [20:29:08] marktraceur tgr : I just updated the current sprint wall with the cards we discussed: http://ur1.ca/gtyrp [20:39:38] (03PS1) 10MarkTraceur: Add "zoom" but really just view-file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138683 [20:41:22] (03CR) 10jenkins-bot: [V: 04-1] Add "zoom" but really just view-file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138683 (owner: 10MarkTraceur) [20:59:01] (03PS2) 10MarkTraceur: Add "zoom" but really just view-file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138683 [21:00:14] OK tgr looks like we're set on that one for now... [21:00:32] marktraceur: Thanks, that was fast! [21:00:59] Yeah it went by a bit faster than I thought [21:01:12] I might decide to go back and Do It Right after deploying it [21:04:26] marktraceur Keegan pau : I propose moving back the Media Viewer release on All Wikis to next week, so we can stay focused on addressing enwiki and dewiki issues. So that would be June 19 instead of June 12. OK with you? [21:04:44] Yup [21:04:56] (sorry James_F, but not) [21:06:14] Keegan: ? [21:07:32] Uhhh [21:07:39] fabriceflorin: I'll be in Seattle, but I'm game [21:08:16] James_F: Keeping MMV in Beta Features one more week [21:08:24] marktraceur: Thanks! Do you think you can handle that task from Seattle as effectively as from SF? [21:08:28] So that's three weeks past deadline, but better safe than sorry :) [21:08:36] Oh, yeah. No problem. [21:09:27] fabriceflorin: Sure, as long as people are on IRC [21:09:42] Keegan: Yeah, it’s not unusual for software projects to slip a few weeks. In my experience, it’s better to have a good community response based on addressing their needs — rather than rushing things to make an arbitrary deadline. [21:09:55] fabriceflorin: I know. [21:10:37] James just asked me about the global deploy last week and I told him it was on for this week, so just making sure he's in the loop that it's changing ;) [21:10:51] marktraceur: Sounds good. We’ll be on IRC. I will add a card into the next sprint planning wall to remind us. And will ping Greg, as well as update the deployment calendar. [21:11:19] greg-g is pinged. [21:11:32] Hey greg-g : We’d like to push back the Media Viewer release on All Wikis to next week, so we can stay focused on addressing enwiki and dewiki issues. So that would be June 19 instead of June 12. marktraceur will be in Seattle, but thinks he can handle it from there. OK with you? [21:12:23] fabriceflorin: marktraceur That's cool with me. They have internet up in Seattle? [21:12:36] greg-g: Hehe … :) [21:12:39] I hear it's mostly MSNET or something [21:12:51] greg-g: Glad it works for you. I will update the deployment calendar now. [21:12:54] greg-g: Most of the internet kitties moved away because of the rain, but the internet otters are still there [21:12:58] fabriceflorin: thanks sir. [21:13:03] MSkyNET [21:13:07] marktraceur: I guess, really, the right joke would have been .NET [21:13:12] greg-g: My pleasure :) [21:13:31] Keegan: :) [21:14:37] sky.NET, MS's new search for extraterrestrial life, gets infected with an intergalactic virus and starts destroying humanity [21:14:43] #sawthatonecoming [21:15:11] * Keegan laugh [21:16:52] https://www.mediawiki.org/w/index.php?title=Talk:Multimedia/About_Media_Viewer&diff=next&oldid=1033155 the comments are getting cleverer, but also include more references to guillotines. Win some, lose some [21:20:01] greg-g: The deployment calendar has been updated. Thanks again! https://wikitech.wikimedia.org/wiki/Deployments [21:20:15] fabriceflorin: thank you, good luck. [21:20:26] fabriceflorin: is it worth a quick note out to -ambassadors? [21:21:20] pginer: any suggestion on how to handle opt-out for anons with old browsers? [21:21:39] I mean we don't do opt-out for them, but how to show that [21:21:45] just hide the link? [21:21:54] greg-g: Good idea. Are you proposing to do it, or should I? [21:22:04] or show an error message width browser upgrade tips? [21:22:15] fabriceflorin: best from you, probably, just needs to be a two liner [21:22:35] greg-g: OK, wanted to make sure that we didn’t both do it :) [21:22:53] yeah :) [21:25:16] (03CR) 10MarkTraceur: [C: 04-1] "Minor ux issue" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138674 (owner: 10Gergő Tisza) [21:25:26] pginer: ^ thoughts welcome [21:25:41] I mean, what else is new [21:25:46] But especially this time :) [21:27:04] marktraceur: this is the same as the old behavior, except when the user presses the wrong key which should not do anything, it still works [21:27:37] * marktraceur sighs [21:27:40] if the panel is too big to fit into the screen, and you are trynig to navigate using the arrow keys exclusively, you are screwed, no change there [21:27:53] I don't think that is a shortcoming of the patch [21:28:15] No, just a shortcoming of how we handle the arrow key presses, so I guess this is sort of an improvement [21:28:19] * marktraceur sighs more, merges [21:28:31] After testing etc. [21:29:54] tgr: We're still using debouncing on the toggler? [21:30:12] did we ever? [21:30:27] I think if you do a lot of keypresses, it just queues up [21:30:33] Ah [21:30:41] Well, it's acting funny, but not too funny [21:30:43] * marktraceur merges [21:30:51] (03CR) 10MarkTraceur: [C: 032] "I retract my comment" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138674 (owner: 10Gergő Tisza) [21:31:05] I thought about clearing the queue, but on the low level it is an animation on the body tag, an there might be other animations queued from other components [21:31:23] (03Merged) 10jenkins-bot: Toggle metadata panel on up/down keypress [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138674 (owner: 10Gergő Tisza) [21:36:55] marktraceur: the zoom icon will be replaced eventually, right? [21:37:30] I guess pginer said he would do so [21:37:51] yeah, I just wasn't sure if this is the new one already [21:38:01] Not afaik [21:38:08] I just looked for something zoom-y [21:38:09] I’m completing the new one, just got a 1h meeting in the middle [21:38:18] I think pginer said to use the old one, and he will make a different one for ‘Expand image’ on Commons. [21:38:19] pginer: no rush [21:38:40] do you think we should hide the icon in fullscreen mode? [21:39:52] If possible, yes [21:41:26] (03CR) 10Gergő Tisza: [C: 04-1] "Looks good but it would be better if the icon would be hidden in fullscreen mode." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138683 (owner: 10MarkTraceur) [21:58:35] Gosh, so demanding. :) [22:03:18] (03PS3) 10MarkTraceur: Add "zoom" but really just view-file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138683 [22:04:08] (03PS4) 10Pginer: Add "zoom" but really just view-file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138683 (owner: 10MarkTraceur) [22:04:21] I amended the patchset to include the new icons [22:04:34] mw-open-control-rtl.svg [22:04:40] mw-open-control-ltr.svg [22:07:09] K [22:07:18] (03PS5) 10MarkTraceur: Add "zoom" but really just view-file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138683 [22:07:23] That should be good [22:16:20] (03CR) 10MarkTraceur: Use link title as fallback for caption (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [22:18:24] (03CR) 10MarkTraceur: [C: 032] Show Commons link to logged out users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138305 (owner: 10Gergő Tisza) [22:19:14] fabriceflorin: What's our next priority? I'm eyeing things to do. [22:19:19] (03Merged) 10jenkins-bot: Show Commons link to logged out users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138305 (owner: 10Gergő Tisza) [22:22:24] marktraceur: How about #703 Instant Opt-in? And/or #704 Opt-out for anons ? Coordinate with tgr ? https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/703 https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/704 [22:23:32] I thought tgr was looking into the opt-out stuff [22:25:06] https://en.wikipedia.org/wiki/SVG_animation#Attributes_to_identify_the_target_attribute it makes me sad that we have to put a note there [22:25:12] (under the images) [22:28:39] Hmm, mediawiki is supposed to output a note on the file description page too [22:29:55] Wait, *mediawiki* does that? [22:30:53] Its supposed to but it doesn't look like its working [22:30:57] Hrm [22:31:04] canAnimateThumb() in the image handler [22:31:08] the idea of using a thumbnail to create a browser feature demo is inherently broken, I would say [22:31:31] But there's not a way around it, is there? [22:31:41] a thumbnail is meant to show the thing, not be the thing [22:31:57] if you want to show how an SVG animation looks, make a video [22:32:30] although it will be pretty boring since it looks just like any other kind of animation [22:32:37] marktraceur: Well if browsers actually had support we could be it in an iframe (for anti-xss goodness) and let the browsers deal with it [22:32:43] if you want to make a browser demo, you can do that as an external link [22:33:05] tgr: Internal even... [[media:Soccer ball whatever.svg]] [22:33:52] well, probably you want to add explanatory labels and browser capability testing and what not [22:34:05] Also, did someone break special:Upload recently... uploading a file named c.jpg. Warning a file named "File:Merry Christmas n Happy New Year.jpg" already exists :s [22:34:32] bawolff: isn't that just a sha1 conflict? [22:34:56] The warning is saying name, not duplicate [22:35:28] Also this is a demo file of an open document file pretending to be a jpeg which should definitely be rejected [22:35:34] so hopefully it doesn't already exist [22:36:18] wow [22:38:41] Guh-roaty [22:38:45] * marktraceur looks... [22:39:02] oh, there's a file redirect c.jpg -> File:Merry Christmas n Happy New Year.jpg [22:39:28] So its just a confusing error message :) [22:39:29] Hah [22:40:07] tgr: But back to opt-out stuff, are you working on it? [22:40:13] sure [22:40:51] OK so fabriceflorin I'm going to need the next thing on the priority list [22:41:04] I guess 664? [22:42:02] Yes, please. If we haven [22:42:20] If we haven’t done #664 yet, let’s do it (Prominent 'View in browser' links in Download panel ) [22:42:25] Cool [22:42:57] fabriceflorin: No need to copy the details into IRC, I have it right here :) [22:43:53] marktraceur: Got it. It’s for my own sanity, want to confirm I’m not misleading you :) [22:44:29] marktraceur tgr : who’s working on #698 Image is misshaped in IE10 ? [22:44:49] Not I said the marktraceur [22:44:54] I dropped that one for now [22:45:43] I could figure out the problem (I think), it's in the bugzilla comments, but I have no clue how to fix [22:46:24] wow, that's embarrasing [22:46:50] I added a method named canAnimateThumb to SVG class, when the method its supposed to override is canAnimateThumbnail [22:57:27] Whoa, am I using the same logo for 664 [22:57:32] Crazypants [22:57:46] Oh, no.