[00:04:00] tgr: Cool. Glad to hear that #706 sounds like 2 points to you. marktraceur : do you agree? [00:04:15] Yeah [00:21:26] 3MediaWiki extensions / 3GWToolset: Complex categories make GWToolset fail on step 3 (batch preview) - 10https://bugzilla.wikimedia.org/65620#c11 (10dan) the issue for the preview page is definitely that complex category and the way i set-up the placement of the categories onto the preview page using $Output... [00:41:13] (03PS2) 10Gergő Tisza: [WIP] Fix URL handling for global usage list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138999 [00:41:15] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Fix URL handling for global usage list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138999 (owner: 10Gergő Tisza) [01:21:25] (03PS1) 10Gergő Tisza: Change flowId data type for funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139057 [01:22:18] marktraceur: ^^ if you still have time to review stuff today, this one would be nice to get out (it's a trivial change) [01:24:43] (03Abandoned) 10Gergő Tisza: Replace progressbar with positionless one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127809 (owner: 10Gergő Tisza) [01:26:12] (03PS3) 10Gergő Tisza: Revert "Use localized namespace name in embed wikitext" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131509 (https://bugzilla.wikimedia.org/64710) [01:28:38] (03Abandoned) 10Gergő Tisza: Add Attribution field to CommonsMetadata output [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96493 (https://bugzilla.wikimedia.org/57197) (owner: 10Gergő Tisza) [04:22:39] (03CR) 10Brian Wolff: "For reference, that is bug 66359" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137529 (https://bugzilla.wikimedia.org/66143) (owner: 10Brian Wolff) [04:24:13] (03CR) 10Mdale: "Is it working well for you now Brian Wolff? Will merge assuming the testing went well, so that we can get embeds working again." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137529 (https://bugzilla.wikimedia.org/66143) (owner: 10Brian Wolff) [05:16:56] 3MediaWiki extensions / 3MultimediaViewer: Overlay scroll height/scrollbar is too high in other skins as Vector - 10https://bugzilla.wikimedia.org/66326 (10Florian) 5PATC>3RESO/FIX [08:29:10] (03CR) 10Gergő Tisza: [C: 032] "Self-merge. Patch is trivial, and I don't want to lose another week of data." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139057 (owner: 10Gergő Tisza) [08:29:34] (03Merged) 10jenkins-bot: Change flowId data type for funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139057 (owner: 10Gergő Tisza) [08:50:35] 3MediaWiki / 3Uploading: Upload broken after upgrade to 1.23 - 10https://bugzilla.wikimedia.org/66467 (10Jesús Martínez Novo (Ciencia Al Poder)) [10:44:26] 3MediaWiki extensions / 3UploadWizard: Error handling: api-error-unknownerror - 10https://bugzilla.wikimedia.org/66366#c8 (10Derk-Jan Hartman) @nicolas, what kind of browser and version of the browser do you have ? [12:13:28] 3MediaWiki extensions / 3UploadWizard: Error handling: api-error-unknownerror - 10https://bugzilla.wikimedia.org/66366#c9 (10Nicolas Raoul) Created attachment 15638 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15638&action=edit no name checking [12:14:41] 3MediaWiki extensions / 3UploadWizard: Error handling: api-error-unknownerror - 10https://bugzilla.wikimedia.org/66366#c10 (10Nicolas Raoul) Default Firefox 29.0 on fully-updated Ubuntu 2014.04 As seen on screenshot above, no character trigger any warning. [14:11:29] 3MediaWiki / 3Uploading: Uploaded file or images are not available in wiki pages until the page is modified with a fake SAVE. - 10https://bugzilla.wikimedia.org/66527 (10Gian Domenico Bomazzoli) 3UNCO p:3Unprio s:3normal a:3None Version 1.23.0 of Mediawiki shows the following bug. If I edit a wiki p... [14:54:43] 3MediaWiki / 3Uploading: upload by url of something that's not a url doesn't give error - 10https://bugzilla.wikimedia.org/32361 (10Rohan Rawat) a:3Rohan Rawat [15:02:27] well duhhh :\ [15:26:42] 3MediaWiki / 3Uploading: Uploaded file or images are not available in wiki pages until the page is modified with a fake SAVE. - 10https://bugzilla.wikimedia.org/66527#c1 (10Andre Klapper) > But mediawiki will still continue to show the link in red How to reproduce? Reloading the page in the browser? Did you... [15:40:27] 3MediaWiki / 3Uploading: Uploaded file or images are not available in wiki pages until the page is modified with a fake SAVE. - 10https://bugzilla.wikimedia.org/66527#c2 (10Gian Domenico Bomazzoli) No the only way to have the "blue" link (and working) is to make a fake edit on the wiki page and SAVE it. All... [16:22:43] (03CR) 10MarkTraceur: [C: 032] Change "learn more" to "learn more about this file" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138303 (owner: 10Gergő Tisza) [16:22:46] (03CR) 10jenkins-bot: [V: 04-1] Change "learn more" to "learn more about this file" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138303 (owner: 10Gergő Tisza) [17:16:57] 3MediaWiki / 3Uploading: Uploaded file or images are not available in wiki pages until the page is modified with a fake SAVE. - 10https://bugzilla.wikimedia.org/66527#c3 (10Bawolff (Brian Wolff)) Hmm. Not sure if we record backlinks for media ns. I know this issue was fixed with [[file:foo]] and [[:file:foo]... [17:17:42] 3MediaWiki / 3Uploading: media namespace backlinks not purged on file upload - 10https://bugzilla.wikimedia.org/66527 (10Bawolff (Brian Wolff)) [17:39:47] (03PS3) 10Gergő Tisza: Fix URL handling for global usage list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138999 (https://bugzilla.wikimedia.org/63908) [17:40:22] (03CR) 10jenkins-bot: [V: 04-1] Fix URL handling for global usage list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138999 (https://bugzilla.wikimedia.org/63908) (owner: 10Gergő Tisza) [17:42:55] (03PS4) 10Gergő Tisza: Fix URL handling for global usage list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138999 (https://bugzilla.wikimedia.org/63908) [17:52:37] marktraceur, tgr, fabriceflorin https://commons.wikimedia.org/w/index.php?title=Commons:Village_pump/Copyright&oldid=prev&diff=126407073 [17:52:43] Second paragraph of the diff [17:53:01] (03PS5) 10Gergő Tisza: Change "learn more" to "learn more about this file" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138303 [17:53:20] A bot could do that pretty easily [17:53:41] for file in files_with_information_template: [17:53:53] Keegan: Thanks for the update. Will ping Luis about this issue, see if he has comments. [17:54:14] This can also inform our structured data project. [17:54:44] Keegan: I don't see any tech problems with the new field [17:56:11] fabriceflorin: no no, don't ping Luis [17:56:11] I'm taking care of that side [17:56:12] eventually we hope to have a "title" Wikidata property on Commons [17:56:16] This was just about what mark is addressing [17:57:03] Keegan: OK, I’ll hold off. Can you keep us in the loop, so we’re all on the same page? [17:57:16] Yup yup :) sorry if I wasn't clear enough :) [17:58:48] (03PS1) 10MarkTraceur: Make preview link more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139157 [17:59:01] Oops missed one [17:59:02] Seeeec [17:59:18] fabriceflorin: The new text for the "Preview" link is "View in browser" right? [17:59:38] marktraceur: Yes, please. [17:59:48] marktraceur, tgr: Cool. I'll tell Jee it's no big deal if he can find a bot to do it, go for it if he wants, structured data is good data. Ja? [17:59:55] Just making sure the acceptance criteria are OK [18:00:10] Da, Keegan [18:00:42] Keegan: chopping the extension off is a pretty trivial Lua task, if the goal is to fall back to a (nicely formatted) version of the filename if the title is not specified [18:00:56] Could probably do it in Wikitext [18:01:11] ugh [18:01:13] What am I saying!? Do it in Lua please god [18:01:22] have you looked into the string manipulation templates? [18:01:45] No, and hope I never have to [18:08:05] (03PS2) 10MarkTraceur: Make preview link more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139157 [18:08:07] Yay there we go [18:10:33] (03PS2) 10Gergő Tisza: Updated chevron icons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139020 (owner: 10Pginer) [18:28:05] tgr: https://gerrit.wikimedia.org/r/136508 should I merge? [18:28:44] something was missing from that [18:28:51] A tooltip? [18:28:59] Oh, the view button [18:29:00] tooltip for the foriginal file button, maybe? [18:29:05] (03PS5) 10MarkTraceur: Tooltips for loads of things [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/136508 [18:29:12] Yeah [18:29:14] Adding [18:29:56] also, still feels a bit annoying with the half sec delay, maybe we should add more? [18:30:13] I'll try it [19:09:41] 3MediaWiki / 3File management: Allowthumbnail size of an image to be defined as proportion of the user's default - 10https://bugzilla.wikimedia.org/7003#c20 (10Nemo) (In reply to Brion Vibber from comment #17) > I really don't like 'upright' or 'upright-factor' at all, and would > recommend taking them right... [19:17:41] 3MediaWiki / 3Uploading: Not accepting uploads if uploader didn't specify license - 10https://bugzilla.wikimedia.org/10716#c4 (10Nemo) Related: https://gerrit.wikimedia.org/r/#/c/134509/2 (I465daaff4aed4b484a1f4707fe57d45c0e9ce6cd) [19:20:43] 3MediaWiki / 3Uploading: Allow to add categories from a dropdown in Special:Upload - 10https://bugzilla.wikimedia.org/5234 (10Nemo) [19:20:43] 3MediaWiki / 3Uploading: Simplify the UI of the upload form - 10https://bugzilla.wikimedia.org/16181#c4 (10Nemo) Does bug 5234 (Allow to add categories from a dropdown in Special:Upload) fit into this? [19:27:30] (03PS6) 10MarkTraceur: Tooltips for loads of things [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/136508 [19:28:28] 3MediaWiki / 3Uploading: Allow to make a license in MediaWiki:Licenses the default, remove "None selected" - 10https://bugzilla.wikimedia.org/66550 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None Some wikis want all their uploads to use some template from the beginning. http://lists.wikimedia.org/pipermail... [19:50:00] tgr: The tooltips patch needs your review, it looks fine to me though [19:50:12] I added new ones and doubled the delay [19:51:27] 3MediaWiki / 3File management: Allowthumbnail size of an image to be defined as proportion of the user's default - 10https://bugzilla.wikimedia.org/7003#c21 (10Spinningspark) (In reply to Brion Vibber from comment #17) > I really don't like 'upright' or 'upright-factor' at all, and would > recommend taking t... [19:52:36] tgr: Also, did you do the data collection card? I can mark it accepted if so [20:02:41] marktraceur: I am running the queries by hand for now so the card is a good reminder [20:04:01] Ah kay [20:39:37] pg [20:57:17] fabriceflorin: Are the attribution lines for card 598 the same as the ones in the embed tab? [20:57:34] Because if so we can probably delete all of the complicated spec nonsense and just say "it's the same as the embed tab" [20:58:26] marktraceur: They are similar, but there are a few differences. Let me check them both and get back to you, to determine if they are really needed. Give me a sec. [20:58:34] 'kay [20:58:42] I can't imagine why they would be different [20:58:49] Since you're attributing for the same thing [20:59:13] Oh, wait, we tore out the attribution [20:59:14] Right [20:59:20] So I need to re-write it :( [21:00:01] The first difference I see is that we propose to have a plain text version in Download, which may not exist in Embed. [21:00:07] *nod* [21:01:22] The HTML should be the same. [21:01:27] Uh wait [21:01:39] fabriceflorin: The HTML right...oh, no, you're right, I was testing with the wrong thing [21:02:42] marktraceur: Sorry, I spoke too soon. The HTML would be different, because you would not be embedding the image, only adding a stand-alone credit. But the rest would be the same. [21:02:50] Right [21:03:05] Want me to see if I can simplify the plain text version for you? [21:03:14] Naw [21:03:33] I think the plain text is the least of my worries [21:04:07] OK, if it gets too hairy, we could probably get away with just one link to the file page in the plain text version, after the full text credit. [21:04:16] Sure [21:04:23] The issue is going to be the HTML [21:04:35] Because I need to create some ridiculous amounts of conditional messages [21:04:47] I did this before when we started the embed stuff, it was hellish [21:05:05] marktraceur: Couldn’t you use the same conditionals as before? All we would need to do is remove the embed code, IMHO. [21:05:18] I mean, I guess [21:05:26] * marktraceur investigates [21:06:46] Seems to me the tag is the main thing that needs to be removed from the embed code. [21:09:10] Oh, we already *have* a separate class for it [21:09:11] Kinda [21:10:17] marktraceur: Super. I also just cut down the plain text attribution to half the size, including only one link to the file description page, where they can find the license info. [21:10:24] OK [21:10:35] That is kinda nicer [21:11:03] our fullscreen sizing is broken [21:11:24] apparently has been since a while since it is broken on the wikipedias as well [21:11:33] marktraceur: Yeah, I think I went overboard in the first draft of the spec. After all the recent exchanges with Luis, it appears we can honor our obligations with a shorter credit. [21:11:52] need moar tests [21:11:58] tgr: Can you elaborate? [21:12:04] Ugh [21:12:26] the image has the same size as in normal mode, I think [21:13:07] It gets bigger, just not all the way maybe [21:13:53] I think it only gets bigger because the metadata panel gets smaller [21:14:12] but it is still sized to fit into (screen height - panel height) [21:14:26] Ah. [21:39:03] fabriceflorin: Should I use the text in the mockups? [21:39:13] For the buttons and labels [21:40:04] marktraceur: You mean ‘You need to attribute the author’? [21:40:07] Yeah [21:40:19] Yes, that one is good, and Luis likes it too. [21:40:51] But I would like to propose a different wording for ‘View how to attribute’ below it. [21:41:03] Which wording? [21:41:22] (things that should be sorted before setting something in "ready for development") [21:41:31] Stand by, I’m thinking. The current wording is not proper english. [21:41:39] 'kay [21:41:52] I mean, it's...valid English [21:41:56] Just sort of awkward [21:42:09] Yeah, it’s kinda weird though. [21:43:25] I’m thinking of something more explicit. Like ‘Copy the credits.’ [21:43:38] That's not what the action does... [21:43:41] "Show me how"? [21:43:59] Yes, that’s much better, thank you. [21:44:01] Sweet [21:44:37] Sort of schizophrenic, with one in the first person and the other in the second, but whatev [21:52:01] (03PS1) 10Gergő Tisza: [WIP] Make the metadata panel opening affordance more obvious [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139267 [21:52:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make the metadata panel opening affordance more obvious [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139267 (owner: 10Gergő Tisza) [22:00:37] (03CR) 10Gergő Tisza: [C: 032] Tooltips for loads of things [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/136508 (owner: 10MarkTraceur) [22:01:11] (03Merged) 10jenkins-bot: Tooltips for loads of things [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/136508 (owner: 10MarkTraceur) [22:29:05] HAIL_ANTS: Wat [22:29:11] Hmm? [22:29:24] Quite the nick change there :) [22:31:01] https://www.youtube.com/watch?v=cPcB3vWGO9k [22:31:14] I, for one, welcome our new ant overlords [22:32:30] HAIL_ANTS: Fair 'nuff [23:04:43] marktraceur: do you remember why we set max-width/max-height on the image? [23:07:56] Uhhh [23:08:15] tgr: It may have been an attempt at doing something else that wound up getting fixed elsewhere [23:08:21] Not sure though [23:08:23] That was early on. [23:09:50] well, it does break if I remove it, I just can't make sense of the way it does [23:10:08] we always set the exact size so it shouldn't matter [23:10:28] maybe we set it wrong in some cases and the max-width fixes that somehow? [23:12:07] Huh. [23:12:13] Maybe [23:47:26] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer fails with “Impossible to load thumbnail data, could not load image from etc.” - 10https://bugzilla.wikimedia.org/64554#c2 (10T. Gries) p:5Unprio>3High Example for output in case of failure. I recent... [23:48:41] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer fails with “Impossible to load thumbnail data, could not load image from etc.” - 10https://bugzilla.wikimedia.org/64554#c3 (10T. Gries) This bug is very annoying, pls. can you fix this with a high priority ? [23:49:27] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer fails with “Impossible to load thumbnail data, could not load image from etc.” - 10https://bugzilla.wikimedia.org/64554#c4 (10Mark Holmquist) This happens when thumbnails aren't ready...I think the reason it doesn't break in production is that thum... [23:49:56] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer fails with “Impossible to load thumbnail data, could not load image from etc.” - 10https://bugzilla.wikimedia.org/64554 (10T. Gries) [23:50:26] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer fails with “Impossible to load thumbnail data, could not load image from etc.” - 10https://bugzilla.wikimedia.org/64554#c5 (10Mark Holmquist) https://www.mediawiki.org/wiki/Manual:Thumb.php#404_Handler [23:50:56] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer fails with “Impossible to load thumbnail data, could not load image from etc.” - 10https://bugzilla.wikimedia.org/64554#c6 (10T. Gries) (In reply to Mark Holmquist from comment #4) > This happens when thumbnails aren't ready...I think the reason it... [23:51:11] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer fails with “Impossible to load thumbnail data, could not load image from etc.” - 10https://bugzilla.wikimedia.org/64554#c7 (10T. Gries) "mid-air collision". thx [23:51:56] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer fails with “Impossible to load thumbnail data, could not load image from etc.” - 10https://bugzilla.wikimedia.org/64554#c8 (10T. Gries) Should be documented in E:MultimediaViewer Installation (wiki and repo) [23:52:58] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer fails with “Impossible to load thumbnail data, could not load image from etc.” - 10https://bugzilla.wikimedia.org/64554#c9 (10T. Gries) @Mark: I will try to test this as soon as possible and report my results (later) here. [23:57:15] 3MediaWiki extensions / 3MultimediaViewer: [Javascript bug]: Some image descriptions show "[object Object]" - 10https://bugzilla.wikimedia.org/66564 (10T. Gries) 3NEW p:3Unprio s:3normal a:3None see screenshot and DOM/Firebug: [23:57:26] 3MediaWiki extensions / 3MultimediaViewer: [Javascript bug]: Some image descriptions show "[object Object]" - 10https://bugzilla.wikimedia.org/66564 (10T. Gries) p:5Unprio>3Normal [23:59:23] (03PS1) 10MarkTraceur: WIP add button for attribution of downloads [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139295 [23:59:25] (03CR) 10jenkins-bot: [V: 04-1] WIP add button for attribution of downloads [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139295 (owner: 10MarkTraceur) [23:59:27] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer fails with “Impossible to load thumbnail data, could not load image from etc.” - 10https://bugzilla.wikimedia.org/64554#c10 (10Tisza Gergő) The image should be generated by the imageinfo API request AFAIK. Might try to set $wgMediaViewerUseThumbnai... [23:59:57] (03PS2) 10Gergő Tisza: [WIP] Make the metadata panel opening affordance more obvious [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139267