[00:55:41] (03PS1) 10Gergő Tisza: Add functionality to TruncatedTextField to toggle full text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143541 [01:04:08] (03CR) 10Gergő Tisza: [C: 032] Styling adjustments for download panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143349 (owner: 10Pginer) [01:04:44] (03Merged) 10jenkins-bot: Styling adjustments for download panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143349 (owner: 10Pginer) [01:04:53] 3MediaWiki / 3File management: Have SvgHandler create a directory for its RSVG input files - 10https://bugzilla.wikimedia.org/67402 (10Tim Starling) 3NEW p:3Unprio s:3normal a:3None RSVG has recently changed its external entity expansion policy, from allowing access to all local files to only allowin... [01:05:39] 3MediaWiki / 3File management: Have SvgHandler create a directory for its RSVG input files - 10https://bugzilla.wikimedia.org/67402 (10Tim Starling) a:3Aaron Schulz [01:10:37] (03PS2) 10Gergő Tisza: Make download panel dropdown button unselectable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143225 [01:10:39] (03PS2) 10Gergő Tisza: Use same text formatting for downloads as for other panels [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143224 [01:10:41] (03PS2) 10Gergő Tisza: Remove the gap the between the download button and the dropdown menu [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143226 [01:10:43] (03PS2) 10Gergő Tisza: Convert non-standard class-names (mw-mlb, multiediaviewer-) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143223 [01:11:03] (03PS3) 10Gergő Tisza: Remove trainling dot from download attibution text to not break URLs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143231 [01:18:24] 3MediaWiki extensions / 3TimedMediaHandler: "vid is undefined" or "Cannot read property 'readyState' of undefined" after playing an audio file - 10https://bugzilla.wikimedia.org/67403 (10Kevin Israel (PleaseStand)) 3NEW p:3Unprio s:3normal a:3None To reproduce, in either Firefox 30 or Chromium 34: 1... [01:51:47] (03PS2) 10Gergő Tisza: Add functionality to TruncatedTextField to toggle full text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143541 [02:44:52] 3MediaWiki / 3Uploading: Unable to upload OGV, Wikipedia thinks it is OGX - 10https://bugzilla.wikimedia.org/67335#c3 (10Bawolff (Brian Wolff)) Can you include a link to the file then? [06:23:53] (03CR) 10Rillke: "Is it only me or are there other people who think `validateWikiText` should be done server-side, e.g. extending the API with a dedicated m" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (https://bugzilla.wikimedia.org/40920) (owner: 10Nischayn22) [06:25:23] tgr, do you know whether someone is working on https://gerrit.wikimedia.org/r/50755/ [06:25:40] or whether it is resolved differently? [08:41:51] 3MediaWiki / 3File management: Have SvgHandler create a directory for its RSVG input files - 10https://bugzilla.wikimedia.org/67402 (10Andre Klapper) p:5Unprio>3Normal [09:02:21] 3MediaWiki extensions / 3TimedMediaHandler: "vid is undefined" or "Cannot read property 'readyState' of undefined" after playing an audio file - 10https://bugzilla.wikimedia.org/67403 (10Andre Klapper) p:5Unprio>3Normal [12:07:44] gi11es: Do you know where we landed on 396? [12:37:40] (03CR) 10Gilles: [C: 04-1] "Looks good, only thing that doesn't match the mockup is the fact that the divider lines at the bottom right are supposed to go much higher" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142725 (owner: 10Gergő Tisza) [12:37:50] (03CR) 10MarkTraceur: [C: 032] "Style changes can be made later if pginer doesn't like it in the wild." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141903 (owner: 10Pginer) [12:38:29] Hah, you're reviewing the same thing I am. [12:38:33] (03Merged) 10jenkins-bot: Angle separator image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141903 (owner: 10Pginer) [12:38:46] * marktraceur feels again that he should delete "in estimation" and create "in code review" [12:40:48] (03CR) 10Gilles: "> Style changes can be made later if pginer doesn't like it in the wild." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141903 (owner: 10Pginer) [12:41:45] (03CR) 10MarkTraceur: "This is a null change until 142725 goes in, anyway." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141903 (owner: 10Pginer) [12:45:57] (03CR) 10MarkTraceur: [C: 04-1] "Agreed about the dividers, but otherwise looks good." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142725 (owner: 10Gergő Tisza) [12:46:21] * marktraceur reviews 712 [12:47:24] (03CR) 10Gilles: [C: 032] RTL positioning tweaks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142761 (owner: 10Gergő Tisza) [12:47:58] (03Merged) 10jenkins-bot: RTL positioning tweaks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142761 (owner: 10Gergő Tisza) [12:49:05] marktraceur: between gergo's changesets the OOF ones and meetings I won't have time to implement any ticket today [12:50:50] Ah, K [12:51:03] I can at least do CR for tgr [12:51:19] Pretty sure 396 just isn't going to happen today. [12:51:29] no, especially since it needs CR as well [12:51:31] We can talk about it at the meeting [12:52:00] (03CR) 10MarkTraceur: [C: 032] "Thanks tgr" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142180 (owner: 10Gergő Tisza) [12:52:34] (03Merged) 10jenkins-bot: Show help tooltip for "view original file" button on image click [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142180 (owner: 10Gergő Tisza) [12:53:14] (03CR) 10MarkTraceur: [C: 032] Remove trainling dot from download attibution text to not break URLs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143231 (owner: 10Gergő Tisza) [12:55:43] (03CR) 10MarkTraceur: [C: 04-1] "I'm seeing some pretty nasty styling errors after this patch..." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143223 (owner: 10Gergő Tisza) [12:57:07] (03CR) 10MarkTraceur: [C: 032] Use same text formatting for downloads as for other panels [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143224 (owner: 10Gergő Tisza) [12:58:25] I think neilk said he would look at the UW refactor patch FWIW [12:58:28] (03CR) 10Gilles: [C: 04-1] Move button setup from lightboxinterface to canvasButton (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143099 (owner: 10Gergő Tisza) [12:59:30] I'm going to substitute my morning run with a morning swim today, becaue it's hot as hell in Memphis. [12:59:36] BRB [13:01:15] (03CR) 10Gilles: [C: 032] Remove the gap the between the download button and the dropdown menu [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143226 (owner: 10Gergő Tisza) [13:06:48] (03CR) 10Gilles: [C: 032] Make download panel dropdown button unselectable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143225 (owner: 10Gergő Tisza) [13:09:23] (03CR) 10Gilles: "Mark: screenshot? I'm not seeing anything unusual in Firefox." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143223 (owner: 10Gergő Tisza) [13:10:02] ah, looks like gergo started on 396 [13:26:31] (03PS3) 10Gilles: Add functionality to TruncatedTextField to toggle full text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143541 (owner: 10Gergő Tisza) [13:28:40] (03CR) 10Gilles: [C: 032] Add functionality to TruncatedTextField to toggle full text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143541 (owner: 10Gergő Tisza) [13:29:15] (03Merged) 10jenkins-bot: Add functionality to TruncatedTextField to toggle full text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143541 (owner: 10Gergő Tisza) [13:42:52] gi11es: http://marktraceur.info/shared/images/mmv-143223-bug.png [13:47:47] marktraceur: funky, chrome? [13:47:57] No, FF on Linux Mint [13:48:04] FF28 [13:52:35] I'm on 30 [13:53:43] Hm, maybe something new fixed the issue [13:53:47] * marktraceur looks at patch again [14:02:00] (03CR) 10Gilles: "Romaine, since you know UploadWizard campaigns well, would you be kind enough to check if those messages are indeed not part of the UI any" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/141871 (owner: 10Reedy) [14:03:17] (03CR) 10Gilles: [C: 032] Support Creative Commons cc-by-(sa-)4.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/138183 (owner: 10Raimond Spekking) [14:03:43] (03CR) 10jenkins-bot: [V: 04-1] Support Creative Commons cc-by-(sa-)4.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/138183 (owner: 10Raimond Spekking) [14:07:01] (03CR) 10Gilles: [C: 04-1] Create title in file NS and validate as such (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [14:17:04] * marktraceur doesn't see anything too fancy in the patch.... [18:00:13] marktraceur: is 3Flr - Collab - StandUp the desk before Browne? [18:01:05] Uhhh [18:01:13] tgr: I think it's the TV near Eloquence's desk [18:02:51] tgr: since you're the only one connecting from hq, anywhere quiet works, really [18:03:00] it was the only room marked as available for that timeslot [18:03:19] FYI http://fab.wmflabs.org/project/view/51/ exists [18:03:23] I'm more worried about other people wanting quiet [18:29:24] 3MediaWiki extensions / 3UploadWizard: Improve Error handling: api-error-unknownerror - 10https://bugzilla.wikimedia.org/66366#c23 (10Pine) Note: bug 67197 appears to be similar or a duplicate of this bug [19:03:36] marktraceur: we could track this in phabricator instead of mingle [19:03:41] I know [19:03:43] I'm doing that [19:04:21] is everyone from the call here ? [19:04:21] that was annoying, couldn't finish it properly [19:04:39] Yeah [19:04:43] neilk_: tgr and gi11es and myself. [19:04:49] tgr: http://fab.wmflabs.org/T433 [19:04:57] we could do irc meetings if that works better [19:05:05] marktraceur: cool, thx [19:07:16] i think video helps from time to time. Emotional context & reminds you that your colleagues are people too :) [19:07:35] neilk_: re validation, in my experience using jquery.validate with lots of AJAX callbacks and promises and other async stuff is a total nightmare [19:07:53] ok so my goal for this week (starting late) is just to fix a trivial bug, b/c you guys have changed almost everything about workflow since 2012 [19:07:53] and next, I have a thing I'm writing about what drove design decisions (such as they were) with UW. For instance, the whole reason why it's "batched" is to support IE6 [19:08:58] btw we didn't talk about the flash issue [19:09:00] "you guys" [19:09:05] tgr: Which flash issue [19:09:14] or is that a non-issue if we don't support IE6? [19:09:33] marktraceur: whether it is acceptable to use Flash as fallback for other browsers [19:09:45] ...older browsers [19:09:46] tgr: I can help with that, it isn't [19:09:57] Why would that be on the table? [19:10:08] why would it not be on the table? [19:10:16] I mean, I don't know what we'd even use it for [19:10:36] well that and the fact that the initial designer tended to work that way with Commons [19:10:37] so, not that expect anyone to read with rapt attention, but just to remind us of existing constraints [19:10:37] he's referring to a discussion we had. One of the reasons why there is UploadWizard at all is that the foundation forbade us from using Flash [19:10:37] for handling the uploads themselves [19:10:52] there were lots of well developed uploading libraries, but they used Flash as a fallback on old browsers like IE6 to provide things like progress bars. [19:11:31] so a lot of UploadWizard's progress indicator is a tortuous design b/c that uploads in IE6 may simply report "done/not done" and in Chrome may report "54% done" [19:11:49] the solution for old browsers, if you want "54% done", is to use Flash [19:11:51] yes, and one of the goals we hope to achieve now is to offload maintenance burden by replacing the transport code with a well-maintained 3rd party upload library [19:12:31] so if we do need IE6 support, we should revisit that decision [19:12:58] if we just send IE6 to Special:Upload and be done with it, then we probably don't need it [19:14:34] re: backbone, PageTriage uses it [19:14:45] not advocating for it or anything, just noting [19:14:46] i think this just shows that knowing what support level we're supposed to provide for browsers is a crucial thing to find out [19:14:59] indeed [19:15:59] doesn't the WMF have a standard for this now? [19:16:47] not really [19:17:24] tgr: by "not really", you are referring to a standard for browser support? [19:18:03] yes, there is a pledge that coming up with it should be a top-level goal, I think [19:18:10] let me find the thread [19:20:20] there is a thread called "Breaking Down Silos, #1: Front-End Code and UX" in the engineering list, I don't know if you are on it [19:20:37] There is a page on mediawiki.org about this but it is marked obsolete https://www.mediawiki.org/wiki/Compatibility/Software_for_using_MediaWiki#Desktop_browsers [19:21:18] tgr: I haven't subscribed to any lists except for multimedia. Frankly as a contractor I'm probably not going to get that deeply involved, this time around. [19:21:35] fair enough :) [19:22:55] so there is a big push from both the top and the bottom of the organization to improve frontend matters, and coming up with browser support guidelines is on goal of that [19:23:42] so it should happen soonish but not soon enough for us, you are right about that [19:23:54] bbs [19:24:19] we might just make up our own policy and see if anyone stops us [19:24:33] ^^ tgr [19:51:40] * marktraceur points someone at https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/623 [20:05:59] marktraceur: gi11es said he wants to review it IIRC [20:06:28] not sure howto properly test it, we would have to send requests from several different IPs [20:07:16] I'll make a card to schedule a GWT test once it is deployed [20:07:48] Fae is on his toes anyway [20:24:16] WTF, who set the current sprint view to a hardcoded value [20:24:40] *grumble* [20:30:22] 3MediaWiki / 3File management: Missing skins/common/images/icons/fileicon.png causes fatal PHP error when viewing file pages for files that can't be thumbnailed - 10https://bugzilla.wikimedia.org/67422 (10Bartosz Dziewoński) 5PATC>3NEW [20:30:23] 3MediaWiki / 3File management: Missing skins/common/images/icons/fileicon.png causes fatal PHP error when viewing file pages for files that can't be thumbnailed - 10https://bugzilla.wikimedia.org/67422 (10Bartosz Dziewoński) a:5Bartosz Dziewoński>3None [20:50:36] 3MediaWiki extensions / 3UploadWizard: Improve Error handling: api-error-unknownerror - 10https://bugzilla.wikimedia.org/66366#c24 (10Marco) *** Bug 67197 has been marked as a duplicate of this bug. *** [20:51:09] fabriceflorin: re: German RfC, any objection to us requesting some corrections there? [20:51:55] tgr: I think it makes perfect sense to propose factual corrections to Birgit, if the RfC is based on inaccurate assumptions. [20:56:20] fabriceflorin: should I write to the RfC page in English and ask her to translate? or how do we do that? [20:57:28] tgr: My recommendation would be to email Birgit directly and Cc us (as well as Sebastian and Dirk). They respond effectively to email. [21:12:25] tgr, we can definitely ignore IE6 :) [21:12:36] and fall back to Special:Upload for that. [21:13:01] cool [21:13:27] Krinkle has expressed interest in taking a crack at the browser compatibility policy. we'll probably start with an RFC to get that to a more sensible place. [21:13:33] probably not hard to find an acceptable 3rd party upload library then [23:07:36] (03PS5) 10Gergő Tisza: Move button setup from lightboxinterface to canvasButton [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143099 [23:07:39] (03CR) 10jenkins-bot: [V: 04-1] Move button setup from lightboxinterface to canvasButton [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143099 (owner: 10Gergő Tisza) [23:15:01] (03PS6) 10Gergő Tisza: Move button setup from lightboxinterface to canvasButton [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143099 [23:20:02] (03CR) 10Gergő Tisza: "I agree about the space but I don't think there was any change in that since those buttons have been first implemented. I'll address that " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142725 (owner: 10Gergő Tisza) [23:22:24] (03PS1) 10Gergő Tisza: Make above-the-fold buttons take up more vertical space [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143790 [23:23:16] (03CR) 10Gergő Tisza: "Addressed in https://gerrit.wikimedia.org/r/#/c/143790/" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142725 (owner: 10Gergő Tisza)