[01:51:03] 3MediaWiki extensions / 3TimedMediaHandler: WebVideoJobRunner silently fails to pick up transcode jobs under HHVM - 10https://bugzilla.wikimedia.org/67973 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None In MediaWiki-Vagrant with 'timedmediahandler' role enabled, manually running WebVideoJobRunner f... [02:41:14] (03PS6) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) [02:42:31] 3MediaWiki extensions / 3TimedMediaHandler: Support ogv.js in player - 10https://bugzilla.wikimedia.org/61823#c7 (10Brion Vibber) I have a live sample wiki running with the patch on labs: http://ogvjs-testing.wmflabs.org/ Still some more work to do, but the basics are working. :D [03:26:46] (03PS1) 10Gergő Tisza: Transclude expand button text in help message instead of copying it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146013 [03:53:31] 3MediaWiki extensions / 3MultimediaViewer: Unexpected outbound link from image summary field - 10https://bugzilla.wikimedia.org/67896#c5 (10Tisza Gergő) Thanks for upstreaming! I don't think this should have been a blocker for deployment. To avoid the Nirvana fallacy, one should compare the cost a feature b... [05:12:07] (03CR) 10Gergő Tisza: [C: 04-1] "This will include users who are inactive for years, so the ratio is not very meaningful. Also I feel uncomfortable about using tsv files a" [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/145595 (owner: 10MarkTraceur) [05:16:42] (03CR) 10Gergő Tisza: [C: 032] "Nice!" [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/145608 (owner: 10MarkTraceur) [05:16:48] (03Merged) 10jenkins-bot: Use preference change events instead of our own [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/145608 (owner: 10MarkTraceur) [06:31:31] (03PS2) 10Nemo bis: Transclude expand button text in help message instead of copying it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146013 (owner: 10Gergő Tisza) [06:31:42] (03CR) 10Nemo bis: [C: 031] "Thanks" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146013 (owner: 10Gergő Tisza) [08:37:03] (03CR) 10Gergő Tisza: Add graphs for opt-outs (031 comment) [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/145599 (owner: 10MarkTraceur) [10:11:02] 3MediaWiki extensions / 3TimedMediaHandler: WebVideoJobRunner silently fails to pick up transcode jobs under HHVM - 10https://bugzilla.wikimedia.org/67973 (10Andre Klapper) p:5Unprio>3Normal [10:20:01] 3MediaWiki extensions / 3TimedMediaHandler: Player shows "12:60" instead of "13:00" briefly - 10https://bugzilla.wikimedia.org/67882 (10Andre Klapper) p:5Unprio>3Low [12:57:02] 3MediaWiki / 3File management: Support for WAV and AIFF by converting files to FLAC automatically. - 10https://bugzilla.wikimedia.org/20252#c11 (10Quim Gil) CCing the Multimedia team is becoming more complex as they grow. ;) Anyway, what do you think? [13:11:12] (03CR) 10Mdale: [C: 032 V: 032] "Tested, and looks pretty safe." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145875 (https://bugzilla.wikimedia.org/67937) (owner: 10Brion VIBBER) [13:14:17] 3MediaWiki extensions / 3UploadWizard: Upload Wizard release "elvis" (tracking) - 10https://bugzilla.wikimedia.org/36680 (10Andre Klapper) 5NEW>3RESO/WOR [13:16:47] 3MediaWiki extensions / 3UploadWizard: Upload Wizard: Allow easier integration of "community tools" (tracking) - 10https://bugzilla.wikimedia.org/38427#c1 (10Andre Klapper) 5NEW>3RESO/WOR This bug is "tracking" exactly one issue which can also be tracked by directly tracking that issue instead. Hence I'm... [13:32:49] 3MediaWiki extensions / 3UploadWizard: Upload Wizard release "elvis" (tracking) - 10https://bugzilla.wikimedia.org/36680#c1 (10Rainer Rillke @commons.wikimedia) Is "elvis" a release name? Is that documented? [13:34:18] 3MediaWiki extensions / 3UploadWizard: Upload Wizard: Allow integration of "community tools" - 10https://bugzilla.wikimedia.org/38428#c1 (10Rainer Rillke @commons.wikimedia) Bug 38427 was closed, hence this gets the generic heading. Events or hooks, handlers or whatever is required but in a well-thought fram... [13:40:32] 3MediaWiki extensions / 3TimedMediaHandler: TimedMediaHandler media players show as "Error missing media source" under HHVM - 10https://bugzilla.wikimedia.org/67937 (10Brion Vibber) 5PATC>3RESO/FIX [14:13:48] 3MediaWiki extensions / 3UploadWizard: Upload Wizard release "elvis" (tracking) - 10https://bugzilla.wikimedia.org/36680#c2 (10Andre Klapper) I think it was (bug 26076 comment 22 implies so) in 2012. [15:03:16] All right children [15:03:22] What the hell needs fixing today [15:06:38] Huh, somehow all of my cards remain in ACR [15:22:37] (03CR) 10MarkTraceur: "We should chat about what medium you'd prefer - I'm guessing this is why you wanted another database table, but that sounds nasty and unne" [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/145595 (owner: 10MarkTraceur) [15:26:24] bd808, can you merge https://gerrit.wikimedia.org/r/140732/ ? [15:28:48] * bd808 looks [15:31:10] y'alls bad at yer mingle tickets [15:31:36] * rillke is in Bryan's dept [15:32:26] Hm rillke? [15:33:21] rillke: {{done}] see the comment :) [15:33:35] thank you :) [15:35:03] marktraceur, ? [15:37:28] rillke: I didn't understand your comment :) [15:38:46] * rillke is causing so much work to you already busy guys ..., marktraceur [15:38:57] bd808: /w/index.php?title=Template:done%7D%5D%20see%20the%20comment%20%3A)&action=edit&redlink=1 [15:39:12] rillke: Naw, it's okay, it's part of the job [15:39:48] marktraceur: my irc client needs a lint or at least preview :) [15:39:57] Absolutely [15:40:20] (and that's totally not what wikitext would output, but anyway) [15:43:49] marktraceur, what are your thoughts about https://gerrit.wikimedia.org/r/145420/ -- I think it's wrong adding messages to an extension which the extension itself does not use [15:45:07] Yeah, that's weird. [15:45:18] rillke: Could probably set them on-wiki? [15:45:39] Not ideal, but maintaining the site config and the on-wiki messages is actually slightly more flexible [15:47:36] the disadvantage is of course that we do only allow administrators to edit commons mw messages, while on translatewiki, there is a real system of proofreading and a lot more translators [15:47:45] Hm, yeah [15:47:51] So less flexible in that sense [15:48:03] Ugh. [15:48:17] rillke: This is where I start wanting Extension:Licenses [15:48:38] Or similar. [15:48:41] Maybe in core [15:48:56] marktraceur, did you file a bug for that? [15:49:01] sounds reasonable to me [15:49:03] I didn't [15:49:13] It's the sort of thing that I keep thinking of, but then shooting myself down for [15:49:31] 'cause it's sort of interesting, and it's useful to a lot of people, but it's a lot of work for not all that much gain IMO [15:49:38] 'cause UW is the heaviest license user, technically [15:50:03] MW core could use it a little - default licensing of contributions and all that [15:50:17] Media Viewer and CMD could, too. Maybe even TMH. [15:50:52] gi11es: Ooh, any chance you figured out how to use arcanist? I could start bothering some platform people if not [15:50:55] everything that offers uploading essentially [15:51:13] * marktraceur looks up arcanist [15:51:20] rillke: Well, or different editing [15:51:25] Hell, even VE could dip into this [15:51:58] I think they have some use of license names in their save dialog [15:52:21] ... and license texts [15:52:49] Oh, didn't know that. [15:53:28] oops, no just a link [15:54:31] it'd be cool having some structured collection of licenses: names, links, texts for use within mediawiki [15:55:01] given the importance of licenses on free content [15:55:02] Yeah. [15:55:10] #makeitaservice [15:55:35] (trending now on #wikimedia-dev) [15:58:18] neil fuck [15:58:23] Just missed him. [16:14:06] Damn it, arcanist, why wouldn't you use my git editor by default [16:22:07] OK by and large, <3 arcanist [16:22:10] <3 phabricator [16:39:36] ne argh [17:17:08] (03CR) 10Gergő Tisza: "The table exists already, it's staging.mediaviewer_optout. As it turns out the research user has the right to create tables in the 'stagin" [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/145595 (owner: 10MarkTraceur) [17:18:10] Whaaaaaat, arcanist [17:18:12] Whaaaaaaaat [17:18:18] 'arc tasks' [17:18:20] whaaaaaat [17:18:47] Oh well tgr in that case maybe you should take it away? [17:18:53] Unless you're busy and I should instead. [17:19:24] neilk_: Ohai [17:19:37] marktraceur: hi [17:19:54] I had a question for you, related to D45 in Phabricator - basically I ripped out most of mw.UtilitiesTime as unused [17:20:10] marktraceur: ok [17:20:12] Just wondering if there are any pitfalls I missed, but most of the methods were never touched based on my grepping [17:20:29] The only thing left is seconds2Measurements [17:20:37] marktraceur: I don't remember. That was a catchall for various stuff [17:20:40] Probably should have put that into GroupProgressBar instead while I'm at it. [17:20:52] marktraceur: let me check [17:20:54] K [17:23:19] marktraceur: did you send me a CR to do? [17:23:31] Uh...sec [17:23:50] marktraceur: I'm not sure how to do stuff in phabricator [17:23:55] neilk_: http://fab.wmflabs.org/D45 [17:23:58] Diff and everything. [17:24:34] ...what's this arc [17:24:53] neilk_: It's a command line tool for using Phabricator [17:24:55] It's the BEST. [17:25:04] Not too hard to install either. [17:25:21] between phabricator, gerrit, mingle, and just committing code I'm not certain what the process is generally [17:25:27] also bugzilla [17:25:40] anyway perhaps that's a discussion for another time. [17:30:45] neilk_: Phabricator is going to be The One Tool to Rule Them All [17:31:46] marktraceur: change seems okay [17:31:54] K [17:32:12] "maniphest" /facepalm [17:32:15] I guess I can put it on Gerrit too [17:32:17] Shrug [17:32:42] The idea here was that we'd do code review in Phabricator, but if you're just +2 on it, we can stick it in Gerrit and merge 'er [17:33:16] marktraceur: I don't see a way to review it... your requested tgr as reviewer for that Phab thing [17:33:33] neilk_: Hm, do you have an account on it? [17:33:50] (also, the ph thing is everywhere, get used to it ;) ) [17:34:30] marktraceur: I guess not. I'll phigure it out. [17:35:02] Phabulous. [17:36:16] I could also just submit it to gerrit [17:36:36] Literally the whole idea here is that we're using the UW refactor as a medium for testing phabricator [17:36:43] Gerrit is where we'll get things done [17:39:46] marktraceur: you say it's "the" idea but I haven't heard that from anyone else, nor have I personally committed to it [17:39:50] Ah. [17:39:51] (03PS1) 10MarkTraceur: Testing UtilitiesTime and removing unused methods [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146139 [17:39:59] Well I can just stop doing that for code review, I just wanted to test it out [17:40:09] Sorry for being confusing :) [17:40:10] marktraceur: not that I want to be obstructionist or anything, but I'm not going to be here long term like the rest of you [17:40:19] neilk_: Yeah, makes sense, we'll make things easy on you [17:40:21] marktraceur: I'd rather there was A process rather than many [17:41:07] (03PS1) 10MarkTraceur: Test UploadWizardUtil and move single-use things to other classes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 [17:41:12] neilk_: That's what the move to Phabricator is supposed to solve, but we're still in the in-between part [17:41:17] marktraceur: if this is something the team committed to, I can get on board. From experience with Wikimedia, there are people who say "This is the new standard" when what they mean is "I wish this was the new standard". [17:41:22] I'll be sure to only send you Gerrit patches from now on. [17:41:31] (03CR) 10jenkins-bot: [V: 04-1] Test UploadWizardUtil and move single-use things to other classes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur) [17:41:56] marktraceur: let me be clear, I can do whatever process there is, but I'd just prefer there was one rather than choose your own adventure for every patch [17:42:05] *nod* [17:42:16] neilk_: So I'm telling you now, for the foreseeable future, it's Gerrit. [17:42:21] marktraceur: ok [17:42:37] And I'll make sure that's true for all of us - tgr and gi11es, we'll avoid using differential and arcanist for now [17:43:28] (03PS2) 10MarkTraceur: Test UploadWizardUtil and move single-use things to other classes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 [18:09:12] marktraceur: re optout stats, I can do that [18:09:31] probably not today, but I don't think it's particularly urgent, either [18:10:44] OK [18:10:47] Yeah I figured not [18:11:00] We can sort of get historical based on preference change events, I figure [18:12:15] hm, that's true [18:12:50] Just not based on edit count or activity...right? [18:13:14] So we lose some history if we wait. [18:13:16] Just not that much IMO [18:14:21] also, it's hard to track whether the user existed at that point [18:15:16] on the whole, seems way more trouble than just saving daily [18:15:19] Yeah. [18:15:42] Just means we lose data while we wait, not sure if that's a problem [18:18:53] I don't think a few days matter, in the short term the data seemed pretty boring for the time when I tracked it manually, very little day-to-day change [18:20:18] Sure. [18:36:42] tgr gi11es marktraceur : Do you know where I could find the MV metrics dashboard for MediaWiki.org? I am getting blank screens on this page: http://multimedia-metrics.wmflabs.org/dashboards/mmv_mediawikiwiki#actions-graphs-tab [18:37:52] must be a bug, that's the right URL [18:39:47] we have quite a few 0-byte tsv files: http://stat1001.wikimedia.org/public-datasets/all/multimedia/ [18:41:03] Labs was having trouble earlier [18:41:08] Might be an issue on their end [18:41:20] Oh, no the tsvs are all blank, that'll do it [18:41:32] probably a bug in https://gerrit.wikimedia.org/r/#/c/145608 [18:41:43] Probably [18:42:00] * marktraceur will look into it in a bit [18:42:47] and END is missing, I'll fix [18:45:16] (03PS1) 10Gergő Tisza: Fix action logging SQL query [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/146158 [18:52:23] tgr marktraceur: Thanks. Should I add a bug on Mingle, so we don’t lose track? These metrics are pretty important for us right now, since we are citing them extensively on community discussion pages. I notice the same thing is happening in the main Media Viewer metrics dashboard: http://multimedia-metrics.wmflabs.org/dashboards/mmv [18:53:02] don't think it's needed [18:53:28] Probably not [18:53:32] Fast task [18:54:38] marktraceur: OK, sounds good. Hope we can fix it today, it’s a critical touchpoint for us. [18:56:28] *nod* [18:56:34] It sounds like tgr is working on it. [18:56:57] it was a quick fix, it just needs a +2 [18:57:13] https://gerrit.wikimedia.org/r/146158 [18:57:22] Agh, SQL [18:57:24] You bastard. [18:57:31] (SQL, not tgr. tgr is wonderful.) [18:57:36] well I hope so, still have no idea how to test these things before deploying [18:57:41] (03CR) 10MarkTraceur: [C: 032] Fix action logging SQL query [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/146158 (owner: 10Gergő Tisza) [18:57:46] (03Merged) 10jenkins-bot: Fix action logging SQL query [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/146158 (owner: 10Gergő Tisza) [18:57:52] Yeah, just basically go with it [18:57:59] * marktraceur runs the scripts [18:58:40] Just the actions, right [18:58:43] Yeah. [18:58:48] Running now [19:04:14] Ugh, this createInterface function [19:04:17] Needs to die [19:04:18] So hard [19:04:22] * marktraceur goes to get brainfood [19:08:32] 3MediaWiki extensions / 3TimedMediaHandler: Support MPEG DASH for multiple webm files - 10https://bugzilla.wikimedia.org/42591#c2 (10Brion Vibber) MPEG-DASH style streaming would also be good for the ogv.js player (or a future webm.js variant) in non-WebM-supporting browsers, as this would enable things that... [20:02:42] (03PS1) 10MarkTraceur: Refactor createInterface into a new class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146229 [20:03:08] Kill. Me. Now. [20:03:13] (03CR) 10jenkins-bot: [V: 04-1] Refactor createInterface into a new class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146229 (owner: 10MarkTraceur) [20:03:25] O.O [20:03:47] Jenkins, you don't want to do that right now [20:10:33] (03PS2) 10MarkTraceur: Refactor createInterface into a new class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146229 [20:10:55] So my git checkout of UW decided to randomly bisect in the middle of my committing process [20:10:58] That was fun [20:15:26] Stats are back [20:15:37] Opt-outs look a little funny...thought we had more anon ones than that. [20:16:15] Also: opt-in is a stupid thing to measure, nobody uses it [21:51:48] (03PS1) 10MarkTraceur: Fix a few issues in unattach [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146294 [21:52:18] tgr: ^ causing issues in master, I think - you can confirm by trying to exit the lightbox in master [21:53:38] Not hitting mw.org, but not sure why [21:54:09] give me a sec [21:54:22] I managed to destroy my vagrant box over the weekend [21:54:28] Sure [22:04:13] Oh, huh, latest mediawiki works fine. [22:04:23] I wonder what we changed....maybe tipsy got upgraded for some reason? [22:05:22] I doubt it, tipsy has been unmaintained for years [22:05:26] Seems like [22:05:43] But then what...things merged in the past few days seem mundane [22:07:38] Reading, sec. [22:08:55] Merge "Remove outdated unused jquery.tipsy styles from common/shared.css" [22:09:00] But that seems like it would be mundane [22:09:27] Nope [22:09:48] And I'm past the deploy on Thursday, so... [22:20:44] (03CR) 10Mattflaschen: "Removing myself as reviewer" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [22:23:31] (03CR) 10MarkTraceur: [C: 04-1] "I don't see any videos or even pages worth testing on that wiki - in any case, this seems way premature, especially given that the issues " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [22:43:01] tgr: Not a wiki page? Son, I am very disappoint. [22:43:17] eh [22:43:27] commenting in Docs is just too convenient [22:44:14] the same thing would be unreadable with inline comments after a few lines of discussions [22:45:34] there are all sort of collapsible templates for that, but they are difficult to use and I am worried they would keep the less wiki-practiced people from contributing