[00:15:36] (03PS1) 10Gergő Tisza: Reveal full text when metadata panel is opened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 [00:18:34] (03CR) 10jenkins-bot: [V: 04-1] Reveal full text when metadata panel is opened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 (owner: 10Gergő Tisza) [00:44:53] (03PS1) 10Gilles: Move repo icon back to the right-hand side [extensions/MultimediaViewer] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146996 [00:46:14] (03CR) 10jenkins-bot: [V: 04-1] Move repo icon back to the right-hand side [extensions/MultimediaViewer] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146996 (owner: 10Gilles) [00:46:49] (03CR) 10Gilles: "recheck" [extensions/MultimediaViewer] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146996 (owner: 10Gilles) [00:46:52] gi11es: followup incoming for the repo move patch [00:47:13] tgr: what's the problem? [00:47:58] (03CR) 10Gilles: "recheck" [extensions/MultimediaViewer] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146996 (owner: 10Gilles) [00:48:15] that animation thing is going to be annoying real faast [00:49:55] gi11es: The metrics scripts don't appear to be running.... [00:50:08] At least from what I can tell [00:51:43] (03PS1) 10Gergő Tisza: Size adjustments for moved-back repo icon [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146998 [00:52:01] gi11es: ^^ [00:52:37] (03CR) 10Gilles: [C: 032] Size adjustments for moved-back repo icon [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146998 (owner: 10Gergő Tisza) [00:53:12] (03Merged) 10jenkins-bot: Size adjustments for moved-back repo icon [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146998 (owner: 10Gergő Tisza) [00:53:14] (03CR) 10Gilles: "recheck" [extensions/MultimediaViewer] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146996 (owner: 10Gilles) [00:53:58] (03PS1) 10Gilles: Size adjustments for moved-back repo icon [extensions/MultimediaViewer] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146999 [00:54:32] (03CR) 10jenkins-bot: [V: 04-1] Size adjustments for moved-back repo icon [extensions/MultimediaViewer] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146999 (owner: 10Gilles) [00:55:43] fun [00:57:32] (03PS1) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [00:58:26] (03PS2) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [00:59:49] I'm just going to force those chagnesets, we know the failure is bogus [01:00:00] (03CR) 10Gilles: [C: 032 V: 032] Move repo icon back to the right-hand side [extensions/MultimediaViewer] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146996 (owner: 10Gilles) [01:00:05] (03CR) 10jenkins-bot: [V: 04-1] More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 (owner: 10Gergő Tisza) [01:00:32] (03CR) 10Gilles: [C: 032] Size adjustments for moved-back repo icon [extensions/MultimediaViewer] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146999 (owner: 10Gilles) [01:00:37] (03CR) 10Gilles: [V: 032] Size adjustments for moved-back repo icon [extensions/MultimediaViewer] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146999 (owner: 10Gilles) [01:01:39] (03PS3) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [01:16:42] (03PS4) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [01:17:28] marktraceur: the SQL to TSV stuff isn't running? [01:19:13] (03PS5) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [01:22:36] (03PS6) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [01:31:10] (03PS7) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [01:34:12] (03PS8) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [01:36:35] (03PS9) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [01:37:34] (03PS10) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [01:44:23] (03PS11) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [01:48:33] (03PS12) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [01:51:27] (03PS13) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [01:56:26] (03PS14) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [01:59:06] (03PS15) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 [02:00:55] (03Abandoned) 10Gergő Tisza: More testing of tests, yay [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147001 (owner: 10Gergő Tisza) [02:02:37] (03PS2) 10Gergő Tisza: Reveal full text when metadata panel is opened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 [02:03:11] (03CR) 10jenkins-bot: [V: 04-1] Reveal full text when metadata panel is opened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 (owner: 10Gergő Tisza) [02:24:34] 3MediaWiki / 3File management: Navigation on final page of Special:ListFiles pager should not loop back - 10https://bugzilla.wikimedia.org/67627 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX [02:31:19] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer stay on black screen after close - 10https://bugzilla.wikimedia.org/68104#c2 (10Albert Chu) Uncaught TypeError: Cannot read property 'hide' of undefined load.php?debug=false&lang=en&modules=jquery.color%2CcolorUtil%2Cfullscreen%2Ctipsy%7Cmediawiki.U... [03:06:49] 3MediaWiki / 3File management: Dutch mediawiki ignores formatting options when using [[Bestand:...]] instead of [[File:...]] - 10https://bugzilla.wikimedia.org/68091#c3 (10Bawolff (Brian Wolff)) I can't reproduce. *Went to https://nl.wikipedia.org/wiki/Speciaal:SjablonenSubstitueren *Typed in [[Bestand:exam... [03:07:04] 3MediaWiki / 3File management: Dutch mediawiki ignores formatting options when using [[Bestand:...]] instead of [[File:...]] - 10https://bugzilla.wikimedia.org/68091 (10Bawolff (Brian Wolff)) [03:30:06] 3MediaWiki extensions / 3Score: MIDI generation on Windows fails with "No MIDI file generated despite being requested"; Support "-dmidi-extension=midi" - 10https://bugzilla.wikimedia.org/47703#c3 (10gnosygnu) I uploaded the patch here: https://gerrit.wikimedia.org/r/#/c/147015/ Let me know if there is anyth... [06:52:50] 3MediaWiki extensions / 3MultimediaViewer: Without CSS, clicks on thumbnails getting silently swallowed - 10https://bugzilla.wikimedia.org/68123#c3 (10christian) (In reply to Tisza Gergő from comment #1) > (In reply to christian from comment #0) > > For users that have CSS disabled (but JavaScript enabled) >... [08:51:23] 3MediaWiki extensions / 3VipsScaler: Apply jpgcrush (mozjpeg) over all thumbnails - 10https://bugzilla.wikimedia.org/68145 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None The weight of JPEG thumbnails, while varying less than PNG thumbnails', is often a relevant factor in the loading times observed on rand... [09:44:05] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer stay on black screen after close - 10https://bugzilla.wikimedia.org/68104#c3 (10th3gov) I'm not sure how I can activate the debug mode. Maybe you can check it by yourself? Here is the URL http://knowledgebase.cc/new/index.php/How_to_pick_a_Defcon_C... [10:45:52] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer shows wrong image for localized SVG files - 10https://bugzilla.wikimedia.org/68154 (10Michael M.) 3NEW p:3Unprio s:3normal a:3None To reproduce go to https://de.wikipedia.org/wiki/Hilfe:Bilder#SVG-Dateien and click on the second thumb (that... [10:49:05] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer shows wrong image for localized SVG files - 10https://bugzilla.wikimedia.org/68154#c1 (10Michael M.) On a second thought: If you navigate through all the images on that page, it works as expected, so this might be just an issue with both [10:51:49] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer shows wrong image for localized SVG files - 10https://bugzilla.wikimedia.org/68154#c2 (10Michael M.) s:5normal>3minor (hit "Save" accidentally) ... the localized version and the unlocalized version of an image are present on a page. As this does... [11:12:51] 3MediaWiki extensions / 3Score: MIDI generation on Windows fails with "No MIDI file generated despite being requested"; Support "-dmidi-extension=midi" - 10https://bugzilla.wikimedia.org/47703#c4 (10Andre Klapper) Great! Fixing the commit message is welcome, see https://www.mediawiki.org/wiki/Gerrit/Commit_m... [11:13:05] 3MediaWiki extensions / 3Score: MIDI generation on Windows fails with "No MIDI file generated despite being requested"; Support "-dmidi-extension=midi" - 10https://bugzilla.wikimedia.org/47703 (10Andre Klapper) 5UNCO>3PATC [11:59:19] 3MediaWiki extensions / 3VipsScaler: Apply jpgcrush (mozjpeg) over all thumbnails - 10https://bugzilla.wikimedia.org/68145#c1 (10Gilles Dubuc) A second pass over existing jpgs would be quite destructive and introduce compression artifacts. This is only worth considering as a swap-in replacement for imagemagi... [12:03:35] 3MediaWiki extensions / 3VipsScaler: Apply jpgcrush (mozjpeg) over all thumbnails - 10https://bugzilla.wikimedia.org/68145#c2 (10Nemo) (In reply to Gilles Dubuc from comment #1) > A second pass over existing jpgs would be quite destructive and introduce > compression artifacts. Are you just giving this for... [12:09:39] (03CR) 10Gilles: [C: 04-1] Remove UploadWizardUtil, replace with other things (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur) [12:30:49] 3MediaWiki extensions / 3VipsScaler: Apply jpgcrush (mozjpeg) over all thumbnails - 10https://bugzilla.wikimedia.org/68145#c3 (10Gilles Dubuc) > Are you just giving this for granted, or is the consideration specifically > based on tests and/or the algorithm they follow? (I didn't inspect either.) Any jpeg r... [12:39:04] 3MediaWiki extensions / 3VipsScaler: Apply jpgcrush (mozjpeg) over all thumbnails - 10https://bugzilla.wikimedia.org/68145#c4 (10Nemo) (In reply to Gilles Dubuc from comment #3) > if there's a > straightforward way to avoid an extra pass I didn't hear of any. > I don't see the > point of having an initial... [12:57:04] 3MediaWiki extensions / 3VipsScaler: Apply jpgcrush (mozjpeg) over all thumbnails - 10https://bugzilla.wikimedia.org/68145#c5 (10Gilles Dubuc) Imagemagick's convert can do the rescaling/sharpening/color profile handling, while targeting an uncompressed format, and then mozjpeg would take care of the JPEG com... [13:25:50] 3MediaWiki extensions / 3VipsScaler: Apply jpgcrush (mozjpeg) over all thumbnails - 10https://bugzilla.wikimedia.org/68145 (10Andre Klapper) p:5Unprio>3Low [13:32:32] (03CR) 10Gilles: "Now that the icon is on the right, I wonder how useful the switch to the smaller icons really is (it doesn't free that much space), but in" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [13:40:49] (03CR) 10Gilles: Reveal full text when user clicks on title or credit (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [13:42:20] (03PS21) 10Gilles: Reveal full text when user clicks on title or credit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [13:43:49] (03CR) 10Gilles: [C: 032] Reveal full text when user clicks on title or credit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [13:44:23] (03Merged) 10jenkins-bot: Reveal full text when user clicks on title or credit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [13:44:33] (03PS3) 10Gilles: Reveal full text when metadata panel is opened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 (owner: 10Gergő Tisza) [13:45:06] (03CR) 10jenkins-bot: [V: 04-1] Reveal full text when metadata panel is opened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 (owner: 10Gergő Tisza) [13:47:34] (03CR) 10Gilles: "I find this one a bit too much in-your-face. I think someone from UI should try it out to check that's what they really want. Seems to me " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 (owner: 10Gergő Tisza) [13:49:03] (03CR) 10Gilles: "Also, we should write browser tests for this and the parent commit." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 (owner: 10Gergő Tisza) [13:50:49] (03CR) 10Gilles: Reveal full text when metadata panel is opened (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 (owner: 10Gergő Tisza) [13:53:17] (03CR) 10Gilles: "Are we still waiting for neilk to review this, or...?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [13:55:04] * marktraceur looks around for neilk [13:55:27] gi11es: I'd say if you think it's good, go for it, but if you want to wait that's OK too [13:59:24] (03CR) 10Gilles: Massive refactor (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [14:01:38] (03CR) 10Gilles: "Krinkle's most recent comments haven't been addressed/replied to, as far as I can see" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (owner: 10MarkTraceur) [14:05:32] (03CR) 10Gilles: Use promises for fetching image info (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146903 (owner: 10MarkTraceur) [14:20:21] (03CR) 10Gilles: "Note that there are in this instance other errors before the animation one, coming from mmv.ui.metadataPanelScroller" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 (owner: 10Gergő Tisza) [15:32:11] gi11es: I don't know if we want to change the behaviour...it's only used on descriptions and uploads, and I'm not even convinced those work very well [15:32:26] But even if they do, there's only ever one description or upload that will match...eh, fuck it. [15:33:35] (03PS5) 10MarkTraceur: Remove UploadWizardUtil, replace with other things [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 [15:39:50] (03CR) 10MarkTraceur: Remove UploadWizardUtil, replace with other things (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur) [16:08:54] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer stay on black screen after close - 10https://bugzilla.wikimedia.org/68104#c4 (10Albert Chu) A couple of quirky things that I noticed this morning: * The behavior I mentioned yesterday doesn't exhibit with th3gov's link * This morning, when I tried... [16:38:30] marktraceur: Hm... it says you replied to them, but I don't see that: https://gerrit.wikimedia.org/r/#/c/146604/2..4/resources/mw.UploadWizardUpload.js [16:38:35] those 4 comments dont have replied. [16:39:15] Anyhow, they're just minor points because I felt like reviewing some of your code in return. I didn't -1. [16:58:16] Oh, yeah. [16:58:21] I thought I got those, sorry :) [17:10:22] (03CR) 10MarkTraceur: Massive refactor (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [17:11:39] gi11es: Did you see any other ( new Date() ).getTime calls that I should fix or are you happy with just that one? [17:11:43] There are like...a lot of them [17:12:13] should be a separate commit if it's existing code, I just saw that one because it was new/moved [17:12:19] 'kay [17:12:26] (03PS28) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [17:12:35] (03PS5) 10MarkTraceur: Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 [17:19:43] (03CR) 10MarkTraceur: Use promises for getting image info (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (owner: 10MarkTraceur) [17:19:58] (03PS6) 10MarkTraceur: Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 [17:33:50] (03PS6) 10MarkTraceur: Use promises for fetching image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146903 [17:35:48] (03CR) 10MarkTraceur: Use promises for fetching image info (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146903 (owner: 10MarkTraceur) [18:03:10] (03CR) 10Rillke: Massive refactor (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [18:13:45] Guh, gi11es, the required format of the upload response for jQuery file upload is bad enough [18:13:50] To axe it, I mean [18:13:51] AFAICT [18:16:07] Ugh, FU does that too [18:16:08] Whyyyy [18:16:20] We're going to need to override their success/failure methods [18:36:46] gi11es: I don't suppose you have any test code for the libraries handy that I could look at [19:13:20] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer shows wrong image for localized SVG files - 10https://bugzilla.wikimedia.org/68154#c3 (10Tisza Gergő) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 58663 *** [19:13:34] 3MediaWiki extensions / 3MultimediaViewer: media viewer doesn't preserve thumbnail options like svg language - 10https://bugzilla.wikimedia.org/58663#c8 (10Tisza Gergő) *** Bug 68154 has been marked as a duplicate of this bug. *** [19:15:50] 3MediaWiki extensions / 3MultimediaViewer: media viewer doesn't preserve thumbnail options like svg language - 10https://bugzilla.wikimedia.org/58663#c9 (10Tisza Gergő) I think this actually works now (with thumbnail guessing, although not with thumbnails requested via the API), and the mixing of the languag... [19:22:20] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer stay on black screen after close - 10https://bugzilla.wikimedia.org/68104#c5 (10Tisza Gergő) 5UNCO>3NEW Thanks! You can activate debug mode like this: http://knowledgebase.cc/new/index.php/How_to_pick_a_Defcon_CL_lock?debug=1 The stack trace i... [19:23:37] marktraceur: what do you think about backporting MediaViewer as it is to REL1_23? [19:23:52] I doubt there would be issues. [19:24:08] A few quick checks...wait, didn't we just merge a fix for OOUI that depends on latest MW? [19:24:20] Yes. [19:24:25] there are a banch of bugs that need backporting, but there were so many changes since the branch cut, doing it by cherry-picking would be way more painful [19:24:48] oh yeah, we did that [19:25:13] maybe backport and revert that? [19:25:20] As long as we test it, I'd be OK with backporting the rest of the work. [19:25:21] should be easier even so [19:26:01] came up with https://bugzilla.wikimedia.org/show_bug.cgi?id=68104 which you just fixed a day ago, but I doubt the patch would apply to REL1_23 cleanly [19:26:33] Yeah, and I think the REL1_23 version of OOUI doesn't have that change anyway [19:26:36] So [19:26:52] We may back-port OOUI updates to 1.23.x. [19:27:20] But a few of them are backwards-incompatible, so we'd need to synchonise between teams. [19:27:35] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer stay on black screen after close - 10https://bugzilla.wikimedia.org/68104#c6 (10Tisza Gergő) https://gerrit.wikimedia.org/r/#/c/146294/ probably fixes this. Needs backport. [19:28:02] James_F: On the mailing list ideally [19:28:04] :3 [19:28:17] marktraceur: Don't you have a meeting to get to [19:28:20] You're absolutely right [19:33:10] marktraceur: Which mailing list? [19:34:15] The one that doesn't exist yet [19:38:06] 3MediaWiki extensions / 3UploadWizard: Add possibility to the start describing steps during upload step - 10https://bugzilla.wikimedia.org/55609 (10Nemo) [19:38:19] 3MediaWiki extensions / 3UploadWizard: Add possibility to start the describing steps during upload step - 10https://bugzilla.wikimedia.org/55609 (10Nemo) [20:04:49] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer stay on black screen after close - 10https://bugzilla.wikimedia.org/68104#c7 (10Daniel Schroeter) 5NEW>3RESO/FIX I replaced my MultimediaViewer extension directory with the latest development version and great it is working fine now :-) Thanks... [21:34:00] marktraceur: http://wikipediocracy.com/forum/viewtopic.php?p=101061#p101061 [21:34:20] marktraceur: and no regarding the libraries, I just read the document, code and examples [21:35:17] tgr: I think that the animation qunit failure might now be triggering when another failure happens earlier. at least that's what I saw in recent occurences [21:35:59] * marktraceur cringes at opening a WO link at work [21:36:15] that one's about you! [21:36:18] Hahaha [21:36:43] gi11es: FWIW FineUploader seems like the better choice, but I'm not sure if it will work very well [21:36:46] I dunno [21:40:18] what would batman do? [21:40:31] !wwbd [21:40:37] I guess is the answer to every engineering question like that in the future [21:40:41] Heh [21:46:37] fabriceflorin, gi11es, tgr, robla FYI https://bugzilla.wikimedia.org/show_bug.cgi?id=61731 [22:06:47] marktraceur: do we really need a team list? [22:07:15] the amount of non-public mailing which stayed within team boundaries was pretty small IMO [22:08:10] although I guess having a place were all that discussion is archived is still a good thing [22:10:19] Yeah [22:10:30] this looks pretty interesting: http://funcunit.com/ [22:10:36] tgr: Plus it's convenient, instead of trying to remember (and maybe forgetting) all of the people involved [22:10:40] Plus consistent [22:11:04] Because we need another unit test framework? [22:11:10] marktraceur: the problem is that all the people involved won't subsrcibe [22:11:57] Erik or Lila or Howie will be interested in a few discussions but not most, so we will still need to juggle huge address lists [22:12:09] Only CCs for specific occasions [22:12:40] (but I would not get half the mail to my personal account, that's already a win) [22:14:26] FuncUnit builds on QUnit, and tries to fill the gap between QUnit and Selenium [22:14:40] which is a gap about half of our tests reside in [22:15:24] Hm. Maybe [22:16:10] the thing I really wish we had right now is waits: http://funcunit.com/guides/funcunit.waits.htmlű [22:16:21] http://funcunit.com/guides/funcunit.waits.html [22:16:47] waits are a recipe for slow tests [22:17:05] I'd rather have the user-simulating stuff moved to cucumber [22:17:27] not if they are done well [22:17:34] I've written large-scale qunit tests simulating user behaviour and it becomes unmaintainable very quickly [22:17:34] I haven't looked at the implementation [22:17:59] but it's really awkward to test async stuff in QUnit, even if it happens immediately [22:18:23] cucumber truly resets stuff between tests, as we've seen a few times with qunit tests inevitably start bleeding into each other over time, introducing problems that are hard to debug [22:18:52] that's just the nature of javascript, you can't truly reset everything between qunit tests [22:19:11] when you trigger an event internally, for example, the handler will execute immediately, but still not in the same iteration of the event loop [22:19:45] so there is no actual waiting involved, but but you need an async test in QUnit and it becomes hard to read [22:21:20] to me user simulation in an uninterrupted JS session isn't cost effective. no matter what tools you use and how well you use them, you'll inevitably waste a significant amount of time chasing test side effects [22:21:37] not resetting things between tests is a problem, but it's one we already have, that won't become worse by choosing a test framework that's more suited to the tests we are already doing [22:21:43] selenium solves that problem and it's not hard to use [22:22:47] selenium can be used to test an application; it cannot be used to test a class [22:23:10] funcunit looks like it could [22:55:12] So I'm thinking of things I want to fix in UW [22:55:25] I think one of them is going to be "moveToStep" and "showNext" [22:55:40] I sort of half want there to be a controller for each step [22:55:48] With their own interface classes [22:56:02] And then a basic interface spec that includes e.g. "moveTo" and "moveFrom" [22:56:29] Then the controllers can bubble events up to the bigger controller when they need to make changes to global(ish) state [22:56:45] Things like adding new uploads, activating upload handlers, etc. [22:58:07] yeah, there definitely should be a separate mini-application for each step [22:58:16] and for each file eventually [22:58:36] basically the steps are a form of routing [22:59:38] Yeah [22:59:42] This means...lots of changes [22:59:51] so you could have one controller and separate action handlers, but that's an implementation detail [22:59:55] * marktraceur sighs, goes back to desperately diagramming [23:00:19] Well right now we have the UploadWizard class and it has a big switch in moveToStep, I think [23:00:24] but there should be no assumption of state preserved from prior steps IMO, all data should be passed directly [23:01:59] Yeah [23:02:02] I would have two separate classess, a step handler and a step selector [23:02:04] tgr: The parent controller, the one that switches between steps, would have the global state [23:02:23] Mostly just the global list of uploads, I think... [23:02:30] (oversimplification much?) [23:02:34] the step handler sets up event handlers on the interface, when you press next, it calls the step selector [23:02:43] the step selector calls another step handler [23:02:56] Sounds right [23:03:07] I mean, the event handlers get set up by the step interface class [23:03:15] in more standard MVC terms, the step selector is the router, the step handler is the controller [23:03:23] Then they bubble up to the UploadWizard class [23:03:49] Then UW calls the right step setup function for whatever it thinks is next - sometimes e.g. there's no Deed step [23:04:30] I would just pass things around, try to avoid global state as much as possible [23:06:23] also, try to have a class that's specifically about selecting the next step, uw.Workflow or something like that [23:06:34] UploadWizard is a bit of a god class now [23:07:24] Yeah. [23:08:22] also I think we should use dependency injection from the start, much of the awkwardness in MediaViewer comes from not having that [23:09:51] Yeah [23:09:56] Well, "start" [23:09:59] Restart maybe [23:10:08] restart, yeah [23:10:25] But definitely [23:10:38] At least for the UI classes...not sure how much we need to worry about different controllers [23:10:57] But definitely the models too, for make benefit glorious nation of Wikidata [23:12:36] it would be nice to have completely storage-agnostic models on the client side [23:12:53] Yeeeeessss [23:13:12] Though actually, the wikidata thing may just be a matter of a different static constructor method? [23:13:21] although not sure how we handle stuff like dates where wikidata has its own complex models [23:14:07] IMO we should try to push all the wikidata stuff server-side [23:14:50] have a new API which sends/accepts structured data about a file, and can transform it to either wikitext or claims [23:15:07] Well yeah that would be way easier. [23:15:17] Wait...didn't I push a model patch for UW already [23:15:20] Or did I dream that [23:15:21] * marktraceur looks [23:21:11] tgr: I'll second that [23:25:32] the plans for the API are at https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/692 BTW [23:30:42] 3MediaWiki extensions / 3MultimediaViewer: Icon to view original file should be a link so it can be middle-clicked - 10https://bugzilla.wikimedia.org/68203 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None This is non-trivial technically as the URL to the original file might not be immediately availab...