[00:05:05] 3MediaWiki extensions / 3MultimediaViewer: Special characters in target of mmv url are hex encoded in url bar - 10https://bugzilla.wikimedia.org/68372#c17 (10Tisza Gergő) Could, but should not, IMO. I'll quote the relevant part from the mail linked in comment 8: 1. Just put the file name as-is (with spaces... [02:19:50] (03PS2) 10Brian Wolff: Add a maintinance report about TimedText pages that don't have a file [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 [02:21:20] (03CR) 10Brian Wolff: "PS2: added code comment explaining what the query does (strips off last 2 "extensions", then looks up result in image.img_name)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 (owner: 10Brian Wolff) [02:26:22] (03PS3) 10Brian Wolff: Add a maintinance report about TimedText pages that don't have a file [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 [02:48:35] 3MediaWiki extensions / 3MultimediaViewer: Special characters in target of mmv url are hex encoded in url bar - 10https://bugzilla.wikimedia.org/68372#c18 (10Bawolff (Brian Wolff)) > > 1. Just put the file name as-is (with spaces replaced by underscores) in > the URL fragment part. > Pro: readable fi... [02:59:35] 3MediaWiki extensions / 3MultimediaViewer: Special characters in target of mmv url are hex encoded in url bar - 10https://bugzilla.wikimedia.org/68372#c19 (10Tisza Gergő) (In reply to Bawolff (Brian Wolff) from comment #18) > What sort of injection vulnerabilities do you mean ( < and > are disallowed > in ti... [03:00:36] tgr: good point with the third parties [03:01:28] that was the problem with RTL too [03:01:52] wikitext already has RTL titles, but people who want to link to them are generally not exposed to that [03:02:22] plus all the crap that can happen when you put a raw link in a non-UTF-8 document [03:03:03] (which can still happen if the link is percent-encoded, but somewhat less likely) [03:03:31] well if they're pasting into a non-ascii compatible charset, they're pretty screwed all around [03:04:18] As far as percent encoding not working goes [03:05:44] when will the bug to allow download from flickr via http be fixed? O_O [03:06:13] We don't allow downloading from flickr via http? [03:07:01] not via [[Special:UploadWizard/flickr]] at commons we don't .. [03:08:51] 3MediaWiki / 3Uploading: Wikimedia Commons support for Flickr HTTPS - 10https://bugzilla.wikimedia.org/63254#c2 (10Bawolff (Brian Wolff)) I think this might be an issue with commons javascript and not mediawiki (In which case it would have to be filed with the commons folks in order to be fixed). [03:09:27] comets: You have a bug number off hand? [03:09:48] https://bugzilla.wikimedia.org/show_bug.cgi?id=67298 i think [03:10:37] we use SSL for all Flickr [03:10:54] they changed their API to require it sometime in June [03:12:21] Ok so that's all fixed. If you're browsing from http, it should use https for the request to flickr [03:12:39] comets: Do you still experiance issues? Or are you unable to use https whatsoever? [03:13:45] i use http on all wikis (its faster) but i'm forced to use the flickr upload wizard on https... [03:15:09] comets: Well in theory, this bug should have been fixed since about july 8th [03:16:49] * bawolff would also be surprised if there is a significant difference in speed of https vs non-http. I would expect the overhead of https to be minimal relative to everything else. But I've never measured [03:18:34] it hasn't, when u input the image link and press "Get from flickr", nothing happens.. :\ [03:19:35] yeha, if u are on lower internet speed, http is far more faster considering all the scripts that run in the background.. [03:20:17] Wow, its hard to get out of using https once you're in. Silly MW, which part of I don't want to use a secure connection aren't you getting [03:21:12] comets: Personally I'd expect the slower your connection, the less the overhead, since latency would be lower so you're less likely to be waiting on the cpu to encrypt things [03:22:25] bawolff, yeha, had the same problem, asked in -tech a few times to have a global " I want out of https" option to apply to all wikis.. [03:22:44] * bawolff generally likes https, but you know, I need to test things [03:24:51] htps doesn't cache so if i reload my watchlist every minute, it will keep relaoding the same thing/scripts...kinda bad for ppl like me with bad internet speed and limited data ;) [03:28:02] https should cache on modern browsers (I think) [03:28:40] Hmm, you're right. on test.wikipedia.org its still loading flickr improperly when viewing over http [03:30:41] comets: google seems to suggest caching still happens on https http://stackoverflow.com/questions/174348/will-web-browsers-cache-content-over-https [03:31:39] It should be noted that for mediawiki, we always get the browser to check to see if the page has been modified recently. e.g. The browser should never be like - oh i fetched this 10 minutes ago, its probably good [03:35:28] yeha i tested that out a few months ago, cleared my cache, ran my enwiki watchlist on https, took around 560kb of data in the first refresh and the same in the second refresh, then cleared the cache, reseted to http and reloaded my watchlist, adn it took under 500kbs in the first refresh and les that 200kbs the 'refresehs' afterwards....http honestly is better...i don't care about getting hacked, its a wiki account, not my bank account [03:35:29] :P [03:36:07] interesting [03:36:48] Did you refresh by visiting the page again "normally", or be hitting the "refresh" button on the browser toolbar (sometimes browsers do different things between "refreshing" and simply coming back to the page) [03:38:10] comets: I figured out what was wrong with flickr api upload on commons [03:38:43] by refresh i mean 'purge' ..sorry, [03:39:22] sweet, can it be fixed? :D [03:39:25] Well in any case, you're totally right about wiki not exactly being something needing security [03:39:44] yeah, it was just a silly oversight [03:40:08] \o/ [03:46:29] comets: Change is https://gerrit.wikimedia.org/r/148593 . Once that's reviewed and deployed (Should take a couple days at the most. Probably a good chance of it happening tommorow), then the flickr api feature should work at commons [03:48:04] excellent, i figured it was too small a bug to take months to fix.. :) [03:48:36] comets: There's also stuff you could add to your special:mypage/common.js to make it work right now, but probably just easier to wait the day for the config change to land [03:49:28] comets: So basically what happened is we needed to use a different url to access flickr. Bug got fixed in the extension, but the wikimedia config files had a line overriding the flickr url, which everyone forgot about [03:50:45] prefer to wait....lol, u would think they would double check everything before updating the MW software.. [03:51:20] There's lots of updates. Mistakes happen [03:51:20] btw, not related to this but someone mentioned a NEW SUL method which is on its way, anyone knows where i can read about this? :d [03:51:37] SUL finalization? [03:51:52] i believe so.. [03:52:04] one username for all wikis [03:52:05] That's where we're planning to make everyone have global accounts (e.g. No more non-global accounts) [03:52:15] one username to rule them all, and in the darkness bind them [03:52:22] I believe legoktm is working on that project [03:52:31] * legoktm hides [03:52:34] was it Bilbo Brions idea? :P [03:52:48] https://www.mediawiki.org/wiki/SUL_finalization [03:52:49] ahh Legolum :P [03:53:13] https://en.wikipedia.org/wiki/Wikipedia:BLAMEWHEEL says it's Jimmy's fault. [03:53:22] looks like brion got off the hook on this one [03:53:23] legoktm: You should get ready to start hiding, you're going to be the fall guy for having to rename people with conflicting accounts :P [03:54:24] Legolum sounds nice lol...My precioussssssssssssssss [03:54:37] I feel like domas hasn't been blamed for anything in many years [03:55:17] bawolff: also, I had a crazy idea the other day to pitch to you. [03:55:33] * bawolff not sure if I should be excited or run away [03:55:37] he should be replaced with Briondom :P [03:56:28] so, you know how E:GlobalUsage only works for local wikis on the same cluster? I was thinking of how to store usage for wikis using InstantCommons [03:57:00] That would make a bunch of people at commons happy [03:57:40] my idea was that each MW install applies for an API key / token on Commons, and then the remote wiki sends API requests authenticated with the token (and validated by IP range maybe?) to add globalusage entries [03:58:26] sounds reasonable [03:58:28] Also I think this system should be in core. [03:58:37] (And the entire GlobalUsage extension) [03:59:04] Should have some system where commons admins can mass remove some site if they misbehave [03:59:28] revoke the API key and the entries are just ignored [03:59:36] sounds good [03:59:51] I'm not sure about in core. But that could just be because I'm always trying to make things extensions [04:00:52] my rule of thumb is that if it starts with "Global" it should be in core. [04:01:58] GlobalUsage as it currently stands is somewhat Wikimedia centric [04:02:23] but it shouldn't be [04:02:44] foreignfilerepo is in core, why shouldn't tracking usage of files (typically a core thing) be in core too? [04:06:43] No particular reason. I don't think there's any hard lines for what should/should not be in core [04:07:22] mhm [04:07:43] just in my experience a lot of Global* extensions end up replicating core functionality, but never as good [04:07:59] GlobalUsage doesn't really do much of that [04:08:14] or, they mask core's deficiencies because it works on the WMF cluster. [04:08:21] It doesn't do that much of anything beyond putting things in a db table [04:08:33] and queuing jobs when people upload a file [04:08:49] which...is a lot. [04:09:18] perhaps, but that's not really things that are duplicated from core [04:09:39] Although I have a patch for it to totally override Special:WantedFiles [04:10:51] sure it is. when you add a file to a page, core adds it to the imagelinks table, and if you upload a already used file, core queues jobs. [04:11:26] but even if you integrated it into core [04:11:45] core would still have to queue the same jobs for the local imagelinks, and then the jobs for the foreign image links [04:12:27] At best maybe you could merge the globalimagelinks and imagelinks table, and just have local queries make sure that gil_wiki = wfWikiID() [04:15:02] right, you would still need to handle it differently, but the extension wouldn't be doing the functionality that core should provide [04:16:02] The number of people maintaining a wikifarm with a common image host and using LBFactory so that all dbs are accessible from the common image host, is probably pretty low [04:16:57] the number of people running MediaWiki that actually need LBFactory is pretty low ;) [04:17:04] indeed [04:17:21] And half of those that should use LBFactory don't because its horribly documented ;) [04:17:47] So I suppose that's why I think it makes sense as an extension, its just a very specialist use case [04:18:13] But I probably wouldn't overly object to merging into core, I would more consider myself "neutral" [04:18:30] ok :P [04:18:36] are you going to be at Wikimania btw? [04:18:46] yes! [04:18:59] Its my first time going to wikimania, so I'm quite excited [04:19:10] :D [04:20:30] going back to the remote GlobalUsage for InstantCommons...do you think that should go in E:GlobalUsage, or a separate extension like E:RemoteGlobalUsage? [04:21:01] It seems like if it was in a separate extension there would be a lot of duplication [04:21:18] er, an extension on top of E:GlobalUsage [04:21:38] but current global usage is pretty clearly aimed at the LBFactory wikis [04:22:14] hmm. [04:22:18] Maybe there could be something like, if gil_wiki starts with some prefix like 'api:', then its treated as a foreign api wiki [04:22:22] but that kind of sounds hacky [04:22:38] oh, we have $wgLocalDatabases for that. [04:23:27] brb in 5 [04:25:18] Hmm. Ok, and then we could have some other table matching identifiers to information for foreign repos [04:27:26] legoktm: I'm not really following whatever wikidata did with the Site table, but could that be used somehow to make it so that we have non-local site identifiers which WikiMap::makeForeignLink would handle appropriately? [04:30:41] yeah, the sites table is in core actually [04:31:05] Well its in "core", but doesn't seem to be used [04:31:16] yeah >.> [04:31:27] WikiMap still relies on $wgConf unfortunately :/ [04:32:17] Do other global thingies use something other than WikiMap? [04:33:05] not that I'm aware of, I'm guessing Wikidata has their own thing [04:39:21] 3MediaWiki extensions / 3TimedMediaHandler: ?embedplayer=yes videos broken (again) - 10https://bugzilla.wikimedia.org/66143#c21 (10Bawolff (Brian Wolff)) > However, when I tried this out, reusing the
HTML (from this wiki page: > https://meta.wikimedia.org/w/index.php?title=... [04:51:13] huh. Why would a 360p webm transcode take more bandwidth than 720p? [04:52:50] oh perhaps because its a broken file [04:53:22] no that's just firefox being silly [05:17:56] Anyone know anything about the quality settings for webm files [05:18:58] At first glance, it looks like the webm 360p and 480p have way too high quality settings [05:33:52] 3MediaWiki extensions / 3TimedMediaHandler: investigate using a non-fixed bitrate for webm transcodes - 10https://bugzilla.wikimedia.org/68418 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3normal a:3None Currently we use a fixed bitrate for webm (and ogg for that matter) transcodes except for webm 720p... [05:49:07] tgr: Merging things in config without deploying them is iffy :/ [05:49:24] did I do that? [05:49:27] Yup [05:49:38] The flickrApiUrl thing [05:49:47] uh [05:49:54] tgr: Let the SWAT team know they have a change to push, it's OK [05:49:55] didn't think that one through [05:50:10] I don't think it is either [05:50:12] I'll add a note [05:50:16] It's fine, one more patch is OK [05:51:20] Unless we're expecting problems, which it seems like we aren't [05:52:26] Unless more alerts happen, then I'd revert it [05:52:34] But anyway [05:52:40] Bedtime, see y'all tomorrow [05:52:43] if you revert, you have 2 commits to sync... :P [05:53:56] Ugh. [05:54:33] might as well just sync it at that point and say "oops" [06:07:30] (03CR) 10Brian Wolff: Add a maintinance report about TimedText pages that don't have a file (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 (owner: 10Brian Wolff) [06:25:31] (03PS1) 10Brian Wolff: [WIP] Show appropriately sized video sources first. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/148603 [06:27:23] 3MediaWiki extensions / 3TimedMediaHandler: ?embedplayer=yes videos broken (again) - 10https://bugzilla.wikimedia.org/66143#c22 (10Bawolff (Brian Wolff)) > This might be more appropriate for a separate bug - in that case, sorry for > the offtopic discussion. Yeah it is kind of something that should be a se... [06:39:41] (03PS2) 10Nemo bis: [WIP] Show appropriately sized video sources first. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/148603 (owner: 10Brian Wolff) [07:44:09] (03PS1) 10Gergő Tisza: Fix metadata footer positioning in fullscreen mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148607 [08:03:28] (03CR) 10Springle: [C: 031] "Performance isn't too bad using the existing (wiki, timestamp) indexes already on all eventlogging tables. We're adding a adding a coverin" [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/148021 (owner: 10Gergő Tisza) [08:21:00] tgr: are you around ? [08:21:20] matanya: for a short time [08:21:45] you might be interested in http://lu.is/blog/2014/07/22/slide-embedding-from-commons/ [08:21:57] tgr: it is Luis Villa's blog [08:22:51] I don't know if it is technically doable, but it might be a cool feature to implement for re-users. [08:25:01] serving an iframe with the slide plus some viewer script is technically doable, TimedMediaHandler does something similar for the video embed option [08:25:22] as long as there is a good opensource app for that [08:25:31] never used viewerjs [08:31:44] matanya: going to bed now, but it seems like a cool hackathon project, if you know someone who is interested, I would be happy to give advice [08:32:33] thanks a lot tgr [08:44:15] (03CR) 10Nuria: Track loading time for MediaViewer and the file page (031 comment) [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/148021 (owner: 10Gergő Tisza) [09:01:21] 3MediaWiki extensions / 3UploadWizard: Flickr API method=flickr.photos.licenses.getInfo requires SSL, we don't use it - 10https://bugzilla.wikimedia.org/67298 (10Andre Klapper) 5PATC>3RESO/FIX [09:03:06] 3MediaWiki extensions / 3MultimediaViewer: Special characters in target of mmv url are hex encoded in url bar - 10https://bugzilla.wikimedia.org/68372#c20 (10Andre Klapper) 5REOP>3RESO/WON I am closing this report again - see comment 8 and comment 17 for reasons to not change current behavior. [11:17:36] 3MediaWiki / 3Uploading: Can't upload SVG because a filter is present on a image - 10https://bugzilla.wikimedia.org/67044#c2 (10PRO) Yes, it is displayed on upload. [13:34:16] (03CR) 10Gilles: [C: 032] Fix metadata footer positioning in fullscreen mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148607 (owner: 10Gergő Tisza) [13:34:58] (03Merged) 10jenkins-bot: Fix metadata footer positioning in fullscreen mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148607 (owner: 10Gergő Tisza) [13:39:26] (03CR) 10Gilles: Add a maintinance report about TimedText pages that don't have a file (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 (owner: 10Brian Wolff) [13:45:51] 3MediaWiki / 3Uploading: Can't upload SVG because a filter is present on a image - 10https://bugzilla.wikimedia.org/67044#c3 (10Andre Klapper) Sorry but the last comment is ambiguous - do you refer to the time or the place? Is this on Commons? Special:Upload or UploadWizard or both? [14:21:57] (03CR) 10Gilles: [C: 032] Add a maintinance report about TimedText pages that don't have a file [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 (owner: 10Brian Wolff) [14:22:07] (03Merged) 10jenkins-bot: Add a maintinance report about TimedText pages that don't have a file [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 (owner: 10Brian Wolff) [15:27:24] (03PS1) 10Gilles: Bring Media Viewer up to date [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148673 [15:27:27] (03CR) 10jenkins-bot: [V: 04-1] Bring Media Viewer up to date [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148673 (owner: 10Gilles) [15:28:27] (03CR) 10MarkTraceur: [C: 04-1] "Wrong branch, mate!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148673 (owner: 10Gilles) [15:31:21] marktraceur: I know, what's the syntax to force it from command line again? [15:31:25] I should write it down somewhere [15:31:49] ah, it's rejecting it because of "no new changes" [15:33:13] I dunno [15:33:23] I think it's probably something like...basing it off of the branch [15:33:29] But I don't remember [15:33:57] (03PS1) 10Gilles: Bring Media Viewer up to date [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 [15:34:18] (03Abandoned) 10Gilles: Bring Media Viewer up to date [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148673 (owner: 10Gilles) [15:34:31] Yay! [15:35:32] I couldn't find a way to change the branch after the fact [15:35:48] It's fine [15:38:15] (03CR) 10jenkins-bot: [V: 04-1] Bring Media Viewer up to date [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [15:41:33] jenkins-lol [15:41:53] ah, I forgot to update .jshint probably [15:43:36] (03PS1) 10Gilles: Bring Media Viewer up to date [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148685 [15:43:39] (03CR) 10jenkins-bot: [V: 04-1] Bring Media Viewer up to date [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148685 (owner: 10Gilles) [15:43:48] bloody git-review... [15:44:00] (03Abandoned) 10Gilles: Bring Media Viewer up to date [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148685 (owner: 10Gilles) [15:45:10] (03PS2) 10Gilles: Bring Media Viewer up to date [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 [15:45:42] (03CR) 10jenkins-bot: [V: 04-1] Bring Media Viewer up to date [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [15:47:02] (03CR) 10Gilles: "No idea where the QUnit errors are coming from in Jenkins, QUnit tests pass fine in Firefox & Chrome locally." [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [15:59:27] marktraceur, fabriceflorin: When you get set up, there's no hangout link on the calendar for today's meeting [15:59:42] I'd like, please :) [16:00:02] Uh, we are in one [16:00:13] I figured it out [17:00:59] (03PS3) 10Gergő Tisza: Bring Media Viewer up to date. [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [17:01:33] (03CR) 10jenkins-bot: [V: 04-1] Bring Media Viewer up to date. [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [17:06:28] (03CR) 10Gergő Tisza: "Is this just an update to the current code, or was there anything you had to change to make it compatible with 1.23 core?" [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [17:20:15] (03CR) 10Gilles: "I just had to change .toggle( false ) calls to .hide() calls. Everything else is the latest code." [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [17:39:28] (03CR) 10Gergő Tisza: "So it seems:" [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [17:45:38] (03CR) 10Gergő Tisza: "Doesn't work for me, the tests aren't even executed, and MediaViewer is not loaded (the enable preference checkbox is added, so the extens" [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [17:48:55] (03CR) 10Gergő Tisza: "Unknown dependency: json" [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [17:51:47] tgr: I can't reproduce, are you running core on REL1_23? [17:51:55] yes [17:52:02] works fine for me on firefox and chrome [17:52:23] but I did not switch all extensions, so the error message could be unrelated, I am currently checking [17:57:26] meh, forgot to run update.php [17:57:41] but now that I did it I am getting a hundred errors [17:57:57] completely different ones than jenkins [17:58:22] tgr, gi11es: is that commons patch for mwv ready to go? I haven't had time to test myself but if you guys are happy with it as a first attempt I can review and and merge. [17:58:42] bd808: it's waiting for another round of review by you and/or ori [17:58:46] bd808: haven't been able to test [17:58:58] I added the separate /images folder. it's a hack, but the cleanest I could come up with [17:59:07] somehow the DNS redirect for local.wmftest.net is not working for me [17:59:11] Ok. I'll try to get to it "soon" maybe tonight [17:59:13] tgr: have you tried override that host in /etc/hosts? [17:59:22] um, no [17:59:26] I'll do that [18:00:10] tgr: I didn't run update.php Is it supposed to work when going to an older version like REL1_23? [18:00:30] fair question [18:00:42] some of it is just clearing caches etc [18:00:51] but it won't unapply DB changes [18:01:29] shouldn't be a big deal for a client-side extension though [18:01:40] right [18:02:58] there is an uppercase/lowercase issue [18:03:01] with logger.js [18:04:35] that seems to be the only real error, I am getting an assload of other errors, but I think that's just resource loading being broken on my setup somehow [18:05:34] oh yeah, I bet it's that the case change wasn't picked up again [18:05:52] and once again it works for me becaus elocally I have the right case [18:06:20] let's not ever commit a case change again... [18:07:11] aw :( [18:07:24] I wanted to uppercase everything [18:07:39] it's the annoying combination of HFS+ and git [18:08:06] ooh, we are running hhvm on beta [18:08:14] that explains all the breakage [18:10:45] (03PS4) 10Gilles: Bring Media Viewer up to date [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 [18:11:28] (03CR) 10jenkins-bot: [V: 04-1] Bring Media Viewer up to date [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [18:12:06] (03PS5) 10Gergő Tisza: Bring Media Viewer up to date. [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [18:15:19] now it's failing on hide(), makes sense [18:15:23] since it's using core master [18:15:39] (03CR) 10jenkins-bot: [V: 04-1] Bring Media Viewer up to date. [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [18:16:01] tgr: open the full log, the animation thing is a red herring, the real errors happen before [18:16:20] I see [18:16:27] basically now whenever we have errors happening in some of our tests, the animation thing happens afterwards [18:16:33] and you only see that in the summary [18:16:35] well, I guess that means there are no real errors [18:16:45] works for me locally, too [18:16:47] right [18:17:31] the animation thing is random, it did not happen in the last test run for example [18:19:09] (03CR) 10Gergő Tisza: [C: 032 V: 032] "The errors are due to an OOJS UI incompatibility between 1.23 and 1.24. Jenkins runs 1.23 MediaViewer with 1.24 core." [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [18:20:06] tgr: Eurgh, that thing still? :-( [18:20:58] James_F: no real problem, Jenkins just uses the wrong version [18:21:19] tgr: Sure, but ideally humans shouldn't have V+2 rights, so… [18:21:28] jenkins can't really guess that we want it to run core on the same branch as the extension, basically [18:21:39] that's very ideal :) [18:22:12] tgr: random but only seems to happen when there are other errors [18:22:19] I haven't seen it recently on clean runs [18:23:58] gi11es: I suppose it should work the same way as the gerrit config: a text file in the extension root which specifies the branch, and the CI system would checkout the matching core branch [18:25:21] now that I mention it, our .gitreview points to master too [18:25:37] that's why your first patch ended up on the wrong branch I suppose [18:27:16] (03PS1) 10Gergő Tisza: Fix branch in .gitreview [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148725 [18:40:06] fabriceflorin: you said the metadata panel mispositioning is not a blocker for Abbey? [18:40:54] I will only backport to wmf/1.24wmf14 then, the branches are updated tomorrow anyway [18:41:01] (03PS1) 10Gergő Tisza: Fix metadata footer positioning in fullscreen mode [extensions/MultimediaViewer] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148729 [18:41:22] tgr: No, it’s not. We already completed the user studies. [18:41:52] (03CR) 10Gergő Tisza: [C: 032] Fix metadata footer positioning in fullscreen mode [extensions/MultimediaViewer] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148729 (owner: 10Gergő Tisza) [18:43:21] 3MediaWiki extensions / 3TimedMediaHandler: investigate using a non-fixed bitrate for webm transcodes - 10https://bugzilla.wikimedia.org/68418#c1 (10Brion Vibber) I believe the original idea was that 160p, 360p, and 480p transcodes were meant for online streaming viewing and 720p was meant for offline downlo... [18:43:51] 3MediaWiki extensions / 3TimedMediaHandler: investigate using a non-fixed bitrate for webm transcodes - 10https://bugzilla.wikimedia.org/68418#c2 (10Brion Vibber) nitrates -> bitrates *damn you autocorrect* [19:03:05] marktraceur: could you try running curl -v http://commons.wiki.local.wmftest.net/ [19:03:08] ? [19:03:23] I am curious if I am the only one for whom this doesn't work [19:04:01] oh, nevermind [19:04:09] it actually works now [19:04:11] weird [19:04:32] And I don't use vagrant, so... [19:05:23] that's not the point, the WMF nameserver has to resolve this to 127.0.0.1 and that was somehow not happening for me, but it works fine now [19:05:32] Oh, hm. [19:09:53] (03CR) 10jenkins-bot: [V: 04-1] Fix metadata footer positioning in fullscreen mode [extensions/MultimediaViewer] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148729 (owner: 10Gergő Tisza) [19:11:07] gi11es: ^^ apparently it still happens on its own [19:42:56] bd808: how do I update vagrant multiwiki databases? [19:43:19] Umm... there's a way... [19:43:37] * bd808 pokes some thigns [19:44:18] tgr: `mwscript update.php --wiki=loginwiki` [19:44:38] mwscript works mostly like it does in prod [19:45:10] no `--wiki` should operate on the default devwiki install [19:45:39] thanks, that worked [19:46:36] https://www.mediawiki.org/wiki/Manual:Maintenance_scripts seems to suggest this works even without mwscript but it didn't [19:48:07] That probably has something to do with the way the the multiwiki roles stores configuration [19:56:05] Hm, I generated a test image named "Swedes overindulged" [19:56:09] Maybe it's a sign [19:57:49] I. Hate. SAUERKRAUT. [19:57:58] (03PS34) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [19:58:00] That's all I'm really tryin' to say. [19:59:10] (03CR) 10MarkTraceur: "I've fixed the issues, I think." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [19:59:48] That was a massively painful fix. [20:09:16] marktraceur: http://www.swansonvitamins.com/biotta-naturals-sauerkraut-juice-16-9-fl-oz-liquid [20:09:55] a.k.a. gag reflex unit test [20:13:38] Eugh [20:15:59] (03CR) 10jenkins-bot: [V: 04-1] Bring Media Viewer up to date. [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [20:16:52] (03CR) 10jenkins-bot: [V: 04-1] Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [20:18:16] (03CR) 10Gilles: [C: 032 V: 032] Bring Media Viewer up to date. [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148678 (owner: 10Gilles) [20:21:21] 3MediaWiki extensions / 3TimedMediaHandler: Audio thumbnails no longer resize - 10https://bugzilla.wikimedia.org/61981#c2 (10hahnchen) I expect the upright parameter affect the width of audio thumbnails, just like the width parameter does, reverting to its 2013 behaviour. It is recommended that the upright... [20:29:14] ugh, why is there a giant play button on audio files when I do it on Special:expandtemplates [20:29:22] I really hope that doesn't happen on normal pages [20:33:12] fab bollocks [20:33:28] Why do people log out [20:35:24] people existing outside the internet. Crazies [20:38:55] (03CR) 10Hashar: [C: 032] Fix branch in .gitreview [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148725 (owner: 10Gergő Tisza) [20:44:20] (03CR) 10jenkins-bot: [V: 04-1] Fix branch in .gitreview [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148725 (owner: 10Gergő Tisza) [20:45:42] (03CR) 10Brian Wolff: [C: 032 V: 032] "Patch isn't touching any js files, so I don't think it matters quinit fails" [extensions/MultimediaViewer] (REL1_23) - 10https://gerrit.wikimedia.org/r/148725 (owner: 10Gergő Tisza) [20:46:02] That's the spirit, bawolff [20:48:14] I live life on the edge [20:48:31] Good, caching is important [20:49:14] Without caching, the site would fall out of the clouds [20:50:22] pg crap, he didn't give us a gears icon, I think... [20:50:35] Oh, ffs, dropbox [20:56:19] btw, marktraceur, has anyone tried to use wave as a google docs replacement? [20:56:37] ...and retained sanity? [20:56:38] I think not [20:56:52] But it's definitely still around... http://waveinabox.net/auth/signin?r=/ [20:57:17] And free, though the code quality is probably pretty low. [20:57:45] some of the commercial wave descendants are ok-ish for structured notetaking/discussion [20:58:13] I didn't know there *was* such a thing [20:58:29] (as a commercial wave descendant) [20:58:40] I tried rizzoma at some point [20:58:45] there were a few others [20:59:20] it was not great but somewhat useful [20:59:24] Hm. [20:59:28] but that was a long time ago [20:59:50] not sure how much of that is shared with apache wave, but might be worth a shot [21:04:02] ugh. https://commons.wikimedia.org/w/index.php?title=Commons:Sandbox&oldid=129716983 doesn't look right [21:11:52] marktraceur: where is the analytics/multimedia repo on stat1003? is the one in your home dir the live one? [21:12:07] Uhhh...I think so. [21:12:13] gi11es messed with it, I'm not sure anymore [21:12:15] Sorry -.- [21:12:22] 3MediaWiki extensions / 3UploadWizard: beta labs: problem storing temporary file - 10https://bugzilla.wikimedia.org/68476 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16024 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16024&action=edit temp file issue All day today... [21:12:30] His crontab has the gory details, if you can get at it... [21:12:43] I don't think I have root there [21:12:54] Yeah [21:13:07] We...should fix it [21:13:37] indeed [21:13:46] are SQL errors logged somewhere? [21:13:51] Eh [21:14:02] Not really sure, probably not though. This is all sort of hacked together. [21:15:11] as a short-term solution, until gi11es gets back, if I just check out in my own home and run from there, that should work, right? [21:15:21] I just need to set REMOTEUSERHOME? [21:15:28] I think so. [21:15:50] uh [21:16:11] apparently only gi11es has write right for the public dataset files [21:16:31] Well that's just...great [21:16:47] Maybe it's time to ask -analytics to reset the permissions or something [21:21:01] do you know which sql host the scripts are using? [21:21:28] we should really come up with a scheme where all the config details are not hidden in personal files... [21:22:24] tgr: I think analytics-store. [21:22:35] And yeah that would be super. [21:25:51] (03PS1) 10Gergő Tisza: Use correct DB for optout queries [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/148838 [21:28:38] 3MediaWiki extensions / 3TimedMediaHandler: Play button is over top of controls since z-index change - 10https://bugzilla.wikimedia.org/68479 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3normal a:3None Since 3bc774a6ccb30ac6, there is now a giant play button over top of the play controls for audio fil... [21:42:00] (03PS1) 10Gergő Tisza: Record optout stats for users with 1+ edits and 100+ edits [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/148842 [21:47:39] Can I just say [21:47:43] What is with styling HTML buttons [21:47:48] They're fine the way they are [21:47:53] * marktraceur rages [21:49:46] (03PS1) 10Gergő Tisza: Add generated files to .gitignore [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/148845 [21:55:05] 3MediaWiki extensions / 3TimedMediaHandler: Play button is over top of controls since z-index change - 10https://bugzilla.wikimedia.org/68479#c1 (10Brion Vibber) I've also seem some issues with those play buttons floating over other files' popup players, looks like related bad z-index to me. See at https://... [21:55:17] welcome to z-index hell \o/ [21:56:19] Which is to say, welcome to z-indexes [21:57:20] hehe [22:11:17] heh, WebDriver for Chrome is a z-index nazi, WebDriver for Firefox is like "whatever, dude, I'll click it" [22:11:35] fabriceflorin: Are the texts on the mingle card for the viewing options panel accurate right now? [22:11:52] (I thought there was some discussion about "View quickly" but I could be wrong) [22:22:38] marktraceur: we have a czwiki in the dashboard DB list but apparently no such wiki exists [22:22:44] it just redirects to cs [22:22:51] is that something that was changed recently? [22:23:14] ...huh [22:23:16] News to me [22:23:55] marktraceur: Pete is still complaining about "View quickly" [22:24:03] but that's easy to change later [22:24:05] Ugh [22:24:23] Or we could just do it right the first time? :D [22:24:34] Too much to hope for, I know [22:24:35] once the performance dashboards are up, it will be easier to decide whether it's quickly or not [22:25:26] on that note, wanna review https://gerrit.wikimedia.org/r/#/c/148024/ ? :) [22:31:20] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer ignores EXIF rotation - 10https://bugzilla.wikimedia.org/68320#c7 (10Brion Vibber) (In reply to Tisza Gergő from comment #6) > I suppose tho goal was to save storage space when the thumbnail and the > original would be exactly the same. It makes the URL... [22:45:35] marktraceur: seems like the dashboard query stuff is actually run on stat1001, not stat1003 [22:45:47] which I don't even have access to :/ [22:46:49] What [22:47:16] http://multimedia-metrics.wmflabs.org/dashboards/mmv [22:47:19] tgr: The queries are run on 1003, the data gets rsync'd from 1003 to 1001 periodically [22:47:34] /a/public-datasets should have the data on 1003 [22:47:35] oh, hm [22:47:38] Or something like that [22:47:53] now that you say, I recall you mentioning that earlier [22:49:27] how frequently does the rsync run? [22:50:10] (03PS2) 10Gergő Tisza: Record optout stats for users with 1+ edits and 100+ edits [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/148842 [22:50:13] (03PS2) 10Gergő Tisza: Add generated files to .gitignore [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/148845 [22:50:19] Uh, I think 10 minutes. [22:51:44] (03Abandoned) 10Gergő Tisza: Add generated files to .gitignore [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/148845 (owner: 10Gergő Tisza) [23:00:53] (03PS1) 10MarkTraceur: WIP Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 [23:01:32] (03CR) 10jenkins-bot: [V: 04-1] WIP Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [23:17:12] (03CR) 10Gergő Tisza: [V: 032] Fix metadata footer positioning in fullscreen mode [extensions/MultimediaViewer] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148729 (owner: 10Gergő Tisza) [23:53:28] (03CR) 10Neilk: [C: 04-1] "Uploading from Flickr does not work at all. In the "upload" step, one can get an image from Flickr, but the "Continue" button doesn't work" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur)