[08:25:11] hi marktraceur are you around? this might be an interesting failure, MMC on mw.o performance https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MultimediaViewer-mediawiki.org-linux-firefox-sauce/87/console [08:25:19] MMV, even [09:27:54] 3MediaWiki extensions / 3GlobalUsage: Mispositioned magnify icon on Special:GlobalUsage - 10https://bugzilla.wikimedia.org/69215 (10Fomafix) 3NEW p:3Unprio s:3trivia a:3None Mispositioned magnify icon on [[Special:GlobalUsage]]. Reason: class="mw-content-ltr" is missing. [09:30:52] 3MediaWiki extensions / 3GlobalUsage: Mispositioned magnify icon on Special:GlobalUsage - 10https://bugzilla.wikimedia.org/69215#c1 (10Fomafix) Created attachment 16147 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16147&action=edit Screenshot of GlobalUsage [09:45:55] 3MediaWiki extensions / 3UploadWizard: {{PD-art-100}} not accepted by custom license field - 10https://bugzilla.wikimedia.org/69217 (10Vera de Kok) 3UNCO p:3Unprio s:3normal a:3None The license {{PD-art-100}} is not recognized as a valid option by the "Another reason not mentioned above" option. It... [09:46:22] 3MediaWiki extensions / 3UploadWizard: {{PD-art-100}} not accepted by custom license field - 10https://bugzilla.wikimedia.org/69217#c1 (10Vera de Kok) Created attachment 16148 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16148&action=edit License not accepted [10:16:37] 3MediaWiki extensions / 3UploadWizard: Upload hangs after "describe" step - 10https://bugzilla.wikimedia.org/64698#c1 (10Katie Chan) Not only applicable when uploading PNGs. It happens to me all the time while uploading JPEGs. Size of the images may contribute to the problem though. [10:56:24] 3MediaWiki extensions / 3GlobalUsage: Mispositioned magnify icon on Special:GlobalUsage - 10https://bugzilla.wikimedia.org/69215 (10Fomafix) a:3Fomafix [11:54:37] 3MediaWiki extensions / 3GlobalUsage: Mispositioned magnify icon on Special:GlobalUsage - 10https://bugzilla.wikimedia.org/69215 (10Andre Klapper) p:5Unprio>3Normal [12:27:48] I've noticed those perf failures happening occasionally since last week. it's a bit strange because we have barely changed anything on mediaviewer recently [12:27:53] http://multimedia-metrics.wmflabs.org/dashboards/mmv#media_viewer_vs_file_page-graphs-tab bottom graph [12:28:13] worth keeping an eye on in the coming days to see if they're just isolated spikes [12:31:09] nothing worrying on the eventlogging front anyway [12:52:20] (03PS4) 10Gilles: [WIP] Minimal Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 [12:53:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Minimal Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 (owner: 10Gilles) [13:01:03] (03PS5) 10Gilles: [WIP] Minimal Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 [13:01:37] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Minimal Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 (owner: 10Gilles) [13:03:44] (03PS6) 10Gilles: [WIP] Minimal Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 [13:17:23] 3MediaWiki extensions / 3MultimediaViewer: "View terms" should switch to "Hide terms" once clicked - 10https://bugzilla.wikimedia.org/69233 (10Thehelpfulone) p:5Unprio>3Normal [13:17:24] 3MediaWiki extensions / 3MultimediaViewer: "View terms" should switch to "Hide terms" once clicked - 10https://bugzilla.wikimedia.org/69233 (10Thehelpfulone) 3NEW p:3Unprio s:3enhanc a:3None Very minor thing, but when I clicked "View terms", I expected to be able to click it again to hide the terms.... [13:21:04] (03PS7) 10Hashar: [WIP] Minimal Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 (owner: 10Gilles) [13:21:14] (03CR) 10Hashar: "dummy commit, Zuul got broke." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 (owner: 10Gilles) [13:21:40] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Minimal Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 (owner: 10Gilles) [13:28:55] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 (owner: 10Gilles) [13:38:47] (03PS8) 10Gilles: [WIP] Minimal Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 [13:39:21] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Minimal Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 (owner: 10Gilles) [13:45:22] (03PS9) 10Gilles: [WIP] Minimal Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 [13:45:59] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Minimal Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 (owner: 10Gilles) [14:01:39] 3MediaWiki extensions / 3GWToolset: Make C0 and C1 control characters into their windows-1252 interpretation automatically - 10https://bugzilla.wikimedia.org/69236 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3normal a:3None See also bug 68724. After listening to Fae's comments about encoding troubles... [14:03:37] 3MediaWiki extensions / 3GWToolset: GWToolset should assume non unicode characters are windows-1252 not iso 8859-1 - 10https://bugzilla.wikimedia.org/68724#c7 (10Bawolff (Brian Wolff)) I kind of changed my mind about this. See bug 69236 [14:06:24] 3MediaWiki extensions / 3MultimediaViewer: Use of SVG nominal size in MMV - 10https://bugzilla.wikimedia.org/69237 (10Tim Starling) 3NEW p:3Unprio s:3normal a:3None MultimediaViewer of an SVG with a small nominal size looks a bit ridiculous, e.g. https://www.mediawiki.org/wiki/User:Zven#mediaviewer/... [14:09:30] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/152554 [14:25:43] 3MediaWiki extensions / 3GWToolset: WikiImporter is not creating TemplateData when importing a Template - 10https://bugzilla.wikimedia.org/69241 (10dan) 3NEW p:3Unprio s:3normal a:3None While trying to import the Artwork Template for a GWToolset test it imports the template, but does not create the T... [15:38:02] Uhhh...can someone tell Fabrice that we can't deploy a damn thing "in coming days"? [15:38:12] Ugh, fine, on the bug [15:40:14] what was requested to be deployed? [15:40:29] The config change [15:40:53] The actual implementation will take...what, five minutes? [15:48:16] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 (owner: 10Gilles) [15:53:31] gi11es: How did the media viewer discussion go? [15:54:19] well, the idea of a better separation of concerns between media viewer and the file page was popular [15:55:08] something interesting that came up in terms of how media viewer is used, is that several people keep it turned on but bypass it with ctrl+click most of the time [15:55:35] i.e. they don't want to fully disable it, because when they're reading articles as a reader, it's nice to use to browser between images [15:55:37] Right [15:55:48] but when they're doing editing/more involved tasks, it gets in the way [15:55:49] gi11es: This is where I come back to the idea about a hover effect on thumbnails [15:56:05] right, we've shown them the various flavours of that pau designed [15:56:15] Oh, I didn't see those [15:56:28] lemme try to find a link... [15:57:01] http://pauginer.github.io/prototypes/media-viewer/desk/mv-integration/index.html [15:57:06] But it's too complex [15:57:14] https://docs.google.com/a/wikimedia.org/presentation/d/1ykHWG8-LyY4u6AhFeMe8TshTdSDTfpxjz2j8tQGJmWg/edit#slide=id.g39154660f_0162 [15:57:23] there's a bigger hover one as well [15:57:31] right, the one you've linked to [15:57:58] Naw, I'm thinking even bigger [15:58:00] I agree with fabrice that we should leave this aside for now, while we still have campaigns against media viewer's default status [15:58:07] Right. [15:58:19] because if we start messing with thumbnails in this climate... we're not going to make friends [15:58:32] Fucking politics man. [15:58:33] event if it tests well from a UX standpoint, which is TBD [15:59:25] something else that came up is that GLAMs would like to keep their name visible. should be the case in minimal media viewer in the author/source section [15:59:47] they mentioned GLAM logos, I guess that's something to think about when we can extract that from structured data in the future [16:00:31] Ugh [16:00:43] luis confirmed that credits area + caption + license summary should is enough, so that's good news [16:00:48] *should be [16:00:51] Yeah [16:01:12] If we aren't legally required to show the institution it sounds like just added clutter [16:02:41] right now we have a link to the institution's site as the source, I think that's enough [16:02:51] it's just that the samples we showed during the slideshow weren't that kind [16:08:53] we also had a good chat about zoom with Dschwen [16:09:29] the plan is to set him up with vagrant, gerrit, etc. to show him that contributing an actual media viewer patch instead of writing a gadget isn't as scary as it looks :) [16:09:43] Heh [16:09:54] gi11es: Weren't we going to finish the plugin interface for that? [16:09:59] so that even if he wants to build zoom for media viewer and not put it inside media viewer proper, he could develop the hooks he needs himself [16:10:09] I hear that mediawiki-vagrant is pretty cool stuff [16:10:22] bd808: has he come visit you? [16:10:53] marktraceur: well, not sure when that's going to happen, and he seems pretty keen on working on zoom now [16:11:14] gi11es: Maybe? I've had a stead stream of mwv folks at my table [16:11:20] *steady [16:11:23] bd808: it's the bee's knees. the cat's pyjamas. [16:11:31] gi11es: I have two open WIP patchsets [16:11:33] bd808: did he look like this? https://commons.wikimedia.org/wiki/User:Dschwen#mediaviewer/File:User_Dschwen_SF.jpg [16:11:35] shucks [16:11:49] Yeah! He just left [16:11:52] awesome [16:12:35] marktraceur: also, in case you missed my commits earlier, a working prototype is up on alpha, with some stubs for specific features [16:12:39] based on pau's latest designs [16:12:41] * marktraceur doesn't need no Wikimania. There are omelettes here. [16:12:48] gi11es: I did, it seems neat [16:12:50] A few issues [16:13:36] bugs? the main thing I've noticed is a blank tipsy thing that appears in the top-left corner [16:13:47] I think I've narrowed it down but it's not a straightforward fix [16:13:55] gi11es: The download dialog never closes from what I can see [16:14:08] if you click on it, it does [16:14:15] did you expect it to go away after a certain amount of time? [16:14:18] we can add that [16:14:32] Ohhh. [16:14:42] gi11es: Clicking outside the dialog, actually. [16:14:47] ooooh ok [16:14:48] good point [16:14:58] Or on the icon again, like with "use this file" [16:15:22] yep, will add that in [16:15:24] good idea [16:16:11] The problem is that the icon is currently the "download" button [16:29:20] * marktraceur brainstorms what tangled mess of UW to tackle next [16:31:04] I guess more models. [16:53:08] gi11es, pginer, aripstra is *on* the team list. [16:53:11] Cool yer jets. [16:53:37] I'm just going to CC her one more time just in case [16:53:53] maybe print the email thread and bring it physically to her too [16:54:08] Heh [16:54:28] gi11es: Take a picture of your screen with the email up, print it out, scan the picture, and put it up on Geocities. [16:55:33] http://thedailywtf.com/articles/web_0_0x2e_1.aspx [16:56:22] haha [16:56:59] Ah man, remember when frames were just part of normal web design [18:32:04] Huh, now I look at it, the license classes are actually pretty good [18:53:52] 3MediaWiki extensions / 3GWToolset: GWT duplicates - 10https://bugzilla.wikimedia.org/64831#c8 (10Steinsplitter) 5PATC>3RESO/FIX Thank you [19:52:37] 3MediaWiki extensions / 3UploadWizard: {{PD-art-100}} not accepted by custom license field - 10https://bugzilla.wikimedia.org/69217#c2 (10Mark Holmquist) 5UNCO>3NEW This is because the API module in core doesn't follow redirects for its getCategories call. I'll discuss with Krinkle, but this should be fi... [20:19:17] (03PS1) 10MarkTraceur: Redirect on all template calls [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152817 (https://bugzilla.wikimedia.org/69217) [20:20:37] 3MediaWiki extensions / 3UploadWizard: {{PD-art-100}} not accepted by custom license field - 10https://bugzilla.wikimedia.org/69217#c4 (10Mark Holmquist) I just fixed it for UW. Slightly less performant, but not by much. [20:45:23] 3MediaWiki extensions / 3UploadWizard: Upload hangs after "describe" step - 10https://bugzilla.wikimedia.org/64698#c2 (10Mark Holmquist) Katie, do the files also have big descriptions? Can you provide us with a log of any API requests that UW makes in these cases? Or an example image that causes the problem? [20:47:52] 3MediaWiki extensions / 3UploadWizard: UploadWizard hangs browser on entering image description - 10https://bugzilla.wikimedia.org/54994#c19 (10Mark Holmquist) Could this be bug 33607 in disguise? [20:48:22] 3MediaWiki extensions / 3UploadWizard: Unexpected freezing of browser after hightlighting from the description field and/or pulling scroll on the bottom right to extend the field - 10https://bugzilla.wikimedia.org/68807#c5 (10Mark Holmquist) This sounds a lot like bug 33607... [20:49:07] 3MediaWiki extensions / 3UploadWizard: Upload Wizard crashes Safari when using long description texts - 10https://bugzilla.wikimedia.org/33607#c28 (10Mark Holmquist) There are a few more reports of similar problems, so I guess this never got fixed. I still haven't been able to reproduce the issue, though.... [20:55:36] Whoa, I spoke too soon. Expanding the description textarea in the browser definitely breaks it. [21:02:36] marktraceur: the bug rillke found repro steps for? [21:02:45] Yeah [21:02:58] And probably that whole string of related bugs [21:05:56] should I try other browser/ OS? [21:06:12] btw, where are you? [21:06:56] and should I try to track this down? [21:09:00] rillke: I'm in San Francisco [21:09:06] I'm looking at it now [21:10:23] oh, they left you in SF, whom to blame for that? [21:10:56] rillke: General policy. If you want to vent at someone, find Eloquence :) [21:12:26] He's always hiding. Saw him once in the botanical garden green house [21:16:56] Hrm...it's probably growTextArea [21:17:40] Yeah, guaranteed. [21:17:47] Fuck that method anyway, I don't see any need for it. [21:20:02] indeed modern browsers have resizers [21:20:05] (03PS1) 10MarkTraceur: Remove growTextArea [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152824 (https://bugzilla.wikimedia.org/33607) [21:20:10] {{done}} [21:20:14] don't try to be overly smart is a good rule [21:20:30] rillke: This *is* UploadWizard we're talking about... :) [21:20:34] (03CR) 10jenkins-bot: [V: 04-1] Remove growTextArea [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152824 (https://bugzilla.wikimedia.org/33607) (owner: 10MarkTraceur) [21:21:11] so a wizard must be smart ? [21:21:18] or wizardy [21:22:36] * marktraceur finds a hat [21:30:01] Argh jenkins [21:32:16] was the goal to do something like http://www.jacklmoore.com/autosize/ ? [21:32:39] gi11es: Exactly [21:32:56] why not switch to a better one, like this? [21:33:08] Dunno [21:33:13] I mostly want to fix the bug [21:33:21] I don't really want the feature, I don't think it's that important. [21:33:39] well... users who type long descriptions might disagree [21:34:32] it's not the most essential thing, but if another plugin is bug-free and just as easy to apply, why not use it? [21:35:26] Sure [21:37:25] gi11es: That plugin breaks the manual resize for me [21:37:30] I can't expand it down. [21:38:01] ah, well. maybe there's a better one? that was just the first google result I stumbled upo [21:38:34] * marktraceur will look. [21:39:12] Oooh wait [21:39:18] I bet I know what the issue is [21:40:13] Hm, no. [21:40:24] Thought there was a cycle of resize events and keyup events [21:46:20] gi11es: Doesn't seem to be anything different out there. [21:46:25] At least not at my first pass. [21:46:43] jquery plugin sites are apparently cesspools. [21:47:14] in that case, I'm ok to remove it, we'll revisit the options if people complain about the loss of functionality [21:52:49] We'll wait until Jenkins gets back I guess [22:00:45] (03CR) 10Rillke: Remove growTextArea (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152824 (https://bugzilla.wikimedia.org/33607) (owner: 10MarkTraceur) [22:01:11] (03CR) 10Rillke: "So I suggest just to test whether there is css height set and to do nothing in this case." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152824 (https://bugzilla.wikimedia.org/33607) (owner: 10MarkTraceur) [22:35:22] rillke: You think just check .css( 'height' )? [22:37:20] Seems to work [22:37:42] (03PS2) 10MarkTraceur: Check for CSS height in growTextArea [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152824 (https://bugzilla.wikimedia.org/33607) [22:41:55] (03PS1) 10Rillke: Fix unresponsive browser on auto-growing input [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152830 (https://bugzilla.wikimedia.org/33607) [22:42:42] (03CR) 10Rillke: [C: 04-1] "Sorry missed to see this in time and did I8e46af40f28baf7002fe35586ea5e" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152824 (https://bugzilla.wikimedia.org/33607) (owner: 10MarkTraceur) [22:43:30] rillke: Will *any* styling affect it, or just height/ [22:43:31] ? [22:44:06] marktraceur, there is only styling if there is height [22:44:28] Hm, not future-proof though [22:44:57] .style.height would be better [22:45:07] will you do in your patchset ? [22:45:20] rillke: I like your commit message better :) go ahead [22:45:37] .style.height is "" for unset height and has a value if set [22:46:02] * rillke sounds like being drunken this evening [22:46:30] Just change it to style.height and I'll merge. [22:46:51] (03PS2) 10Rillke: Fix unresponsive browser on auto-growing input [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152830 (https://bugzilla.wikimedia.org/33607) [22:48:13] (03CR) 10MarkTraceur: [C: 032] "Thanks rillke!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152830 (https://bugzilla.wikimedia.org/33607) (owner: 10Rillke) [22:48:17] So, done. Have to go to my hostle now so Jack the ripper doesn't capture me. Good night. [22:48:21] and thank you! [22:48:22] KK [22:48:27] Get home safe, cheers :) [22:48:40] (03Merged) 10jenkins-bot: Fix unresponsive browser on auto-growing input [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152830 (https://bugzilla.wikimedia.org/33607) (owner: 10Rillke) [22:48:48] (03Abandoned) 10MarkTraceur: Check for CSS height in growTextArea [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152824 (https://bugzilla.wikimedia.org/33607) (owner: 10MarkTraceur) [23:11:20] hi marktraceur [23:12:43] marktraceur: I've been busy with my other projects and some visitors this week. Since you are doing the most with UW by far, I was wondering if we could coordinate what we're doing [23:13:21] marktraceur: I'm supposed to be writing tests for the existing UW, but you're changing a lot so that seems like a moving target right now. But, also changing it so it's much more testable usually [23:13:54] marktraceur: I could be following after you and writing tests or just picking tasks off Mingle or Phabricator or whatever is the thing now [23:14:28] marktraceur: or or we could agree on rough plans and start doing similar stuff together [23:15:04] marktraceur: I realize that's kind of sandbagging you if you want to move fast, I don't think it has to be heavy coordination. It could be a list of stuff to eliminate & replace with events for instance [23:21:57] neilk_: I don't really have a task list, I'm just sort of...doing [23:22:12] neilk_: We can talk about plans for sure though [23:24:12] marktraceur: ok but there's a general pattern you're following I think [23:24:32] Rrrroughly [23:24:42] neilk_: I've been grabbing low hanging fruit, mostly [23:24:56] The grander pattern is "move towards MVC" [23:25:10] well given last week's discussion on coupling, and the general movement towards more testable code, maybe eliminating some of the dumber ways the components communicate [23:25:40] like, some things poll, some things use $.trigger, some things use callbacks. I would say change it all to EventEmitter or callbacks [23:26:13] MVC means different things to different people :) [23:26:13] Right [23:26:19] Well true. [23:26:43] neilk_: I want the steps to be easier to work with at first, but I'm sort of spinning my wheels right now figuring out the next way to go [23:26:59] ok well perhaps we can do that together. Want to talk about this Friday? [23:27:07] Sure! [23:27:19] I'll be around here all day, drop in anytime :) [23:27:32] heh [23:28:10] ok I am deep in some postgres stuff right now (another project) but I'll review stuff tonight & chat with you tomorrow morning [23:28:22] Sure sure