[07:17:23] 3MediaWiki extensions / 3GWToolset: GWtoolset throws database error "1205 Lock wait timeout exceeded" - 10https://bugzilla.wikimedia.org/63818#c13 (10dan) 5PATC>3RESO/FIX assuming that this is no longer an issue with https://gerrit.wikimedia.org/r/#/c/127839/ applied ... [09:55:11] 3MediaWiki extensions / 3MultimediaViewer: No indication that file shown is up for deletion and thus may actually not be free - 10https://bugzilla.wikimedia.org/69389 (10Lupo) 3NEW p:3Unprio s:3normal a:3None When a file that has a license but is up for deletion, there is no clear indication in the m... [10:14:25] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer shows incomplete Permission field - 10https://bugzilla.wikimedia.org/69392 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Compare the following two pages: Media Viewer: https://he.wikipedia.org/wiki/%D7%A9%D7%A8%D7%99%D7%AA_%D7%97%D7%... [14:17:57] Hm, I don't think neilk ever sent me the thing he was going to write. [14:40:46] Curses, missed him. [15:07:09] Hm, I didn't get signed out of Mingle. [15:07:15] I wonder if they fixed it. [15:25:20] (03PS5) 10MarkTraceur: Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 [15:51:20] (03PS3) 10MarkTraceur: Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 [15:51:29] Ohai neilk_ [15:51:39] marktraceur: hi [15:51:51] (03CR) 10jenkins-bot: [V: 04-1] Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 (owner: 10MarkTraceur) [15:51:59] What's up? [15:52:34] nothing :( [15:52:40] (03PS4) 10MarkTraceur: Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 [15:52:55] neilk_: I think you had hinted at writing up a plan, but then I didn't hear anything more :) [15:52:58] I promised some sort of strategy thing friday but I ended up fixing my other project, sorry. [15:53:00] Aha [15:53:03] It's OK :) [15:53:20] I think I'm going to dive headfirst into an Upload step controller/UI thing [15:53:24] ok [15:53:36] Seems like it might not suck too much [15:53:40] maybe i'll just work on selenium testing? [15:53:58] That could work :) [15:54:14] marktraceur: do you guys pick tasks off the mingle...? it doesn't seem to have much relationship to what people actually do [15:54:33] but perhaps this is an odd month, with summer and wikimania [15:54:36] neilk_: Only for the UW stuff, because I'm basically playing it by ear [15:54:47] i get that sense [15:54:59] well i guess this is our chance to be awesome [15:55:11] I Really Probably Should fix that and add cards for these things. [15:55:46] I find agile-ish methods tends to be really bad at dealing with refactoring [15:55:51] a lot of it is playing by ear as you say [15:56:20] (03PS3) 10MarkTraceur: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 [15:56:24] True [15:56:36] (03CR) 10MarkTraceur: "Rebase." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [15:56:46] (03CR) 10jenkins-bot: [V: 04-1] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [15:57:53] (03PS4) 10MarkTraceur: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 [16:06:23] (03PS1) 10MarkTraceur: Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 [16:07:08] (03CR) 10jenkins-bot: [V: 04-1] Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 (owner: 10MarkTraceur) [16:08:58] (03PS2) 10MarkTraceur: Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 [16:09:00] Need more coffee. [16:52:05] (03PS10) 10Pginer: [WIP] Minimal Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 (owner: 10Gilles) [16:52:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Minimal Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 (owner: 10Gilles) [16:55:42] Hm. [16:55:57] Well now I'm thinking about invalidating the UploadList work [16:56:05] By just using an array passed around [17:06:03] Eh whatever, I can tear the promises stuff out of that patchset...probably [17:11:29] wb tgr [17:11:33] Did you make it back to SF? [17:11:55] Oh, no, you're staying in Europe for a bit [17:12:43] still in the UK, actually [17:13:19] one more day of vacation left [17:13:30] sleeping this one through, though [17:21:27] *nod* [18:30:50] (03CR) 10Rillke: "Thanks so far for the code-review." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [19:27:42] (03PS1) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [19:27:46] (03CR) 10jenkins-bot: [V: 04-1] Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [19:28:01] Is there no pleasing you, Jenkins [19:28:22] (03CR) 10MarkTraceur: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [19:32:46] ....sigh [19:32:59] That doesn't make any sense, I'm just leaving it [19:38:08] 3MediaWiki extensions / 3TimedMediaHandler: Audio does not stop playing after clicking close button - 10https://bugzilla.wikimedia.org/69408 (10Mark Holmquist) 5UNCO>3NEW [19:42:45] Well, at least I can reproduce [19:55:28] GILLES BROKE IT [19:56:27] Er, probably [19:59:01] Definitely. [19:59:01] (03PS1) 10MarkTraceur: Pause video/audio when closing dialog [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/153438 (https://bugzilla.wikimedia.org/69408) [20:06:24] (03CR) 10Nikerabbit: "Unfortunately I do not have any useful data about language detection (like comparison of different algorithms and accuracy of them with tw" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [20:14:38] (03CR) 10Gilles: [C: 032] Pause video/audio when closing dialog [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/153438 (https://bugzilla.wikimedia.org/69408) (owner: 10MarkTraceur) [20:14:45] (03Merged) 10jenkins-bot: Pause video/audio when closing dialog [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/153438 (https://bugzilla.wikimedia.org/69408) (owner: 10MarkTraceur) [20:15:53] 3MediaWiki extensions / 3TimedMediaHandler: Audio does not stop playing after clicking close button - 10https://bugzilla.wikimedia.org/69408#c3 (10Mark Holmquist) 5PATC>3RESO/FIX Gilles is vindicated. [20:30:02] I think I'm going to stop trying to be useful right now; I'm very tired [20:30:07] I'll be back on later though [20:30:38] and I'm going to review the backlog of changesets tomorrow [20:30:43] *try to [21:26:41] 3MediaWiki extensions / 3MultimediaViewer: Zoom and scroll gestures unusable on mobile browsers - 10https://bugzilla.wikimedia.org/69414 (10Zack Weinberg) 3UNCO p:3Unprio s:3critic a:3None On smartphones and other devices with small screens, it's essential to be able to zoom into and scroll around im... [21:32:53] 3MediaWiki extensions / 3MultimediaViewer: Zoom and scroll gestures unusable on mobile browsers - 10https://bugzilla.wikimedia.org/69414 (10Sumana Harihareswara) p:5Unprio>3High [21:33:26] gi11es: tgr https://bugzilla.wikimedia.org/show_bug.cgi?id=69414 [21:34:16] marktraceur: ^^ [21:34:38] sumanah: I don't see that as high; we don't have the extension enabled on the mobile site AFAIK [21:35:05] interesting - do you know why the user saw that behavior then? [21:35:12] Probably pretending to be a laptop [21:35:36] * marktraceur will wait for brion to test. [21:36:53] 3MediaWiki extensions / 3MultimediaViewer: Zoom and scroll gestures unusable on mobile browsers - 10https://bugzilla.wikimedia.org/69414#c1 (10Sumana Harihareswara) Zack, can you provide the URL(s) of the page(s) where you saw this behavior? Basically to check whether it was an m.* URL or a "regular" (deskto... [21:36:59] ok looks like the mobilefrontend photo overlay is fine [21:37:04] but desktop MMV on an ipad is a little funky [21:37:14] pinch-zoom works but panning doesn’t do as expected [21:37:33] it’ll pan left-right but up-down just moves the details panel [21:41:41] lemme test on a phone in case it’s doing something weirder than the ipad [21:43:38] 3MediaWiki extensions / 3MultimediaViewer: Zoom and scroll gestures unusable on mobile browsers - 10https://bugzilla.wikimedia.org/69414#c2 (10Zack Weinberg) I did all the above testing with m.* URLs: http://en.m.wikipedia.org/wiki/Orthodox_cross#/image/File:ChurchMilitant_(detail_01).jpg http://en.m.wikipe... [21:44:38] 3MediaWiki extensions / 3MultimediaViewer: Zoom and scroll gestures unusable on mobile browsers - 10https://bugzilla.wikimedia.org/69414#c3 (10Zack Weinberg) Created attachment 16167 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16167&action=edit screen shot, iPhone, zoomed out [21:44:39] seems slightly funkier on an iphone but still workable [21:44:53] 3MediaWiki extensions / 3MultimediaViewer: Zoom and scroll gestures unusable on mobile browsers - 10https://bugzilla.wikimedia.org/69414#c4 (10Zack Weinberg) Created attachment 16168 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16168&action=edit screen shot, iPhone, zoomed in [21:45:57] Sounds like it's not MMV [21:48:00] yeah that’s MF [21:48:07] Moved the bug [21:48:10] gl;hf