[00:27:41] 3MediaWiki extensions / 3UploadWizard: Skip tutorial does not set user preference in Chrome and Firefox - 10https://bugzilla.wikimedia.org/70303#c6 (10Neil Kandalgaonkar) It's true that in the code, we do not block on preference setting before going to the next step in the UploadWizard. So if you're very q... [00:33:43] 3MediaWiki extensions / 3UploadWizard: Skip tutorial does not set user preference in Chrome and Firefox - 10https://bugzilla.wikimedia.org/70303#c7 (10Chris McMahon) If we can't guarantee that the preference gets set then we should delete the test for it. Alternately, let's just not set the preference at al... [00:55:27] 3MediaWiki extensions / 3UploadWizard: Skip tutorial does not set user preference in Chrome and Firefox - 10https://bugzilla.wikimedia.org/70303#c8 (10Neil Kandalgaonkar) We're not going to drop a feature because we're having problems testing it. I think your first suggestion is better; maybe this is not br... [01:27:30] (03PS1) 10Neilk: Feature is not reliably browser-testable; remove [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158041 [01:29:12] 3MediaWiki extensions / 3UploadWizard: Skip tutorial does not set user preference in Chrome and Firefox - 10https://bugzilla.wikimedia.org/70303#c9 (10Neil Kandalgaonkar) Okay I removed the related automated test. I don't seem to have the authority to mark this a WONTFIX, but that's my recommendation. [04:59:27] 3MediaWiki / 3File management: GIF Issues (tracking) - 10https://bugzilla.wikimedia.org/16456 (10Bawolff (Brian Wolff)) [05:22:56] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer should display licensetpl_attr instead of author when set (by {{Credit line}} and other templates) - 10https://bugzilla.wikimedia.org/65445#c15 (10Erik Moeller) *sigh* It's actually a bit more complex, as currently explained on the talk page. At the fi... [05:57:02] marktraceur: I'm not sure that https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/828 works. the results the runs on sauce labs are giving are completely strange and unlike what I get locally. I've asked cmcmahon for an opinion on the merged changeset [06:05:53] (03PS1) 10Gilles: Fix or remove calls deprecated in 1.25 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158056 [06:18:27] (03CR) 10Gilles: [C: 032] Feature is not reliably browser-testable; remove [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158041 (owner: 10Neilk) [06:18:54] (03Merged) 10jenkins-bot: Feature is not reliably browser-testable; remove [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158041 (owner: 10Neilk) [06:51:03] marktraceur: do you know how to configure grrrit-wm to also follow gergo's ImageMetrics extension? [06:51:22] labs/tools/grrrit-wm [06:51:34] https://github.com/wikimedia/labs-tools-grrrit actually [06:51:52] neat, thank you [06:54:54] https://github.com/wikimedia/labs-tools-grrrit/pull/4 [07:14:32] gi11es: errr, that's a gerrit repository, not a github one [07:14:49] darnit [07:14:57] it's ok [07:15:07] I'll upload it to gerrit [07:16:22] hah: https://gerrit.wikimedia.org/r/#/c/156945/ [07:19:39] oh lol [07:19:47] gi11es: deployed the change [07:20:31] thanks [07:44:57] 3MediaWiki / 3File management: When a local image and an image redirect on Commons have the same name, the wrong description page is linked - 10https://bugzilla.wikimedia.org/36118#c4 (10Michael M.) 5RESO/WOR>3REOP New testcase: http://de.wikipedia.beta.wmflabs.org/wiki/Bug_36118 This shows the image fr... [08:27:19] (03CR) 10Gergő Tisza: [C: 032] Fix or remove calls deprecated in 1.25 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158056 (owner: 10Gilles) [08:27:48] (03Merged) 10jenkins-bot: Fix or remove calls deprecated in 1.25 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158056 (owner: 10Gilles) [11:28:50] (03PS2) 10Gergő Tisza: Make the main script load on-demand [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/157815 [11:59:36] (03CR) 10Gergő Tisza: "I think this is still worthwhile. The patch basically allows us to read the caption in cases where we could not before (currently we find " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [12:04:28] (03PS8) 10Gergő Tisza: Use link title as fallback for caption [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [12:04:32] (03CR) 10jenkins-bot: [V: 04-1] Use link title as fallback for caption [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [12:13:52] (03PS9) 10Gergő Tisza: Use link title as fallback for caption [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [12:14:27] (03CR) 10Gergő Tisza: "Rebased." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [12:35:23] (03CR) 10Gergő Tisza: [C: 031] "Tested a bit more with HTML in the caption, and it is actually stripped by the parser, not MMV. So the parsing on our side should be fine." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129847 (owner: 10MarkTraceur) [14:16:26] 3MediaWiki extensions / 3TimedMediaHandler: Prevent creation of empty TimedText by anonymous IPs - 10https://bugzilla.wikimedia.org/70254#c3 (10Marco) Another 3 in 24h: 3 September 2014 (diff | hist) . . N TimedText:President Obama Makes a Statement on Iraq - 080714.ogg.ru.srt‎; 09:27 . . (0)‎ . . ‎188... [14:56:42] 3MediaWiki extensions / 3UploadWizard: Skip tutorial does not set user preference in Chrome and Firefox - 10https://bugzilla.wikimedia.org/70303 (10Chris McMahon) 5NEW>3RESO/WON [14:58:26] 3MediaWiki extensions / 3UploadWizard: Skip tutorial does not set user preference in Chrome and Firefox - 10https://bugzilla.wikimedia.org/70303#c10 (10Chris McMahon) I am still a bit concerned that users will see an instruction that may or may not actually function as stated, but it's not a big deal. [16:40:23] marktraceur: did you happen to see yesterday's UW bug about preferences? https://bugzilla.wikimedia.org/show_bug.cgi?id=70303 I am a little concerned about UW telling users it's doing something when it may or may not actually do it. [16:40:43] I saw it [16:40:50] I'll look at it after my deluge of meetings [16:41:35] marktraceur: thanks I am also meeting-heavy today [17:54:39] fabriceflorin: Are we going to have a video backchannel or is it not that important? [17:55:15] marktraceur: Yes, we will use the backchannel. [17:59:20] fabriceflorin: we're in the hangout [19:08:56] hey all, is anyone on gwtoolset review this week? [19:10:06] there's one patch i have in gerrit that would help alot if it got deployed. i'm hoping it's simple enough to review. [19:10:09] https://gerrit.wikimedia.org/r/#/c/156243/ [19:13:45] hey fabriceflorin, do you know who is on gwtooolset review this week? [19:14:08] dan-nl: I think it’s gi11es … [19:14:24] thanks [20:35:44] https://meta.wikimedia.org/wiki/Talk:Community_Engagement_(Product)/Media_Viewer_consultation#mediaviewer/File:NamcheMarkt.jpg O_O [20:36:21] I had to reload that several times to get information to appear. [20:36:22] Odd [20:40:53] Whaaaat is happening [20:41:03] None of the images show up there [20:41:25] Crazy things [20:41:50] Other sites too [20:41:54] WTF [20:42:14] Error: Could not load image data. file does not exist: File:NamcheMarkt.jpg [20:42:51] this is unhood [20:42:54] *ungood [20:42:59] Not hood at all [20:44:06] Now that I've been the bearer of bad news, I'm off for a couple hours. [20:44:13] bbl [20:45:00] Buhbye [20:59:14] (03PS1) 10Neilk: wait for ajax calls to complete [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158240 [21:05:43] (03PS1) 10Neilk: This class is just Preferences now, not Reset [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158241 [21:07:04] chrismcmahon: so it turns out that there's a hidden wait_for_ajax thingy in PageObject. [21:07:42] chrismcmahon: To my surprise, I think I didn't commit the change to remove that failing test. But now I think this might fix the failing test. [21:07:54] (03CR) 10Cmcmahon: "I would rather just remove the test, or fix Bug 70303. Jumping through hoops to make a test pass for a feature known to have a race condi" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158240 (owner: 10Neilk) [21:08:46] neilk_: I left a comment on the change. I'd rather just remove the test. Making the test pass when the code still has a race condition seems counter-productive. [21:08:57] chrismcmahon: yeah I know, I'm responding :) [21:12:11] 3MediaWiki extensions / 3UploadWizard: Skip tutorial does not set user preference in Chrome and Firefox - 10https://bugzilla.wikimedia.org/70303#c11 (10Neil Kandalgaonkar) Okay yesterday I suggested we close this, but I think there is a way to fix it. We can add a confirmCloseWindow() to the AJAX call. This... [21:12:22] (03CR) 10Neilk: "I don't agree that this is "jumping through hoops". The wait_for_ajax thing will have many uses on ajax-heavy pages. There are lots of aja" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158240 (owner: 10Neilk) [21:30:01] (03CR) 10Cmcmahon: "The convention for AJAX calls is to use the "foo_element.when_present." syntax for objects that are expected to appear. You'll fi" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158240 (owner: 10Neilk) [21:31:42] 3MediaWiki extensions / 3UploadWizard: Skip tutorial does not set user preference in Chrome and Firefox - 10https://bugzilla.wikimedia.org/70303#c12 (10Chris McMahon) 5RESO/WON>3REOP I'm going to defer to Mark and Fabrice about the desired behavior of UW. My interest is in consistent behavior (whatever i... [21:41:12] (03PS1) 10Neilk: Alert user if navigating away before skip pref set [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158249 [21:41:56] 3MediaWiki extensions / 3UploadWizard: Skip tutorial does not set user preference in Chrome and Firefox - 10https://bugzilla.wikimedia.org/70303#c13 (10Neil Kandalgaonkar) Potential fix in Gerrit as described in comment 11 above. https://gerrit.wikimedia.org/r/#/c/158249/ [21:48:52] chrismcmahon: I don't understand what you meant in your last comment on https://gerrit.wikimedia.org/r/#/c/158240/ [21:49:14] chrismcmahon: the when_present convention doesn't apply if there's no changed element on the page [21:49:41] chrismcmahon: but, I beg your patience; I'm trying to grok a lot of stuff at once. [21:50:18] neilk_: I may not have understood what you were after. [21:51:52] chrismcmahon: it's a weird feature - there's nothing to "wait" for :) [21:52:22] chrismcmahon: but you were right to call that out as weird, I think I've got a fix for the UI, and this other change fixes the test. [21:58:34] neilk_: sounds good, thanks [21:58:43] :) [22:12:21] (03CR) 10Cmcmahon: "adding Zeljko and Dan just because I've never seen this before" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158240 (owner: 10Neilk) [23:22:10] (03PS2) 10Neilk: Alert user if navigating away before skip pref set [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158249 [23:59:11] 3MediaWiki / 3Uploading: Special:Upload should pre-fill summary field without Javascript - 10https://bugzilla.wikimedia.org/70146 (10Ryan Kaldari)